From: Dong Aisheng <aisheng.dong@nxp.com> To: linux-gpio@vger.kernel.org Cc: aisheng.dong@nxp.com, dongas86@gmail.com, Fabio Estevam <festevam@gmail.com>, linus.walleij@linaro.org, stefan@agner.ch, linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/6] pinctrl: imx: use seq_puts() instead of seq_printf() Date: Sat, 28 Apr 2018 03:01:50 +0800 [thread overview] Message-ID: <1524855713-15527-4-git-send-email-aisheng.dong@nxp.com> (raw) In-Reply-To: <1524855713-15527-1-git-send-email-aisheng.dong@nxp.com> For a constant format without additional arguments, use seq_puts() instead of seq_printf(). Also, it fixes the following checkpatch warning. WARNING: Prefer seq_puts to seq_printf + seq_printf(s, "N/A"); WARNING: Prefer seq_puts to seq_printf + seq_printf(s, "\n"); Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Fabio Estevam <festevam@gmail.com> Cc: Stefan Agner <stefan@agner.ch> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/pinctrl/freescale/pinctrl-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index ff6ca6a4..4e730c3 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -371,7 +371,7 @@ static void imx_pinconf_dbg_show(struct pinctrl_dev *pctldev, unsigned long config; if (!pin_reg || pin_reg->conf_reg == -1) { - seq_printf(s, "N/A"); + seq_puts(s, "N/A"); return; } @@ -390,7 +390,7 @@ static void imx_pinconf_group_dbg_show(struct pinctrl_dev *pctldev, if (group > pctldev->num_groups) return; - seq_printf(s, "\n"); + seq_puts(s, "\n"); grp = pinctrl_generic_get_group(pctldev, group); if (!grp) return; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: aisheng.dong@nxp.com (Dong Aisheng) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/6] pinctrl: imx: use seq_puts() instead of seq_printf() Date: Sat, 28 Apr 2018 03:01:50 +0800 [thread overview] Message-ID: <1524855713-15527-4-git-send-email-aisheng.dong@nxp.com> (raw) In-Reply-To: <1524855713-15527-1-git-send-email-aisheng.dong@nxp.com> For a constant format without additional arguments, use seq_puts() instead of seq_printf(). Also, it fixes the following checkpatch warning. WARNING: Prefer seq_puts to seq_printf + seq_printf(s, "N/A"); WARNING: Prefer seq_puts to seq_printf + seq_printf(s, "\n"); Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Fabio Estevam <festevam@gmail.com> Cc: Stefan Agner <stefan@agner.ch> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/pinctrl/freescale/pinctrl-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index ff6ca6a4..4e730c3 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -371,7 +371,7 @@ static void imx_pinconf_dbg_show(struct pinctrl_dev *pctldev, unsigned long config; if (!pin_reg || pin_reg->conf_reg == -1) { - seq_printf(s, "N/A"); + seq_puts(s, "N/A"); return; } @@ -390,7 +390,7 @@ static void imx_pinconf_group_dbg_show(struct pinctrl_dev *pctldev, if (group > pctldev->num_groups) return; - seq_printf(s, "\n"); + seq_puts(s, "\n"); grp = pinctrl_generic_get_group(pctldev, group); if (!grp) return; -- 2.7.4
next prev parent reply other threads:[~2018-04-27 19:01 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-27 19:01 [PATCH 0/6] pinctrl: imx: add imx8qxp pinctrl support Dong Aisheng 2018-04-27 19:01 ` Dong Aisheng 2018-04-27 19:01 ` [PATCH 1/6] pinctrl: imx: fix unsigned check if nfuncs with less than or equal zero Dong Aisheng 2018-04-27 19:01 ` Dong Aisheng 2018-05-02 12:22 ` Linus Walleij 2018-05-02 12:22 ` Linus Walleij 2018-04-27 19:01 ` [PATCH 2/6] pinctrl: pinctrl-imx: improve the code comments of PIN_FUNC_ID Dong Aisheng 2018-04-27 19:01 ` Dong Aisheng 2018-05-02 12:23 ` Linus Walleij 2018-05-02 12:23 ` Linus Walleij 2018-04-27 19:01 ` Dong Aisheng [this message] 2018-04-27 19:01 ` [PATCH 3/6] pinctrl: imx: use seq_puts() instead of seq_printf() Dong Aisheng 2018-05-02 12:24 ` Linus Walleij 2018-05-02 12:24 ` Linus Walleij 2018-04-27 19:01 ` [PATCH 4/6] pinctrl: fsl: add scu based pinctrl support Dong Aisheng 2018-04-27 19:01 ` Dong Aisheng 2018-05-02 12:27 ` Linus Walleij 2018-05-02 12:27 ` Linus Walleij 2018-05-02 12:29 ` Linus Walleij 2018-05-02 12:29 ` Linus Walleij 2018-05-02 12:36 ` Sascha Hauer 2018-05-02 12:36 ` Sascha Hauer 2018-05-02 13:03 ` Linus Walleij 2018-05-02 13:03 ` Linus Walleij 2018-05-02 15:05 ` Sascha Hauer 2018-05-02 15:05 ` Sascha Hauer 2018-05-02 18:42 ` A.s. Dong 2018-05-02 18:42 ` A.s. Dong 2018-04-27 19:01 ` [PATCH 5/6] dt-bindings: pinctrl: add imx8qxp pinctrl binding doc Dong Aisheng 2018-04-27 19:01 ` Dong Aisheng 2018-05-01 15:58 ` Rob Herring 2018-05-01 15:58 ` Rob Herring 2018-05-02 18:07 ` A.s. Dong 2018-05-02 18:07 ` A.s. Dong 2018-04-27 19:01 ` [PATCH 6/6] pinctrl: imx: add imx8qxp driver Dong Aisheng 2018-04-27 19:01 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1524855713-15527-4-git-send-email-aisheng.dong@nxp.com \ --to=aisheng.dong@nxp.com \ --cc=dongas86@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=shawnguo@kernel.org \ --cc=stefan@agner.ch \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.