* [PATCH] ARM: dts: stm32: Fix IRQ_TYPE_NONE warnings on stm32mp157c
@ 2018-05-02 13:23 ` Alexandre Torgue
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Torgue @ 2018-05-02 13:23 UTC (permalink / raw)
To: Maxime Coquelin, arnd, robh+dt, mark.rutland, linux
Cc: devicetree, Alexandre Torgue, linux-arm-kernel, erwan.leray
Since commit 83a86fbb5b56 ("irqchip/gic: Loudly complain about
the use of IRQ_TYPE_NONE"), a warning is raised if IRQ_TYPE_NONE is used.
So we use IRQ_TYPE_LEVEL_HIGH for usart nodes instead of IRQ_TYPE_NONE.
Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index 9c1a6c4..d096d06 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -314,7 +314,7 @@
usart2: serial@4000e000 {
compatible = "st,stm32h7-uart";
reg = <0x4000e000 0x400>;
- interrupts = <GIC_SPI 38 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc USART2_K>;
status = "disabled";
};
@@ -322,7 +322,7 @@
usart3: serial@4000f000 {
compatible = "st,stm32h7-uart";
reg = <0x4000f000 0x400>;
- interrupts = <GIC_SPI 39 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc USART3_K>;
status = "disabled";
};
@@ -330,7 +330,7 @@
uart4: serial@40010000 {
compatible = "st,stm32h7-uart";
reg = <0x40010000 0x400>;
- interrupts = <GIC_SPI 52 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc UART4_K>;
status = "disabled";
};
@@ -338,7 +338,7 @@
uart5: serial@40011000 {
compatible = "st,stm32h7-uart";
reg = <0x40011000 0x400>;
- interrupts = <GIC_SPI 53 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc UART5_K>;
status = "disabled";
};
@@ -370,7 +370,7 @@
uart7: serial@40018000 {
compatible = "st,stm32h7-uart";
reg = <0x40018000 0x400>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc UART7_K>;
status = "disabled";
};
@@ -378,7 +378,7 @@
uart8: serial@40019000 {
compatible = "st,stm32h7-uart";
reg = <0x40019000 0x400>;
- interrupts = <GIC_SPI 83 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc UART8_K>;
status = "disabled";
};
@@ -428,7 +428,7 @@
usart6: serial@44003000 {
compatible = "st,stm32h7-uart";
reg = <0x44003000 0x400>;
- interrupts = <GIC_SPI 71 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc USART6_K>;
status = "disabled";
};
@@ -591,7 +591,7 @@
usart1: serial@5c000000 {
compatible = "st,stm32h7-uart";
reg = <0x5c000000 0x400>;
- interrupts = <GIC_SPI 37 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc USART1_K>;
status = "disabled";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: stm32: Fix IRQ_TYPE_NONE warnings on stm32mp157c
@ 2018-05-02 13:23 ` Alexandre Torgue
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Torgue @ 2018-05-02 13:23 UTC (permalink / raw)
To: linux-arm-kernel
Since commit 83a86fbb5b56 ("irqchip/gic: Loudly complain about
the use of IRQ_TYPE_NONE"), a warning is raised if IRQ_TYPE_NONE is used.
So we use IRQ_TYPE_LEVEL_HIGH for usart nodes instead of IRQ_TYPE_NONE.
Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index 9c1a6c4..d096d06 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -314,7 +314,7 @@
usart2: serial at 4000e000 {
compatible = "st,stm32h7-uart";
reg = <0x4000e000 0x400>;
- interrupts = <GIC_SPI 38 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc USART2_K>;
status = "disabled";
};
@@ -322,7 +322,7 @@
usart3: serial at 4000f000 {
compatible = "st,stm32h7-uart";
reg = <0x4000f000 0x400>;
- interrupts = <GIC_SPI 39 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc USART3_K>;
status = "disabled";
};
@@ -330,7 +330,7 @@
uart4: serial at 40010000 {
compatible = "st,stm32h7-uart";
reg = <0x40010000 0x400>;
- interrupts = <GIC_SPI 52 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc UART4_K>;
status = "disabled";
};
@@ -338,7 +338,7 @@
uart5: serial at 40011000 {
compatible = "st,stm32h7-uart";
reg = <0x40011000 0x400>;
- interrupts = <GIC_SPI 53 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc UART5_K>;
status = "disabled";
};
@@ -370,7 +370,7 @@
uart7: serial at 40018000 {
compatible = "st,stm32h7-uart";
reg = <0x40018000 0x400>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc UART7_K>;
status = "disabled";
};
@@ -378,7 +378,7 @@
uart8: serial at 40019000 {
compatible = "st,stm32h7-uart";
reg = <0x40019000 0x400>;
- interrupts = <GIC_SPI 83 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc UART8_K>;
status = "disabled";
};
@@ -428,7 +428,7 @@
usart6: serial at 44003000 {
compatible = "st,stm32h7-uart";
reg = <0x44003000 0x400>;
- interrupts = <GIC_SPI 71 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc USART6_K>;
status = "disabled";
};
@@ -591,7 +591,7 @@
usart1: serial at 5c000000 {
compatible = "st,stm32h7-uart";
reg = <0x5c000000 0x400>;
- interrupts = <GIC_SPI 37 IRQ_TYPE_NONE>;
+ interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&rcc USART1_K>;
status = "disabled";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Fix IRQ_TYPE_NONE warnings on stm32mp157c
2018-05-02 13:23 ` Alexandre Torgue
@ 2018-05-02 14:28 ` Fabrice Gasnier
-1 siblings, 0 replies; 4+ messages in thread
From: Fabrice Gasnier @ 2018-05-02 14:28 UTC (permalink / raw)
To: Alexandre Torgue, Maxime Coquelin, arnd, robh+dt, mark.rutland, linux
Cc: devicetree, erwan.leray, linux-arm-kernel
On 05/02/2018 03:23 PM, Alexandre Torgue wrote:
> Since commit 83a86fbb5b56 ("irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE"), a warning is raised if IRQ_TYPE_NONE is used.
> So we use IRQ_TYPE_LEVEL_HIGH for usart nodes instead of IRQ_TYPE_NONE.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Hi Alexandre,
Tested-by: Fabrice Gasnier <fabrice.gasnier@st.com>
BR,
Fabrice
>
> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
> index 9c1a6c4..d096d06 100644
> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
> @@ -314,7 +314,7 @@
> usart2: serial@4000e000 {
> compatible = "st,stm32h7-uart";
> reg = <0x4000e000 0x400>;
> - interrupts = <GIC_SPI 38 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART2_K>;
> status = "disabled";
> };
> @@ -322,7 +322,7 @@
> usart3: serial@4000f000 {
> compatible = "st,stm32h7-uart";
> reg = <0x4000f000 0x400>;
> - interrupts = <GIC_SPI 39 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART3_K>;
> status = "disabled";
> };
> @@ -330,7 +330,7 @@
> uart4: serial@40010000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40010000 0x400>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART4_K>;
> status = "disabled";
> };
> @@ -338,7 +338,7 @@
> uart5: serial@40011000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40011000 0x400>;
> - interrupts = <GIC_SPI 53 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART5_K>;
> status = "disabled";
> };
> @@ -370,7 +370,7 @@
> uart7: serial@40018000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40018000 0x400>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART7_K>;
> status = "disabled";
> };
> @@ -378,7 +378,7 @@
> uart8: serial@40019000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40019000 0x400>;
> - interrupts = <GIC_SPI 83 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART8_K>;
> status = "disabled";
> };
> @@ -428,7 +428,7 @@
> usart6: serial@44003000 {
> compatible = "st,stm32h7-uart";
> reg = <0x44003000 0x400>;
> - interrupts = <GIC_SPI 71 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART6_K>;
> status = "disabled";
> };
> @@ -591,7 +591,7 @@
> usart1: serial@5c000000 {
> compatible = "st,stm32h7-uart";
> reg = <0x5c000000 0x400>;
> - interrupts = <GIC_SPI 37 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART1_K>;
> status = "disabled";
> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: stm32: Fix IRQ_TYPE_NONE warnings on stm32mp157c
@ 2018-05-02 14:28 ` Fabrice Gasnier
0 siblings, 0 replies; 4+ messages in thread
From: Fabrice Gasnier @ 2018-05-02 14:28 UTC (permalink / raw)
To: linux-arm-kernel
On 05/02/2018 03:23 PM, Alexandre Torgue wrote:
> Since commit 83a86fbb5b56 ("irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE"), a warning is raised if IRQ_TYPE_NONE is used.
> So we use IRQ_TYPE_LEVEL_HIGH for usart nodes instead of IRQ_TYPE_NONE.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Hi Alexandre,
Tested-by: Fabrice Gasnier <fabrice.gasnier@st.com>
BR,
Fabrice
>
> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
> index 9c1a6c4..d096d06 100644
> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
> @@ -314,7 +314,7 @@
> usart2: serial at 4000e000 {
> compatible = "st,stm32h7-uart";
> reg = <0x4000e000 0x400>;
> - interrupts = <GIC_SPI 38 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART2_K>;
> status = "disabled";
> };
> @@ -322,7 +322,7 @@
> usart3: serial at 4000f000 {
> compatible = "st,stm32h7-uart";
> reg = <0x4000f000 0x400>;
> - interrupts = <GIC_SPI 39 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART3_K>;
> status = "disabled";
> };
> @@ -330,7 +330,7 @@
> uart4: serial at 40010000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40010000 0x400>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART4_K>;
> status = "disabled";
> };
> @@ -338,7 +338,7 @@
> uart5: serial at 40011000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40011000 0x400>;
> - interrupts = <GIC_SPI 53 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART5_K>;
> status = "disabled";
> };
> @@ -370,7 +370,7 @@
> uart7: serial at 40018000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40018000 0x400>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART7_K>;
> status = "disabled";
> };
> @@ -378,7 +378,7 @@
> uart8: serial at 40019000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40019000 0x400>;
> - interrupts = <GIC_SPI 83 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART8_K>;
> status = "disabled";
> };
> @@ -428,7 +428,7 @@
> usart6: serial at 44003000 {
> compatible = "st,stm32h7-uart";
> reg = <0x44003000 0x400>;
> - interrupts = <GIC_SPI 71 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART6_K>;
> status = "disabled";
> };
> @@ -591,7 +591,7 @@
> usart1: serial at 5c000000 {
> compatible = "st,stm32h7-uart";
> reg = <0x5c000000 0x400>;
> - interrupts = <GIC_SPI 37 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART1_K>;
> status = "disabled";
> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-02 14:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 13:23 [PATCH] ARM: dts: stm32: Fix IRQ_TYPE_NONE warnings on stm32mp157c Alexandre Torgue
2018-05-02 13:23 ` Alexandre Torgue
2018-05-02 14:28 ` Fabrice Gasnier
2018-05-02 14:28 ` Fabrice Gasnier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.