* Re: [SPDK] GerritHub rejects push
@ 2018-05-02 19:13 Walker, Benjamin
0 siblings, 0 replies; 11+ messages in thread
From: Walker, Benjamin @ 2018-05-02 19:13 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-04 16:20 Meneghini, John
0 siblings, 0 replies; 11+ messages in thread
From: Meneghini, John @ 2018-05-04 16:20 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 12200 bytes --]
This means that all Authors have to sign their own changes if they want to upload it themselves.
> Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license
Agreed, Signed-off has to do with the license, not the code review or the content. We are using the Signed-off internally to signify that another engineer has reviewed the authors code and verified that it can be released upstream under the associated licence.
> We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author. Both you and Ed are now in this list
However, we can’t upload or update our own patches w/out Signing them.
/John
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of Jim Harris <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 12:10 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi Ed,
Yes – it blocked you because John M had the only Signed-off-by but he was not the author nor the uploader.
Or to put it another way, you were both the author and the uploader, but you did not have a Signed-off-by line.
-Jim
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Rodriguez, Edwin" <Ed.Rodriguez(a)netapp.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 9:03 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Well, I was the author and uploader with John M being the signer yet it still blocked me.
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 12:00 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi Ed,
Yes – adding yourself was the right way to fix this. Either the author (as designated in the patch) or the uploader must match one of the Signed-off-by lines.
-Jim
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Rodriguez, Edwin" <Ed.Rodriguez(a)netapp.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 8:55 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
I then signed it myself and the push succeeded:
[edwinr(a)edwinr-mac-0:16]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git commit --amend --sign
[bdev_fprint_removal 97fe5a5a] bdev: Replace fprintf with log message
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
[edwinr(a)edwinr-mac-0:17]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit 97fe5a5af80c0e9b48c7d50625bbf3ea747b3879 (HEAD -> bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Change-Id: Ic980f3f2f04db61e3ff7ce305817eede7a09cb5a
Signed-off-by: John Meneghini <johnm(a)netapp.com>
Signed-off-by: Ed rodriguez <edwinr(a)netapp.com>
[edwinr(a)edwinr-mac-0:18]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 538 bytes | 76.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: new: 1, done
remote:
remote: New Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/410056 bdev: Replace fprintf with log message
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
From: Ed Rodriguez <Ed.Rodriguez(a)netapp.com>
Date: Friday, May 4, 2018 at 11:52 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
In this case I’m trying to push a change to gerrithub that was signed by John M. And I get:
[edwinr(a)edwinr-mac-0:14]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b (HEAD -> bdev_fprint_removal, bitbucket/bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Signed-off-by: John Meneghini <johnm(a)netapp.com>
[edwinr(a)edwinr-mac-0:15]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 489 bytes | 69.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
remote:
remote: ERROR: In commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b
remote: ERROR: committer email address johnm(a)netapp.com
remote: ERROR: does not match your user account and you have no 'forge committer' permission.
remote: ERROR:
remote: ERROR: The following addresses are currently registered:
remote: ERROR: ed.rodriguez(a)netapp.com
remote: ERROR: edwinr(a)netapp.com
remote: ERROR:
remote: ERROR: To register an email address, please visit:
remote: ERROR: https://review.gerrithub.io/#/settings/contact
remote:
remote:
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (invalid committer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
Ed R
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Thursday, May 3, 2018 at 5:59 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi John,
Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license. Multiple people may add their own Signed-off-by line. But at least one Signed-off-by line is required for every patch and GerritHub is enforcing that correctly.
“Signed off” in terms of “I sign off on this patch being ready to go into SPDK” should really be done with Reviewed-by tags.
We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author. Both you and Ed are now in this list. If anyone else needs to be added, please ask and the core maintainers will add you (this goes for anyone reading this message – not just John’s team!)
Thanks,
-Jim
On 5/3/18, 2:35 PM, "SPDK on behalf of Meneghini, John" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of John.Meneghini(a)netapp.com<mailto:John.Meneghini(a)netapp.com>> wrote:
OK. Thanks Jim.
I think this works now... at least for me.
Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes. As a matter of policy, we'd like:
- Others to sign-off the author's code (we don't want people signing their own changes)
- The author or signer to be able to upload changes
In this example Ed signed my change and uploaded it. This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility.
In the example below I had to sign my own change to get GerritHub to take it. This is a different from the original problem which rejected my change even after I signed it.
If possible, can we fix this problem?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
[add_git_hooks 4bfdb4fe] git: add .githooks to repository
Date: Mon Feb 5 13:15:54 2018 -0500
3 files changed, 165 insertions(+)
create mode 100755 .githooks/pre-commit
create mode 100755 .githooks/pre-push
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: updated: 1, done
remote:
remote: Updated Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of james.r.harris(a)intel.com<mailto:james.r.harris(a)intel.com>> wrote:
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of benjamin.walker(a)intel.com<mailto:benjamin.walker(a)intel.com>> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 59262 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-04 16:10 Harris, James R
0 siblings, 0 replies; 11+ messages in thread
From: Harris, James R @ 2018-05-04 16:10 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 11130 bytes --]
Hi Ed,
Yes – it blocked you because John M had the only Signed-off-by but he was not the author nor the uploader.
Or to put it another way, you were both the author and the uploader, but you did not have a Signed-off-by line.
-Jim
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Rodriguez, Edwin" <Ed.Rodriguez(a)netapp.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 9:03 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Well, I was the author and uploader with John M being the signer yet it still blocked me.
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 12:00 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi Ed,
Yes – adding yourself was the right way to fix this. Either the author (as designated in the patch) or the uploader must match one of the Signed-off-by lines.
-Jim
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Rodriguez, Edwin" <Ed.Rodriguez(a)netapp.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 8:55 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
I then signed it myself and the push succeeded:
[edwinr(a)edwinr-mac-0:16]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git commit --amend --sign
[bdev_fprint_removal 97fe5a5a] bdev: Replace fprintf with log message
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
[edwinr(a)edwinr-mac-0:17]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit 97fe5a5af80c0e9b48c7d50625bbf3ea747b3879 (HEAD -> bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Change-Id: Ic980f3f2f04db61e3ff7ce305817eede7a09cb5a
Signed-off-by: John Meneghini <johnm(a)netapp.com>
Signed-off-by: Ed rodriguez <edwinr(a)netapp.com>
[edwinr(a)edwinr-mac-0:18]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 538 bytes | 76.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: new: 1, done
remote:
remote: New Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/410056 bdev: Replace fprintf with log message
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
From: Ed Rodriguez <Ed.Rodriguez(a)netapp.com>
Date: Friday, May 4, 2018 at 11:52 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
In this case I’m trying to push a change to gerrithub that was signed by John M. And I get:
[edwinr(a)edwinr-mac-0:14]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b (HEAD -> bdev_fprint_removal, bitbucket/bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Signed-off-by: John Meneghini <johnm(a)netapp.com>
[edwinr(a)edwinr-mac-0:15]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 489 bytes | 69.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
remote:
remote: ERROR: In commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b
remote: ERROR: committer email address johnm(a)netapp.com
remote: ERROR: does not match your user account and you have no 'forge committer' permission.
remote: ERROR:
remote: ERROR: The following addresses are currently registered:
remote: ERROR: ed.rodriguez(a)netapp.com
remote: ERROR: edwinr(a)netapp.com
remote: ERROR:
remote: ERROR: To register an email address, please visit:
remote: ERROR: https://review.gerrithub.io/#/settings/contact
remote:
remote:
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (invalid committer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
Ed R
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Thursday, May 3, 2018 at 5:59 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi John,
Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license. Multiple people may add their own Signed-off-by line. But at least one Signed-off-by line is required for every patch and GerritHub is enforcing that correctly.
“Signed off” in terms of “I sign off on this patch being ready to go into SPDK” should really be done with Reviewed-by tags.
We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author. Both you and Ed are now in this list. If anyone else needs to be added, please ask and the core maintainers will add you (this goes for anyone reading this message – not just John’s team!)
Thanks,
-Jim
On 5/3/18, 2:35 PM, "SPDK on behalf of Meneghini, John" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of John.Meneghini(a)netapp.com<mailto:John.Meneghini(a)netapp.com>> wrote:
OK. Thanks Jim.
I think this works now... at least for me.
Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes. As a matter of policy, we'd like:
- Others to sign-off the author's code (we don't want people signing their own changes)
- The author or signer to be able to upload changes
In this example Ed signed my change and uploaded it. This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility.
In the example below I had to sign my own change to get GerritHub to take it. This is a different from the original problem which rejected my change even after I signed it.
If possible, can we fix this problem?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
[add_git_hooks 4bfdb4fe] git: add .githooks to repository
Date: Mon Feb 5 13:15:54 2018 -0500
3 files changed, 165 insertions(+)
create mode 100755 .githooks/pre-commit
create mode 100755 .githooks/pre-push
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: updated: 1, done
remote:
remote: Updated Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of james.r.harris(a)intel.com<mailto:james.r.harris(a)intel.com>> wrote:
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of benjamin.walker(a)intel.com<mailto:benjamin.walker(a)intel.com>> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 40038 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-04 16:03 Rodriguez, Edwin
0 siblings, 0 replies; 11+ messages in thread
From: Rodriguez, Edwin @ 2018-05-04 16:03 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 10565 bytes --]
Well, I was the author and uploader with John M being the signer yet it still blocked me.
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 12:00 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi Ed,
Yes – adding yourself was the right way to fix this. Either the author (as designated in the patch) or the uploader must match one of the Signed-off-by lines.
-Jim
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Rodriguez, Edwin" <Ed.Rodriguez(a)netapp.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 8:55 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
I then signed it myself and the push succeeded:
[edwinr(a)edwinr-mac-0:16]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git commit --amend --sign
[bdev_fprint_removal 97fe5a5a] bdev: Replace fprintf with log message
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
[edwinr(a)edwinr-mac-0:17]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit 97fe5a5af80c0e9b48c7d50625bbf3ea747b3879 (HEAD -> bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Change-Id: Ic980f3f2f04db61e3ff7ce305817eede7a09cb5a
Signed-off-by: John Meneghini <johnm(a)netapp.com>
Signed-off-by: Ed rodriguez <edwinr(a)netapp.com>
[edwinr(a)edwinr-mac-0:18]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 538 bytes | 76.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: new: 1, done
remote:
remote: New Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/410056 bdev: Replace fprintf with log message
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
From: Ed Rodriguez <Ed.Rodriguez(a)netapp.com>
Date: Friday, May 4, 2018 at 11:52 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
In this case I’m trying to push a change to gerrithub that was signed by John M. And I get:
[edwinr(a)edwinr-mac-0:14]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b (HEAD -> bdev_fprint_removal, bitbucket/bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Signed-off-by: John Meneghini <johnm(a)netapp.com>
[edwinr(a)edwinr-mac-0:15]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 489 bytes | 69.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
remote:
remote: ERROR: In commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b
remote: ERROR: committer email address johnm(a)netapp.com
remote: ERROR: does not match your user account and you have no 'forge committer' permission.
remote: ERROR:
remote: ERROR: The following addresses are currently registered:
remote: ERROR: ed.rodriguez(a)netapp.com
remote: ERROR: edwinr(a)netapp.com
remote: ERROR:
remote: ERROR: To register an email address, please visit:
remote: ERROR: https://review.gerrithub.io/#/settings/contact
remote:
remote:
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (invalid committer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
Ed R
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Thursday, May 3, 2018 at 5:59 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi John,
Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license. Multiple people may add their own Signed-off-by line. But at least one Signed-off-by line is required for every patch and GerritHub is enforcing that correctly.
“Signed off” in terms of “I sign off on this patch being ready to go into SPDK” should really be done with Reviewed-by tags.
We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author. Both you and Ed are now in this list. If anyone else needs to be added, please ask and the core maintainers will add you (this goes for anyone reading this message – not just John’s team!)
Thanks,
-Jim
On 5/3/18, 2:35 PM, "SPDK on behalf of Meneghini, John" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of John.Meneghini(a)netapp.com<mailto:John.Meneghini(a)netapp.com>> wrote:
OK. Thanks Jim.
I think this works now... at least for me.
Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes. As a matter of policy, we'd like:
- Others to sign-off the author's code (we don't want people signing their own changes)
- The author or signer to be able to upload changes
In this example Ed signed my change and uploaded it. This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility.
In the example below I had to sign my own change to get GerritHub to take it. This is a different from the original problem which rejected my change even after I signed it.
If possible, can we fix this problem?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
[add_git_hooks 4bfdb4fe] git: add .githooks to repository
Date: Mon Feb 5 13:15:54 2018 -0500
3 files changed, 165 insertions(+)
create mode 100755 .githooks/pre-commit
create mode 100755 .githooks/pre-push
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: updated: 1, done
remote:
remote: Updated Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of james.r.harris(a)intel.com<mailto:james.r.harris(a)intel.com>> wrote:
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of benjamin.walker(a)intel.com<mailto:benjamin.walker(a)intel.com>> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 50286 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-04 15:59 Harris, James R
0 siblings, 0 replies; 11+ messages in thread
From: Harris, James R @ 2018-05-04 15:59 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 10153 bytes --]
Hi Ed,
Yes – adding yourself was the right way to fix this. Either the author (as designated in the patch) or the uploader must match one of the Signed-off-by lines.
-Jim
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Rodriguez, Edwin" <Ed.Rodriguez(a)netapp.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Friday, May 4, 2018 at 8:55 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
I then signed it myself and the push succeeded:
[edwinr(a)edwinr-mac-0:16]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git commit --amend --sign
[bdev_fprint_removal 97fe5a5a] bdev: Replace fprintf with log message
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
[edwinr(a)edwinr-mac-0:17]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit 97fe5a5af80c0e9b48c7d50625bbf3ea747b3879 (HEAD -> bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Change-Id: Ic980f3f2f04db61e3ff7ce305817eede7a09cb5a
Signed-off-by: John Meneghini <johnm(a)netapp.com>
Signed-off-by: Ed rodriguez <edwinr(a)netapp.com>
[edwinr(a)edwinr-mac-0:18]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 538 bytes | 76.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: new: 1, done
remote:
remote: New Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/410056 bdev: Replace fprintf with log message
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
From: Ed Rodriguez <Ed.Rodriguez(a)netapp.com>
Date: Friday, May 4, 2018 at 11:52 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
In this case I’m trying to push a change to gerrithub that was signed by John M. And I get:
[edwinr(a)edwinr-mac-0:14]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b (HEAD -> bdev_fprint_removal, bitbucket/bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Signed-off-by: John Meneghini <johnm(a)netapp.com>
[edwinr(a)edwinr-mac-0:15]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 489 bytes | 69.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
remote:
remote: ERROR: In commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b
remote: ERROR: committer email address johnm(a)netapp.com
remote: ERROR: does not match your user account and you have no 'forge committer' permission.
remote: ERROR:
remote: ERROR: The following addresses are currently registered:
remote: ERROR: ed.rodriguez(a)netapp.com
remote: ERROR: edwinr(a)netapp.com
remote: ERROR:
remote: ERROR: To register an email address, please visit:
remote: ERROR: https://review.gerrithub.io/#/settings/contact
remote:
remote:
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (invalid committer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
Ed R
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Thursday, May 3, 2018 at 5:59 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi John,
Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license. Multiple people may add their own Signed-off-by line. But at least one Signed-off-by line is required for every patch and GerritHub is enforcing that correctly.
“Signed off” in terms of “I sign off on this patch being ready to go into SPDK” should really be done with Reviewed-by tags.
We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author. Both you and Ed are now in this list. If anyone else needs to be added, please ask and the core maintainers will add you (this goes for anyone reading this message – not just John’s team!)
Thanks,
-Jim
On 5/3/18, 2:35 PM, "SPDK on behalf of Meneghini, John" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of John.Meneghini(a)netapp.com<mailto:John.Meneghini(a)netapp.com>> wrote:
OK. Thanks Jim.
I think this works now... at least for me.
Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes. As a matter of policy, we'd like:
- Others to sign-off the author's code (we don't want people signing their own changes)
- The author or signer to be able to upload changes
In this example Ed signed my change and uploaded it. This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility.
In the example below I had to sign my own change to get GerritHub to take it. This is a different from the original problem which rejected my change even after I signed it.
If possible, can we fix this problem?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
[add_git_hooks 4bfdb4fe] git: add .githooks to repository
Date: Mon Feb 5 13:15:54 2018 -0500
3 files changed, 165 insertions(+)
create mode 100755 .githooks/pre-commit
create mode 100755 .githooks/pre-push
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: updated: 1, done
remote:
remote: Updated Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of james.r.harris(a)intel.com<mailto:james.r.harris(a)intel.com>> wrote:
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of benjamin.walker(a)intel.com<mailto:benjamin.walker(a)intel.com>> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 35608 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-04 15:55 Rodriguez, Edwin
0 siblings, 0 replies; 11+ messages in thread
From: Rodriguez, Edwin @ 2018-05-04 15:55 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 9650 bytes --]
I then signed it myself and the push succeeded:
[edwinr(a)edwinr-mac-0:16]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git commit --amend --sign
[bdev_fprint_removal 97fe5a5a] bdev: Replace fprintf with log message
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
[edwinr(a)edwinr-mac-0:17]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit 97fe5a5af80c0e9b48c7d50625bbf3ea747b3879 (HEAD -> bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Change-Id: Ic980f3f2f04db61e3ff7ce305817eede7a09cb5a
Signed-off-by: John Meneghini <johnm(a)netapp.com>
Signed-off-by: Ed rodriguez <edwinr(a)netapp.com>
[edwinr(a)edwinr-mac-0:18]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 538 bytes | 76.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: new: 1, done
remote:
remote: New Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/410056 bdev: Replace fprintf with log message
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
From: Ed Rodriguez <Ed.Rodriguez(a)netapp.com>
Date: Friday, May 4, 2018 at 11:52 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
In this case I’m trying to push a change to gerrithub that was signed by John M. And I get:
[edwinr(a)edwinr-mac-0:14]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b (HEAD -> bdev_fprint_removal, bitbucket/bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Signed-off-by: John Meneghini <johnm(a)netapp.com>
[edwinr(a)edwinr-mac-0:15]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 489 bytes | 69.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
remote:
remote: ERROR: In commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b
remote: ERROR: committer email address johnm(a)netapp.com
remote: ERROR: does not match your user account and you have no 'forge committer' permission.
remote: ERROR:
remote: ERROR: The following addresses are currently registered:
remote: ERROR: ed.rodriguez(a)netapp.com
remote: ERROR: edwinr(a)netapp.com
remote: ERROR:
remote: ERROR: To register an email address, please visit:
remote: ERROR: https://review.gerrithub.io/#/settings/contact
remote:
remote:
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (invalid committer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
Ed R
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Thursday, May 3, 2018 at 5:59 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi John,
Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license. Multiple people may add their own Signed-off-by line. But at least one Signed-off-by line is required for every patch and GerritHub is enforcing that correctly.
“Signed off” in terms of “I sign off on this patch being ready to go into SPDK” should really be done with Reviewed-by tags.
We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author. Both you and Ed are now in this list. If anyone else needs to be added, please ask and the core maintainers will add you (this goes for anyone reading this message – not just John’s team!)
Thanks,
-Jim
On 5/3/18, 2:35 PM, "SPDK on behalf of Meneghini, John" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of John.Meneghini(a)netapp.com<mailto:John.Meneghini(a)netapp.com>> wrote:
OK. Thanks Jim.
I think this works now... at least for me.
Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes. As a matter of policy, we'd like:
- Others to sign-off the author's code (we don't want people signing their own changes)
- The author or signer to be able to upload changes
In this example Ed signed my change and uploaded it. This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility.
In the example below I had to sign my own change to get GerritHub to take it. This is a different from the original problem which rejected my change even after I signed it.
If possible, can we fix this problem?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
[add_git_hooks 4bfdb4fe] git: add .githooks to repository
Date: Mon Feb 5 13:15:54 2018 -0500
3 files changed, 165 insertions(+)
create mode 100755 .githooks/pre-commit
create mode 100755 .githooks/pre-push
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: updated: 1, done
remote:
remote: Updated Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of james.r.harris(a)intel.com<mailto:james.r.harris(a)intel.com>> wrote:
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of benjamin.walker(a)intel.com<mailto:benjamin.walker(a)intel.com>> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 40290 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-04 15:52 Rodriguez, Edwin
0 siblings, 0 replies; 11+ messages in thread
From: Rodriguez, Edwin @ 2018-05-04 15:52 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 7945 bytes --]
In this case I’m trying to push a change to gerrithub that was signed by John M. And I get:
[edwinr(a)edwinr-mac-0:14]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git log -1
commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b (HEAD -> bdev_fprint_removal, bitbucket/bdev_fprint_removal)
Author: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Date: Thu May 3 14:36:36 2018 -0400
bdev: Replace fprintf with log message
Signed-off-by: John Meneghini <johnm(a)netapp.com>
[edwinr(a)edwinr-mac-0:15]~/p4/SPDK/gerrithub/add_git_hooks/spdk(bdev_fprint_removal)> git push origin HEAD:refs/for/master
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 489 bytes | 69.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
remote:
remote: ERROR: In commit bd6c9f009f1e08f8bb24bda62a81d06b154e6c9b
remote: ERROR: committer email address johnm(a)netapp.com
remote: ERROR: does not match your user account and you have no 'forge committer' permission.
remote: ERROR:
remote: ERROR: The following addresses are currently registered:
remote: ERROR: ed.rodriguez(a)netapp.com
remote: ERROR: edwinr(a)netapp.com
remote: ERROR:
remote: ERROR: To register an email address, please visit:
remote: ERROR: https://review.gerrithub.io/#/settings/contact
remote:
remote:
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (invalid committer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
Ed R
From: SPDK <spdk-bounces(a)lists.01.org> on behalf of "Harris, James R" <james.r.harris(a)intel.com>
Reply-To: Storage Performance Development Kit <spdk(a)lists.01.org>
Date: Thursday, May 3, 2018 at 5:59 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] GerritHub rejects push
Hi John,
Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license. Multiple people may add their own Signed-off-by line. But at least one Signed-off-by line is required for every patch and GerritHub is enforcing that correctly.
“Signed off” in terms of “I sign off on this patch being ready to go into SPDK” should really be done with Reviewed-by tags.
We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author. Both you and Ed are now in this list. If anyone else needs to be added, please ask and the core maintainers will add you (this goes for anyone reading this message – not just John’s team!)
Thanks,
-Jim
On 5/3/18, 2:35 PM, "SPDK on behalf of Meneghini, John" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of John.Meneghini(a)netapp.com<mailto:John.Meneghini(a)netapp.com>> wrote:
OK. Thanks Jim.
I think this works now... at least for me.
Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes. As a matter of policy, we'd like:
- Others to sign-off the author's code (we don't want people signing their own changes)
- The author or signer to be able to upload changes
In this example Ed signed my change and uploaded it. This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility.
In the example below I had to sign my own change to get GerritHub to take it. This is a different from the original problem which rejected my change even after I signed it.
If possible, can we fix this problem?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
[add_git_hooks 4bfdb4fe] git: add .githooks to repository
Date: Mon Feb 5 13:15:54 2018 -0500
3 files changed, 165 insertions(+)
create mode 100755 .githooks/pre-commit
create mode 100755 .githooks/pre-push
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: updated: 1, done
remote:
remote: Updated Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of james.r.harris(a)intel.com<mailto:james.r.harris(a)intel.com>> wrote:
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org<mailto:spdk-bounces(a)lists.01.org> on behalf of benjamin.walker(a)intel.com<mailto:benjamin.walker(a)intel.com>> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 32622 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-03 21:58 Harris, James R
0 siblings, 0 replies; 11+ messages in thread
From: Harris, James R @ 2018-05-03 21:58 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 5565 bytes --]
Hi John,
Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license. Multiple people may add their own Signed-off-by line. But at least one Signed-off-by line is required for every patch and GerritHub is enforcing that correctly.
“Signed off” in terms of “I sign off on this patch being ready to go into SPDK” should really be done with Reviewed-by tags.
We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author. Both you and Ed are now in this list. If anyone else needs to be added, please ask and the core maintainers will add you (this goes for anyone reading this message – not just John’s team!)
Thanks,
-Jim
On 5/3/18, 2:35 PM, "SPDK on behalf of Meneghini, John" <spdk-bounces(a)lists.01.org on behalf of John.Meneghini(a)netapp.com> wrote:
OK. Thanks Jim.
I think this works now... at least for me.
Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes. As a matter of policy, we'd like:
- Others to sign-off the author's code (we don't want people signing their own changes)
- The author or signer to be able to upload changes
In this example Ed signed my change and uploaded it. This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility.
In the example below I had to sign my own change to get GerritHub to take it. This is a different from the original problem which rejected my change even after I signed it.
If possible, can we fix this problem?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
[add_git_hooks 4bfdb4fe] git: add .githooks to repository
Date: Mon Feb 5 13:15:54 2018 -0500
3 files changed, 165 insertions(+)
create mode 100755 .githooks/pre-commit
create mode 100755 .githooks/pre-push
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: updated: 1, done
remote:
remote: Updated Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org on behalf of james.r.harris(a)intel.com> wrote:
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org on behalf of benjamin.walker(a)intel.com> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-03 21:35 Meneghini, John
0 siblings, 0 replies; 11+ messages in thread
From: Meneghini, John @ 2018-05-03 21:35 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 4144 bytes --]
OK. Thanks Jim.
I think this works now... at least for me.
Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes. As a matter of policy, we'd like:
- Others to sign-off the author's code (we don't want people signing their own changes)
- The author or signer to be able to upload changes
In this example Ed signed my change and uploaded it. This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility.
In the example below I had to sign my own change to get GerritHub to take it. This is a different from the original problem which rejected my change even after I signed it.
If possible, can we fix this problem?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
[add_git_hooks 4bfdb4fe] git: add .githooks to repository
Date: Mon Feb 5 13:15:54 2018 -0500
3 files changed, 165 insertions(+)
create mode 100755 .githooks/pre-commit
create mode 100755 .githooks/pre-push
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: updated: 1, done
remote:
remote: Updated Changes:
remote: https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
remote:
To https://review.gerrithub.io/spdk/spdk
* [new branch] HEAD -> refs/for/master
On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org on behalf of james.r.harris(a)intel.com> wrote:
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org on behalf of benjamin.walker(a)intel.com> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [SPDK] GerritHub rejects push
@ 2018-05-02 20:49 Harris, James R
0 siblings, 0 replies; 11+ messages in thread
From: Harris, James R @ 2018-05-02 20:49 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]
John – can you try it again and let me know if it works now?
On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org on behalf of benjamin.walker(a)intel.com> wrote:
On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
> I’m trying to update change request: 409577
>
> And GerritHub is complaining with the following error.
> ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to
> 409577.)
> error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
>
> Any clues as to what the problem is?
We don't allow reviews to be updated with new patch sets from people that aren't
the original owner. We did allow it originally, but some spammer/bot started
uploading junk over top of my reviews at one point. It is a permission I can
grant (I think) - I just have to figure out how to do it in a reasonable way.
It should work if Ed tries to upload the new revision though.
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk
^ permalink raw reply [flat|nested] 11+ messages in thread
* [SPDK] GerritHub rejects push
@ 2018-05-02 17:59 Meneghini, John
0 siblings, 0 replies; 11+ messages in thread
From: Meneghini, John @ 2018-05-02 17:59 UTC (permalink / raw)
To: spdk
[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]
I’m trying to update change request: 409577<https://review.gerrithub.io/409577>
And GerritHub is complaining with the following error.
Any clues as to what the problem is?
johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
Total 6 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
To https://review.gerrithub.io/spdk/spdk
! [remote rejected] HEAD -> refs/for/master (cannot add patch set to 409577.)
error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
johnm-mac-0:spdk(add_git_hooks) > git log -1
commit 9c8600f612dc617f8424e68b81b0c8a9ad09983d (HEAD -> add_git_hooks)
Author: John Meneghini <johnm(a)netapp.com>
Date: Mon Feb 5 13:15:54 2018 -0500
git: add .githooks to repository
- Add git pre-commit and pre-push hooks
- To enable type 'git config core.hooksPath .githooks'
- For for additional example hooks see the .git/hooks directory
Change-Id: I92155f4083c8547759bfbbfe4df64923548fa4d5
Signed-off-by: Ed Rodriguez <ed.rodriguez(a)netapp.com>
Signed-off-by: John Meneghini <johnm(a)netapp.com>
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 6200 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-05-04 16:20 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 19:13 [SPDK] GerritHub rejects push Walker, Benjamin
-- strict thread matches above, loose matches on Subject: below --
2018-05-04 16:20 Meneghini, John
2018-05-04 16:10 Harris, James R
2018-05-04 16:03 Rodriguez, Edwin
2018-05-04 15:59 Harris, James R
2018-05-04 15:55 Rodriguez, Edwin
2018-05-04 15:52 Rodriguez, Edwin
2018-05-03 21:58 Harris, James R
2018-05-03 21:35 Meneghini, John
2018-05-02 20:49 Harris, James R
2018-05-02 17:59 Meneghini, John
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.