All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
	John Youn <johnyoun@synopsys.com>,
	Vardan Mikayelyan <mvardan@synopsys.com>,
	Artur Petrosyan <arturp@synopsys.com>,
	Grigor Tovmasyan <tovmasya@synopsys.com>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	linux-usb@vger.kernel.org
Subject: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature
Date: Fri, 18 May 2018 17:49:03 -0700	[thread overview]
Message-ID: <1526690943-8211-1-git-send-email-john.stultz@linaro.org> (raw)

In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down")
caused the HiKey board to not correctly handle switching between
usb-gadget and usb-host mode.

Unplugging the OTG port would result in:
[   42.240973] dwc2 f72c0000.usb: dwc2_restore_host_registers: no host registers to restore
[   42.249066] dwc2 f72c0000.usb: dwc2_host_exit_hibernation: failed to restore host registers

And the USB-host ports would not function.

And plugging in the OTG port, we would see:
[   46.046557] WARNING: CPU: 3 PID: 6 at drivers/usb/dwc2/gadget.c:260 dwc2_hsotg_init_fifo+0x194/0x1a0
[   46.055761] CPU: 3 PID: 6 Comm: kworker/u16:0 Not tainted 4.17.0-rc5-00030-ge67da8c #231
[   46.055767] Hardware name: HiKey Development Board (DT)
[   46.055784] Workqueue: dwc2 dwc2_conn_id_status_change
...

Thus, this patch sets the hisi params to disable the power_down
flag by default, and gets thing working again.

Cc: John Youn <johnyoun@synopsys.com>
Cc: Vardan Mikayelyan <mvardan@synopsys.com>
Cc: Artur Petrosyan <arturp@synopsys.com>
Cc: Grigor Tovmasyan <tovmasya@synopsys.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/usb/dwc2/params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index f03e418..96b1b25 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -70,6 +70,7 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
 		GAHBCFG_HBSTLEN_SHIFT;
 	p->uframe_sched = false;
 	p->change_speed_quirk = true;
+	p->power_down = false;
 }
 
 static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
	John Youn <johnyoun@synopsys.com>,
	Vardan Mikayelyan <mvardan@synopsys.com>,
	Artur Petrosyan <arturp@synopsys.com>,
	Grigor Tovmasyan <tovmasya@synopsys.com>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	linux-usb@vger.kernel.org
Subject: usb: dwc2: Fix HiKey regression caused by power_down feature
Date: Fri, 18 May 2018 17:49:03 -0700	[thread overview]
Message-ID: <1526690943-8211-1-git-send-email-john.stultz@linaro.org> (raw)

In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down")
caused the HiKey board to not correctly handle switching between
usb-gadget and usb-host mode.

Unplugging the OTG port would result in:
[   42.240973] dwc2 f72c0000.usb: dwc2_restore_host_registers: no host registers to restore
[   42.249066] dwc2 f72c0000.usb: dwc2_host_exit_hibernation: failed to restore host registers

And the USB-host ports would not function.

And plugging in the OTG port, we would see:
[   46.046557] WARNING: CPU: 3 PID: 6 at drivers/usb/dwc2/gadget.c:260 dwc2_hsotg_init_fifo+0x194/0x1a0
[   46.055761] CPU: 3 PID: 6 Comm: kworker/u16:0 Not tainted 4.17.0-rc5-00030-ge67da8c #231
[   46.055767] Hardware name: HiKey Development Board (DT)
[   46.055784] Workqueue: dwc2 dwc2_conn_id_status_change
...

Thus, this patch sets the hisi params to disable the power_down
flag by default, and gets thing working again.

Cc: John Youn <johnyoun@synopsys.com>
Cc: Vardan Mikayelyan <mvardan@synopsys.com>
Cc: Artur Petrosyan <arturp@synopsys.com>
Cc: Grigor Tovmasyan <tovmasya@synopsys.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/usb/dwc2/params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index f03e418..96b1b25 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -70,6 +70,7 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
 		GAHBCFG_HBSTLEN_SHIFT;
 	p->uframe_sched = false;
 	p->change_speed_quirk = true;
+	p->power_down = false;
 }
 
 static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)

             reply	other threads:[~2018-05-19  0:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-19  0:49 John Stultz [this message]
2018-05-19  0:49 ` usb: dwc2: Fix HiKey regression caused by power_down feature John Stultz
2018-05-21  8:45 ` [PATCH] " Minas Harutyunyan
2018-05-21  8:45   ` Minas Harutyunyan
2018-05-21 19:40   ` [PATCH] " John Stultz
2018-05-21 19:40     ` John Stultz
2018-05-22 14:24     ` [PATCH] " Minas Harutyunyan
2018-05-22 14:24       ` Minas Harutyunyan
2018-05-22 21:57       ` [PATCH] " John Stultz
2018-05-22 21:57         ` John Stultz
2018-09-20 14:17         ` [PATCH] " Artur Petrosyan
2018-09-20 14:17           ` Artur Petrosyan
2018-09-21  1:05           ` [PATCH] " John Stultz
2018-09-21  1:05             ` John Stultz
2018-09-24  5:57             ` [PATCH] " Artur Petrosyan
2018-09-24  5:57               ` Artur Petrosyan
2018-09-24 18:51               ` [PATCH] " John Stultz
2018-09-24 18:51                 ` John Stultz
2018-09-25 10:04                 ` [PATCH] " Artur Petrosyan
2018-09-25 10:04                   ` Artur Petrosyan
2018-09-25 17:59                   ` [PATCH] " John Stultz
2018-09-25 17:59                     ` John Stultz
2018-09-26  6:02                     ` [PATCH] " Artur Petrosyan
2018-09-26  6:02                       ` Artur Petrosyan
     [not found]                       ` <CALAqxLWOBFO_CjfBFNwbC+qNjtK=TgYrPusb4r5-dThBD5bVnw@mail.gmail.com>
2018-10-01  6:56                         ` [PATCH] " Artur Petrosyan
2018-10-01  6:56                           ` Artur Petrosyan
2018-09-27 12:33                     ` [PATCH] " Artur Petrosyan
2018-09-27 12:33                       ` Artur Petrosyan
2018-09-28 18:32                       ` [PATCH] " John Stultz
2018-09-28 18:32                         ` John Stultz
2018-10-01  7:06                         ` [PATCH] " Artur Petrosyan
2018-10-01  7:06                           ` Artur Petrosyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526690943-8211-1-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=arturp@synopsys.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=johnyoun@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mvardan@synopsys.com \
    --cc=tovmasya@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.