Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

From: Artur Petrosyan <arthur.petrosyan@synopsys.com>
To: John Stultz <john.stultz@linaro.org>,
	Artur Petrosyan <arthur.petrosyan@synopsys.com>
Cc: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
	lkml <linux-kernel@vger.kernel.org>,
	John Youn <John.Youn@synopsys.com>,
	"Felipe Balbi" <felipe.balbi@linux.intel.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature
Date: Mon, 1 Oct 2018 06:56:20 +0000	[thread overview]
Message-ID: <3AD91E696667BF4BA728303C178E8A63532B89A4@am04wembxb.internal.synopsys.com> (raw)
In-Reply-To: CALAqxLWOBFO_CjfBFNwbC+qNjtK=TgYrPusb4r5-dThBD5bVnw@mail.gmail.com

Hi John,

On 9/28/2018 22:30, John Stultz wrote:
> On Tue, Sep 25, 2018 at 11:02 PM, Artur Petrosyan 
> <arthur.petrosyan@synopsys.com <mailto:arthur.petrosyan@synopsys.com>> 
> wrote:
>  > On 9/25/2018 21:59, John Stultz wrote:
>  >> On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan
>  >> <arthur.petrosyan@synopsys.com 
> <mailto:arthur.petrosyan@synopsys.com>> wrote:
>  >>> Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey
>  >>> regression caused by power_down feature"
>  >>> 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__marc.info_-3Fl-3Dlinux-2Dusb-26m-3D152669095513248-26w-3D2&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=0lMkv7adFVwkzyaUzD6-pUG0iwg4fd6b1-aHQgbqvSI&s=m8SZvo3J_Za08sMbo-S9EkhoA06YnzEN-SRm-uTPnbg&e=
>  >>>
>  >>> the power_down is disabled setting "p->power_down = false;" in
>  >>> "dwc2_set_his_params" function.
>  >>>
>  >>> Could you please clarify that the testes done for those 3 patches were
>  >>> done enabling "p->power_down = true;" in "dwc2_set_his_params" 
> function.
>  >>
>  >> So if I remove the "power_down = true" initialization, USB does not
>  >> seem to function.
>  >>
>  >> If I boot w/ the gadget port removed, the USB host ports do work, but
>  >> plugging in the gadget cable results in a bunch of:
>  >>     dwc2 f72c0000.usb: Waiting for Host Mode, Mode=Peripheral
>  >> messages.
>  >>
>  >> If I boot w/ the gadget port plugged in, USB gadget mode doesn't seem
>  >> to function at all, and when I remove the gadget cable nothing
>  >> happens, it doesn't switch to host mode.
>  >>
>  >
>  > Could you please send the dmesg logs for those situations?
> 
> Attached with some annotations in the log.
> 
>  > Also, please specify the version of the kernel that the testes has been
>  > done on.
> 
> This was done utilizing my dev/hikey-mainline-WIP branch here:
> https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/hikey-mainline-WIP 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__git.linaro.org_people_john.stultz_android-2Ddev.git_log_-3Fh-3Ddev_hikey-2Dmainline-2DWIP&d=DwMFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=NziBHu0F0eefQE7CehTMAHF9RnbfSzfHeSOy5MUMv_o&s=MzQmTF47Ved3Qe2vhL66-hyxWyLUwcC5kK7BhZjxRvI&e=>
> 
> which is 4.19.0-rc5 based + your 3 patches + removing the "p->power_down 
> = true" line.
> 
> Though the changes in my tree are mainly for getting Android up and 
> running and not related to USB.
> 
> thanks
> -john

Looking through the dmesg log you have provided, It seems that the debug 
is disabled.
Could you please provide log with debug enabled configuration. So that 
we can see more about the described problem.

Also, the register dump could be really helpful for us. Please provide 
it too.

Regards,
Artur