From: Waiman Long <longman@redhat.com> To: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>, Johannes Weiner <hannes@cmpxchg.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com> Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, Mike Galbraith <efault@gmx.de>, torvalds@linux-foundation.org, Roman Gushchin <guro@fb.com>, Juri Lelli <juri.lelli@redhat.com>, Patrick Bellasi <patrick.bellasi@arm.com>, Waiman Long <longman@redhat.com> Subject: [PATCH v9 5/7] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root Date: Tue, 29 May 2018 09:41:32 -0400 [thread overview] Message-ID: <1527601294-3444-6-git-send-email-longman@redhat.com> (raw) In-Reply-To: <1527601294-3444-1-git-send-email-longman@redhat.com> Because of the fact that setting the "cpuset.sched.domain_root" in a direct child of root can remove CPUs from the root's effective CPU list, it makes sense to know what CPUs are left in the root cgroup for scheduling purpose. So the "cpuset.cpus.effective" control file is now exposed in the v2 cgroup root. For consistency, the "cpuset.mems.effective" control file is exposed as well. Signed-off-by: Waiman Long <longman@redhat.com> --- Documentation/cgroup-v2.txt | 4 ++-- kernel/cgroup/cpuset.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/cgroup-v2.txt b/Documentation/cgroup-v2.txt index 681a809..b97f211 100644 --- a/Documentation/cgroup-v2.txt +++ b/Documentation/cgroup-v2.txt @@ -1474,7 +1474,7 @@ Cpuset Interface Files and won't be affected by any CPU hotplug events. cpuset.cpus.effective - A read-only multiple values file which exists on non-root + A read-only multiple values file which exists on all cpuset-enabled cgroups. It lists the onlined CPUs that are actually allowed to be @@ -1504,7 +1504,7 @@ Cpuset Interface Files and won't be affected by any memory nodes hotplug events. cpuset.mems.effective - A read-only multiple values file which exists on non-root + A read-only multiple values file which exists on all cpuset-enabled cgroups. It lists the onlined memory nodes that are actually allowed to diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 71cd920..f6ae483 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -2214,14 +2214,12 @@ static s64 cpuset_read_s64(struct cgroup_subsys_state *css, struct cftype *cft) .name = "cpus.effective", .seq_show = cpuset_common_seq_show, .private = FILE_EFFECTIVE_CPULIST, - .flags = CFTYPE_NOT_ON_ROOT, }, { .name = "mems.effective", .seq_show = cpuset_common_seq_show, .private = FILE_EFFECTIVE_MEMLIST, - .flags = CFTYPE_NOT_ON_ROOT, }, { -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Waiman Long <longman@redhat.com> To: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>, Johannes Weiner <hannes@cmpxchg.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com> Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, Mike Galbraith <efault@gmx.de>, torvalds@linux-foundation.org, Roman Gushchin <guro@fb.com>, Juri Lelli <juri.lelli@redhat.com>, Patrick Bellasi <patrick.bellasi@arm.com>, Waiman Long <longman@redhat.com> Subject: [PATCH v9 5/7] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root Date: Tue, 29 May 2018 09:41:32 -0400 [thread overview] Message-ID: <1527601294-3444-6-git-send-email-longman@redhat.com> (raw) In-Reply-To: <1527601294-3444-1-git-send-email-longman@redhat.com> Because of the fact that setting the "cpuset.sched.domain_root" in a direct child of root can remove CPUs from the root's effective CPU list, it makes sense to know what CPUs are left in the root cgroup for scheduling purpose. So the "cpuset.cpus.effective" control file is now exposed in the v2 cgroup root. For consistency, the "cpuset.mems.effective" control file is exposed as well. Signed-off-by: Waiman Long <longman@redhat.com> --- Documentation/cgroup-v2.txt | 4 ++-- kernel/cgroup/cpuset.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/cgroup-v2.txt b/Documentation/cgroup-v2.txt index 681a809..b97f211 100644 --- a/Documentation/cgroup-v2.txt +++ b/Documentation/cgroup-v2.txt @@ -1474,7 +1474,7 @@ Cpuset Interface Files and won't be affected by any CPU hotplug events. cpuset.cpus.effective - A read-only multiple values file which exists on non-root + A read-only multiple values file which exists on all cpuset-enabled cgroups. It lists the onlined CPUs that are actually allowed to be @@ -1504,7 +1504,7 @@ Cpuset Interface Files and won't be affected by any memory nodes hotplug events. cpuset.mems.effective - A read-only multiple values file which exists on non-root + A read-only multiple values file which exists on all cpuset-enabled cgroups. It lists the onlined memory nodes that are actually allowed to diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 71cd920..f6ae483 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -2214,14 +2214,12 @@ static s64 cpuset_read_s64(struct cgroup_subsys_state *css, struct cftype *cft) .name = "cpus.effective", .seq_show = cpuset_common_seq_show, .private = FILE_EFFECTIVE_CPULIST, - .flags = CFTYPE_NOT_ON_ROOT, }, { .name = "mems.effective", .seq_show = cpuset_common_seq_show, .private = FILE_EFFECTIVE_MEMLIST, - .flags = CFTYPE_NOT_ON_ROOT, }, { -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-29 13:43 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-29 13:41 [PATCH v9 0/7] Enable cpuset controller in default hierarchy Waiman Long 2018-05-29 13:41 ` Waiman Long 2018-05-29 13:41 ` [PATCH v9 1/7] cpuset: " Waiman Long 2018-05-29 13:41 ` Waiman Long 2018-05-29 13:41 ` [PATCH v9 2/7] cpuset: Add new v2 cpuset.sched.domain_root flag Waiman Long 2018-05-29 13:41 ` Waiman Long 2018-05-30 14:18 ` Juri Lelli 2018-05-30 14:18 ` Juri Lelli 2018-05-30 14:57 ` Waiman Long 2018-05-30 14:57 ` Waiman Long 2018-05-31 9:49 ` Peter Zijlstra 2018-05-31 9:49 ` Peter Zijlstra 2018-05-29 13:41 ` [PATCH v9 3/7] cpuset: Add cpuset.sched.load_balance flag to v2 Waiman Long 2018-05-29 13:41 ` Waiman Long 2018-05-31 10:44 ` Peter Zijlstra 2018-05-31 10:44 ` Peter Zijlstra 2018-05-31 10:54 ` Peter Zijlstra 2018-05-31 10:54 ` Peter Zijlstra 2018-05-31 13:36 ` Waiman Long 2018-05-31 13:36 ` Waiman Long 2018-05-31 12:26 ` Peter Zijlstra 2018-05-31 12:26 ` Peter Zijlstra 2018-05-31 13:54 ` Waiman Long 2018-05-31 13:54 ` Waiman Long 2018-05-31 15:20 ` Peter Zijlstra 2018-05-31 15:20 ` Peter Zijlstra 2018-05-31 15:36 ` Waiman Long 2018-05-31 15:36 ` Waiman Long 2018-05-31 16:08 ` Peter Zijlstra 2018-05-31 16:08 ` Peter Zijlstra 2018-05-31 16:42 ` Waiman Long 2018-05-31 16:42 ` Waiman Long 2018-06-20 14:46 ` Peter Zijlstra 2018-06-20 14:46 ` Peter Zijlstra 2018-06-21 7:40 ` Waiman Long 2018-06-21 7:40 ` Waiman Long 2018-05-29 13:41 ` [PATCH v9 4/7] cpuset: Make generate_sched_domains() recognize isolated_cpus Waiman Long 2018-05-29 13:41 ` Waiman Long 2018-05-29 13:41 ` Waiman Long [this message] 2018-05-29 13:41 ` [PATCH v9 5/7] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root Waiman Long 2018-05-29 13:41 ` [PATCH v9 6/7] cpuset: Don't rebuild sched domains if cpu changes in non-domain root Waiman Long 2018-05-29 13:41 ` Waiman Long 2018-05-29 13:41 ` [PATCH v9 7/7] cpuset: Allow reporting of sched domain generation info Waiman Long 2018-05-29 13:41 ` Waiman Long 2018-05-30 10:13 ` [PATCH v9 0/7] Enable cpuset controller in default hierarchy Juri Lelli 2018-05-30 10:13 ` Juri Lelli 2018-05-30 12:56 ` Waiman Long 2018-05-30 12:56 ` Waiman Long 2018-05-30 13:05 ` Juri Lelli 2018-05-30 13:05 ` Juri Lelli 2018-05-30 13:47 ` Waiman Long 2018-05-30 13:47 ` Waiman Long 2018-05-30 13:52 ` Juri Lelli 2018-05-30 13:52 ` Juri Lelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1527601294-3444-6-git-send-email-longman@redhat.com \ --to=longman@redhat.com \ --cc=cgroups@vger.kernel.org \ --cc=efault@gmx.de \ --cc=guro@fb.com \ --cc=hannes@cmpxchg.org \ --cc=juri.lelli@redhat.com \ --cc=kernel-team@fb.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan@huawei.com \ --cc=luto@amacapital.net \ --cc=mingo@redhat.com \ --cc=patrick.bellasi@arm.com \ --cc=peterz@infradead.org \ --cc=pjt@google.com \ --cc=tj@kernel.org \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.