All of lore.kernel.org
 help / color / mirror / Atom feed
From: Filippo Sironi <sironi@amazon.de>
To: sironi@amazon.de, tony.luck@intel.com, bp@alien8.de,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] x86/MCE: Get microcode revision from cpu_info instead of boot_cpu_data
Date: Fri,  1 Jun 2018 13:30:26 +0200	[thread overview]
Message-ID: <1527852626-7258-1-git-send-email-sironi@amazon.de> (raw)

Commit fa94d0c6e0f3 ("x86/MCE: Save microcode revision in machine check
records") extended MCE entries to report the microcode revision taken
from boot_cpu_data. Unfortunately, boot_cpu_data isn't updated on late
microcode loading, thus making MCE entries slightly incorrect.
Use cpu_info instead, which is updated on late microcode loading.

Fixes: fa94d0c6e0f3 ("x86/MCE: Save microcode revision in machine check records")
Signed-off-by: Filippo Sironi <sironi@amazon.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 42cf2880d0ed..4be323f9b390 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -134,7 +134,7 @@ void mce_setup(struct mce *m)
 	if (this_cpu_has(X86_FEATURE_INTEL_PPIN))
 		rdmsrl(MSR_PPIN, m->ppin);
 
-	m->microcode = boot_cpu_data.microcode;
+	m->microcode = cpu_data(m->extcpu).microcode;
 }
 
 DEFINE_PER_CPU(struct mce, injectm);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Filippo Sironi <sironi@amazon.de>
To: sironi@amazon.de, tony.luck@intel.com, bp@alien8.de,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: x86/MCE: Get microcode revision from cpu_info instead of boot_cpu_data
Date: Fri,  1 Jun 2018 13:30:26 +0200	[thread overview]
Message-ID: <1527852626-7258-1-git-send-email-sironi@amazon.de> (raw)

Commit fa94d0c6e0f3 ("x86/MCE: Save microcode revision in machine check
records") extended MCE entries to report the microcode revision taken
from boot_cpu_data. Unfortunately, boot_cpu_data isn't updated on late
microcode loading, thus making MCE entries slightly incorrect.
Use cpu_info instead, which is updated on late microcode loading.

Fixes: fa94d0c6e0f3 ("x86/MCE: Save microcode revision in machine check records")
Signed-off-by: Filippo Sironi <sironi@amazon.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 42cf2880d0ed..4be323f9b390 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -134,7 +134,7 @@ void mce_setup(struct mce *m)
 	if (this_cpu_has(X86_FEATURE_INTEL_PPIN))
 		rdmsrl(MSR_PPIN, m->ppin);
 
-	m->microcode = boot_cpu_data.microcode;
+	m->microcode = cpu_data(m->extcpu).microcode;
 }
 
 DEFINE_PER_CPU(struct mce, injectm);

             reply	other threads:[~2018-06-01 11:30 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 11:30 Filippo Sironi [this message]
2018-06-01 11:30 ` x86/MCE: Get microcode revision from cpu_info instead of boot_cpu_data Filippo Sironi
2018-06-01 12:19 ` [PATCH] " Borislav Petkov
2018-06-01 12:19   ` Borislav Petkov
2018-06-01 12:32   ` [PATCH] " Sironi, Filippo
2018-06-01 12:32     ` Filippo Sironi
2018-06-01 12:40     ` [PATCH] " Borislav Petkov
2018-06-01 12:40       ` Borislav Petkov
2018-07-30 17:49   ` [PATCH] arch/x86: Fix boot_cpu_data.microcode version output Prarit Bhargava
2018-07-30 17:49     ` Prarit Bhargava
2018-07-30 17:53     ` [PATCH] " Prarit Bhargava
2018-07-30 17:53       ` Prarit Bhargava
2018-07-31  4:02       ` [PATCH] " Borislav Petkov
2018-07-31  4:02         ` Borislav Petkov
2018-07-31 11:27   ` [PATCH v2] " Prarit Bhargava
2018-07-31 11:27     ` [v2] " Prarit Bhargava
2018-07-31 11:46     ` [PATCH v2] " Sironi, Filippo
2018-07-31 11:46       ` [v2] " Filippo Sironi
2018-07-31 13:00       ` [PATCH v2] " Borislav Petkov
2018-07-31 13:00         ` [v2] " Borislav Petkov
2018-07-31 15:31         ` [PATCH v2] " Sironi, Filippo
2018-07-31 15:31           ` [v2] " Filippo Sironi
2018-08-01 15:43     ` [PATCH v2] " Borislav Petkov
2018-08-01 15:43       ` [v2] " Borislav Petkov
2018-08-01 15:44       ` [PATCH 1/2] x86/microcode: Make sure boot_cpu_data.microcode is up-to-date Borislav Petkov
2018-08-01 15:44         ` [1/2] " Borislav Petkov
2018-08-01 15:45       ` [PATCH 2/2] x86/microcode: Update the new microcode revision unconditionally Borislav Petkov
2018-08-01 15:45         ` [2/2] " Borislav Petkov
2018-08-01 15:55       ` [PATCH v2] arch/x86: Fix boot_cpu_data.microcode version output Prarit Bhargava
2018-08-01 15:55         ` [v2] " Prarit Bhargava
2018-09-02 12:15     ` [tip:x86/urgent] x86/microcode: Make sure boot_cpu_data.microcode is up-to-date tip-bot for Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527852626-7258-1-git-send-email-sironi@amazon.de \
    --to=sironi@amazon.de \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.