All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sironi, Filippo" <sironi@amazon.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Prarit Bhargava <prarit@redhat.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] arch/x86: Fix boot_cpu_data.microcode version output
Date: Tue, 31 Jul 2018 15:31:07 +0000	[thread overview]
Message-ID: <8DCDB4EE-A8DC-4368-88C6-D70F8F98170E@amazon.de> (raw)
In-Reply-To: <20180731130003.GA22814@nazgul.tnic>


> On 31. Jul 2018, at 15:00, Borislav Petkov <bp@alien8.de> wrote:
> 
> On Tue, Jul 31, 2018 at 11:46:09AM +0000, Sironi, Filippo wrote:
>> There may be a chance of skipping this code, I think.
>> 
>> If the microcode is loaded on the hyperthread sibling of the boot cpu
>> before being loaded on the boot cpu, the boot cpu will exit earlier
>> from apply_microcode_intel() - in if (rev >= mc->hdr.rev) { ... }.
>> 
>> (This seems to be possible in apply_microcode_amd() as well.)
>> 
>> In my tree with the aforementioned change - Intel only - I also had
>> the following patch:
> 
> Yap, good catch.
> 
> -- 
> Regards/Gruss,
>    Boris.
> 
> ECO tip #101: Trim your mails when you reply.
> --
> 

Boris, Prarit,

I've sent the patch the I had in my tree and extended it to cover
apply_microcode_amd(). I don't have an AMD host available for testing,
can one of you give that a spin?

Thanks,
Filippo


Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B


WARNING: multiple messages have this Message-ID (diff)
From: Filippo Sironi <sironi@amazon.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Prarit Bhargava <prarit@redhat.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: [v2] arch/x86: Fix boot_cpu_data.microcode version output
Date: Tue, 31 Jul 2018 15:31:07 +0000	[thread overview]
Message-ID: <8DCDB4EE-A8DC-4368-88C6-D70F8F98170E@amazon.de> (raw)

> On 31. Jul 2018, at 15:00, Borislav Petkov <bp@alien8.de> wrote:
> 
> On Tue, Jul 31, 2018 at 11:46:09AM +0000, Sironi, Filippo wrote:
>> There may be a chance of skipping this code, I think.
>> 
>> If the microcode is loaded on the hyperthread sibling of the boot cpu
>> before being loaded on the boot cpu, the boot cpu will exit earlier
>> from apply_microcode_intel() - in if (rev >= mc->hdr.rev) { ... }.
>> 
>> (This seems to be possible in apply_microcode_amd() as well.)
>> 
>> In my tree with the aforementioned change - Intel only - I also had
>> the following patch:
> 
> Yap, good catch.
> 
> -- 
> Regards/Gruss,
>    Boris.
> 
> ECO tip #101: Trim your mails when you reply.
> --
> 

Boris, Prarit,

I've sent the patch the I had in my tree and extended it to cover
apply_microcode_amd(). I don't have an AMD host available for testing,
can one of you give that a spin?

Thanks,
Filippo


Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
---
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-07-31 15:35 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 11:30 [PATCH] x86/MCE: Get microcode revision from cpu_info instead of boot_cpu_data Filippo Sironi
2018-06-01 11:30 ` Filippo Sironi
2018-06-01 12:19 ` [PATCH] " Borislav Petkov
2018-06-01 12:19   ` Borislav Petkov
2018-06-01 12:32   ` [PATCH] " Sironi, Filippo
2018-06-01 12:32     ` Filippo Sironi
2018-06-01 12:40     ` [PATCH] " Borislav Petkov
2018-06-01 12:40       ` Borislav Petkov
2018-07-30 17:49   ` [PATCH] arch/x86: Fix boot_cpu_data.microcode version output Prarit Bhargava
2018-07-30 17:49     ` Prarit Bhargava
2018-07-30 17:53     ` [PATCH] " Prarit Bhargava
2018-07-30 17:53       ` Prarit Bhargava
2018-07-31  4:02       ` [PATCH] " Borislav Petkov
2018-07-31  4:02         ` Borislav Petkov
2018-07-31 11:27   ` [PATCH v2] " Prarit Bhargava
2018-07-31 11:27     ` [v2] " Prarit Bhargava
2018-07-31 11:46     ` [PATCH v2] " Sironi, Filippo
2018-07-31 11:46       ` [v2] " Filippo Sironi
2018-07-31 13:00       ` [PATCH v2] " Borislav Petkov
2018-07-31 13:00         ` [v2] " Borislav Petkov
2018-07-31 15:31         ` Sironi, Filippo [this message]
2018-07-31 15:31           ` Filippo Sironi
2018-08-01 15:43     ` [PATCH v2] " Borislav Petkov
2018-08-01 15:43       ` [v2] " Borislav Petkov
2018-08-01 15:44       ` [PATCH 1/2] x86/microcode: Make sure boot_cpu_data.microcode is up-to-date Borislav Petkov
2018-08-01 15:44         ` [1/2] " Borislav Petkov
2018-08-01 15:45       ` [PATCH 2/2] x86/microcode: Update the new microcode revision unconditionally Borislav Petkov
2018-08-01 15:45         ` [2/2] " Borislav Petkov
2018-08-01 15:55       ` [PATCH v2] arch/x86: Fix boot_cpu_data.microcode version output Prarit Bhargava
2018-08-01 15:55         ` [v2] " Prarit Bhargava
2018-09-02 12:15     ` [tip:x86/urgent] x86/microcode: Make sure boot_cpu_data.microcode is up-to-date tip-bot for Prarit Bhargava
     [not found] <<20180731112739.32338-1-prarit@redhat.com>
2018-08-01  6:38 ` [PATCH v2] arch/x86: Fix boot_cpu_data.microcode version output Oleksandr Natalenko
2018-08-01 11:38   ` Prarit Bhargava
2018-08-01 14:16     ` Oleksandr Natalenko
2018-08-01 15:29       ` Borislav Petkov
2018-08-01 15:59         ` Luck, Tony
2018-08-01 16:01           ` Oleksandr Natalenko
2018-08-01 16:14             ` Boris Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8DCDB4EE-A8DC-4368-88C6-D70F8F98170E@amazon.de \
    --to=sironi@amazon.de \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.