All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 10/20] drm/i915/gtt Onionify error handling for gen6_ppgtt_create
Date: Thu, 07 Jun 2018 11:21:34 +0100	[thread overview]
Message-ID: <152836689444.1522.7221862550800679446@mail.alporthouse.com> (raw)
In-Reply-To: <CAM0jSHMAqGO77qyMR5r1YSY1Ra9YRh0cfQh6V64EZKv9wHokZQ@mail.gmail.com>

Quoting Matthew Auld (2018-06-07 11:17:14)
> On 7 June 2018 at 10:58, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Pull the empty stubs together into the top level gen6_ppgtt_create, and
> > tear each one down on error in proper onion order (rather than use
> > Joonas' pet hate of calling the cleanup function in indeterminable
> > state).
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > Cc: Matthew Auld <matthew.william.auld@gmail.com>
> > Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
> 
> s/gtt Onionify/gtt: Onionify/

/o\ Sorry, I thought I had fixed it, I intended to when adding your r-b.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-06-07 10:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07  9:57 Guess what? HSW full-ppgtt. Almost Chris Wilson
2018-06-07  9:57 ` [PATCH 01/20] drm/i915: Apply batch location restrictions before pinning Chris Wilson
2018-06-07  9:57 ` [PATCH 02/20] drm/i915/ringbuffer: Make order of mmio to CCID/PP_DIR consistent with switch_context() Chris Wilson
2018-06-07  9:57 ` [PATCH 03/20] drm/i915/ringbuffer: Brute force context restore Chris Wilson
2018-06-07  9:57 ` [PATCH 04/20] drm/i915/ringbuffer: Force restore of mm after failed context switch Chris Wilson
2018-06-07  9:58 ` [PATCH 05/20] drm/i915/gtt: Invalidate GGTT caches after writing the gen6 page directories Chris Wilson
2018-06-07  9:58 ` [PATCH 06/20] drm/i915: Prepare for non-object vma Chris Wilson
2018-06-07  9:58 ` [PATCH 07/20] drm/i915: Decouple vma vfuncs from vm Chris Wilson
2018-06-07  9:58 ` [PATCH 08/20] drm/i915/gtt: Push allocation to hw ppgtt constructor Chris Wilson
2018-06-07  9:58 ` [PATCH 09/20] drm/i915/gtt: Subclass gen6_hw_ppgtt Chris Wilson
2018-06-07  9:58 ` [PATCH 10/20] drm/i915/gtt Onionify error handling for gen6_ppgtt_create Chris Wilson
2018-06-07 10:17   ` Matthew Auld
2018-06-07 10:21     ` Chris Wilson [this message]
2018-06-07  9:58 ` [PATCH 11/20] drm/i915/gtt: Reorder aliasing_ppgtt fini Chris Wilson
2018-06-07  9:58 ` [PATCH 12/20] drm/i915/gtt: Make gen6 page directories evictable Chris Wilson
2018-06-07  9:58 ` [PATCH 13/20] drm/i915/gtt: Only keep gen6 page directories pinned while active Chris Wilson
2018-06-07  9:58 ` [PATCH 14/20] drm/i915/gtt: Lazily allocate page directories for gen7 Chris Wilson
2018-06-07  9:58 ` [PATCH 15/20] drm/i915/gtt: Free unused page tables on unbind the context Chris Wilson
2018-06-07  9:58 ` [PATCH 16/20] drm/i915/gtt: Skip initializing PT with scratch if full Chris Wilson
2018-06-07  9:58 ` [PATCH 17/20] drm/i915/gtt: Cache the PTE encoding of the scratch page Chris Wilson
2018-06-07  9:58 ` [PATCH 18/20] drm/i915/gtt: Reduce a pair of runtime asserts Chris Wilson
2018-06-07  9:58 ` [PATCH 19/20] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt Chris Wilson
2018-06-07  9:58 ` [PATCH 20/20] RFT drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
2018-06-07 10:13 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/20] drm/i915: Apply batch location restrictions before pinning Patchwork
2018-06-07 10:18 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-06-07 10:29 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-07 14:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-06-07 14:18   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152836689444.1522.7221862550800679446@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.william.auld@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.