From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL v2 4/9] hw/pci-host/xilinx-pcie: don't make "io" region be RAM
Date: Wed, 27 Jun 2018 20:29:04 +0200 [thread overview]
Message-ID: <1530124149-3900-5-git-send-email-aleksandar.markovic@rt-rk.com> (raw)
In-Reply-To: <1530124149-3900-1-git-send-email-aleksandar.markovic@rt-rk.com>
From: Peter Maydell <peter.maydell@linaro.org>
Currently we use memory_region_init_rom_nomigrate() to create
the "io" memory region to pass to pci_register_root_bus().
This is a dummy region, because this PCI controller doesn't
support accesses to PCI IO space.
There is no reason for the dummy region to be a RAM region;
it is only used as a place where PCI BARs can be mapped,
and if you could get a PCI card to do a bus master access
to the IO space it should not get acts-like-RAM behaviour.
Use a simple container memory region instead. (We do have
one PCI card model which can do bus master accesses to IO
space -- the LSI53C895A SCSI adaptor.)
This avoids the oddity of having a memory region which is
RAM but where the RAM is not migrated.
Note that the size of the region we use here has no
effect on behaviour.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
---
hw/pci-host/xilinx-pcie.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/pci-host/xilinx-pcie.c b/hw/pci-host/xilinx-pcie.c
index 044e312..b0a31b9 100644
--- a/hw/pci-host/xilinx-pcie.c
+++ b/hw/pci-host/xilinx-pcie.c
@@ -120,9 +120,8 @@ static void xilinx_pcie_host_realize(DeviceState *dev, Error **errp)
memory_region_init(&s->mmio, OBJECT(s), "mmio", UINT64_MAX);
memory_region_set_enabled(&s->mmio, false);
- /* dummy I/O region */
- memory_region_init_ram_nomigrate(&s->io, OBJECT(s), "io", 16, NULL);
- memory_region_set_enabled(&s->io, false);
+ /* dummy PCI I/O region (not visible to the CPU) */
+ memory_region_init(&s->io, OBJECT(s), "io", 16);
/* interrupt out */
qdev_init_gpio_out_named(dev, &s->irq, "interrupt_out", 1);
--
2.7.4
next prev parent reply other threads:[~2018-06-27 18:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 18:29 [Qemu-devel] [PULL v2 0/9] MIPS queue 2018-06-27 Aleksandar Markovic
2018-06-27 18:29 ` [Qemu-devel] [PULL v2 1/9] MAINTAINERS: update target-mips maintainers Aleksandar Markovic
2018-06-27 18:29 ` [Qemu-devel] [PULL v2 2/9] hw/mips/boston: don't make flash region 'nomigrate' Aleksandar Markovic
2018-06-27 18:29 ` [Qemu-devel] [PULL v2 3/9] hw/mips/mips_malta: don't make bios " Aleksandar Markovic
2018-06-27 18:29 ` Aleksandar Markovic [this message]
2018-06-27 18:29 ` [Qemu-devel] [PULL v2 5/9] target/mips: Raise a RI when given fs is n/a from CTC1 Aleksandar Markovic
2018-06-27 18:29 ` [Qemu-devel] [PULL v2 6/9] target/mips: Fix microMIPS on reset Aleksandar Markovic
2018-06-27 18:29 ` [Qemu-devel] [PULL v2 7/9] target/mips: Update gen_flt_ldst() Aleksandar Markovic
2018-06-27 18:29 ` [Qemu-devel] [PULL v2 8/9] target/mips: Fix data type for offset Aleksandar Markovic
2018-06-27 18:29 ` [Qemu-devel] [PULL v2 9/9] target/mips: Fix gdbstub to read/write 64 bit FP registers Aleksandar Markovic
2018-06-28 14:30 ` [Qemu-devel] [PULL v2 0/9] MIPS queue 2018-06-27 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530124149-3900-5-git-send-email-aleksandar.markovic@rt-rk.com \
--to=aleksandar.markovic@rt-rk.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.