All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Gong <yibin.gong@nxp.com>
To: "festevam@gmail.com" <festevam@gmail.com>,
	Anson Huang <anson.huang@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
Date: Mon, 2 Jul 2018 02:12:52 +0000	[thread overview]
Message-ID: <1530526335.15665.13.camel@nxp.com> (raw)
In-Reply-To: <CAOMZO5BdtxKjQge5ONpnjr1yNVeTJf4u8Gh-fPqpHz7G9ipOTg@mail.gmail.com>

On 日, 2018-07-01 at 22:17 -0300, Fabio Estevam wrote:
> On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang <anson.huang@nxp.com>
> wrote:
> 
> > 
> > On some new i.MX platforms, PFuze switches are used for supplying
> > GPU/VPU
> > or other non-critical modules only, these switches need to be
> > turned off by
> > runtime PM to avoid very high power leakage, like on mScale850D.
> Ok, in this case I suggest adding a new property so that the switches
> can be turned off only when the new property is present.
> 
> When this new property is absent, then we keep the current behavior
> and avoid dtb breakage.
> 
> Since MX8M support is not in place yet, this is not urgent, so I will
> send a revert and then you can re-work the patch so that it does not
> affect the old dtbs.
> 
> Do you agree with such approach?
But in fact, the original dts is not correct without 'regulator-always-
on'since SW4 is the critical DDR power rail, although, it's kept on in
the previous kernel by no switches enable/disable interfaces provided
in pfuze driver. Adding new property which can be done totally by the
common 'regulator-always-on' is not a good choice. Keep the dts patch
adding 'regulator-always-on' ahead of pfuze driver pach adding
enable/disable interface is enough for such case I think. 

WARNING: multiple messages have this Message-ID (diff)
From: yibin.gong@nxp.com (Robin Gong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
Date: Mon, 2 Jul 2018 02:12:52 +0000	[thread overview]
Message-ID: <1530526335.15665.13.camel@nxp.com> (raw)
In-Reply-To: <CAOMZO5BdtxKjQge5ONpnjr1yNVeTJf4u8Gh-fPqpHz7G9ipOTg@mail.gmail.com>

On ?, 2018-07-01 at 22:17 -0300, Fabio Estevam wrote:
> On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang <anson.huang@nxp.com>
> wrote:
> 
> > 
> > On some new i.MX platforms, PFuze switches are used for supplying
> > GPU/VPU
> > or other non-critical modules only, these switches need to be
> > turned off by
> > runtime PM to avoid very high power leakage, like on mScale850D.
> Ok, in this case I suggest adding a new property so that the switches
> can be turned off only when the new property is present.
> 
> When this new property is absent, then we keep the current behavior
> and avoid dtb breakage.
> 
> Since MX8M support is not in place yet, this is not urgent, so I will
> send a revert and then you can re-work the patch so that it does not
> affect the old dtbs.
> 
> Do you agree with such approach?
But in fact, the original dts is not correct without 'regulator-always-
on'since SW4 is the critical DDR power rail, although, it's kept on in
the previous kernel by no switches enable/disable interfaces provided
in pfuze driver. Adding new property which can be done totally by the
common 'regulator-always-on' is not a good choice. Keep the dts patch
adding 'regulator-always-on' ahead of pfuze driver pach adding
enable/disable interface is enough for such case I think.?

  parent reply	other threads:[~2018-07-02  2:13 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 12:34 [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on Robin Gong
2018-06-25 12:34 ` Robin Gong
2018-06-25  5:53 ` Anson Huang
2018-06-25  5:53   ` Anson Huang
2018-06-25  5:53   ` Anson Huang
2018-07-01  9:34 ` Shawn Guo
2018-07-01  9:34   ` Shawn Guo
2018-07-01 23:32   ` Fabio Estevam
2018-07-01 23:32     ` Fabio Estevam
2018-07-01 23:32     ` Fabio Estevam
2018-07-02  0:53     ` Anson Huang
2018-07-02  0:53       ` Anson Huang
2018-07-02  0:53       ` Anson Huang
2018-07-02  0:54       ` Fabio Estevam
2018-07-02  0:54         ` Fabio Estevam
2018-07-02  0:54         ` Fabio Estevam
2018-07-02  0:57         ` Anson Huang
2018-07-02  0:57           ` Anson Huang
2018-07-02  0:57           ` Anson Huang
2018-07-02  1:00           ` Fabio Estevam
2018-07-02  1:00             ` Fabio Estevam
2018-07-02  1:00             ` Fabio Estevam
2018-07-02  1:03             ` Anson Huang
2018-07-02  1:03               ` Anson Huang
2018-07-02  1:03               ` Anson Huang
2018-07-02  1:05               ` Fabio Estevam
2018-07-02  1:05                 ` Fabio Estevam
2018-07-02  1:05                 ` Fabio Estevam
2018-07-02  1:09                 ` Anson Huang
2018-07-02  1:09                   ` Anson Huang
2018-07-02  1:09                   ` Anson Huang
2018-07-02  1:17                   ` Fabio Estevam
2018-07-02  1:17                     ` Fabio Estevam
2018-07-02  1:17                     ` Fabio Estevam
2018-07-02  1:19                     ` Anson Huang
2018-07-02  1:19                       ` Anson Huang
2018-07-02  1:19                       ` Anson Huang
2018-07-02  2:12                     ` Robin Gong [this message]
2018-07-02  2:12                       ` Robin Gong
2018-07-02  2:12                       ` Robin Gong
2018-07-02 23:14                       ` Fabio Estevam
2018-07-02 23:14                         ` Fabio Estevam
2018-07-02 23:14                         ` Fabio Estevam
2018-07-03  5:38                       ` Shawn Guo
2018-07-03  5:38                         ` Shawn Guo
2018-07-03  5:38                         ` Shawn Guo
2018-07-03  7:44                         ` Anson Huang
2018-07-03  7:44                           ` Anson Huang
2018-07-03  7:44                           ` Anson Huang
2018-07-03 11:10                           ` Fabio Estevam
2018-07-03 11:10                             ` Fabio Estevam
2018-07-03 11:10                             ` Fabio Estevam
2018-07-04  1:42                             ` Robin Gong
2018-07-04  1:42                               ` Robin Gong
2018-07-04  1:42                               ` Robin Gong
2018-07-04  6:56                               ` Lothar Waßmann
2018-07-04  6:56                                 ` Lothar Waßmann
2018-07-04  6:56                                 ` Lothar Waßmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530526335.15665.13.camel@nxp.com \
    --to=yibin.gong@nxp.com \
    --cc=anson.huang@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.