From: Anson Huang <anson.huang@nxp.com>
To: Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>
Cc: Robin Gong <yibin.gong@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
Date: Mon, 2 Jul 2018 00:53:50 +0000 [thread overview]
Message-ID: <AM3PR04MB131507901BFEE1A5E426EECBF5430@AM3PR04MB1315.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOMZO5BjOEGWv2dC-bp0BYHq+PhLssEKic+o7ock8_1Dobd=sQ@mail.gmail.com>
Anson Huang
Best Regards!
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: Monday, July 2, 2018 7:33 AM
> To: Shawn Guo <shawnguo@kernel.org>; Anson Huang
> <anson.huang@nxp.com>
> Cc: Robin Gong <yibin.gong@nxp.com>; Mark Rutland
> <mark.rutland@arm.com>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-kernel
> <linux-kernel@vger.kernel.org>; Rob Herring <robh+dt@kernel.org>;
> dl-linux-imx <linux-imx@nxp.com>; Sascha Hauer <kernel@pengutronix.de>;
> Fabio Estevam <fabio.estevam@nxp.com>; moderated list:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>
> Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
>
> On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote:
> >> SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should be kept
> >> always on. But it's disabled after switch disabled interface
> >> implemented in pfuze driver 'commit 5fe156f1cab4
> >> ("regulator: pfuze100: add enable/disable for switch")'.Thus, it
> >> breaks kernel bootup. Add 'regulator-always-on' for SW4.
> >>
> >> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> >
> > Does that mean boards with existing DTB installed will stop working
> > with new kernel? That's bad, and the kernel commit should probably be
> > reverted.
>
> Yes, this is a good point.
>
> Anson,
>
> Should 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for
> switch") be reverted to avoid such breakage?
Yes, I think we can revert it to avoid breakage. Didn't notice that some
i.MX platform do NOT have those critical switches always-on.
Anson.
WARNING: multiple messages have this Message-ID (diff)
From: anson.huang@nxp.com (Anson Huang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
Date: Mon, 2 Jul 2018 00:53:50 +0000 [thread overview]
Message-ID: <AM3PR04MB131507901BFEE1A5E426EECBF5430@AM3PR04MB1315.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOMZO5BjOEGWv2dC-bp0BYHq+PhLssEKic+o7ock8_1Dobd=sQ@mail.gmail.com>
Anson Huang
Best Regards!
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: Monday, July 2, 2018 7:33 AM
> To: Shawn Guo <shawnguo@kernel.org>; Anson Huang
> <anson.huang@nxp.com>
> Cc: Robin Gong <yibin.gong@nxp.com>; Mark Rutland
> <mark.rutland@arm.com>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-kernel
> <linux-kernel@vger.kernel.org>; Rob Herring <robh+dt@kernel.org>;
> dl-linux-imx <linux-imx@nxp.com>; Sascha Hauer <kernel@pengutronix.de>;
> Fabio Estevam <fabio.estevam@nxp.com>; moderated list:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>
> Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
>
> On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote:
> >> SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should be kept
> >> always on. But it's disabled after switch disabled interface
> >> implemented in pfuze driver 'commit 5fe156f1cab4
> >> ("regulator: pfuze100: add enable/disable for switch")'.Thus, it
> >> breaks kernel bootup. Add 'regulator-always-on' for SW4.
> >>
> >> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> >
> > Does that mean boards with existing DTB installed will stop working
> > with new kernel? That's bad, and the kernel commit should probably be
> > reverted.
>
> Yes, this is a good point.
>
> Anson,
>
> Should 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for
> switch") be reverted to avoid such breakage?
Yes, I think we can revert it to avoid breakage. Didn't notice that some
i.MX platform do NOT have those critical switches always-on.
Anson.
next prev parent reply other threads:[~2018-07-02 0:54 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 12:34 [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on Robin Gong
2018-06-25 12:34 ` Robin Gong
2018-06-25 5:53 ` Anson Huang
2018-06-25 5:53 ` Anson Huang
2018-06-25 5:53 ` Anson Huang
2018-07-01 9:34 ` Shawn Guo
2018-07-01 9:34 ` Shawn Guo
2018-07-01 23:32 ` Fabio Estevam
2018-07-01 23:32 ` Fabio Estevam
2018-07-01 23:32 ` Fabio Estevam
2018-07-02 0:53 ` Anson Huang [this message]
2018-07-02 0:53 ` Anson Huang
2018-07-02 0:53 ` Anson Huang
2018-07-02 0:54 ` Fabio Estevam
2018-07-02 0:54 ` Fabio Estevam
2018-07-02 0:54 ` Fabio Estevam
2018-07-02 0:57 ` Anson Huang
2018-07-02 0:57 ` Anson Huang
2018-07-02 0:57 ` Anson Huang
2018-07-02 1:00 ` Fabio Estevam
2018-07-02 1:00 ` Fabio Estevam
2018-07-02 1:00 ` Fabio Estevam
2018-07-02 1:03 ` Anson Huang
2018-07-02 1:03 ` Anson Huang
2018-07-02 1:03 ` Anson Huang
2018-07-02 1:05 ` Fabio Estevam
2018-07-02 1:05 ` Fabio Estevam
2018-07-02 1:05 ` Fabio Estevam
2018-07-02 1:09 ` Anson Huang
2018-07-02 1:09 ` Anson Huang
2018-07-02 1:09 ` Anson Huang
2018-07-02 1:17 ` Fabio Estevam
2018-07-02 1:17 ` Fabio Estevam
2018-07-02 1:17 ` Fabio Estevam
2018-07-02 1:19 ` Anson Huang
2018-07-02 1:19 ` Anson Huang
2018-07-02 1:19 ` Anson Huang
2018-07-02 2:12 ` Robin Gong
2018-07-02 2:12 ` Robin Gong
2018-07-02 2:12 ` Robin Gong
2018-07-02 23:14 ` Fabio Estevam
2018-07-02 23:14 ` Fabio Estevam
2018-07-02 23:14 ` Fabio Estevam
2018-07-03 5:38 ` Shawn Guo
2018-07-03 5:38 ` Shawn Guo
2018-07-03 5:38 ` Shawn Guo
2018-07-03 7:44 ` Anson Huang
2018-07-03 7:44 ` Anson Huang
2018-07-03 7:44 ` Anson Huang
2018-07-03 11:10 ` Fabio Estevam
2018-07-03 11:10 ` Fabio Estevam
2018-07-03 11:10 ` Fabio Estevam
2018-07-04 1:42 ` Robin Gong
2018-07-04 1:42 ` Robin Gong
2018-07-04 1:42 ` Robin Gong
2018-07-04 6:56 ` Lothar Waßmann
2018-07-04 6:56 ` Lothar Waßmann
2018-07-04 6:56 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM3PR04MB131507901BFEE1A5E426EECBF5430@AM3PR04MB1315.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.