All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Oliver Hübers" <oliver.huebers@web.de>
To: gregkh@linuxfoundation.org
Cc: matthias.bgg@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@i4.cs.fau.de,
	"Oliver Hübers" <oliver.huebers@web.de>,
	"Vanessa Borgmann" <nessa.x@web.de>
Subject: [PATCH 3/4] staging: mt7621: Add braces around macro argument
Date: Fri, 13 Jul 2018 15:41:05 +0200	[thread overview]
Message-ID: <1531489266-20410-3-git-send-email-oliver.huebers@web.de> (raw)
In-Reply-To: <1531489266-20410-1-git-send-email-oliver.huebers@web.de>

Add braces around macro argument to avoid precedence problems.
This fixes the corresponding checkpatch warning.

Signed-off-by: Oliver Hübers <oliver.huebers@web.de>
Signed-off-by: Vanessa Borgmann <nessa.x@web.de>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index d0d3fb9..c118d78 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -132,7 +132,8 @@
 		else							\
 			rt_sysc_m32(val, 0, RALINK_RSTCTRL);		\
 	} while (0)
-#define DEASSERT_SYSRST_PCIE(val)	\
+
+#define DEASSERT_SYSRST_PCIE(val)					\
 	do {								\
 		if (rt_sysc_r32(SYSC_REG_CHIP_REV) == 0x00030101)	\
 			rt_sysc_m32(val, 0, RALINK_RSTCTRL);		\
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: "Oliver Hübers" <oliver.huebers@web.de>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org,
	"Oliver Hübers" <oliver.huebers@web.de>,
	linux-kernel@i4.cs.fau.de, "Vanessa Borgmann" <nessa.x@web.de>,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] staging: mt7621: Add braces around macro argument
Date: Fri, 13 Jul 2018 15:41:05 +0200	[thread overview]
Message-ID: <1531489266-20410-3-git-send-email-oliver.huebers@web.de> (raw)
In-Reply-To: <1531489266-20410-1-git-send-email-oliver.huebers@web.de>

Add braces around macro argument to avoid precedence problems.
This fixes the corresponding checkpatch warning.

Signed-off-by: Oliver Hübers <oliver.huebers@web.de>
Signed-off-by: Vanessa Borgmann <nessa.x@web.de>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index d0d3fb9..c118d78 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -132,7 +132,8 @@
 		else							\
 			rt_sysc_m32(val, 0, RALINK_RSTCTRL);		\
 	} while (0)
-#define DEASSERT_SYSRST_PCIE(val)	\
+
+#define DEASSERT_SYSRST_PCIE(val)					\
 	do {								\
 		if (rt_sysc_r32(SYSC_REG_CHIP_REV) == 0x00030101)	\
 			rt_sysc_m32(val, 0, RALINK_RSTCTRL);		\
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)
From: oliver.huebers@web.de (Oliver Hübers)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] staging: mt7621: Add braces around macro argument
Date: Fri, 13 Jul 2018 15:41:05 +0200	[thread overview]
Message-ID: <1531489266-20410-3-git-send-email-oliver.huebers@web.de> (raw)
In-Reply-To: <1531489266-20410-1-git-send-email-oliver.huebers@web.de>

Add braces around macro argument to avoid precedence problems.
This fixes the corresponding checkpatch warning.

Signed-off-by: Oliver H?bers <oliver.huebers@web.de>
Signed-off-by: Vanessa Borgmann <nessa.x@web.de>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index d0d3fb9..c118d78 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -132,7 +132,8 @@
 		else							\
 			rt_sysc_m32(val, 0, RALINK_RSTCTRL);		\
 	} while (0)
-#define DEASSERT_SYSRST_PCIE(val)	\
+
+#define DEASSERT_SYSRST_PCIE(val)					\
 	do {								\
 		if (rt_sysc_r32(SYSC_REG_CHIP_REV) == 0x00030101)	\
 			rt_sysc_m32(val, 0, RALINK_RSTCTRL);		\
-- 
2.7.4

  parent reply	other threads:[~2018-07-13 13:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 13:41 [PATCH 1/4] staging: mt7621-pci: Include preferred headers Oliver Hübers
2018-07-13 13:41 ` Oliver Hübers
2018-07-13 13:41 ` [PATCH 2/4] staging: mt7621-pci: Fix coding style issues reported by checkpatch Oliver Hübers
2018-07-13 13:41   ` Oliver Hübers
2018-07-16  8:34   ` Greg KH
2018-07-16  8:34     ` Greg KH
2018-07-13 13:41 ` Oliver Hübers [this message]
2018-07-13 13:41   ` [PATCH 3/4] staging: mt7621: Add braces around macro argument Oliver Hübers
2018-07-13 13:41   ` Oliver Hübers
2018-07-16  8:35   ` Greg KH
2018-07-16  8:35     ` Greg KH
2018-07-13 13:41 ` [PATCH 4/4] staging: mt7621: Add SPDX license identifier Oliver Hübers
2018-07-13 13:41   ` Oliver Hübers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531489266-20410-3-git-send-email-oliver.huebers@web.de \
    --to=oliver.huebers@web.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nessa.x@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.