All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Oliver Hübers" <oliver.huebers@web.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de,
	Vanessa Borgmann <nessa.x@web.de>,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] staging: mt7621-pci: Fix coding style issues reported by checkpatch
Date: Mon, 16 Jul 2018 10:34:41 +0200	[thread overview]
Message-ID: <20180716083441.GA7903@kroah.com> (raw)
In-Reply-To: <1531489266-20410-2-git-send-email-oliver.huebers@web.de>

On Fri, Jul 13, 2018 at 03:41:04PM +0200, Oliver Hübers wrote:
> From: Vanessa Borgmann <nessa.x@web.de>
> 
> Fix errors: space errors, braces
> Fix warnings: comment warnings
> 
> Signed-off-by: Oliver Hübers <oliver.huebers@web.de>
> Signed-off-by: Vanessa Borgmann <nessa.x@web.de>
> ---
>  drivers/staging/mt7621-pci/pci-mt7621.c | 230 ++++++++++++++++----------------
>  1 file changed, 112 insertions(+), 118 deletions(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] staging: mt7621-pci: Fix coding style issues reported by checkpatch
Date: Mon, 16 Jul 2018 10:34:41 +0200	[thread overview]
Message-ID: <20180716083441.GA7903@kroah.com> (raw)
In-Reply-To: <1531489266-20410-2-git-send-email-oliver.huebers@web.de>

On Fri, Jul 13, 2018 at 03:41:04PM +0200, Oliver H?bers wrote:
> From: Vanessa Borgmann <nessa.x@web.de>
> 
> Fix errors: space errors, braces
> Fix warnings: comment warnings
> 
> Signed-off-by: Oliver H?bers <oliver.huebers@web.de>
> Signed-off-by: Vanessa Borgmann <nessa.x@web.de>
> ---
>  drivers/staging/mt7621-pci/pci-mt7621.c | 230 ++++++++++++++++----------------
>  1 file changed, 112 insertions(+), 118 deletions(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

  reply	other threads:[~2018-07-16  8:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 13:41 [PATCH 1/4] staging: mt7621-pci: Include preferred headers Oliver Hübers
2018-07-13 13:41 ` Oliver Hübers
2018-07-13 13:41 ` [PATCH 2/4] staging: mt7621-pci: Fix coding style issues reported by checkpatch Oliver Hübers
2018-07-13 13:41   ` Oliver Hübers
2018-07-16  8:34   ` Greg KH [this message]
2018-07-16  8:34     ` Greg KH
2018-07-13 13:41 ` [PATCH 3/4] staging: mt7621: Add braces around macro argument Oliver Hübers
2018-07-13 13:41   ` Oliver Hübers
2018-07-13 13:41   ` Oliver Hübers
2018-07-16  8:35   ` Greg KH
2018-07-16  8:35     ` Greg KH
2018-07-13 13:41 ` [PATCH 4/4] staging: mt7621: Add SPDX license identifier Oliver Hübers
2018-07-13 13:41   ` Oliver Hübers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716083441.GA7903@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nessa.x@web.de \
    --cc=oliver.huebers@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.