From: Wei Wang <wei.w.wang@intel.com> To: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org Cc: wei.w.wang@intel.com Subject: [PATCH v2 1/2] virtio-balloon: remove BUG() in init_vqs Date: Fri, 27 Jul 2018 17:24:54 +0800 [thread overview] Message-ID: <1532683495-31974-2-git-send-email-wei.w.wang@intel.com> (raw) In-Reply-To: <1532683495-31974-1-git-send-email-wei.w.wang@intel.com> It's a bit overkill to use BUG when failing to add an entry to the stats_vq in init_vqs. So remove it and just return the error to the caller to bail out nicely. Signed-off-by: Wei Wang <wei.w.wang@intel.com> Cc: Michael S. Tsirkin <mst@redhat.com> --- drivers/virtio/virtio_balloon.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 6b237e3..9356a1a 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -455,9 +455,13 @@ static int init_vqs(struct virtio_balloon *vb) num_stats = update_balloon_stats(vb); sg_init_one(&sg, vb->stats, sizeof(vb->stats[0]) * num_stats); - if (virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, GFP_KERNEL) - < 0) - BUG(); + err = virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, + GFP_KERNEL); + if (err) { + dev_warn(&vb->vdev->dev, "%s: add stat_vq failed\n", + __func__); + return err; + } virtqueue_kick(vb->stats_vq); } return 0; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com> To: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org Cc: wei.w.wang@intel.com Subject: [virtio-dev] [PATCH v2 1/2] virtio-balloon: remove BUG() in init_vqs Date: Fri, 27 Jul 2018 17:24:54 +0800 [thread overview] Message-ID: <1532683495-31974-2-git-send-email-wei.w.wang@intel.com> (raw) In-Reply-To: <1532683495-31974-1-git-send-email-wei.w.wang@intel.com> It's a bit overkill to use BUG when failing to add an entry to the stats_vq in init_vqs. So remove it and just return the error to the caller to bail out nicely. Signed-off-by: Wei Wang <wei.w.wang@intel.com> Cc: Michael S. Tsirkin <mst@redhat.com> --- drivers/virtio/virtio_balloon.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 6b237e3..9356a1a 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -455,9 +455,13 @@ static int init_vqs(struct virtio_balloon *vb) num_stats = update_balloon_stats(vb); sg_init_one(&sg, vb->stats, sizeof(vb->stats[0]) * num_stats); - if (virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, GFP_KERNEL) - < 0) - BUG(); + err = virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, + GFP_KERNEL); + if (err) { + dev_warn(&vb->vdev->dev, "%s: add stat_vq failed\n", + __func__); + return err; + } virtqueue_kick(vb->stats_vq); } return 0; -- 2.7.4 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-07-27 9:52 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-27 9:24 [PATCH v2 0/2] virtio-balloon: some improvements Wei Wang 2018-07-27 9:24 ` [virtio-dev] " Wei Wang 2018-07-27 9:24 ` Wei Wang 2018-07-27 9:24 ` [PATCH v2 1/2] virtio-balloon: remove BUG() in init_vqs Wei Wang 2018-07-27 9:24 ` Wei Wang [this message] 2018-07-27 9:24 ` [virtio-dev] " Wei Wang 2018-07-27 9:24 ` [PATCH v2 2/2] virtio_balloon: replace oom notifier with shrinker Wei Wang 2018-07-27 9:24 ` [virtio-dev] " Wei Wang 2018-07-30 9:00 ` Michal Hocko 2018-07-30 9:00 ` Michal Hocko 2018-08-01 11:12 ` Wei Wang 2018-08-01 11:12 ` [virtio-dev] " Wei Wang 2018-08-01 11:34 ` Michal Hocko 2018-08-01 11:34 ` Michal Hocko 2018-08-02 10:32 ` Wei Wang 2018-08-02 10:32 ` [virtio-dev] " Wei Wang 2018-08-02 11:00 ` Tetsuo Handa 2018-08-02 11:00 ` Tetsuo Handa 2018-08-02 11:27 ` Wei Wang 2018-08-02 11:27 ` Wei Wang 2018-08-02 11:27 ` [virtio-dev] " Wei Wang 2018-08-02 11:29 ` Michal Hocko 2018-08-02 11:29 ` Michal Hocko 2018-08-02 11:47 ` Michal Hocko 2018-08-03 5:35 ` Wei Wang 2018-08-03 5:35 ` [virtio-dev] " Wei Wang 2018-08-03 5:35 ` Wei Wang 2018-08-02 11:47 ` Michal Hocko 2018-08-02 15:18 ` Michael S. Tsirkin 2018-08-02 15:18 ` [virtio-dev] " Michael S. Tsirkin 2018-08-02 15:18 ` Michael S. Tsirkin 2018-08-02 10:32 ` Wei Wang 2018-08-01 11:12 ` Wei Wang 2018-07-27 9:24 ` Wei Wang 2018-07-27 14:06 ` [PATCH v2 0/2] virtio-balloon: some improvements Michael S. Tsirkin 2018-07-27 14:06 ` Michael S. Tsirkin 2018-07-27 14:06 ` [virtio-dev] " Michael S. Tsirkin 2018-07-28 2:00 ` Wang, Wei W 2018-07-28 2:00 ` Wang, Wei W 2018-07-28 2:00 ` [virtio-dev] " Wang, Wei W 2018-07-28 2:00 ` Wang, Wei W
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1532683495-31974-2-git-send-email-wei.w.wang@intel.com \ --to=wei.w.wang@intel.com \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=mst@redhat.com \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.