From: Wei Wang <wei.w.wang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
mst@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH v2 2/2] virtio_balloon: replace oom notifier with shrinker
Date: Wed, 01 Aug 2018 19:12:25 +0800 [thread overview]
Message-ID: <5B619599.1000307@intel.com> (raw)
In-Reply-To: <20180730090041.GC24267@dhcp22.suse.cz>
On 07/30/2018 05:00 PM, Michal Hocko wrote:
> On Fri 27-07-18 17:24:55, Wei Wang wrote:
>> The OOM notifier is getting deprecated to use for the reasons mentioned
>> here by Michal Hocko: https://lkml.org/lkml/2018/7/12/314
>>
>> This patch replaces the virtio-balloon oom notifier with a shrinker
>> to release balloon pages on memory pressure.
> It would be great to document the replacement. This is not a small
> change...
OK. I plan to document the following to the commit log:
The OOM notifier is getting deprecated to use for the reasons:
- As a callout from the oom context, it is too subtle and easy to
generate bugs and corner cases which are hard to track;
- It is called too late (after the reclaiming has been performed).
Drivers with large amuont of reclaimable memory is expected to be
released them at an early age of memory pressure;
- The notifier callback isn't aware of the oom contrains;
Link: https://lkml.org/lkml/2018/7/12/314
This patch replaces the virtio-balloon oom notifier with a shrinker
to release balloon pages on memory pressure. Users can set the
amount of
memory pages to release each time a shrinker_scan is called via the
module parameter balloon_pages_to_shrink, and the default amount is 256
pages. Historically, the feature VIRTIO_BALLOON_F_DEFLATE_ON_OOM has
been used to release balloon pages on OOM. We continue to use this
feature bit for the shrinker, so the shrinker is only registered when
this feature bit has been negotiated with host.
In addition, the bug in the replaced virtballoon_oom_notify that only
VIRTIO_BALLOON_ARRAY_PFNS_MAX (i.e 256) balloon pages can be freed
though the user has specified more than that number is fixed in the
shrinker_scan function.
Best,
Wei
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
mst@redhat.com, akpm@linux-foundation.org
Subject: [virtio-dev] Re: [PATCH v2 2/2] virtio_balloon: replace oom notifier with shrinker
Date: Wed, 01 Aug 2018 19:12:25 +0800 [thread overview]
Message-ID: <5B619599.1000307@intel.com> (raw)
In-Reply-To: <20180730090041.GC24267@dhcp22.suse.cz>
On 07/30/2018 05:00 PM, Michal Hocko wrote:
> On Fri 27-07-18 17:24:55, Wei Wang wrote:
>> The OOM notifier is getting deprecated to use for the reasons mentioned
>> here by Michal Hocko: https://lkml.org/lkml/2018/7/12/314
>>
>> This patch replaces the virtio-balloon oom notifier with a shrinker
>> to release balloon pages on memory pressure.
> It would be great to document the replacement. This is not a small
> change...
OK. I plan to document the following to the commit log:
The OOM notifier is getting deprecated to use for the reasons:
- As a callout from the oom context, it is too subtle and easy to
generate bugs and corner cases which are hard to track;
- It is called too late (after the reclaiming has been performed).
Drivers with large amuont of reclaimable memory is expected to be
released them at an early age of memory pressure;
- The notifier callback isn't aware of the oom contrains;
Link: https://lkml.org/lkml/2018/7/12/314
This patch replaces the virtio-balloon oom notifier with a shrinker
to release balloon pages on memory pressure. Users can set the
amount of
memory pages to release each time a shrinker_scan is called via the
module parameter balloon_pages_to_shrink, and the default amount is 256
pages. Historically, the feature VIRTIO_BALLOON_F_DEFLATE_ON_OOM has
been used to release balloon pages on OOM. We continue to use this
feature bit for the shrinker, so the shrinker is only registered when
this feature bit has been negotiated with host.
In addition, the bug in the replaced virtballoon_oom_notify that only
VIRTIO_BALLOON_ARRAY_PFNS_MAX (i.e 256) balloon pages can be freed
though the user has specified more than that number is fixed in the
shrinker_scan function.
Best,
Wei
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-08-01 11:08 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 9:24 [PATCH v2 0/2] virtio-balloon: some improvements Wei Wang
2018-07-27 9:24 ` [virtio-dev] " Wei Wang
2018-07-27 9:24 ` Wei Wang
2018-07-27 9:24 ` [PATCH v2 1/2] virtio-balloon: remove BUG() in init_vqs Wei Wang
2018-07-27 9:24 ` Wei Wang
2018-07-27 9:24 ` [virtio-dev] " Wei Wang
2018-07-27 9:24 ` [PATCH v2 2/2] virtio_balloon: replace oom notifier with shrinker Wei Wang
2018-07-27 9:24 ` [virtio-dev] " Wei Wang
2018-07-30 9:00 ` Michal Hocko
2018-07-30 9:00 ` Michal Hocko
2018-08-01 11:12 ` Wei Wang [this message]
2018-08-01 11:12 ` [virtio-dev] " Wei Wang
2018-08-01 11:34 ` Michal Hocko
2018-08-01 11:34 ` Michal Hocko
2018-08-02 10:32 ` Wei Wang
2018-08-02 10:32 ` [virtio-dev] " Wei Wang
2018-08-02 11:00 ` Tetsuo Handa
2018-08-02 11:00 ` Tetsuo Handa
2018-08-02 11:27 ` Wei Wang
2018-08-02 11:27 ` Wei Wang
2018-08-02 11:27 ` [virtio-dev] " Wei Wang
2018-08-02 11:29 ` Michal Hocko
2018-08-02 11:29 ` Michal Hocko
2018-08-02 11:47 ` Michal Hocko
2018-08-03 5:35 ` Wei Wang
2018-08-03 5:35 ` [virtio-dev] " Wei Wang
2018-08-03 5:35 ` Wei Wang
2018-08-02 11:47 ` Michal Hocko
2018-08-02 15:18 ` Michael S. Tsirkin
2018-08-02 15:18 ` [virtio-dev] " Michael S. Tsirkin
2018-08-02 15:18 ` Michael S. Tsirkin
2018-08-02 10:32 ` Wei Wang
2018-08-01 11:12 ` Wei Wang
2018-07-27 9:24 ` Wei Wang
2018-07-27 14:06 ` [PATCH v2 0/2] virtio-balloon: some improvements Michael S. Tsirkin
2018-07-27 14:06 ` Michael S. Tsirkin
2018-07-27 14:06 ` [virtio-dev] " Michael S. Tsirkin
2018-07-28 2:00 ` Wang, Wei W
2018-07-28 2:00 ` Wang, Wei W
2018-07-28 2:00 ` [virtio-dev] " Wang, Wei W
2018-07-28 2:00 ` Wang, Wei W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B619599.1000307@intel.com \
--to=wei.w.wang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.