From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: "jarkko.sakkinen@linux.intel.com"
<jarkko.sakkinen@linux.intel.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
"nayna@linux.ibm.com" <nayna@linux.ibm.com>
Cc: "nayna@linux.vnet.ibm.com" <nayna@linux.vnet.ibm.com>,
"Struk, Tadeusz" <tadeusz.struk@intel.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 05/21] tpm: factor out tpm_get_timeouts()
Date: Thu, 11 Oct 2018 20:16:34 +0000 [thread overview]
Message-ID: <1539288758.1669.15.camel@intel.com> (raw)
In-Reply-To: <b6b0fb96-e955-bf86-9bac-e6acee1e33e0@linux.ibm.com>
On Thu, 2018-10-11 at 22:30 +0530, Nayna Jain wrote:
>
> On 09/29/2018 04:00 AM, Tomas Winkler wrote:
> >
> > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> > index 73511cd89bef..a97d72fcda5b 100644
> > --- a/drivers/char/tpm/tpm.h
> > +++ b/drivers/char/tpm/tpm.h
> > @@ -544,8 +544,10 @@ int tpm_startup(struct tpm_chip *chip);
> > ssize_t tpm_getcap(struct tpm_chip *chip, u32 subcap_id, cap_t *cap,
> > const char *desc, size_t min_cap_length);
> > int tpm_get_timeouts(struct tpm_chip *);
> > -int tpm1_auto_startup(struct tpm_chip *chip);
> > int tpm_do_selftest(struct tpm_chip *chip);
> > +
> > +int tpm1_auto_startup(struct tpm_chip *chip);
>
> What is different in this tpm1_auto_startup(...) and the original one ?
>
> Is this needed ?
Looks like an amending hiccup, will fix.
Thanks
Tomas
next prev parent reply other threads:[~2018-10-11 20:18 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 22:30 [PATCH v5 00/21] tpm: separate tpm 1.x and tpm 2.x commands Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 01/21] tpm2: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-02 0:38 ` Jarkko Sakkinen
2018-10-02 0:40 ` Jarkko Sakkinen
2018-09-28 22:30 ` [PATCH v5 02/21] tpm: sort objects in the Makefile Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 03/21] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-11 16:55 ` Nayna Jain
2018-10-11 16:55 ` Nayna Jain
2018-09-28 22:30 ` [PATCH v5 04/21] tpm: add tpm_calc_ordinal_duration() wrapper Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 05/21] tpm: factor out tpm_get_timeouts() Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-11 17:00 ` Nayna Jain
2018-10-11 17:00 ` Nayna Jain
2018-10-11 20:16 ` Winkler, Tomas [this message]
2018-10-11 20:16 ` Winkler, Tomas
2018-09-28 22:30 ` [PATCH v5 06/21] tpm: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-02 0:42 ` Jarkko Sakkinen
2018-10-02 0:42 ` Jarkko Sakkinen
2018-10-02 9:28 ` Nayna Jain
2018-10-02 9:28 ` Nayna Jain
2018-10-03 12:02 ` Jarkko Sakkinen
2018-10-03 12:02 ` Jarkko Sakkinen
2018-10-12 9:31 ` Nayna Jain
2018-10-12 9:31 ` Nayna Jain
2018-10-16 16:48 ` Jarkko Sakkinen
2018-09-28 22:30 ` [PATCH v5 07/21] tpm: move tpm_getcap " Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 08/21] tpm: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-02 0:43 ` Jarkko Sakkinen
2018-09-28 22:30 ` [PATCH v5 09/21] tpm: move tpm 1.x selftest code from tpm-interface.c tpm1-cmd.c Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 10/21] tpm: factor out tpm 1.x pm suspend flow into tpm1-cmd.c Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-02 0:45 ` Jarkko Sakkinen
2018-09-28 22:30 ` [PATCH v5 11/21] tpm: factor out tpm_startup function Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-02 0:46 ` Jarkko Sakkinen
2018-09-28 22:30 ` [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-02 0:52 ` Jarkko Sakkinen
2018-10-02 4:58 ` Winkler, Tomas
2018-10-02 4:58 ` Winkler, Tomas
2018-10-03 12:01 ` Jarkko Sakkinen
2018-10-03 12:01 ` Jarkko Sakkinen
2018-10-03 22:24 ` Winkler, Tomas
2018-10-03 22:24 ` Winkler, Tomas
2018-10-04 11:35 ` Jarkko Sakkinen
2018-10-04 11:35 ` Jarkko Sakkinen
2018-10-04 11:36 ` Jarkko Sakkinen
2018-10-04 11:36 ` Jarkko Sakkinen
2018-10-04 11:45 ` Winkler, Tomas
2018-10-04 11:45 ` Winkler, Tomas
2018-10-04 12:20 ` Roberto Sassu
2018-10-04 12:20 ` Roberto Sassu
2018-10-04 13:46 ` Winkler, Tomas
2018-10-04 13:46 ` Winkler, Tomas
2018-10-04 14:10 ` Roberto Sassu
2018-10-04 14:10 ` Roberto Sassu
2018-10-05 11:31 ` Jarkko Sakkinen
2018-10-05 11:31 ` Jarkko Sakkinen
2018-09-28 22:30 ` [PATCH v5 13/21] tpm: add tpm_auto_startup() into tpm-interface.c Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-02 0:56 ` Jarkko Sakkinen
2018-09-28 22:30 ` [PATCH v5 14/21] tpm: tpm-interface.c drop unused macros Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 15/21] tpm: tpm-space.c remove unneeded semicolon Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 16/21] tpm: tpm1: rewrite tpm1_get_random() using tpm_buf structure Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 17/21] tpm1: implement tpm1_pcr_read_dev() " Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 18/21] tmp1: rename tpm1_pcr_read_dev to tpm1_pcr_read() Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 19/21] tpm1: reimplement SAVESTATE using tpm_buf Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-09-28 22:30 ` [PATCH v5 20/21] tpm1: reimplement tpm1_continue_selftest() " Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-17 6:02 ` Nayna Jain
2018-10-17 6:02 ` Nayna Jain
2018-09-28 22:30 ` [PATCH v5 21/21] tpm: use u32 instead of int for PCR index Tomas Winkler
2018-09-28 22:30 ` Tomas Winkler
2018-10-02 0:58 ` Jarkko Sakkinen
2018-10-02 0:44 ` [PATCH v5 00/21] tpm: separate tpm 1.x and tpm 2.x commands Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539288758.1669.15.camel@intel.com \
--to=tomas.winkler@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=nayna@linux.vnet.ibm.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.