From: Nayna Jain <nayna@linux.vnet.ibm.com> To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Tomas Winkler <tomas.winkler@intel.com> Cc: Jason Gunthorpe <jgg@ziepe.ca>, Alexander Usyskin <alexander.usyskin@intel.com>, Tadeusz Struk <tadeusz.struk@intel.com>, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 06/21] tpm: move tpm1_pcr_extend to tpm1-cmd.c Date: Tue, 2 Oct 2018 14:58:00 +0530 [thread overview] Message-ID: <7e42b9c4-2299-a62d-ac79-0e147cb60573@linux.vnet.ibm.com> (raw) In-Reply-To: <20181002004248.GC23753@linux.intel.com> On 10/02/2018 06:12 AM, Jarkko Sakkinen wrote: > On Sat, Sep 29, 2018 at 01:30:20AM +0300, Tomas Winkler wrote: >> Move tpm1_pcr_extend to tpm1-cmd.c and remove >> unused pcrextend_header structure and >> EXTEND_PCR_RESULT_SIZE and EXTEND_PCR_RESULT_BODY_SIZE >> defines. >> >> Fixes warning: >> drivers/char/tpm/tpm-interface.c:609:38: warning: ‘pcrextend_header’ defined but not used [-Wunused-const-variable=] >> static const struct tpm_input_header pcrextend_header = { >> ^~~~~~~~~~~~~~~~ >> >> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> >> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Would need help with this from someone with a working IMA setup > on testing. My test system is down for now.. I think it will be up later in this week. I can test it then. Thanks & Regards, - Nayna > > /Jarkko >
WARNING: multiple messages have this Message-ID (diff)
From: Nayna Jain <nayna@linux.vnet.ibm.com> To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Tomas Winkler <tomas.winkler@intel.com> Cc: Jason Gunthorpe <jgg@ziepe.ca>, Alexander Usyskin <alexander.usyskin@intel.com>, Tadeusz Struk <tadeusz.struk@intel.com>, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 06/21] tpm: move tpm1_pcr_extend to tpm1-cmd.c Date: Tue, 2 Oct 2018 14:58:00 +0530 [thread overview] Message-ID: <7e42b9c4-2299-a62d-ac79-0e147cb60573@linux.vnet.ibm.com> (raw) In-Reply-To: <20181002004248.GC23753@linux.intel.com> On 10/02/2018 06:12 AM, Jarkko Sakkinen wrote: > On Sat, Sep 29, 2018 at 01:30:20AM +0300, Tomas Winkler wrote: >> Move tpm1_pcr_extend to tpm1-cmd.c and remove >> unused pcrextend_header structure and >> EXTEND_PCR_RESULT_SIZE and EXTEND_PCR_RESULT_BODY_SIZE >> defines. >> >> Fixes warning: >> drivers/char/tpm/tpm-interface.c:609:38: warning: 'pcrextend_header' defined but not used [-Wunused-const-variable=] >> static const struct tpm_input_header pcrextend_header = { >> ^~~~~~~~~~~~~~~~ >> >> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> >> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Would need help with this from someone with a working IMA setup > on testing. My test system is down for now.. I think it will be up later in this week. I can test it then. Thanks & Regards, - Nayna > > /Jarkko >
next prev parent reply other threads:[~2018-10-02 9:31 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-28 22:30 [PATCH v5 00/21] tpm: separate tpm 1.x and tpm 2.x commands Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 01/21] tpm2: add new tpm2 commands according to TCG 1.36 Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-02 0:38 ` Jarkko Sakkinen 2018-10-02 0:40 ` Jarkko Sakkinen 2018-09-28 22:30 ` [PATCH v5 02/21] tpm: sort objects in the Makefile Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 03/21] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-11 16:55 ` Nayna Jain 2018-10-11 16:55 ` Nayna Jain 2018-09-28 22:30 ` [PATCH v5 04/21] tpm: add tpm_calc_ordinal_duration() wrapper Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 05/21] tpm: factor out tpm_get_timeouts() Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-11 17:00 ` Nayna Jain 2018-10-11 17:00 ` Nayna Jain 2018-10-11 20:16 ` Winkler, Tomas 2018-10-11 20:16 ` Winkler, Tomas 2018-09-28 22:30 ` [PATCH v5 06/21] tpm: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-02 0:42 ` Jarkko Sakkinen 2018-10-02 0:42 ` Jarkko Sakkinen 2018-10-02 9:28 ` Nayna Jain [this message] 2018-10-02 9:28 ` Nayna Jain 2018-10-03 12:02 ` Jarkko Sakkinen 2018-10-03 12:02 ` Jarkko Sakkinen 2018-10-12 9:31 ` Nayna Jain 2018-10-12 9:31 ` Nayna Jain 2018-10-16 16:48 ` Jarkko Sakkinen 2018-09-28 22:30 ` [PATCH v5 07/21] tpm: move tpm_getcap " Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 08/21] tpm: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-02 0:43 ` Jarkko Sakkinen 2018-09-28 22:30 ` [PATCH v5 09/21] tpm: move tpm 1.x selftest code from tpm-interface.c tpm1-cmd.c Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 10/21] tpm: factor out tpm 1.x pm suspend flow into tpm1-cmd.c Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-02 0:45 ` Jarkko Sakkinen 2018-09-28 22:30 ` [PATCH v5 11/21] tpm: factor out tpm_startup function Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-02 0:46 ` Jarkko Sakkinen 2018-09-28 22:30 ` [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-02 0:52 ` Jarkko Sakkinen 2018-10-02 4:58 ` Winkler, Tomas 2018-10-02 4:58 ` Winkler, Tomas 2018-10-03 12:01 ` Jarkko Sakkinen 2018-10-03 12:01 ` Jarkko Sakkinen 2018-10-03 22:24 ` Winkler, Tomas 2018-10-03 22:24 ` Winkler, Tomas 2018-10-04 11:35 ` Jarkko Sakkinen 2018-10-04 11:35 ` Jarkko Sakkinen 2018-10-04 11:36 ` Jarkko Sakkinen 2018-10-04 11:36 ` Jarkko Sakkinen 2018-10-04 11:45 ` Winkler, Tomas 2018-10-04 11:45 ` Winkler, Tomas 2018-10-04 12:20 ` Roberto Sassu 2018-10-04 12:20 ` Roberto Sassu 2018-10-04 13:46 ` Winkler, Tomas 2018-10-04 13:46 ` Winkler, Tomas 2018-10-04 14:10 ` Roberto Sassu 2018-10-04 14:10 ` Roberto Sassu 2018-10-05 11:31 ` Jarkko Sakkinen 2018-10-05 11:31 ` Jarkko Sakkinen 2018-09-28 22:30 ` [PATCH v5 13/21] tpm: add tpm_auto_startup() into tpm-interface.c Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-02 0:56 ` Jarkko Sakkinen 2018-09-28 22:30 ` [PATCH v5 14/21] tpm: tpm-interface.c drop unused macros Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 15/21] tpm: tpm-space.c remove unneeded semicolon Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 16/21] tpm: tpm1: rewrite tpm1_get_random() using tpm_buf structure Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 17/21] tpm1: implement tpm1_pcr_read_dev() " Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 18/21] tmp1: rename tpm1_pcr_read_dev to tpm1_pcr_read() Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 19/21] tpm1: reimplement SAVESTATE using tpm_buf Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-09-28 22:30 ` [PATCH v5 20/21] tpm1: reimplement tpm1_continue_selftest() " Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-17 6:02 ` Nayna Jain 2018-10-17 6:02 ` Nayna Jain 2018-09-28 22:30 ` [PATCH v5 21/21] tpm: use u32 instead of int for PCR index Tomas Winkler 2018-09-28 22:30 ` Tomas Winkler 2018-10-02 0:58 ` Jarkko Sakkinen 2018-10-02 0:44 ` [PATCH v5 00/21] tpm: separate tpm 1.x and tpm 2.x commands Jarkko Sakkinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7e42b9c4-2299-a62d-ac79-0e147cb60573@linux.vnet.ibm.com \ --to=nayna@linux.vnet.ibm.com \ --cc=alexander.usyskin@intel.com \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jgg@ziepe.ca \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=tadeusz.struk@intel.com \ --cc=tomas.winkler@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.