All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Wang <wei.w.wang@intel.com>
To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
	mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com
Cc: peterx@redhat.com, pbonzini@redhat.com,
	liliang.opensource@gmail.com, nilal@redhat.com, riel@redhat.com,
	wei.w.wang@intel.com
Subject: [Qemu-devel] [PATCH v9 6/8] migration/ram.c: add a function to disable the bulk stage
Date: Thu, 15 Nov 2018 18:08:02 +0800	[thread overview]
Message-ID: <1542276484-25508-7-git-send-email-wei.w.wang@intel.com> (raw)
In-Reply-To: <1542276484-25508-1-git-send-email-wei.w.wang@intel.com>

This patch adds a function to enable a precopy notifier callback outside
the migration subsystem to disable the bulk stage flag. This is needed by
the free page optimization offered by virtio-balloon.

Signed-off-by: Wei Wang <wei.w.wang@intel.com>
CC: Dr. David Alan Gilbert <dgilbert@redhat.com>
CC: Juan Quintela <quintela@redhat.com>
CC: Michael S. Tsirkin <mst@redhat.com>
CC: Peter Xu <peterx@redhat.com>
---
 include/migration/misc.h | 1 +
 migration/ram.c          | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/include/migration/misc.h b/include/migration/misc.h
index 0bac623..67cb275 100644
--- a/include/migration/misc.h
+++ b/include/migration/misc.h
@@ -30,6 +30,7 @@ typedef enum PrecopyNotifyReason {
 void precopy_infrastructure_init(void);
 void precopy_add_notifier(Notifier *n);
 void precopy_remove_notifier(Notifier *n);
+void precopy_disable_bulk_stage(void);
 
 void ram_mig_init(void);
 void qemu_guest_free_page_hint(void *addr, size_t len);
diff --git a/migration/ram.c b/migration/ram.c
index 65b1223..8745ca3 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -352,6 +352,15 @@ static void precopy_notify(PrecopyNotifyReason reason)
     notifier_list_notify(&precopy_notifier_list, &reason);
 }
 
+void precopy_disable_bulk_stage(void)
+{
+    if (!ram_state) {
+        return;
+    }
+
+    ram_state->ram_bulk_stage = false;
+}
+
 uint64_t ram_bytes_remaining(void)
 {
     return ram_state ? (ram_state->migration_dirty_pages * TARGET_PAGE_SIZE) :
-- 
1.8.3.1

WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
	mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com
Cc: peterx@redhat.com, pbonzini@redhat.com,
	liliang.opensource@gmail.com, nilal@redhat.com, riel@redhat.com,
	wei.w.wang@intel.com
Subject: [virtio-dev] [PATCH v9 6/8] migration/ram.c: add a function to disable the bulk stage
Date: Thu, 15 Nov 2018 18:08:02 +0800	[thread overview]
Message-ID: <1542276484-25508-7-git-send-email-wei.w.wang@intel.com> (raw)
In-Reply-To: <1542276484-25508-1-git-send-email-wei.w.wang@intel.com>

This patch adds a function to enable a precopy notifier callback outside
the migration subsystem to disable the bulk stage flag. This is needed by
the free page optimization offered by virtio-balloon.

Signed-off-by: Wei Wang <wei.w.wang@intel.com>
CC: Dr. David Alan Gilbert <dgilbert@redhat.com>
CC: Juan Quintela <quintela@redhat.com>
CC: Michael S. Tsirkin <mst@redhat.com>
CC: Peter Xu <peterx@redhat.com>
---
 include/migration/misc.h | 1 +
 migration/ram.c          | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/include/migration/misc.h b/include/migration/misc.h
index 0bac623..67cb275 100644
--- a/include/migration/misc.h
+++ b/include/migration/misc.h
@@ -30,6 +30,7 @@ typedef enum PrecopyNotifyReason {
 void precopy_infrastructure_init(void);
 void precopy_add_notifier(Notifier *n);
 void precopy_remove_notifier(Notifier *n);
+void precopy_disable_bulk_stage(void);
 
 void ram_mig_init(void);
 void qemu_guest_free_page_hint(void *addr, size_t len);
diff --git a/migration/ram.c b/migration/ram.c
index 65b1223..8745ca3 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -352,6 +352,15 @@ static void precopy_notify(PrecopyNotifyReason reason)
     notifier_list_notify(&precopy_notifier_list, &reason);
 }
 
+void precopy_disable_bulk_stage(void)
+{
+    if (!ram_state) {
+        return;
+    }
+
+    ram_state->ram_bulk_stage = false;
+}
+
 uint64_t ram_bytes_remaining(void)
 {
     return ram_state ? (ram_state->migration_dirty_pages * TARGET_PAGE_SIZE) :
-- 
1.8.3.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2018-11-15 10:41 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 10:07 [Qemu-devel] [PATCH v9 0/8] virtio-balloon: free page hint support Wei Wang
2018-11-15 10:07 ` [virtio-dev] " Wei Wang
2018-11-15 10:07 ` [Qemu-devel] [PATCH v9 1/8] bitmap: fix bitmap_count_one Wei Wang
2018-11-15 10:07   ` [virtio-dev] " Wei Wang
2018-11-15 10:07 ` [Qemu-devel] [PATCH v9 2/8] bitmap: bitmap_count_one_with_offset Wei Wang
2018-11-15 10:07   ` [virtio-dev] " Wei Wang
2018-11-15 10:07 ` [Qemu-devel] [PATCH v9 3/8] migration: use bitmap_mutex in migration_bitmap_clear_dirty Wei Wang
2018-11-15 10:07   ` [virtio-dev] " Wei Wang
2018-11-27  5:40   ` [Qemu-devel] " Peter Xu
2018-11-27  6:02     ` Wei Wang
2018-11-27  6:02       ` [virtio-dev] " Wei Wang
2018-11-27  6:12       ` [Qemu-devel] " Wei Wang
2018-11-27  6:12         ` Wei Wang
2018-11-27  7:41         ` [Qemu-devel] " Peter Xu
2018-11-27 10:17           ` Wei Wang
2018-11-27 10:17             ` Wei Wang
2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 4/8] migration: API to clear bits of guest free pages from the dirty bitmap Wei Wang
2018-11-15 10:08   ` [virtio-dev] " Wei Wang
2018-11-27  6:06   ` [Qemu-devel] " Peter Xu
2018-11-27  6:52     ` Wei Wang
2018-11-27  6:52       ` [virtio-dev] " Wei Wang
2018-11-27  7:43       ` [Qemu-devel] " Peter Xu
2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy Wei Wang
2018-11-15 10:08   ` [virtio-dev] " Wei Wang
2018-11-27  7:38   ` [Qemu-devel] " Peter Xu
2018-11-27 10:25     ` Wei Wang
2018-11-27 10:25       ` [virtio-dev] " Wei Wang
2018-11-28  5:26       ` [Qemu-devel] " Peter Xu
2018-11-28  9:01         ` Wei Wang
2018-11-28  9:01           ` [virtio-dev] " Wei Wang
2018-11-28  9:32           ` [Qemu-devel] " Peter Xu
2018-11-29  3:40             ` Wei Wang
2018-11-29  3:40               ` [virtio-dev] " Wei Wang
2018-11-29  5:10               ` [Qemu-devel] " Peter Xu
2018-11-29  5:47                 ` Peter Xu
2018-11-29  6:30                 ` Wei Wang
2018-11-29  6:30                   ` [virtio-dev] " Wei Wang
2018-11-30  5:05                 ` [Qemu-devel] " Wei Wang
2018-11-30  5:05                   ` [virtio-dev] " Wei Wang
2018-11-30  5:57                   ` [Qemu-devel] " Peter Xu
2018-11-30  7:09                     ` Wei Wang
2018-11-30  7:09                       ` [virtio-dev] " Wei Wang
2018-11-15 10:08 ` Wei Wang [this message]
2018-11-15 10:08   ` [virtio-dev] [PATCH v9 6/8] migration/ram.c: add a function to disable the bulk stage Wei Wang
2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 7/8] migration: move migrate_postcopy() to include/migration/misc.h Wei Wang
2018-11-15 10:08   ` [virtio-dev] " Wei Wang
2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 8/8] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-11-15 10:08   ` [virtio-dev] " Wei Wang
2018-11-15 18:50 ` [Qemu-devel] [PATCH v9 0/8] virtio-balloon: free page hint support no-reply
2018-11-16  1:38   ` Wei Wang
2018-11-16  1:38     ` [virtio-dev] " Wei Wang
2018-11-27  3:11 ` Wei Wang
2018-11-27  3:11   ` [virtio-dev] " Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542276484-25508-7-git-send-email-wei.w.wang@intel.com \
    --to=wei.w.wang@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=liliang.opensource@gmail.com \
    --cc=mst@redhat.com \
    --cc=nilal@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=riel@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.