From: Wei Wang <wei.w.wang@intel.com> To: Peter Xu <peterx@redhat.com> Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, nilal@redhat.com, riel@redhat.com Subject: Re: [Qemu-devel] [PATCH v9 4/8] migration: API to clear bits of guest free pages from the dirty bitmap Date: Tue, 27 Nov 2018 14:52:35 +0800 [thread overview] Message-ID: <5BFCE9B3.4020605@intel.com> (raw) In-Reply-To: <20181127060638.GB3205@xz-x1> On 11/27/2018 02:06 PM, Peter Xu wrote: > On Thu, Nov 15, 2018 at 06:08:00PM +0800, Wei Wang wrote: > Again, is it possible to resize during migration? > > So I think the check is fine, but uncertain about the comment. Yes, resize would not happen with the current implementation. But heard it could just be a temporal implementation. Probably we could improve the comment like this: " Though the implementation might not support ram resize currently, this could happen in theory with future updates. So the check here handles the case that RAMBLOCK is resized after the free page hint is reported. " > > And shall we print something if that happened? We can use > error_report_once(), and squashing the above assert: > > if (!block || offset > block->used_length) { > /* should never happen, but if it happens we ignore the hints and warn */ > error_report_once("..."); > return; > } > > What do you think? Sounds good. > >> + >> + if (len <= block->used_length - offset) { >> + used_len = len; >> + } else { >> + used_len = block->used_length - offset; >> + addr += used_len; > Maybe moving this line into the for() could be a bit better? > > for (; len > 0; len -= used_len, addr += used_len) { > Yes, I think it looks better, thanks. Best, Wei
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com> To: Peter Xu <peterx@redhat.com> Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, nilal@redhat.com, riel@redhat.com Subject: [virtio-dev] Re: [PATCH v9 4/8] migration: API to clear bits of guest free pages from the dirty bitmap Date: Tue, 27 Nov 2018 14:52:35 +0800 [thread overview] Message-ID: <5BFCE9B3.4020605@intel.com> (raw) In-Reply-To: <20181127060638.GB3205@xz-x1> On 11/27/2018 02:06 PM, Peter Xu wrote: > On Thu, Nov 15, 2018 at 06:08:00PM +0800, Wei Wang wrote: > Again, is it possible to resize during migration? > > So I think the check is fine, but uncertain about the comment. Yes, resize would not happen with the current implementation. But heard it could just be a temporal implementation. Probably we could improve the comment like this: " Though the implementation might not support ram resize currently, this could happen in theory with future updates. So the check here handles the case that RAMBLOCK is resized after the free page hint is reported. " > > And shall we print something if that happened? We can use > error_report_once(), and squashing the above assert: > > if (!block || offset > block->used_length) { > /* should never happen, but if it happens we ignore the hints and warn */ > error_report_once("..."); > return; > } > > What do you think? Sounds good. > >> + >> + if (len <= block->used_length - offset) { >> + used_len = len; >> + } else { >> + used_len = block->used_length - offset; >> + addr += used_len; > Maybe moving this line into the for() could be a bit better? > > for (; len > 0; len -= used_len, addr += used_len) { > Yes, I think it looks better, thanks. Best, Wei --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-11-27 6:47 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-15 10:07 [Qemu-devel] [PATCH v9 0/8] virtio-balloon: free page hint support Wei Wang 2018-11-15 10:07 ` [virtio-dev] " Wei Wang 2018-11-15 10:07 ` [Qemu-devel] [PATCH v9 1/8] bitmap: fix bitmap_count_one Wei Wang 2018-11-15 10:07 ` [virtio-dev] " Wei Wang 2018-11-15 10:07 ` [Qemu-devel] [PATCH v9 2/8] bitmap: bitmap_count_one_with_offset Wei Wang 2018-11-15 10:07 ` [virtio-dev] " Wei Wang 2018-11-15 10:07 ` [Qemu-devel] [PATCH v9 3/8] migration: use bitmap_mutex in migration_bitmap_clear_dirty Wei Wang 2018-11-15 10:07 ` [virtio-dev] " Wei Wang 2018-11-27 5:40 ` [Qemu-devel] " Peter Xu 2018-11-27 6:02 ` Wei Wang 2018-11-27 6:02 ` [virtio-dev] " Wei Wang 2018-11-27 6:12 ` [Qemu-devel] " Wei Wang 2018-11-27 6:12 ` Wei Wang 2018-11-27 7:41 ` [Qemu-devel] " Peter Xu 2018-11-27 10:17 ` Wei Wang 2018-11-27 10:17 ` Wei Wang 2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 4/8] migration: API to clear bits of guest free pages from the dirty bitmap Wei Wang 2018-11-15 10:08 ` [virtio-dev] " Wei Wang 2018-11-27 6:06 ` [Qemu-devel] " Peter Xu 2018-11-27 6:52 ` Wei Wang [this message] 2018-11-27 6:52 ` [virtio-dev] " Wei Wang 2018-11-27 7:43 ` [Qemu-devel] " Peter Xu 2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy Wei Wang 2018-11-15 10:08 ` [virtio-dev] " Wei Wang 2018-11-27 7:38 ` [Qemu-devel] " Peter Xu 2018-11-27 10:25 ` Wei Wang 2018-11-27 10:25 ` [virtio-dev] " Wei Wang 2018-11-28 5:26 ` [Qemu-devel] " Peter Xu 2018-11-28 9:01 ` Wei Wang 2018-11-28 9:01 ` [virtio-dev] " Wei Wang 2018-11-28 9:32 ` [Qemu-devel] " Peter Xu 2018-11-29 3:40 ` Wei Wang 2018-11-29 3:40 ` [virtio-dev] " Wei Wang 2018-11-29 5:10 ` [Qemu-devel] " Peter Xu 2018-11-29 5:47 ` Peter Xu 2018-11-29 6:30 ` Wei Wang 2018-11-29 6:30 ` [virtio-dev] " Wei Wang 2018-11-30 5:05 ` [Qemu-devel] " Wei Wang 2018-11-30 5:05 ` [virtio-dev] " Wei Wang 2018-11-30 5:57 ` [Qemu-devel] " Peter Xu 2018-11-30 7:09 ` Wei Wang 2018-11-30 7:09 ` [virtio-dev] " Wei Wang 2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 6/8] migration/ram.c: add a function to disable the bulk stage Wei Wang 2018-11-15 10:08 ` [virtio-dev] " Wei Wang 2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 7/8] migration: move migrate_postcopy() to include/migration/misc.h Wei Wang 2018-11-15 10:08 ` [virtio-dev] " Wei Wang 2018-11-15 10:08 ` [Qemu-devel] [PATCH v9 8/8] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang 2018-11-15 10:08 ` [virtio-dev] " Wei Wang 2018-11-15 18:50 ` [Qemu-devel] [PATCH v9 0/8] virtio-balloon: free page hint support no-reply 2018-11-16 1:38 ` Wei Wang 2018-11-16 1:38 ` [virtio-dev] " Wei Wang 2018-11-27 3:11 ` Wei Wang 2018-11-27 3:11 ` [virtio-dev] " Wei Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5BFCE9B3.4020605@intel.com \ --to=wei.w.wang@intel.com \ --cc=dgilbert@redhat.com \ --cc=liliang.opensource@gmail.com \ --cc=mst@redhat.com \ --cc=nilal@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=quintela@redhat.com \ --cc=riel@redhat.com \ --cc=virtio-dev@lists.oasis-open.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.