[PATCH v2 0/2] CPU hotplug fixes for ARM32

[PATCH v2 0/2] CPU hotplug fixes for ARM32

[Oleksandr Tyshchenko]

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hi, all.

This is small patch series for ARM32 which needed to be able to bring
secondary CPUs up not only during the initial boot, but at runtime also.
For example, during CPU hotplug.

Actually these are follow-up patches to the following series [1], which covers 
generic ARM and ARM64 parts. 

[1] https://lists.xenproject.org/archives/html/xen-devel/2018-06/msg00039.html

Changes since v1:
   - Fix typoes
   - Rename ".init.proc.info" to ".data.proc.info"

Oleksandr Tyshchenko (2):
  xen/arm: link: Link proc_info_list in .data instead of .init.data
  xen/arm32: Remove __init prefixes from funcs that are used within CPU
    up flow

 xen/arch/arm/arm32/proc-v7.S |  6 +++---
 xen/arch/arm/arm32/smpboot.c |  2 +-
 xen/arch/arm/platform.c      |  2 +-
 xen/arch/arm/xen.lds.S       | 10 ++++++----
 4 files changed, 11 insertions(+), 9 deletions(-)

-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 1/2] xen/arm: link: Link proc_info_list in .data instead of .init.data

[Oleksandr Tyshchenko]

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

To be able to use it for the hot-plugged CPUs as well.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

---
    Changes in v2:
        - Fix typoes
        - Rename ".init.proc.info" to ".data.proc.info"
---
 xen/arch/arm/arm32/proc-v7.S |  6 +++---
 xen/arch/arm/xen.lds.S       | 10 ++++++----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
index 80a250d..a0c0c9e 100644
--- a/xen/arch/arm/arm32/proc-v7.S
+++ b/xen/arch/arm/arm32/proc-v7.S
@@ -30,7 +30,7 @@ brahma15mp_init:
         mcr   CP32(r0, ACTLR)
         mov   pc, lr
 
-        .section ".init.proc.info", #alloc, #execinstr
+        .section ".data.proc.info", #alloc, #execinstr
         .type __v7_ca15mp_proc_info, #object
 __v7_ca15mp_proc_info:
         .long 0x410FC0F0             /* Cortex-A15 */
@@ -39,7 +39,7 @@ __v7_ca15mp_proc_info:
         .long caxx_processor
         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
 
-        .section ".init.proc.info", #alloc, #execinstr
+        .section ".data.proc.info", #alloc, #execinstr
         .type __v7_ca7mp_proc_info, #object
 __v7_ca7mp_proc_info:
         .long 0x410FC070             /* Cortex-A7 */
@@ -48,7 +48,7 @@ __v7_ca7mp_proc_info:
         .long caxx_processor
         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
 
-        .section ".init.proc.info", #alloc, #execinstr
+        .section ".data.proc.info", #alloc, #execinstr
         .type __v7_brahma15mp_proc_info, #object
 __v7_brahma15mp_proc_info:
         .long 0x420F00F0             /* Broadcom Brahma-B15 */
diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index 245a0e0..624da9b 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -88,6 +88,12 @@ SECTIONS
        . = ALIGN(PAGE_SIZE);
        *(.data.page_aligned)
        *(.data)
+
+       . = ALIGN(POINTER_ALIGN);
+       __proc_info_start = .;
+       *(.data.proc.info)
+       __proc_info_end = .;
+
        . = ALIGN(8);
        __start_schedulers_array = .;
        *(.data.schedulers)
@@ -151,10 +157,6 @@ SECTIONS
        *(.init.setup)
        __setup_end = .;
 
-       __proc_info_start = .;
-       *(.init.proc.info)
-       __proc_info_end = .;
-
        __initcall_start = .;
        *(.initcallpresmp.init)
        __presmp_initcall_end = .;
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 2/2] xen/arm32: Remove __init prefixes from funcs that are used within CPU up flow

[Oleksandr Tyshchenko]

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is a follow-up patch to
commit 01a7e8ccef6e7d5718a251ad587567afbe723330
xen/arm: Remove __initdata and __init to enable CPU hotplug

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Acked-by: Julien Grall <julien.grall@arm.com>
---
 xen/arch/arm/arm32/smpboot.c | 2 +-
 xen/arch/arm/platform.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/arm32/smpboot.c b/xen/arch/arm/arm32/smpboot.c
index 2a77f29..e736866 100644
--- a/xen/arch/arm/arm32/smpboot.c
+++ b/xen/arch/arm/arm32/smpboot.c
@@ -16,7 +16,7 @@ int __init arch_cpu_init(int cpu, struct dt_device_node *dn)
     return 0;
 }
 
-int __init arch_cpu_up(int cpu)
+int arch_cpu_up(int cpu)
 {
     return platform_cpu_up(cpu);
 }
diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
index 6989e58..0ba2001 100644
--- a/xen/arch/arm/platform.c
+++ b/xen/arch/arm/platform.c
@@ -95,7 +95,7 @@ int __init platform_specific_mapping(struct domain *d)
 }
 
 #ifdef CONFIG_ARM_32
-int __init platform_cpu_up(int cpu)
+int platform_cpu_up(int cpu)
 {
     if ( psci_ver )
         return call_psci_cpu_on(cpu);
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 0/2] CPU hotplug fixes for ARM32

[Julien Grall]

On 07/12/2018 09:45, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Hi, all.
> 
> This is small patch series for ARM32 which needed to be able to bring
> secondary CPUs up not only during the initial boot, but at runtime also.
> For example, during CPU hotplug.

OOI, we don't have CPU hotplug in Xen at the moment. So do you have CPU hotplug 
patch coming up?

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 1/2] xen/arm: link: Link proc_info_list in .data instead of .init.data

[Julien Grall]

Hi Oleksandr,

On 07/12/2018 09:45, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> To be able to use it for the hot-plugged CPUs as well.

You need to explain in the commit message why you rename .init.proc.info.

> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> ---
>      Changes in v2:
>          - Fix typoes
>          - Rename ".init.proc.info" to ".data.proc.info"
> ---
>   xen/arch/arm/arm32/proc-v7.S |  6 +++---
>   xen/arch/arm/xen.lds.S       | 10 ++++++----
>   2 files changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
> index 80a250d..a0c0c9e 100644
> --- a/xen/arch/arm/arm32/proc-v7.S
> +++ b/xen/arch/arm/arm32/proc-v7.S
> @@ -30,7 +30,7 @@ brahma15mp_init:
>           mcr   CP32(r0, ACTLR)
>           mov   pc, lr
>   
> -        .section ".init.proc.info", #alloc, #execinstr
> +        .section ".data.proc.info", #alloc, #execinstr

NIT: .proc.info would be sufficient. This would avoid to rename again the 
section if we decide to move it in a separate section.

>           .type __v7_ca15mp_proc_info, #object
>   __v7_ca15mp_proc_info:
>           .long 0x410FC0F0             /* Cortex-A15 */
> @@ -39,7 +39,7 @@ __v7_ca15mp_proc_info:
>           .long caxx_processor
>           .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
>   
> -        .section ".init.proc.info", #alloc, #execinstr
> +        .section ".data.proc.info", #alloc, #execinstr
>           .type __v7_ca7mp_proc_info, #object
>   __v7_ca7mp_proc_info:
>           .long 0x410FC070             /* Cortex-A7 */
> @@ -48,7 +48,7 @@ __v7_ca7mp_proc_info:
>           .long caxx_processor
>           .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
>   
> -        .section ".init.proc.info", #alloc, #execinstr
> +        .section ".data.proc.info", #alloc, #execinstr
>           .type __v7_brahma15mp_proc_info, #object
>   __v7_brahma15mp_proc_info:
>           .long 0x420F00F0             /* Broadcom Brahma-B15 */
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index 245a0e0..624da9b 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -88,6 +88,12 @@ SECTIONS
>          . = ALIGN(PAGE_SIZE);
>          *(.data.page_aligned)
>          *(.data)
> +
> +       . = ALIGN(POINTER_ALIGN);
> +       __proc_info_start = .;
> +       *(.data.proc.info)
> +       __proc_info_end = .;

Sorry I haven't noticed it in the previous version. proc.info should never 
modified, right? So it should be in rodata in that case.

> +
>          . = ALIGN(8);
>          __start_schedulers_array = .;
>          *(.data.schedulers)
> @@ -151,10 +157,6 @@ SECTIONS
>          *(.init.setup)
>          __setup_end = .;
>   
> -       __proc_info_start = .;
> -       *(.init.proc.info)
> -       __proc_info_end = .;
> -
>          __initcall_start = .;
>          *(.initcallpresmp.init)
>          __presmp_initcall_end = .;
> 

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 1/2] xen/arm: link: Link proc_info_list in .data instead of .init.data

[Oleksandr Tyshchenko]

[-- Attachment #1.1: Type: text/plain, Size: 3439 bytes --]

On Fri, Dec 7, 2018 at 12:05 PM Julien Grall <julien.grall@arm.com> wrote:

> Hi Oleksandr,
>
Hi Julien


>
> On 07/12/2018 09:45, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >
> > To be able to use it for the hot-plugged CPUs as well.
>
> You need to explain in the commit message why you rename .init.proc.info.
>
ok


>
> >
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >
> > ---
> >      Changes in v2:
> >          - Fix typoes
> >          - Rename ".init.proc.info" to ".data.proc.info"
> > ---
> >   xen/arch/arm/arm32/proc-v7.S |  6 +++---
> >   xen/arch/arm/xen.lds.S       | 10 ++++++----
> >   2 files changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
> > index 80a250d..a0c0c9e 100644
> > --- a/xen/arch/arm/arm32/proc-v7.S
> > +++ b/xen/arch/arm/arm32/proc-v7.S
> > @@ -30,7 +30,7 @@ brahma15mp_init:
> >           mcr   CP32(r0, ACTLR)
> >           mov   pc, lr
> >
> > -        .section ".init.proc.info", #alloc, #execinstr
> > +        .section ".data.proc.info", #alloc, #execinstr
>
> NIT: .proc.info would be sufficient. This would avoid to rename again the
> section if we decide to move it in a separate section.
>
ok


>
> >           .type __v7_ca15mp_proc_info, #object
> >   __v7_ca15mp_proc_info:
> >           .long 0x410FC0F0             /* Cortex-A15 */
> > @@ -39,7 +39,7 @@ __v7_ca15mp_proc_info:
> >           .long caxx_processor
> >           .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
> >
> > -        .section ".init.proc.info", #alloc, #execinstr
> > +        .section ".data.proc.info", #alloc, #execinstr
> >           .type __v7_ca7mp_proc_info, #object
> >   __v7_ca7mp_proc_info:
> >           .long 0x410FC070             /* Cortex-A7 */
> > @@ -48,7 +48,7 @@ __v7_ca7mp_proc_info:
> >           .long caxx_processor
> >           .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
> >
> > -        .section ".init.proc.info", #alloc, #execinstr
> > +        .section ".data.proc.info", #alloc, #execinstr
> >           .type __v7_brahma15mp_proc_info, #object
> >   __v7_brahma15mp_proc_info:
> >           .long 0x420F00F0             /* Broadcom Brahma-B15 */
> > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> > index 245a0e0..624da9b 100644
> > --- a/xen/arch/arm/xen.lds.S
> > +++ b/xen/arch/arm/xen.lds.S
> > @@ -88,6 +88,12 @@ SECTIONS
> >          . = ALIGN(PAGE_SIZE);
> >          *(.data.page_aligned)
> >          *(.data)
> > +
> > +       . = ALIGN(POINTER_ALIGN);
> > +       __proc_info_start = .;
> > +       *(.data.proc.info)
> > +       __proc_info_end = .;
>
> Sorry I haven't noticed it in the previous version. proc.info should
> never
> modified, right? So it should be in rodata in that case.
>
agree, will link it in rodata.

May I resend just this patch after address your comments?


>
> > +
> >          . = ALIGN(8);
> >          __start_schedulers_array = .;
> >          *(.data.schedulers)
> > @@ -151,10 +157,6 @@ SECTIONS
> >          *(.init.setup)
> >          __setup_end = .;
> >
> > -       __proc_info_start = .;
> > -       *(.init.proc.info)
> > -       __proc_info_end = .;
> > -
> >          __initcall_start = .;
> >          *(.initcallpresmp.init)
> >          __presmp_initcall_end = .;
> >
>
> Cheers,
>
> --
> Julien Grall
>


-- 
Regards,

Oleksandr Tyshchenko

[-- Attachment #1.2: Type: text/html, Size: 6695 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 1/2] xen/arm: link: Link proc_info_list in .data instead of .init.data

[Julien Grall]

Hi Oleksandr,

Please configure your client to quote with > rather than indentation. Below is 
an example how it can get messy in just 3 answers, I let you imagine with longer 
thread :).

This is a general issue with gmail web-interface that quote using tabulation. It 
would be best if you use an external mail client (e.g thunderbird, mute...).

On 07/12/2018 10:32, Oleksandr Tyshchenko wrote:
> 
> 
> On Fri, Dec 7, 2018 at 12:05 PM Julien Grall <julien.grall@arm.com 
> <mailto:julien.grall@arm.com>> wrote:
> 
>     Hi Oleksandr,
> 
> Hi Julien
> 
> 
>     On 07/12/2018 09:45, Oleksandr Tyshchenko wrote:
>      > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com
>     <mailto:oleksandr_tyshchenko@epam.com>>
>      >
>      > To be able to use it for the hot-plugged CPUs as well.
> 
>     You need to explain in the commit message why you rename .init.proc.info
>     <http://init.proc.info>.
> 
> ok
> 
> 
>      >
>      > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com
>     <mailto:oleksandr_tyshchenko@epam.com>>
>      >
>      > ---
>      >      Changes in v2:
>      >          - Fix typoes
>      >          - Rename ".init.proc.info <http://init.proc.info>" to
>     ".data.proc.info <http://data.proc.info>"
>      > ---
>      >   xen/arch/arm/arm32/proc-v7.S |  6 +++---
>      >   xen/arch/arm/xen.lds.S       | 10 ++++++----
>      >   2 files changed, 9 insertions(+), 7 deletions(-)
>      >
>      > diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
>      > index 80a250d..a0c0c9e 100644
>      > --- a/xen/arch/arm/arm32/proc-v7.S
>      > +++ b/xen/arch/arm/arm32/proc-v7.S
>      > @@ -30,7 +30,7 @@ brahma15mp_init:
>      >           mcr   CP32(r0, ACTLR)
>      >           mov   pc, lr
>      >
>      > -        .section ".init.proc.info <http://init.proc.info>", #alloc,
>     #execinstr
>      > +        .section ".data.proc.info <http://data.proc.info>", #alloc,
>     #execinstr
> 
>     NIT: .proc.info <http://proc.info> would be sufficient. This would avoid to
>     rename again the
>     section if we decide to move it in a separate section.
> 
> ok
> 
> 
>      >           .type __v7_ca15mp_proc_info, #object
>      >   __v7_ca15mp_proc_info:
>      >           .long 0x410FC0F0             /* Cortex-A15 */
>      > @@ -39,7 +39,7 @@ __v7_ca15mp_proc_info:
>      >           .long caxx_processor
>      >           .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
>      >
>      > -        .section ".init.proc.info <http://init.proc.info>", #alloc,
>     #execinstr
>      > +        .section ".data.proc.info <http://data.proc.info>", #alloc,
>     #execinstr
>      >           .type __v7_ca7mp_proc_info, #object
>      >   __v7_ca7mp_proc_info:
>      >           .long 0x410FC070             /* Cortex-A7 */
>      > @@ -48,7 +48,7 @@ __v7_ca7mp_proc_info:
>      >           .long caxx_processor
>      >           .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
>      >
>      > -        .section ".init.proc.info <http://init.proc.info>", #alloc,
>     #execinstr
>      > +        .section ".data.proc.info <http://data.proc.info>", #alloc,
>     #execinstr
>      >           .type __v7_brahma15mp_proc_info, #object
>      >   __v7_brahma15mp_proc_info:
>      >           .long 0x420F00F0             /* Broadcom Brahma-B15 */
>      > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
>      > index 245a0e0..624da9b 100644
>      > --- a/xen/arch/arm/xen.lds.S
>      > +++ b/xen/arch/arm/xen.lds.S
>      > @@ -88,6 +88,12 @@ SECTIONS
>      >          . = ALIGN(PAGE_SIZE);
>      >          *(.data.page_aligned)
>      >          *(.data)
>      > +
>      > +       . = ALIGN(POINTER_ALIGN);
>      > +       __proc_info_start = .;
>      > +       *(.data.proc.info <http://data.proc.info>)
>      > +       __proc_info_end = .;
> 
>     Sorry I haven't noticed it in the previous version. proc.info
>     <http://proc.info> should never
>     modified, right? So it should be in rodata in that case.
> 
> agree, will link it in rodata.
> 
> May I resend just this patch after address your comments?

Yes please. I will commit the other soon.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 0/2] CPU hotplug fixes for ARM32

[Oleksandr]

On 07.12.18 12:02, Julien Grall wrote:

Hi, Julien.

>
> On 07/12/2018 09:45, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Hi, all.
>>
>> This is small patch series for ARM32 which needed to be able to bring
>> secondary CPUs up not only during the initial boot, but at runtime also.
>> For example, during CPU hotplug.
>
> OOI, we don't have CPU hotplug in Xen at the moment. So do you have 
> CPU hotplug patch coming up?

No, I don't. These patches are result of my playing with PSCI). I just 
wanted to be sure that second CPU_ON request would properly bring CPU up 
again after performing CPU_OFF request. For that reason, I just hacked 
Xen to issue cpu_up()/cpu_down() by pressing a key. So this is 
definitely not for upstream)

>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 1/2] xen/arm: link: Link proc_info_list in .data instead of .init.data

[Oleksandr]

On 07.12.18 12:34, Julien Grall wrote:
> Hi Oleksandr,

Hi Julien


>
> Please configure your client to quote with > rather than indentation. 
> Below is an example how it can get messy in just 3 answers, I let you 
> imagine with longer thread :).
>
> This is a general issue with gmail web-interface that quote using 
> tabulation. It would be best if you use an external mail client (e.g 
> thunderbird, mute...).

Have already configured, sorry for the inconvenience.


>
> On 07/12/2018 10:32, Oleksandr Tyshchenko wrote:
>>
>>
>> On Fri, Dec 7, 2018 at 12:05 PM Julien Grall <julien.grall@arm.com 
>> <mailto:julien.grall@arm.com>> wrote:
>>
>>     Hi Oleksandr,
>>
>> Hi Julien
>>
>>
>>     On 07/12/2018 09:45, Oleksandr Tyshchenko wrote:
>>      > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com
>>     <mailto:oleksandr_tyshchenko@epam.com>>
>>      >
>>      > To be able to use it for the hot-plugged CPUs as well.
>>
>>     You need to explain in the commit message why you rename 
>> .init.proc.info
>>     <http://init.proc.info>.
>>
>> ok
>>
>>
>>      >
>>      > Signed-off-by: Oleksandr Tyshchenko 
>> <oleksandr_tyshchenko@epam.com
>>     <mailto:oleksandr_tyshchenko@epam.com>>
>>      >
>>      > ---
>>      >      Changes in v2:
>>      >          - Fix typoes
>>      >          - Rename ".init.proc.info <http://init.proc.info>" to
>>     ".data.proc.info <http://data.proc.info>"
>>      > ---
>>      >   xen/arch/arm/arm32/proc-v7.S |  6 +++---
>>      >   xen/arch/arm/xen.lds.S       | 10 ++++++----
>>      >   2 files changed, 9 insertions(+), 7 deletions(-)
>>      >
>>      > diff --git a/xen/arch/arm/arm32/proc-v7.S 
>> b/xen/arch/arm/arm32/proc-v7.S
>>      > index 80a250d..a0c0c9e 100644
>>      > --- a/xen/arch/arm/arm32/proc-v7.S
>>      > +++ b/xen/arch/arm/arm32/proc-v7.S
>>      > @@ -30,7 +30,7 @@ brahma15mp_init:
>>      >           mcr   CP32(r0, ACTLR)
>>      >           mov   pc, lr
>>      >
>>      > -        .section ".init.proc.info <http://init.proc.info>", 
>> #alloc,
>>     #execinstr
>>      > +        .section ".data.proc.info <http://data.proc.info>", 
>> #alloc,
>>     #execinstr
>>
>>     NIT: .proc.info <http://proc.info> would be sufficient. This 
>> would avoid to
>>     rename again the
>>     section if we decide to move it in a separate section.
>>
>> ok
>>
>>
>>      >           .type __v7_ca15mp_proc_info, #object
>>      >   __v7_ca15mp_proc_info:
>>      >           .long 0x410FC0F0             /* Cortex-A15 */
>>      > @@ -39,7 +39,7 @@ __v7_ca15mp_proc_info:
>>      >           .long caxx_processor
>>      >           .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
>>      >
>>      > -        .section ".init.proc.info <http://init.proc.info>", 
>> #alloc,
>>     #execinstr
>>      > +        .section ".data.proc.info <http://data.proc.info>", 
>> #alloc,
>>     #execinstr
>>      >           .type __v7_ca7mp_proc_info, #object
>>      >   __v7_ca7mp_proc_info:
>>      >           .long 0x410FC070             /* Cortex-A7 */
>>      > @@ -48,7 +48,7 @@ __v7_ca7mp_proc_info:
>>      >           .long caxx_processor
>>      >           .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
>>      >
>>      > -        .section ".init.proc.info <http://init.proc.info>", 
>> #alloc,
>>     #execinstr
>>      > +        .section ".data.proc.info <http://data.proc.info>", 
>> #alloc,
>>     #execinstr
>>      >           .type __v7_brahma15mp_proc_info, #object
>>      >   __v7_brahma15mp_proc_info:
>>      >           .long 0x420F00F0             /* Broadcom Brahma-B15 */
>>      > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
>>      > index 245a0e0..624da9b 100644
>>      > --- a/xen/arch/arm/xen.lds.S
>>      > +++ b/xen/arch/arm/xen.lds.S
>>      > @@ -88,6 +88,12 @@ SECTIONS
>>      >          . = ALIGN(PAGE_SIZE);
>>      >          *(.data.page_aligned)
>>      >          *(.data)
>>      > +
>>      > +       . = ALIGN(POINTER_ALIGN);
>>      > +       __proc_info_start = .;
>>      > +       *(.data.proc.info <http://data.proc.info>)
>>      > +       __proc_info_end = .;
>>
>>     Sorry I haven't noticed it in the previous version. proc.info
>>     <http://proc.info> should never
>>     modified, right? So it should be in rodata in that case.
>>
>> agree, will link it in rodata.
>>
>> May I resend just this patch after address your comments?
>
> Yes please. I will commit the other soon.

Done.

https://lists.xenproject.org/archives/html/xen-devel/2018-12/msg00777.html


>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel