All of lore.kernel.org
 help / color / mirror / Atom feed
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Lars Melin <larsm17@gmail.com>
Cc: Oliver Neukum <oneukum@suse.com>,
	Andrey Arapov <andrey.arapov@gmail.com>,
	Johan Hovold <johan@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
	<linux-usb@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader.
Date: Wed, 19 Dec 2018 12:03:23 +0800	[thread overview]
Message-ID: <1545192203.4134.11.camel@mtkswgap22> (raw)
In-Reply-To: <3465233a-1afd-8112-ebd6-78cceb426c9d@gmail.com>

On Wed, 2018-12-19 at 10:31 +0700, Lars Melin wrote:
> On 12/19/2018 10:16, Macpaul Lin wrote: 
> 
> Hi Macpaul,
> your verbose usb listing show me that Mediatek has made two different 
> 0e8d:003 devices, see my verbose lsusb listing below.
> (Notice also the reverse order for cmd and data interfaces in it 
> compared to yours).
> USB id's are intended to identify a device and its needs so there should
> never be more than one unique device per id.
> 
> 
> Fairphone FP-1, MT6227  (no CDC union !!!)
> 
Hi Lars,

Ha ha ha, it is a little bit embarrassing.
What I've used to capture verbose log is MT6765 platform.
Then I've checked Fairphone FP-1, which is MT6589 a pretty old platform.
The BROM (boot ROM) has been maintained by other teams and will vary by
different SoC project in Mediatek. I'm not sure why they changed the
descriptors.

For the consistency of BROM's behavior, I'll update a new patch keeps
PID:0003 remain untouched. I'll trying to report it to BROM team and see
if they have any action on this issue.

Regards,
Macpaul Lin

WARNING: multiple messages have this Message-ID (diff)
From: macpaul.lin@mediatek.com
To: Lars Melin <larsm17@gmail.com>
Cc: Oliver Neukum <oneukum@suse.com>,
	Andrey Arapov <andrey.arapov@gmail.com>,
	Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
	linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: [v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader.
Date: Wed, 19 Dec 2018 12:03:23 +0800	[thread overview]
Message-ID: <1545192203.4134.11.camel@mtkswgap22> (raw)

On Wed, 2018-12-19 at 10:31 +0700, Lars Melin wrote:
> On 12/19/2018 10:16, Macpaul Lin wrote: 
> 
> Hi Macpaul,
> your verbose usb listing show me that Mediatek has made two different 
> 0e8d:003 devices, see my verbose lsusb listing below.
> (Notice also the reverse order for cmd and data interfaces in it 
> compared to yours).
> USB id's are intended to identify a device and its needs so there should
> never be more than one unique device per id.
> 
> 
> Fairphone FP-1, MT6227  (no CDC union !!!)
> 
Hi Lars,

Ha ha ha, it is a little bit embarrassing.
What I've used to capture verbose log is MT6765 platform.
Then I've checked Fairphone FP-1, which is MT6589 a pretty old platform.
The BROM (boot ROM) has been maintained by other teams and will vary by
different SoC project in Mediatek. I'm not sure why they changed the
descriptors.

For the consistency of BROM's behavior, I'll update a new patch keeps
PID:0003 remain untouched. I'll trying to report it to BROM team and see
if they have any action on this issue.

Regards,
Macpaul Lin

  reply	other threads:[~2018-12-19  4:03 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  3:27 cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader macpaul.lin
2018-12-18  5:00 ` [PATCH v2] " Macpaul Lin
2018-12-18  5:00   ` [v2] " macpaul.lin
2018-12-18  9:02   ` [PATCH v2] " Johan Hovold
2018-12-18  9:02     ` [v2] " Johan Hovold
2018-12-18 10:41 ` [PATCH v3] " Macpaul Lin
2018-12-18 10:41   ` [v3] " macpaul.lin
2018-12-18 10:54   ` [PATCH v3] " Johan Hovold
2018-12-18 10:54     ` [v3] " Johan Hovold
2018-12-18 11:38 ` [PATCH v4] " Macpaul Lin
2018-12-18 11:38   ` [v4] " macpaul.lin
2018-12-18 11:44   ` [PATCH v4] " Johan Hovold
2018-12-18 11:44     ` [v4] " Johan Hovold
2018-12-18 11:59 ` [PATCH v5] " Macpaul Lin
2018-12-18 11:59   ` [v5] " macpaul.lin
2018-12-18 12:38   ` [PATCH v5] " Johan Hovold
2018-12-18 12:38     ` [v5] " Johan Hovold
2018-12-18 13:37     ` [PATCH v5] " Oliver Neukum
2018-12-18 13:37       ` [v5] " Oliver Neukum
2018-12-18 14:26       ` [PATCH v5] " Macpaul Lin
2018-12-18 14:26         ` [v5] " macpaul.lin
2018-12-18 15:19         ` [PATCH v5] " Macpaul Lin
2018-12-18 15:19           ` [v5] " macpaul.lin
2018-12-18 16:42           ` [PATCH v5] " Lars Melin
2018-12-18 16:42             ` [v5] " Lars Melin
2018-12-18 17:48             ` [PATCH v5] " Macpaul Lin
2018-12-18 17:48               ` [v5] " macpaul.lin
2018-12-19  0:45               ` [PATCH v5] " Lars Melin
2018-12-19  0:45                 ` [v5] " Lars Melin
2018-12-19  2:22               ` [PATCH v5] " Macpaul Lin
2018-12-19  2:22                 ` [v5] " macpaul.lin
2018-12-19  3:16                 ` [PATCH v5] " Macpaul Lin
2018-12-19  3:16                   ` [v5] " macpaul.lin
2018-12-19  3:31                   ` [PATCH v5] " Lars Melin
2018-12-19  3:31                     ` [v5] " Lars Melin
2018-12-19  4:03                     ` Macpaul Lin [this message]
2018-12-19  4:03                       ` macpaul.lin
2018-12-19  8:56                       ` [PATCH v5] " Oliver Neukum
2018-12-19  8:56                         ` [v5] " Oliver Neukum
2018-12-20 15:19                         ` [PATCH v5] " Greg Kroah-Hartman
2018-12-20 15:19                           ` [v5] " Greg Kroah-Hartman
2018-12-18 15:37 ` [PATCH v6] " Macpaul Lin
2018-12-18 15:37   ` [v6] " macpaul.lin
2018-12-19  4:11 ` [PATCH v7] " Macpaul Lin
2018-12-19  4:11   ` [v7] " macpaul.lin
2018-12-19  9:00   ` [PATCH v7] " Johan Hovold
2018-12-19  9:00     ` [v7] " Johan Hovold
2018-12-20 15:28     ` [PATCH v7] " Oliver Neukum
2018-12-20 15:28       ` [v7] " Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545192203.4134.11.camel@mtkswgap22 \
    --to=macpaul.lin@mediatek.com \
    --cc=andrey.arapov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=larsm17@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=stable@vger.kernel.org \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.