* [U-Boot] [PATCH] Add support for initializing MMC
@ 2018-12-14 6:53 tien.fong.chee at intel.com
2018-12-21 8:25 ` Chee, Tien Fong
0 siblings, 1 reply; 8+ messages in thread
From: tien.fong.chee at intel.com @ 2018-12-14 6:53 UTC (permalink / raw)
To: u-boot
From: Tien Fong Chee <tien.fong.chee@intel.com>
Firmware loader would encounter problem if the MMC is accessed before
initializing it. This patch would adding the support of initializing
MMC before the MMC is accessed by firmware loader.
Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
---
drivers/misc/fs_loader.c | 31 +++++++++++++++++++++++++++++++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
index 57a14a3..744fa46 100644
--- a/drivers/misc/fs_loader.c
+++ b/drivers/misc/fs_loader.c
@@ -12,6 +12,7 @@
#include <linux/string.h>
#include <mapmem.h>
#include <malloc.h>
+#include <mmc.h>
#include <spl.h>
DECLARE_GLOBAL_DATA_PTR;
@@ -252,6 +253,36 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev)
static int fs_loader_probe(struct udevice *dev)
{
+#ifdef CONFIG_MMC
+ int ret;
+ struct device_platdata *plat = dev->platdata;
+
+ ret = mmc_initialize(NULL);
+ if (ret) {
+ debug("MMC: could not initialize mmc. error: %d\n", ret);
+
+ return ret;
+ }
+
+ if (plat->phandlepart.phandle) {
+ ofnode node = ofnode_get_by_phandle(plat->phandlepart.phandle);
+
+ struct udevice *mmc_dev = NULL;
+
+ ret = device_get_global_by_ofnode(node, &mmc_dev);
+ if (!ret) {
+ struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
+
+ ret = mmc_init(mmc);
+ if (ret) {
+ debug("MMC: mmc init failed with error: %d\n",
+ ret);
+
+ return ret;
+ }
+ }
+ }
+#endif
return 0;
};
--
1.7.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] Add support for initializing MMC
2018-12-14 6:53 [U-Boot] [PATCH] Add support for initializing MMC tien.fong.chee at intel.com
@ 2018-12-21 8:25 ` Chee, Tien Fong
2018-12-21 17:16 ` Simon Glass
0 siblings, 1 reply; 8+ messages in thread
From: Chee, Tien Fong @ 2018-12-21 8:25 UTC (permalink / raw)
To: u-boot
On Fri, 2018-12-14 at 14:53 +0800, tien.fong.chee at intel.com wrote:
> From: Tien Fong Chee <tien.fong.chee@intel.com>
>
> Firmware loader would encounter problem if the MMC is accessed before
> initializing it. This patch would adding the support of initializing
> MMC before the MMC is accessed by firmware loader.
>
> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> ---
> drivers/misc/fs_loader.c | 31 +++++++++++++++++++++++++++++++
> 1 files changed, 31 insertions(+), 0 deletions(-)
>
Any comment for this patch?
> diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> index 57a14a3..744fa46 100644
> --- a/drivers/misc/fs_loader.c
> +++ b/drivers/misc/fs_loader.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <mapmem.h>
> #include <malloc.h>
> +#include <mmc.h>
> #include <spl.h>
>
> DECLARE_GLOBAL_DATA_PTR;
> @@ -252,6 +253,36 @@ static int fs_loader_ofdata_to_platdata(struct
> udevice *dev)
>
> static int fs_loader_probe(struct udevice *dev)
> {
> +#ifdef CONFIG_MMC
> + int ret;
> + struct device_platdata *plat = dev->platdata;
> +
> + ret = mmc_initialize(NULL);
> + if (ret) {
> + debug("MMC: could not initialize mmc. error: %d\n",
> ret);
> +
> + return ret;
> + }
> +
> + if (plat->phandlepart.phandle) {
> + ofnode node = ofnode_get_by_phandle(plat-
> >phandlepart.phandle);
> +
> + struct udevice *mmc_dev = NULL;
> +
> + ret = device_get_global_by_ofnode(node, &mmc_dev);
> + if (!ret) {
> + struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
> +
> + ret = mmc_init(mmc);
> + if (ret) {
> + debug("MMC: mmc init failed with
> error: %d\n",
> + ret);
> +
> + return ret;
> + }
> + }
> + }
> +#endif
> return 0;
> };
>
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] Add support for initializing MMC
2018-12-21 8:25 ` Chee, Tien Fong
@ 2018-12-21 17:16 ` Simon Glass
2018-12-21 17:50 ` Chee, Tien Fong
0 siblings, 1 reply; 8+ messages in thread
From: Simon Glass @ 2018-12-21 17:16 UTC (permalink / raw)
To: u-boot
Hi,
On Fri, 21 Dec 2018 at 01:25, Chee, Tien Fong <tien.fong.chee@intel.com> wrote:
>
> On Fri, 2018-12-14 at 14:53 +0800, tien.fong.chee at intel.com wrote:
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > Firmware loader would encounter problem if the MMC is accessed before
> > initializing it. This patch would adding the support of initializing
> > MMC before the MMC is accessed by firmware loader.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> > drivers/misc/fs_loader.c | 31 +++++++++++++++++++++++++++++++
> > 1 files changed, 31 insertions(+), 0 deletions(-)
> >
> Any comment for this patch?
This should not be needed with CONFIG_DM_MMC enabled as it should be
enough to probe the mmc device. Is that right?
Regards,
Simon
>
> > diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> > index 57a14a3..744fa46 100644
> > --- a/drivers/misc/fs_loader.c
> > +++ b/drivers/misc/fs_loader.c
> > @@ -12,6 +12,7 @@
> > #include <linux/string.h>
> > #include <mapmem.h>
> > #include <malloc.h>
> > +#include <mmc.h>
> > #include <spl.h>
> >
> > DECLARE_GLOBAL_DATA_PTR;
> > @@ -252,6 +253,36 @@ static int fs_loader_ofdata_to_platdata(struct
> > udevice *dev)
> >
> > static int fs_loader_probe(struct udevice *dev)
> > {
> > +#ifdef CONFIG_MMC
> > + int ret;
> > + struct device_platdata *plat = dev->platdata;
> > +
> > + ret = mmc_initialize(NULL);
> > + if (ret) {
> > + debug("MMC: could not initialize mmc. error: %d\n",
> > ret);
> > +
> > + return ret;
> > + }
> > +
> > + if (plat->phandlepart.phandle) {
> > + ofnode node = ofnode_get_by_phandle(plat-
> > >phandlepart.phandle);
> > +
> > + struct udevice *mmc_dev = NULL;
> > +
> > + ret = device_get_global_by_ofnode(node, &mmc_dev);
> > + if (!ret) {
> > + struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
> > +
> > + ret = mmc_init(mmc);
> > + if (ret) {
> > + debug("MMC: mmc init failed with
> > error: %d\n",
> > + ret);
> > +
> > + return ret;
> > + }
> > + }
> > + }
> > +#endif
> > return 0;
> > };
> >
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] Add support for initializing MMC
2018-12-21 17:16 ` Simon Glass
@ 2018-12-21 17:50 ` Chee, Tien Fong
2018-12-22 20:51 ` Simon Glass
0 siblings, 1 reply; 8+ messages in thread
From: Chee, Tien Fong @ 2018-12-21 17:50 UTC (permalink / raw)
To: u-boot
On Fri, 2018-12-21 at 10:16 -0700, Simon Glass wrote:
> Hi,
>
> On Fri, 21 Dec 2018 at 01:25, Chee, Tien Fong <tien.fong.chee@intel.c
> om> wrote:
> >
> >
> > On Fri, 2018-12-14 at 14:53 +0800, tien.fong.chee at intel.com wrote:
> > >
> > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > >
> > > Firmware loader would encounter problem if the MMC is accessed
> > > before
> > > initializing it. This patch would adding the support of
> > > initializing
> > > MMC before the MMC is accessed by firmware loader.
> > >
> > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > ---
> > > drivers/misc/fs_loader.c | 31 +++++++++++++++++++++++++++++++
> > > 1 files changed, 31 insertions(+), 0 deletions(-)
> > >
> > Any comment for this patch?
> This should not be needed with CONFIG_DM_MMC enabled as it should be
> enough to probe the mmc device. Is that right?
No, CONFIG_DM_MMC is required, otherwise compiler would tell you error.
This whole mechanism is always developed in DM context.
What's your concern? You want me to add CONFIG_DM_MMC or replace with
CONFIG_MMC? or You want to improve the document?
>
> Regards,
> Simon
>
> >
> >
> > >
> > > diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> > > index 57a14a3..744fa46 100644
> > > --- a/drivers/misc/fs_loader.c
> > > +++ b/drivers/misc/fs_loader.c
> > > @@ -12,6 +12,7 @@
> > > #include <linux/string.h>
> > > #include <mapmem.h>
> > > #include <malloc.h>
> > > +#include <mmc.h>
> > > #include <spl.h>
> > >
> > > DECLARE_GLOBAL_DATA_PTR;
> > > @@ -252,6 +253,36 @@ static int
> > > fs_loader_ofdata_to_platdata(struct
> > > udevice *dev)
> > >
> > > static int fs_loader_probe(struct udevice *dev)
> > > {
> > > +#ifdef CONFIG_MMC
> > > + int ret;
> > > + struct device_platdata *plat = dev->platdata;
> > > +
> > > + ret = mmc_initialize(NULL);
> > > + if (ret) {
> > > + debug("MMC: could not initialize mmc. error: %d\n",
> > > ret);
> > > +
> > > + return ret;
> > > + }
> > > +
> > > + if (plat->phandlepart.phandle) {
> > > + ofnode node = ofnode_get_by_phandle(plat-
> > > >
> > > > phandlepart.phandle);
> > > +
> > > + struct udevice *mmc_dev = NULL;
> > > +
> > > + ret = device_get_global_by_ofnode(node, &mmc_dev);
> > > + if (!ret) {
> > > + struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
> > > +
> > > + ret = mmc_init(mmc);
> > > + if (ret) {
> > > + debug("MMC: mmc init failed with
> > > error: %d\n",
> > > + ret);
> > > +
> > > + return ret;
> > > + }
> > > + }
> > > + }
> > > +#endif
> > > return 0;
> > > };
> > >
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] Add support for initializing MMC
2018-12-21 17:50 ` Chee, Tien Fong
@ 2018-12-22 20:51 ` Simon Glass
2018-12-24 3:41 ` Chee, Tien Fong
0 siblings, 1 reply; 8+ messages in thread
From: Simon Glass @ 2018-12-22 20:51 UTC (permalink / raw)
To: u-boot
Hi Tien,
On Fri, 21 Dec 2018 at 10:50, Chee, Tien Fong <tien.fong.chee@intel.com> wrote:
>
> On Fri, 2018-12-21 at 10:16 -0700, Simon Glass wrote:
> > Hi,
> >
> > On Fri, 21 Dec 2018 at 01:25, Chee, Tien Fong <tien.fong.chee@intel.c
> > om> wrote:
> > >
> > >
> > > On Fri, 2018-12-14 at 14:53 +0800, tien.fong.chee at intel.com wrote:
> > > >
> > > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > >
> > > > Firmware loader would encounter problem if the MMC is accessed
> > > > before
> > > > initializing it. This patch would adding the support of
> > > > initializing
> > > > MMC before the MMC is accessed by firmware loader.
> > > >
> > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > ---
> > > > drivers/misc/fs_loader.c | 31 +++++++++++++++++++++++++++++++
> > > > 1 files changed, 31 insertions(+), 0 deletions(-)
> > > >
> > > Any comment for this patch?
> > This should not be needed with CONFIG_DM_MMC enabled as it should be
> > enough to probe the mmc device. Is that right?
> No, CONFIG_DM_MMC is required, otherwise compiler would tell you error.
> This whole mechanism is always developed in DM context.
> What's your concern? You want me to add CONFIG_DM_MMC or replace with
> CONFIG_MMC? or You want to improve the document?
Well, mmc_blk_probe() calls mmc_init() on the device. So instead of
the code you have, would it be possible to probe the blk device? You
can use device_find_first_child() for that. Perhaps write a function
in blk.h which probes the first block device for a parent?
Regards,
Simon
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Add support for initializing MMC
2018-12-22 20:51 ` Simon Glass
@ 2018-12-24 3:41 ` Chee, Tien Fong
0 siblings, 0 replies; 8+ messages in thread
From: Chee, Tien Fong @ 2018-12-24 3:41 UTC (permalink / raw)
To: u-boot
On Sat, 2018-12-22 at 13:51 -0700, Simon Glass wrote:
> Hi Tien,
>
> On Fri, 21 Dec 2018 at 10:50, Chee, Tien Fong <tien.fong.chee@intel.c
> om> wrote:
> >
> >
> > On Fri, 2018-12-21 at 10:16 -0700, Simon Glass wrote:
> > >
> > > Hi,
> > >
> > > On Fri, 21 Dec 2018 at 01:25, Chee, Tien Fong <tien.fong.chee@int
> > > el.c
> > > om> wrote:
> > > >
> > > >
> > > >
> > > > On Fri, 2018-12-14 at 14:53 +0800, tien.fong.chee at intel.com
> > > > wrote:
> > > > >
> > > > >
> > > > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > >
> > > > > Firmware loader would encounter problem if the MMC is
> > > > > accessed
> > > > > before
> > > > > initializing it. This patch would adding the support of
> > > > > initializing
> > > > > MMC before the MMC is accessed by firmware loader.
> > > > >
> > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > > ---
> > > > > drivers/misc/fs_loader.c | 31
> > > > > +++++++++++++++++++++++++++++++
> > > > > 1 files changed, 31 insertions(+), 0 deletions(-)
> > > > >
> > > > Any comment for this patch?
> > > This should not be needed with CONFIG_DM_MMC enabled as it should
> > > be
> > > enough to probe the mmc device. Is that right?
> > No, CONFIG_DM_MMC is required, otherwise compiler would tell you
> > error.
> > This whole mechanism is always developed in DM context.
> > What's your concern? You want me to add CONFIG_DM_MMC or replace
> > with
> > CONFIG_MMC? or You want to improve the document?
> Well, mmc_blk_probe() calls mmc_init() on the device. So instead of
> the code you have, would it be possible to probe the blk device? You
> can use device_find_first_child() for that. Perhaps write a function
> in blk.h which probes the first block device for a parent?
Yeah, sure. Let me find out more info.
>
> Regards,
> Simon
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Add support for initializing MMC
@ 2018-12-13 15:32 tien.fong.chee at intel.com
2018-12-13 16:22 ` Chee, Tien Fong
0 siblings, 1 reply; 8+ messages in thread
From: tien.fong.chee at intel.com @ 2018-12-13 15:32 UTC (permalink / raw)
To: u-boot
From: Tien Fong Chee <tien.fong.chee@intel.com>
Firmware loader would encounter problem if the MMC is accessed before
initializing it. This patch would adding the support of initializing
MMC before the MMC is accessed by firmware loader.
Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
---
drivers/misc/fs_loader.c | 33 ++++++++++++++++++++++++++++++++-
1 files changed, 32 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
index 57a14a3..675f625 100644
--- a/drivers/misc/fs_loader.c
+++ b/drivers/misc/fs_loader.c
@@ -12,6 +12,7 @@
#include <linux/string.h>
#include <mapmem.h>
#include <malloc.h>
+#include <mmc.h>
#include <spl.h>
DECLARE_GLOBAL_DATA_PTR;
@@ -221,6 +222,7 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev)
{
const char *fs_loader_path;
u32 phandlepart[2];
+ struct device_platdata *plat = NULL;
fs_loader_path = ofnode_get_chosen_prop("firmware-loader");
@@ -229,7 +231,6 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev)
fs_loader_node = ofnode_path(fs_loader_path);
if (ofnode_valid(fs_loader_node)) {
- struct device_platdata *plat;
plat = dev->platdata;
if (!ofnode_read_u32_array(fs_loader_node,
@@ -247,6 +248,36 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev)
}
}
+#ifdef CONFIG_MMC
+ int ret;
+
+ ret = mmc_initialize(NULL);
+ if (ret) {
+ debug("MMC: could not initialize mmc. error: %d\n", ret);
+
+ return ret;
+ }
+
+ if (plat->phandlepart.phandle) {
+ ofnode node = ofnode_get_by_phandle(plat->phandlepart.phandle);
+
+ struct udevice *mmc_dev = NULL;
+
+ ret = device_get_global_by_ofnode(node, &mmc_dev);
+ if (!ret) {
+ struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
+
+ ret = mmc_init(mmc);
+ if (ret) {
+ debug("MMC: mmc init failed with error: %d\n",
+ ret);
+
+ return ret;
+ }
+ }
+ }
+#endif
+
return 0;
}
--
1.7.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] Add support for initializing MMC
2018-12-13 15:32 tien.fong.chee at intel.com
@ 2018-12-13 16:22 ` Chee, Tien Fong
0 siblings, 0 replies; 8+ messages in thread
From: Chee, Tien Fong @ 2018-12-13 16:22 UTC (permalink / raw)
To: u-boot
On Thu, 2018-12-13 at 23:32 +0800, tien.fong.chee at intel.com wrote:
> From: Tien Fong Chee <tien.fong.chee@intel.com>
>
> Firmware loader would encounter problem if the MMC is accessed before
> initializing it. This patch would adding the support of initializing
> MMC before the MMC is accessed by firmware loader.
>
> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> ---
> drivers/misc/fs_loader.c | 33 ++++++++++++++++++++++++++++++++-
> 1 files changed, 32 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> index 57a14a3..675f625 100644
> --- a/drivers/misc/fs_loader.c
> +++ b/drivers/misc/fs_loader.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <mapmem.h>
> #include <malloc.h>
> +#include <mmc.h>
> #include <spl.h>
>
> DECLARE_GLOBAL_DATA_PTR;
> @@ -221,6 +222,7 @@ static int fs_loader_ofdata_to_platdata(struct
> udevice *dev)
> {
> const char *fs_loader_path;
> u32 phandlepart[2];
> + struct device_platdata *plat = NULL;
>
> fs_loader_path = ofnode_get_chosen_prop("firmware-loader");
>
> @@ -229,7 +231,6 @@ static int fs_loader_ofdata_to_platdata(struct
> udevice *dev)
>
> fs_loader_node = ofnode_path(fs_loader_path);
> if (ofnode_valid(fs_loader_node)) {
> - struct device_platdata *plat;
> plat = dev->platdata;
>
> if (!ofnode_read_u32_array(fs_loader_node,
> @@ -247,6 +248,36 @@ static int fs_loader_ofdata_to_platdata(struct
> udevice *dev)
> }
> }
>
I just realized this portion of codes should be moved to polling
function. I will send out another patch tomorrow.
> +#ifdef CONFIG_MMC
> + int ret;
> +
> + ret = mmc_initialize(NULL);
> + if (ret) {
> + debug("MMC: could not initialize mmc. error: %d\n",
> ret);
> +
> + return ret;
> + }
> +
> + if (plat->phandlepart.phandle) {
> + ofnode node = ofnode_get_by_phandle(plat-
> >phandlepart.phandle);
> +
> + struct udevice *mmc_dev = NULL;
> +
> + ret = device_get_global_by_ofnode(node, &mmc_dev);
> + if (!ret) {
> + struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
> +
> + ret = mmc_init(mmc);
> + if (ret) {
> + debug("MMC: mmc init failed with
> error: %d\n",
> + ret);
> +
> + return ret;
> + }
> + }
> + }
> +#endif
> +
> return 0;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-12-24 3:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14 6:53 [U-Boot] [PATCH] Add support for initializing MMC tien.fong.chee at intel.com
2018-12-21 8:25 ` Chee, Tien Fong
2018-12-21 17:16 ` Simon Glass
2018-12-21 17:50 ` Chee, Tien Fong
2018-12-22 20:51 ` Simon Glass
2018-12-24 3:41 ` Chee, Tien Fong
-- strict thread matches above, loose matches on Subject: below --
2018-12-13 15:32 tien.fong.chee at intel.com
2018-12-13 16:22 ` Chee, Tien Fong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.