All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: "Angus Ainslie (Purism)" <angus@akkea.ca>
Cc: angus.ainslie@puri.sm, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Daniel Baluta <daniel.baluta@gmail.com>
Subject: [v4,2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts
Date: Fri, 25 Jan 2019 10:35:30 +0100	[thread overview]
Message-ID: <1548408930.28802.34.camel@pengutronix.de> (raw)

Am Donnerstag, den 24.01.2019, 19:55 -0700 schrieb Angus Ainslie (Purism):
> This is identical to the imx7d data structures but we need to
> be able to differentiate that the imx8mq has 2 sdma controllers.

No, we don't, see comment on patch 4/5. This can reuse the imx7d data.

Regards,
Lucas

> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
>  drivers/dma/imx-sdma.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 5e5ef0b5a973..ec6fb48f387a 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -556,6 +556,12 @@ static struct sdma_driver_data sdma_imx7d = {
> >  	.script_addrs = &sdma_script_imx7d,
>  };
>  
> +static struct sdma_driver_data sdma_imx8mq = {
> > +	.chnenbl0 = SDMA_CHNENBL0_IMX35,
> > +	.num_events = 48,
> > +	.script_addrs = &sdma_script_imx7d,
> +};
> +
>  static const struct platform_device_id sdma_devtypes[] = {
> >  	{
> >  		.name = "imx25-sdma",
> @@ -578,6 +584,9 @@ static const struct platform_device_id sdma_devtypes[] = {
> >  	}, {
> >  		.name = "imx7d-sdma",
> >  		.driver_data = (unsigned long)&sdma_imx7d,
> > +	}, {
> > +		.name = "imx8mq-sdma",
> > +		.driver_data = (unsigned long)&sdma_imx8mq,
> >  	}, {
> >  		/* sentinel */
> >  	}
> @@ -592,6 +601,7 @@ static const struct of_device_id sdma_dt_ids[] = {
> >  	{ .compatible = "fsl,imx31-sdma", .data = &sdma_imx31, },
> >  	{ .compatible = "fsl,imx25-sdma", .data = &sdma_imx25, },
> >  	{ .compatible = "fsl,imx7d-sdma", .data = &sdma_imx7d, },
> > +	{ .compatible = "fsl,imx8mq-sdma", .data = &sdma_imx8mq, },
> >  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, sdma_dt_ids);

WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de>
To: "Angus Ainslie (Purism)" <angus@akkea.ca>
Cc: angus.ainslie@puri.sm, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Daniel Baluta <daniel.baluta@gmail.com>
Subject: Re: [PATCH v4 2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts
Date: Fri, 25 Jan 2019 10:35:30 +0100	[thread overview]
Message-ID: <1548408930.28802.34.camel@pengutronix.de> (raw)
In-Reply-To: <20190125025528.15645-3-angus@akkea.ca>

Am Donnerstag, den 24.01.2019, 19:55 -0700 schrieb Angus Ainslie (Purism):
> This is identical to the imx7d data structures but we need to
> be able to differentiate that the imx8mq has 2 sdma controllers.

No, we don't, see comment on patch 4/5. This can reuse the imx7d data.

Regards,
Lucas

> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
>  drivers/dma/imx-sdma.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 5e5ef0b5a973..ec6fb48f387a 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -556,6 +556,12 @@ static struct sdma_driver_data sdma_imx7d = {
> >  	.script_addrs = &sdma_script_imx7d,
>  };
>  
> +static struct sdma_driver_data sdma_imx8mq = {
> > +	.chnenbl0 = SDMA_CHNENBL0_IMX35,
> > +	.num_events = 48,
> > +	.script_addrs = &sdma_script_imx7d,
> +};
> +
>  static const struct platform_device_id sdma_devtypes[] = {
> >  	{
> >  		.name = "imx25-sdma",
> @@ -578,6 +584,9 @@ static const struct platform_device_id sdma_devtypes[] = {
> >  	}, {
> >  		.name = "imx7d-sdma",
> >  		.driver_data = (unsigned long)&sdma_imx7d,
> > +	}, {
> > +		.name = "imx8mq-sdma",
> > +		.driver_data = (unsigned long)&sdma_imx8mq,
> >  	}, {
> >  		/* sentinel */
> >  	}
> @@ -592,6 +601,7 @@ static const struct of_device_id sdma_dt_ids[] = {
> >  	{ .compatible = "fsl,imx31-sdma", .data = &sdma_imx31, },
> >  	{ .compatible = "fsl,imx25-sdma", .data = &sdma_imx25, },
> >  	{ .compatible = "fsl,imx7d-sdma", .data = &sdma_imx7d, },
> > +	{ .compatible = "fsl,imx8mq-sdma", .data = &sdma_imx8mq, },
> >  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, sdma_dt_ids);

WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de>
To: "Angus Ainslie (Purism)" <angus@akkea.ca>
Cc: Daniel Baluta <daniel.baluta@gmail.com>,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	angus.ainslie@puri.sm, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts
Date: Fri, 25 Jan 2019 10:35:30 +0100	[thread overview]
Message-ID: <1548408930.28802.34.camel@pengutronix.de> (raw)
In-Reply-To: <20190125025528.15645-3-angus@akkea.ca>

Am Donnerstag, den 24.01.2019, 19:55 -0700 schrieb Angus Ainslie (Purism):
> This is identical to the imx7d data structures but we need to
> be able to differentiate that the imx8mq has 2 sdma controllers.

No, we don't, see comment on patch 4/5. This can reuse the imx7d data.

Regards,
Lucas

> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
>  drivers/dma/imx-sdma.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 5e5ef0b5a973..ec6fb48f387a 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -556,6 +556,12 @@ static struct sdma_driver_data sdma_imx7d = {
> >  	.script_addrs = &sdma_script_imx7d,
>  };
>  
> +static struct sdma_driver_data sdma_imx8mq = {
> > +	.chnenbl0 = SDMA_CHNENBL0_IMX35,
> > +	.num_events = 48,
> > +	.script_addrs = &sdma_script_imx7d,
> +};
> +
>  static const struct platform_device_id sdma_devtypes[] = {
> >  	{
> >  		.name = "imx25-sdma",
> @@ -578,6 +584,9 @@ static const struct platform_device_id sdma_devtypes[] = {
> >  	}, {
> >  		.name = "imx7d-sdma",
> >  		.driver_data = (unsigned long)&sdma_imx7d,
> > +	}, {
> > +		.name = "imx8mq-sdma",
> > +		.driver_data = (unsigned long)&sdma_imx8mq,
> >  	}, {
> >  		/* sentinel */
> >  	}
> @@ -592,6 +601,7 @@ static const struct of_device_id sdma_dt_ids[] = {
> >  	{ .compatible = "fsl,imx31-sdma", .data = &sdma_imx31, },
> >  	{ .compatible = "fsl,imx25-sdma", .data = &sdma_imx25, },
> >  	{ .compatible = "fsl,imx7d-sdma", .data = &sdma_imx7d, },
> > +	{ .compatible = "fsl,imx8mq-sdma", .data = &sdma_imx8mq, },
> >  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, sdma_dt_ids);

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2019-01-25  9:35 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25  9:35 Lucas Stach [this message]
2019-01-25  9:35 ` [PATCH v4 2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts Lucas Stach
2019-01-25  9:35 ` Lucas Stach
  -- strict thread matches above, loose matches on Subject: below --
2019-02-25 13:31 [v6,2/3] dmaengine: imx-sdma: add a test for imx8mq multi sdma devices Daniel Baluta
2019-02-25 13:31 ` [PATCH v6 2/3] " Daniel Baluta
2019-02-25 13:31 ` Daniel Baluta
2019-01-28 16:03 [v6,3/3] dmaengine: imx-sdma: fix consistent dma test failures Angus Ainslie
2019-01-28 16:03 ` [PATCH v6 3/3] " Angus Ainslie (Purism)
2019-01-28 16:03 ` Angus Ainslie (Purism)
2019-01-28 16:03 [v6,2/3] dmaengine: imx-sdma: add a test for imx8mq multi sdma devices Angus Ainslie
2019-01-28 16:03 ` [PATCH v6 2/3] " Angus Ainslie (Purism)
2019-01-28 16:03 ` Angus Ainslie (Purism)
2019-01-28 16:03 [v6,1/3] dmaengine: imx-sdma: add clock ratio 1:1 check Angus Ainslie
2019-01-28 16:03 ` [PATCH v6 1/3] " Angus Ainslie (Purism)
2019-01-28 16:03 ` Angus Ainslie (Purism)
2019-01-28  9:33 [v5,4/5] dmaengine: imx-sdma: add a test for imx8mq multi sdma devices Lucas Stach
2019-01-28  9:33 ` [PATCH v5 4/5] " Lucas Stach
2019-01-28  9:33 ` Lucas Stach
2019-01-28  9:32 [v5,2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts Lucas Stach
2019-01-28  9:32 ` [PATCH v5 2/5] " Lucas Stach
2019-01-28  9:32 ` Lucas Stach
2019-01-28  9:29 [v5,1/5] dmaengine: imx-sdma: add clock ratio 1:1 check Lucas Stach
2019-01-28  9:29 ` [PATCH v5 1/5] " Lucas Stach
2019-01-28  9:29 ` Lucas Stach
2019-01-28  6:08 [v5,5/5] dmaengine: imx-sdma: fix consistent dma test failures Angus Ainslie
2019-01-28  6:08 ` [PATCH v5 5/5] " Angus Ainslie (Purism)
2019-01-28  6:08 ` Angus Ainslie (Purism)
2019-01-28  6:08 [v5,4/5] dmaengine: imx-sdma: add a test for imx8mq multi sdma devices Angus Ainslie
2019-01-28  6:08 ` [PATCH v5 4/5] " Angus Ainslie (Purism)
2019-01-28  6:08 ` Angus Ainslie (Purism)
2019-01-28  6:08 [v5,3/5] dt-bindings: dma: fsl-imx-sdma: add fsl,imx8mq to the accepted compatible node Angus Ainslie
2019-01-28  6:08 ` [PATCH v5 3/5] dt-bindings: dma: fsl-imx-sdma: add fsl, imx8mq " Angus Ainslie (Purism)
2019-01-28  6:08 ` [PATCH v5 3/5] dt-bindings: dma: fsl-imx-sdma: add fsl,imx8mq " Angus Ainslie (Purism)
2019-01-28  6:08 [v5,2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts Angus Ainslie
2019-01-28  6:08 ` [PATCH v5 2/5] " Angus Ainslie (Purism)
2019-01-28  6:08 ` Angus Ainslie (Purism)
2019-01-28  6:08 [v5,1/5] dmaengine: imx-sdma: add clock ratio 1:1 check Angus Ainslie
2019-01-28  6:08 ` [PATCH v5 1/5] " Angus Ainslie (Purism)
2019-01-28  6:08 ` Angus Ainslie (Purism)
2019-01-25  9:42 [v4,1/5] " Lucas Stach
2019-01-25  9:42 ` [PATCH v4 1/5] " Lucas Stach
2019-01-25  9:42 ` Lucas Stach
2019-01-25  9:39 [v4,3/5] dt-bindings: dma: fsl-imx-sdma: add fsl,imx8mq to the accepted compatible node Lucas Stach
2019-01-25  9:39 ` [PATCH v4 3/5] " Lucas Stach
2019-01-25  9:39 ` Lucas Stach
2019-01-25  9:38 [v4,5/5] imx8mq.dtsi: add the sdma nodes Lucas Stach
2019-01-25  9:38 ` [PATCH v4 5/5] " Lucas Stach
2019-01-25  9:38 ` Lucas Stach
2019-01-25  9:34 [v4,4/5] dma: imx-sdma: add a test for imx8mq multi sdma devices Lucas Stach
2019-01-25  9:34 ` [PATCH v4 4/5] " Lucas Stach
2019-01-25  9:34 ` Lucas Stach
2019-01-25  2:55 [v4,5/5] imx8mq.dtsi: add the sdma nodes Angus Ainslie
2019-01-25  2:55 ` [PATCH v4 5/5] " Angus Ainslie (Purism)
2019-01-25  2:55 ` Angus Ainslie (Purism)
2019-01-25  2:55 [v4,4/5] dma: imx-sdma: add a test for imx8mq multi sdma devices Angus Ainslie
2019-01-25  2:55 ` [PATCH v4 4/5] " Angus Ainslie (Purism)
2019-01-25  2:55 ` Angus Ainslie (Purism)
2019-01-25  2:55 [v4,3/5] dt-bindings: dma: fsl-imx-sdma: add fsl,imx8mq to the accepted compatible node Angus Ainslie
2019-01-25  2:55 ` [PATCH v4 3/5] dt-bindings: dma: fsl-imx-sdma: add fsl, imx8mq " Angus Ainslie (Purism)
2019-01-25  2:55 ` [PATCH v4 3/5] dt-bindings: dma: fsl-imx-sdma: add fsl,imx8mq " Angus Ainslie (Purism)
2019-01-25  2:55 [v4,2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts Angus Ainslie
2019-01-25  2:55 ` [PATCH v4 2/5] " Angus Ainslie (Purism)
2019-01-25  2:55 ` Angus Ainslie (Purism)
2019-01-25  2:55 [v4,1/5] dmaengine: imx-sdma: add clock ratio 1:1 check Angus Ainslie
2019-01-25  2:55 ` [PATCH v4 1/5] " Angus Ainslie (Purism)
2019-01-25  2:55 ` Angus Ainslie (Purism)
2019-01-23 16:50 [v3,5/5] imx8mq.dtsi: add the sdma nodes Lucas Stach
2019-01-23 16:50 ` [PATCH v3 5/5] " Lucas Stach
2019-01-23 16:50 ` Lucas Stach
2019-01-23 15:55 [v3,4/5] dma: imx-sdma: add an index for imx8mq multi sdma devices Vinod Koul
2019-01-23 15:55 ` [PATCH v3 4/5] " Vinod Koul
2019-01-23 15:55 ` Vinod Koul
2019-01-23 15:43 [v3,1/5] dma: imx-sdma: add clock ratio 1:1 check Lucas Stach
2019-01-23 15:43 ` [PATCH v3 1/5] " Lucas Stach
2019-01-23 15:43 ` Lucas Stach
2019-01-23 15:42 [v3,4/5] dma: imx-sdma: add an index for imx8mq multi sdma devices Angus Ainslie
2019-01-23 15:42 ` [PATCH v3 4/5] " Angus Ainslie
2019-01-23 15:42 ` Angus Ainslie
2019-01-23 15:31 [v3,4/5] " Lucas Stach
2019-01-23 15:31 ` [PATCH v3 4/5] " Lucas Stach
2019-01-23 15:31 ` Lucas Stach
2019-01-23 15:23 [v3,5/5] imx8mq.dtsi: add the sdma nodes Angus Ainslie
2019-01-23 15:23 ` [PATCH v3 5/5] " Angus Ainslie (Purism)
2019-01-23 15:23 ` Angus Ainslie (Purism)
2019-01-23 15:23 [v3,4/5] dma: imx-sdma: add an index for imx8mq multi sdma devices Angus Ainslie
2019-01-23 15:23 ` [PATCH v3 4/5] " Angus Ainslie (Purism)
2019-01-23 15:23 ` Angus Ainslie (Purism)
2019-01-23 15:23 [v3,3/5] dt-bindings: dma: fsl-imx-sdma: add imx8mq compatible string Angus Ainslie
2019-01-23 15:23 ` [PATCH v3 3/5] " Angus Ainslie (Purism)
2019-01-23 15:23 ` Angus Ainslie (Purism)
2019-01-23 15:23 [v3,2/5] dma: imx-sdma: add imx8mq sdma compatible parts Angus Ainslie
2019-01-23 15:23 ` [PATCH v3 2/5] " Angus Ainslie (Purism)
2019-01-23 15:23 ` Angus Ainslie (Purism)
2019-01-23 15:23 [v3,1/5] dma: imx-sdma: add clock ratio 1:1 check Angus Ainslie
2019-01-23 15:23 ` [PATCH v3 1/5] " Angus Ainslie (Purism)
2019-01-23 15:23 ` Angus Ainslie (Purism)
2019-01-21 14:43 [v2,2/3] " Angus Ainslie
2019-01-21 14:43 ` [PATCH v2 2/3] " Angus Ainslie
2019-01-21 14:43 ` Angus Ainslie
2019-01-21  9:17 [v2,2/3] " Lucas Stach
2019-01-21  9:17 ` [PATCH v2 2/3] " Lucas Stach
2019-01-21  9:17 ` Lucas Stach
2019-01-20 18:00 [v2,2/3] " Daniel Baluta
2019-01-20 18:00 ` [PATCH v2 2/3] " Daniel Baluta
2019-01-20 18:00 ` Daniel Baluta
2019-01-20 15:04 [v2,1/3] dma: imx-sdma: fix NULL pointer de-reference Angus Ainslie
2019-01-20 15:04 ` [PATCH v2 1/3] " Angus Ainslie
2019-01-20 15:04 ` Angus Ainslie
2019-01-20 14:38 [v2,2/3] dma: imx-sdma: add clock ratio 1:1 check Angus Ainslie
2019-01-20 14:38 ` [PATCH v2 2/3] " Angus Ainslie
2019-01-20 14:38 ` Angus Ainslie
2019-01-20  9:58 [v2,2/3] " Daniel Baluta
2019-01-20  9:58 ` [PATCH v2 2/3] " Daniel Baluta
2019-01-20  9:58 ` Daniel Baluta
2019-01-20  9:54 [v2,1/3] dma: imx-sdma: fix NULL pointer de-reference Daniel Baluta
2019-01-20  9:54 ` [PATCH v2 1/3] " Daniel Baluta
2019-01-20  9:54 ` Daniel Baluta
2019-01-20  2:31 [v2,3/3] imx8mq.dtsi: add the sdma nodes Angus Ainslie
2019-01-20  2:31 ` [PATCH v2 3/3] " Angus Ainslie (Purism)
2019-01-20  2:31 ` Angus Ainslie (Purism)
2019-01-20  2:31 [v2,2/3] dma: imx-sdma: add clock ratio 1:1 check Angus Ainslie
2019-01-20  2:31 ` [PATCH v2 2/3] " Angus Ainslie (Purism)
2019-01-20  2:31 ` Angus Ainslie (Purism)
2019-01-20  2:31 [v2,1/3] dma: imx-sdma: fix NULL pointer de-reference Angus Ainslie
2019-01-20  2:31 ` [PATCH v2 1/3] " Angus Ainslie (Purism)
2019-01-20  2:31 ` Angus Ainslie (Purism)
2019-01-20  2:31 [PATCH v2 0/3] dma: imx-sdma: add the sdma engine to the imx8mq Angus Ainslie (Purism)
2019-01-20  2:31 ` Angus Ainslie (Purism)
2019-01-23 15:23 ` [PATCH v3 0/5] " Angus Ainslie (Purism)
2019-01-23 15:23   ` Angus Ainslie (Purism)
2019-01-25  2:55 ` [PATCH v4 0/5] dmaengine: " Angus Ainslie (Purism)
2019-01-25  2:55   ` Angus Ainslie (Purism)
2019-01-28  6:08 ` [PATCH v5 " Angus Ainslie (Purism)
2019-01-28  6:08   ` Angus Ainslie (Purism)
2019-01-28 16:03 ` [PATCH v6 0/3] " Angus Ainslie (Purism)
2019-01-28 16:03   ` Angus Ainslie (Purism)
2019-02-25 17:56   ` Vinod Koul
2019-02-25 17:56     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548408930.28802.34.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=angus.ainslie@puri.sm \
    --cc=angus@akkea.ca \
    --cc=daniel.baluta@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.