From: no-reply@patchew.org
To: crosa@redhat.com
Cc: fam@euphon.net, qemu-devel@nongnu.orgfam@euphon.net,
ehabkost@redhat.com, arikalo@wavecomp.com, philmd@redhat.com,
cohuck@redhat.com, qemu-s390x@nongnu.org, wainersm@redhat.com,
smarkovic@wavecomp.com, amarkovic@wavecomp.com,
ccarrara@redhat.com, alex.bennee@linaro.org,
aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support
Date: Sat, 2 Feb 2019 11:23:16 -0800 (PST) [thread overview]
Message-ID: <154913539410.29184.10312009405637121973@ebba9967afc0> (raw)
In-Reply-To: <20190202005610.24048-1-crosa@redhat.com>
Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support
Message-id: 20190202005610.24048-1-crosa@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190202005610.24048-1-crosa@redhat.com -> patchew/20190202005610.24048-1-crosa@redhat.com
* [new tag] patchew/20190202011048.12343-1-jsnow@redhat.com -> patchew/20190202011048.12343-1-jsnow@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out '9b7ab2fa020341dee8bf9df6c9cf40003e0136df'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
6655fa7 Boot Linux Console Test: add a test for alpha + clipper
f6dd48f Boot Linux Console Test: add a test for s390x + s390-ccw-virtio
018f196 Boot Linux Console Test: add a test for arm + virt
1b3a235 Boot Linux Console Test: add a test for aarch64 + virt
a72b513 Boot Linux Console Test: add a test for ppc64 + pseries
53b6bd6 Boot Linux Console Test: add a test for mips64el + malta
9e99bc7 Boot Linux Console Test: add a test for mips + malta
ad537d2 scripts/qemu.py: support adding a console with the default serial device
a90473b Boot Linux Console Test: refactor the console watcher into utility method
31e1e8e Boot Linux Console Test: increase timeout
71fd9a8 Boot Linux Console Test: add common kernel command line options
1f01854 Boot Linux Console Test: update the x86_64 kernel
fd958ac Boot Linux Console Test: rename the x86_64 after the arch and machine
5353486 Acceptance tests: look for target architecture in test tags first
0eec679 Acceptance tests: use "arch:" tag to filter target specific tests
d8bdead Acceptance tests: introduce arch parameter and attribute
68ac450 Acceptance tests: fix doc reference to avocado_qemu directory
4ef4e6b Acceptance tests: improve docstring on pick_default_qemu_bin()
9255bba Acceptance tests: show avocado test execution by default
3401845 scripts/qemu.py: log QEMU launch command line
=== OUTPUT BEGIN ===
1/20 Checking commit 3401845f7eb9 (scripts/qemu.py: log QEMU launch command line)
2/20 Checking commit 9255bba791a8 (Acceptance tests: show avocado test execution by default)
3/20 Checking commit 4ef4e6bab129 (Acceptance tests: improve docstring on pick_default_qemu_bin())
4/20 Checking commit 68ac450c2b81 (Acceptance tests: fix doc reference to avocado_qemu directory)
5/20 Checking commit d8bdead7f506 (Acceptance tests: introduce arch parameter and attribute)
6/20 Checking commit 0eec679cae2b (Acceptance tests: use "arch:" tag to filter target specific tests)
7/20 Checking commit 5353486417ba (Acceptance tests: look for target architecture in test tags first)
8/20 Checking commit fd958acfdb06 (Boot Linux Console Test: rename the x86_64 after the arch and machine)
9/20 Checking commit 1f018544557b (Boot Linux Console Test: update the x86_64 kernel)
10/20 Checking commit 71fd9a85460e (Boot Linux Console Test: add common kernel command line options)
11/20 Checking commit 31e1e8e772d2 (Boot Linux Console Test: increase timeout)
12/20 Checking commit a90473b9e34b (Boot Linux Console Test: refactor the console watcher into utility method)
13/20 Checking commit ad537d2fcc3d (scripts/qemu.py: support adding a console with the default serial device)
14/20 Checking commit 9e99bc7ca7b3 (Boot Linux Console Test: add a test for mips + malta)
15/20 Checking commit 53b6bd6a83fb (Boot Linux Console Test: add a test for mips64el + malta)
ERROR: line over 90 characters
#61: FILE: tests/acceptance/boot_linux_console.py:116:
+ [1] http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48
ERROR: line over 90 characters
#62: FILE: tests/acceptance/boot_linux_console.py:117:
+ [2] https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official
total: 2 errors, 0 warnings, 49 lines checked
Patch 15/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/20 Checking commit a72b513a0156 (Boot Linux Console Test: add a test for ppc64 + pseries)
17/20 Checking commit 1b3a2357bc57 (Boot Linux Console Test: add a test for aarch64 + virt)
WARNING: line over 80 characters
#51: FILE: tests/acceptance/boot_linux_console.py:170:
+ kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0'
total: 0 errors, 1 warnings, 31 lines checked
Patch 17/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/20 Checking commit 018f1969af3b (Boot Linux Console Test: add a test for arm + virt)
WARNING: line over 80 characters
#48: FILE: tests/acceptance/boot_linux_console.py:190:
+ kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0'
total: 0 errors, 1 warnings, 30 lines checked
Patch 18/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/20 Checking commit f6dd48f84608 (Boot Linux Console Test: add a test for s390x + s390-ccw-virtio)
20/20 Checking commit 6655fa70dfc9 (Boot Linux Console Test: add a test for alpha + clipper)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2019-02-02 23:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 0:55 [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support Cleber Rosa
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 01/20] scripts/qemu.py: log QEMU launch command line Cleber Rosa
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 02/20] Acceptance tests: show avocado test execution by default Cleber Rosa
2019-02-06 14:36 ` Cornelia Huck
2019-02-06 17:02 ` Cleber Rosa
2019-02-06 17:20 ` Cornelia Huck
2019-02-06 17:36 ` Cleber Rosa
2019-02-07 10:25 ` Cornelia Huck
2019-02-07 18:32 ` Cleber Rosa
2019-02-08 9:54 ` Cornelia Huck
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 03/20] Acceptance tests: improve docstring on pick_default_qemu_bin() Cleber Rosa
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 04/20] Acceptance tests: fix doc reference to avocado_qemu directory Cleber Rosa
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 05/20] Acceptance tests: introduce arch parameter and attribute Cleber Rosa
2019-02-06 15:40 ` Cornelia Huck
2019-02-07 18:02 ` Cleber Rosa
2019-02-07 18:22 ` Cleber Rosa
2019-02-08 10:10 ` Cornelia Huck
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 06/20] Acceptance tests: use "arch:" tag to filter target specific tests Cleber Rosa
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 07/20] Acceptance tests: look for target architecture in test tags first Cleber Rosa
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 08/20] Boot Linux Console Test: rename the x86_64 after the arch and machine Cleber Rosa
2019-02-02 0:55 ` [Qemu-devel] [PATCH v2 09/20] Boot Linux Console Test: update the x86_64 kernel Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 10/20] Boot Linux Console Test: add common kernel command line options Cleber Rosa
2019-02-02 1:01 ` Philippe Mathieu-Daudé
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 11/20] Boot Linux Console Test: increase timeout Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 12/20] Boot Linux Console Test: refactor the console watcher into utility method Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 13/20] scripts/qemu.py: support adding a console with the default serial device Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 14/20] Boot Linux Console Test: add a test for mips + malta Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 15/20] Boot Linux Console Test: add a test for mips64el " Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 16/20] Boot Linux Console Test: add a test for ppc64 + pseries Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 17/20] Boot Linux Console Test: add a test for aarch64 + virt Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 18/20] Boot Linux Console Test: add a test for arm " Cleber Rosa
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 19/20] Boot Linux Console Test: add a test for s390x + s390-ccw-virtio Cleber Rosa
2019-02-06 15:44 ` Cornelia Huck
2019-02-02 0:56 ` [Qemu-devel] [PATCH v2 20/20] Boot Linux Console Test: add a test for alpha + clipper Cleber Rosa
2019-02-02 19:20 ` [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support no-reply
2019-02-02 19:20 ` no-reply
2019-02-02 19:23 ` no-reply [this message]
2019-02-02 19:25 ` no-reply
2019-02-02 19:26 ` no-reply
2019-02-03 17:46 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154913539410.29184.10312009405637121973@ebba9967afc0 \
--to=no-reply@patchew.org \
--cc=crosa@redhat.com \
--cc=fam@euphon.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-devel@nongnu.orgfam \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.