Re: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support
Type: series
Message-id: 20190202005610.24048-1-crosa@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190202005610.24048-1-crosa@redhat.com -> patchew/20190202005610.24048-1-crosa@redhat.com
Switched to a new branch 'test'
17035afa87 Boot Linux Console Test: add a test for alpha + clipper
664f768105 Boot Linux Console Test: add a test for s390x + s390-ccw-virtio
af7932545d Boot Linux Console Test: add a test for arm + virt
afe4751b4d Boot Linux Console Test: add a test for aarch64 + virt
34684e2787 Boot Linux Console Test: add a test for ppc64 + pseries
828dece1c0 Boot Linux Console Test: add a test for mips64el + malta
eafeed88f9 Boot Linux Console Test: add a test for mips + malta
04af0c729d scripts/qemu.py: support adding a console with the default serial device
cb969cd6fe Boot Linux Console Test: refactor the console watcher into utility method
a446d2e9ba Boot Linux Console Test: increase timeout
cbedab968c Boot Linux Console Test: add common kernel command line options
14bf9a0f17 Boot Linux Console Test: update the x86_64 kernel
b41b04b466 Boot Linux Console Test: rename the x86_64 after the arch and machine
d957397957 Acceptance tests: look for target architecture in test tags first
e15cd2534a Acceptance tests: use "arch:" tag to filter target specific tests
c558ad7dc5 Acceptance tests: introduce arch parameter and attribute
981c7f300d Acceptance tests: fix doc reference to avocado_qemu directory
19b5d68909 Acceptance tests: improve docstring on pick_default_qemu_bin()
db08e24a7e Acceptance tests: show avocado test execution by default
fe7c5846dc scripts/qemu.py: log QEMU launch command line

=== OUTPUT BEGIN ===
1/20 Checking commit fe7c5846dca6 (scripts/qemu.py: log QEMU launch command line)
2/20 Checking commit db08e24a7ead (Acceptance tests: show avocado test execution by default)
3/20 Checking commit 19b5d6890978 (Acceptance tests: improve docstring on pick_default_qemu_bin())
4/20 Checking commit 981c7f300d93 (Acceptance tests: fix doc reference to avocado_qemu directory)
5/20 Checking commit c558ad7dc50a (Acceptance tests: introduce arch parameter and attribute)
6/20 Checking commit e15cd2534a41 (Acceptance tests: use "arch:" tag to filter target specific tests)
7/20 Checking commit d95739795725 (Acceptance tests: look for target architecture in test tags first)
8/20 Checking commit b41b04b4662d (Boot Linux Console Test: rename the x86_64 after the arch and machine)
9/20 Checking commit 14bf9a0f170e (Boot Linux Console Test: update the x86_64 kernel)
10/20 Checking commit cbedab968cbf (Boot Linux Console Test: add common kernel command line options)
11/20 Checking commit a446d2e9baf6 (Boot Linux Console Test: increase timeout)
12/20 Checking commit cb969cd6fe2b (Boot Linux Console Test: refactor the console watcher into utility method)
13/20 Checking commit 04af0c729dfa (scripts/qemu.py: support adding a console with the default serial device)
14/20 Checking commit eafeed88f9b4 (Boot Linux Console Test: add a test for mips + malta)
15/20 Checking commit 828dece1c0ce (Boot Linux Console Test: add a test for mips64el + malta)
ERROR: line over 90 characters
#61: FILE: tests/acceptance/boot_linux_console.py:116:
+        [1] http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48

ERROR: line over 90 characters
#62: FILE: tests/acceptance/boot_linux_console.py:117:
+        [2] https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official

total: 2 errors, 0 warnings, 49 lines checked

Patch 15/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/20 Checking commit 34684e2787d1 (Boot Linux Console Test: add a test for ppc64 + pseries)
17/20 Checking commit afe4751b4d91 (Boot Linux Console Test: add a test for aarch64 + virt)
WARNING: line over 80 characters
#51: FILE: tests/acceptance/boot_linux_console.py:170:
+        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0'

total: 0 errors, 1 warnings, 31 lines checked

Patch 17/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/20 Checking commit af7932545dc5 (Boot Linux Console Test: add a test for arm + virt)
WARNING: line over 80 characters
#48: FILE: tests/acceptance/boot_linux_console.py:190:
+        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0'

total: 0 errors, 1 warnings, 30 lines checked

Patch 18/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/20 Checking commit 664f768105fe (Boot Linux Console Test: add a test for s390x + s390-ccw-virtio)
20/20 Checking commit 17035afa8703 (Boot Linux Console Test: add a test for alpha + clipper)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com