Re: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190202005610.24048-1-crosa@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190202005610.24048-1-crosa@redhat.com -> patchew/20190202005610.24048-1-crosa@redhat.com
 * [new tag]         patchew/20190202144531.5772-1-n54@gmx.com -> patchew/20190202144531.5772-1-n54@gmx.com
Switched to a new branch 'test'
13c391b Boot Linux Console Test: add a test for alpha + clipper
273b9ac Boot Linux Console Test: add a test for s390x + s390-ccw-virtio
0a9b73c Boot Linux Console Test: add a test for arm + virt
e070e1d Boot Linux Console Test: add a test for aarch64 + virt
86d4a09 Boot Linux Console Test: add a test for ppc64 + pseries
d2b7457 Boot Linux Console Test: add a test for mips64el + malta
4f2bf45 Boot Linux Console Test: add a test for mips + malta
5d2bc37 scripts/qemu.py: support adding a console with the default serial device
e93021f Boot Linux Console Test: refactor the console watcher into utility method
58cb1eb Boot Linux Console Test: increase timeout
8e8235f Boot Linux Console Test: add common kernel command line options
5034fd3 Boot Linux Console Test: update the x86_64 kernel
14bbc9f Boot Linux Console Test: rename the x86_64 after the arch and machine
3787369 Acceptance tests: look for target architecture in test tags first
69d1e10 Acceptance tests: use "arch:" tag to filter target specific tests
8494959 Acceptance tests: introduce arch parameter and attribute
ae64545 Acceptance tests: fix doc reference to avocado_qemu directory
3ca6eaa Acceptance tests: improve docstring on pick_default_qemu_bin()
8960ff3 Acceptance tests: show avocado test execution by default
e154b53 scripts/qemu.py: log QEMU launch command line

=== OUTPUT BEGIN ===
1/20 Checking commit e154b53986c2 (scripts/qemu.py: log QEMU launch command line)
2/20 Checking commit 8960ff314a40 (Acceptance tests: show avocado test execution by default)
3/20 Checking commit 3ca6eaaa5580 (Acceptance tests: improve docstring on pick_default_qemu_bin())
4/20 Checking commit ae645458d956 (Acceptance tests: fix doc reference to avocado_qemu directory)
5/20 Checking commit 84949598dc7a (Acceptance tests: introduce arch parameter and attribute)
6/20 Checking commit 69d1e10ba586 (Acceptance tests: use "arch:" tag to filter target specific tests)
7/20 Checking commit 37873698dc9e (Acceptance tests: look for target architecture in test tags first)
8/20 Checking commit 14bbc9fdbca8 (Boot Linux Console Test: rename the x86_64 after the arch and machine)
9/20 Checking commit 5034fd3690c5 (Boot Linux Console Test: update the x86_64 kernel)
10/20 Checking commit 8e8235fd2f21 (Boot Linux Console Test: add common kernel command line options)
11/20 Checking commit 58cb1eb0af81 (Boot Linux Console Test: increase timeout)
12/20 Checking commit e93021fae9d0 (Boot Linux Console Test: refactor the console watcher into utility method)
13/20 Checking commit 5d2bc37cd347 (scripts/qemu.py: support adding a console with the default serial device)
14/20 Checking commit 4f2bf45f1281 (Boot Linux Console Test: add a test for mips + malta)
15/20 Checking commit d2b7457492bd (Boot Linux Console Test: add a test for mips64el + malta)
ERROR: line over 90 characters
#61: FILE: tests/acceptance/boot_linux_console.py:116:
+        [1] http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48

ERROR: line over 90 characters
#62: FILE: tests/acceptance/boot_linux_console.py:117:
+        [2] https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official

total: 2 errors, 0 warnings, 49 lines checked

Patch 15/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/20 Checking commit 86d4a092b14e (Boot Linux Console Test: add a test for ppc64 + pseries)
17/20 Checking commit e070e1db9f0f (Boot Linux Console Test: add a test for aarch64 + virt)
WARNING: line over 80 characters
#51: FILE: tests/acceptance/boot_linux_console.py:170:
+        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0'

total: 0 errors, 1 warnings, 31 lines checked

Patch 17/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/20 Checking commit 0a9b73c4cf58 (Boot Linux Console Test: add a test for arm + virt)
WARNING: line over 80 characters
#48: FILE: tests/acceptance/boot_linux_console.py:190:
+        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0'

total: 0 errors, 1 warnings, 30 lines checked

Patch 18/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/20 Checking commit 273b9ac35793 (Boot Linux Console Test: add a test for s390x + s390-ccw-virtio)
20/20 Checking commit 13c391bc2771 (Boot Linux Console Test: add a test for alpha + clipper)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com