From: Stephen Boyd <sboyd@kernel.org>
To: akshu.agrawal@amd.com, andrew.smirnov@gmail.com,
b.zolnierkie@samsung.com, corbet@lwn.net, cw00.choi@samsung.com,
djkurtz@chromium.org, krzk@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@armlinux.org.uk, linux@roeck-us.net,
matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com,
mturquette@baylibre.com, pavel@ucw.cz, pombredanne@nexb.com,
rafael.j.wysocki@intel.com, sjhuang@iluvatar.ai, sre@kernel.org,
vkoul@kernel.org
Subject: Re: [PATCH v7 2/3] clk: clk-max77686: Clean clkdev lookup leak and use devm
Date: Wed, 06 Feb 2019 11:05:08 -0800 [thread overview]
Message-ID: <154947990848.115909.478174902516192562@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <05409aafa108c77b2b878ed9663717c4b4a183ca.1544177090.git.matti.vaittinen@fi.rohmeurope.com>
Quoting Matti Vaittinen (2018-12-07 03:10:15)
> clk-max77686 never clean clkdev lookup at remove. This can cause
> oops if clk-max77686 is removed and inserted again. Fix leak by
> using new devm clkdev lookup registration. Simplify also error
> path by using new devm_of_clk_add_hw_provider.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Applied to clk-next
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: akshu.agrawal@amd.com, andrew.smirnov@gmail.com,
b.zolnierkie@samsung.com, corbet@lwn.net, cw00.choi@samsung.com,
djkurtz@chromium.org, krzk@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@armlinux.org.uk, linux@roeck-us.net,
matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com,
mturquette@baylibre.com, pavel@ucw.cz, pombredanne@nexb.com,
rafael.j.wysocki@intel.com, sjhuang@iluvatar.ai, sre@kernel.org,
vkoul@kernel.org
Subject: Re: [PATCH v7 2/3] clk: clk-max77686: Clean clkdev lookup leak and use devm
Date: Wed, 06 Feb 2019 11:05:08 -0800 [thread overview]
Message-ID: <154947990848.115909.478174902516192562@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <05409aafa108c77b2b878ed9663717c4b4a183ca.1544177090.git.matti.vaittinen@fi.rohmeurope.com>
Quoting Matti Vaittinen (2018-12-07 03:10:15)
> clk-max77686 never clean clkdev lookup at remove. This can cause
> oops if clk-max77686 is removed and inserted again. Fix leak by
> using new devm clkdev lookup registration. Simplify also error
> path by using new devm_of_clk_add_hw_provider.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-06 19:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 11:09 [PATCH v7 0/3] clk: clkdev add managed lookup registrations Matti Vaittinen
2018-12-07 11:09 ` Matti Vaittinen
2018-12-07 11:09 ` [PATCH v7 1/3] clkdev: add managed clkdev lookup registration Matti Vaittinen
2018-12-07 11:09 ` Matti Vaittinen
2019-02-06 19:05 ` Stephen Boyd
2019-02-06 19:05 ` Stephen Boyd
2018-12-07 11:10 ` [PATCH v7 2/3] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2018-12-07 11:10 ` Matti Vaittinen
2019-02-06 19:05 ` Stephen Boyd [this message]
2019-02-06 19:05 ` Stephen Boyd
2018-12-07 11:10 ` [PATCH v7 3/3] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2018-12-07 11:10 ` Matti Vaittinen
2019-02-06 19:05 ` Stephen Boyd
2019-02-06 19:05 ` Stephen Boyd
2019-01-31 13:24 ` [PATCH v7 0/3] clk: clkdev add managed lookup registrations Matti Vaittinen
2019-01-31 13:24 ` Matti Vaittinen
2019-01-31 15:21 ` Russell King - ARM Linux admin
2019-01-31 15:21 ` Russell King - ARM Linux admin
2019-01-31 19:38 ` Stephen Boyd
2019-01-31 19:38 ` Stephen Boyd
2019-02-01 8:40 ` Matti Vaittinen
2019-02-01 8:40 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154947990848.115909.478174902516192562@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=akshu.agrawal@amd.com \
--cc=andrew.smirnov@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=cw00.choi@samsung.com \
--cc=djkurtz@chromium.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=pombredanne@nexb.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sjhuang@iluvatar.ai \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.