All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com,
	corbet@lwn.net, cw00.choi@samsung.com, krzk@kernel.org,
	b.zolnierkie@samsung.com, mturquette@baylibre.com,
	sboyd@kernel.org, linux@armlinux.org.uk, pombredanne@nexb.com,
	sre@kernel.org, vkoul@kernel.org, linux@roeck-us.net,
	pavel@ucw.cz, sjhuang@iluvatar.ai, andrew.smirnov@gmail.com,
	djkurtz@chromium.org, akshu.agrawal@amd.com,
	rafael.j.wysocki@intel.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/3] clk: clk-st: avoid clkdev lookup leak at remove
Date: Fri, 7 Dec 2018 13:10:51 +0200	[thread overview]
Message-ID: <f40c69fc858cc7ec3cc722c6664d933ea6558fb9.1544177090.git.matti.vaittinen@fi.rohmeurope.com> (raw)
In-Reply-To: <cover.1544177090.git.matti.vaittinen@fi.rohmeurope.com>

Use devm based clkdev lookup registration to avoid leaking lookup
structures.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
 drivers/clk/x86/clk-st.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c
index 3a0996f2d556..25d4b97aff9b 100644
--- a/drivers/clk/x86/clk-st.c
+++ b/drivers/clk/x86/clk-st.c
@@ -52,7 +52,8 @@ static int st_clk_probe(struct platform_device *pdev)
 		0, st_data->base + MISCCLKCNTL1, OSCCLKENB,
 		CLK_GATE_SET_TO_DISABLE, NULL);
 
-	clk_hw_register_clkdev(hws[ST_CLK_GATE], "oscout1", NULL);
+	devm_clk_hw_register_clkdev(&pdev->dev, hws[ST_CLK_GATE], "oscout1",
+				    NULL);
 
 	return 0;
 }
-- 
2.14.3

WARNING: multiple messages have this Message-ID (diff)
From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com,
	corbet@lwn.net, cw00.choi@samsung.com, krzk@kernel.org,
	b.zolnierkie@samsung.com, mturquette@baylibre.com,
	sboyd@kernel.org, linux@armlinux.org.uk, pombredanne@nexb.com,
	sre@kernel.org, vkoul@kernel.org, linux@roeck-us.net,
	pavel@ucw.cz, sjhuang@iluvatar.ai, andrew.smirnov@gmail.com,
	djkurtz@chromium.org, akshu.agrawal@amd.com,
	rafael.j.wysocki@intel.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/3] clk: clk-st: avoid clkdev lookup leak at remove
Date: Fri, 7 Dec 2018 13:10:51 +0200	[thread overview]
Message-ID: <f40c69fc858cc7ec3cc722c6664d933ea6558fb9.1544177090.git.matti.vaittinen@fi.rohmeurope.com> (raw)
In-Reply-To: <cover.1544177090.git.matti.vaittinen@fi.rohmeurope.com>

Use devm based clkdev lookup registration to avoid leaking lookup
structures.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
 drivers/clk/x86/clk-st.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c
index 3a0996f2d556..25d4b97aff9b 100644
--- a/drivers/clk/x86/clk-st.c
+++ b/drivers/clk/x86/clk-st.c
@@ -52,7 +52,8 @@ static int st_clk_probe(struct platform_device *pdev)
 		0, st_data->base + MISCCLKCNTL1, OSCCLKENB,
 		CLK_GATE_SET_TO_DISABLE, NULL);
 
-	clk_hw_register_clkdev(hws[ST_CLK_GATE], "oscout1", NULL);
+	devm_clk_hw_register_clkdev(&pdev->dev, hws[ST_CLK_GATE], "oscout1",
+				    NULL);
 
 	return 0;
 }
-- 
2.14.3

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2018-12-07 11:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07 11:09 [PATCH v7 0/3] clk: clkdev add managed lookup registrations Matti Vaittinen
2018-12-07 11:09 ` Matti Vaittinen
2018-12-07 11:09 ` [PATCH v7 1/3] clkdev: add managed clkdev lookup registration Matti Vaittinen
2018-12-07 11:09   ` Matti Vaittinen
2019-02-06 19:05   ` Stephen Boyd
2019-02-06 19:05     ` Stephen Boyd
2018-12-07 11:10 ` [PATCH v7 2/3] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2018-12-07 11:10   ` Matti Vaittinen
2019-02-06 19:05   ` Stephen Boyd
2019-02-06 19:05     ` Stephen Boyd
2018-12-07 11:10 ` Matti Vaittinen [this message]
2018-12-07 11:10   ` [PATCH v7 3/3] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2019-02-06 19:05   ` Stephen Boyd
2019-02-06 19:05     ` Stephen Boyd
2019-01-31 13:24 ` [PATCH v7 0/3] clk: clkdev add managed lookup registrations Matti Vaittinen
2019-01-31 13:24   ` Matti Vaittinen
2019-01-31 15:21   ` Russell King - ARM Linux admin
2019-01-31 15:21     ` Russell King - ARM Linux admin
2019-01-31 19:38     ` Stephen Boyd
2019-01-31 19:38       ` Stephen Boyd
2019-02-01  8:40       ` Matti Vaittinen
2019-02-01  8:40         ` Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f40c69fc858cc7ec3cc722c6664d933ea6558fb9.1544177090.git.matti.vaittinen@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=akshu.agrawal@amd.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=corbet@lwn.net \
    --cc=cw00.choi@samsung.com \
    --cc=djkurtz@chromium.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=mazziesaccount@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=pavel@ucw.cz \
    --cc=pombredanne@nexb.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sboyd@kernel.org \
    --cc=sjhuang@iluvatar.ai \
    --cc=sre@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.