From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> To: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, =linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Subject: Re: [PATCH] ARM: dts: add rk3288-firefly-reload Date: Mon, 18 Jul 2016 13:24:20 +0200 [thread overview] Message-ID: <1549971.ctkvOGm2xW@diego> (raw) In-Reply-To: <1468769937-23387-2-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> Hi Randy, Am Sonntag, 17. Juli 2016, 23:38:57 schrieb Randy Li: > The Firefly RK3288 Reload is a combination Firefly rk3288 core board > with the Reload baseboard. Add a dtsi for the Firefly rk3288 core > which can be included into the dts for the various baseboards > in the future and dts for Reload base board. > > Currently supported are serial console, wired networking, eMMC and > SD storage, SPFIF, IR receiver, LEDs, SDIO wifi and USB. But only > the OTG could work on the host mode now, the other USB host can't > work now, additional patches are required. > > Signed-off-by: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> looks mostly good, two small issues below. While I could replace the io-domain node with the newer variant myself, the licensing issue will require a resend anyway. Please also carry over Rob's Ack in your resend as well. > --- > Documentation/devicetree/bindings/arm/rockchip.txt | 4 + > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 304 > ++++++++++++++++++++ arch/arm/boot/dts/rk3288-firefly-reload.dts | > 320 +++++++++++++++++++++ 4 files changed, 629 insertions(+) > create mode 100644 arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > create mode 100644 arch/arm/boot/dts/rk3288-firefly-reload.dts > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > b/Documentation/devicetree/bindings/arm/rockchip.txt index > 715d960..3380212c 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > @@ -31,6 +31,10 @@ Rockchip platforms device tree bindings > or > - compatible = "firefly,firefly-rk3288-beta", "rockchip,rk3288"; > > +- Firefly Firefly-RK3288 Reload board: > + Required root node properties: > + - compatible = "firefly,firefly-rk3288-reload", "rockchip,rk3288"; > + > - ChipSPARK PopMetal-RK3288 board: > Required root node properties: > - compatible = "chipspark,popmetal-rk3288", "rockchip,rk3288"; > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 414b427..8173e77 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -606,6 +606,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \ > rk3288-evb-rk808.dtb \ > rk3288-firefly-beta.dtb \ > rk3288-firefly.dtb \ > + rk3288-firefly-reload.dtb \ > rk3288-miqi.dtb \ > rk3288-popmetal.dtb \ > rk3288-r89.dtb \ > diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi new file mode 100644 > index 0000000..039ae16 > --- /dev/null > +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > @@ -0,0 +1,304 @@ > +/* > + * Device tree file for Firefly Rockchip RK3288 Core board > + * Copyright (c) 2016 Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> > + * > + * Licensed under GPLv2 or later. > + */ please allow licensing under GPL and MIT licenses ... see license headers of the other Rockchip boards. Same for the dts file below. > +#include <dt-bindings/input/input.h> > +#include "rk3288.dtsi" > + > +/ { > + memory { > + device_type = "memory"; > + reg = <0 0x80000000>; > + }; > + > + dovdd_1v8: dovdd-1v8-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "dovdd_1v8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc28_dvp>; > + }; > + > + ext_gmac: external-gmac-clock { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <125000000>; > + clock-output-names = "ext_gmac"; > + }; > + > + io_domains: io-domains { > + compatible = "rockchip,rk3288-io-voltage-domain"; > + rockchip,grf = <&grf>; > + > + audio-supply = <&vcca_33>; > + bb-supply = <&vcc_io>; > + dvp-supply = <&dovdd_1v8>; > + flash0-supply = <&vcc_flash>; > + flash1-supply = <&vcc_lan>; > + gpio30-supply = <&vcc_io>; > + gpio1830-supply = <&vcc_io>; > + lcdc-supply = <&vcc_io>; > + sdcard-supply = <&vccio_sd>; > + wifi-supply = <&vccio_wl>; > + }; io-domains are now a sub-device of the GRF, see https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.8-armsoc/dts32&id=3445b2fae55f1a232e6e4843f4f74de074d8c07f Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: dts: add rk3288-firefly-reload Date: Mon, 18 Jul 2016 13:24:20 +0200 [thread overview] Message-ID: <1549971.ctkvOGm2xW@diego> (raw) In-Reply-To: <1468769937-23387-2-git-send-email-ayaka@soulik.info> Hi Randy, Am Sonntag, 17. Juli 2016, 23:38:57 schrieb Randy Li: > The Firefly RK3288 Reload is a combination Firefly rk3288 core board > with the Reload baseboard. Add a dtsi for the Firefly rk3288 core > which can be included into the dts for the various baseboards > in the future and dts for Reload base board. > > Currently supported are serial console, wired networking, eMMC and > SD storage, SPFIF, IR receiver, LEDs, SDIO wifi and USB. But only > the OTG could work on the host mode now, the other USB host can't > work now, additional patches are required. > > Signed-off-by: Randy Li <ayaka@soulik.info> looks mostly good, two small issues below. While I could replace the io-domain node with the newer variant myself, the licensing issue will require a resend anyway. Please also carry over Rob's Ack in your resend as well. > --- > Documentation/devicetree/bindings/arm/rockchip.txt | 4 + > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 304 > ++++++++++++++++++++ arch/arm/boot/dts/rk3288-firefly-reload.dts | > 320 +++++++++++++++++++++ 4 files changed, 629 insertions(+) > create mode 100644 arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > create mode 100644 arch/arm/boot/dts/rk3288-firefly-reload.dts > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > b/Documentation/devicetree/bindings/arm/rockchip.txt index > 715d960..3380212c 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > @@ -31,6 +31,10 @@ Rockchip platforms device tree bindings > or > - compatible = "firefly,firefly-rk3288-beta", "rockchip,rk3288"; > > +- Firefly Firefly-RK3288 Reload board: > + Required root node properties: > + - compatible = "firefly,firefly-rk3288-reload", "rockchip,rk3288"; > + > - ChipSPARK PopMetal-RK3288 board: > Required root node properties: > - compatible = "chipspark,popmetal-rk3288", "rockchip,rk3288"; > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 414b427..8173e77 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -606,6 +606,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \ > rk3288-evb-rk808.dtb \ > rk3288-firefly-beta.dtb \ > rk3288-firefly.dtb \ > + rk3288-firefly-reload.dtb \ > rk3288-miqi.dtb \ > rk3288-popmetal.dtb \ > rk3288-r89.dtb \ > diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi new file mode 100644 > index 0000000..039ae16 > --- /dev/null > +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > @@ -0,0 +1,304 @@ > +/* > + * Device tree file for Firefly Rockchip RK3288 Core board > + * Copyright (c) 2016 Randy Li <ayaka@soulik.info> > + * > + * Licensed under GPLv2 or later. > + */ please allow licensing under GPL and MIT licenses ... see license headers of the other Rockchip boards. Same for the dts file below. > +#include <dt-bindings/input/input.h> > +#include "rk3288.dtsi" > + > +/ { > + memory { > + device_type = "memory"; > + reg = <0 0x80000000>; > + }; > + > + dovdd_1v8: dovdd-1v8-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "dovdd_1v8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc28_dvp>; > + }; > + > + ext_gmac: external-gmac-clock { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <125000000>; > + clock-output-names = "ext_gmac"; > + }; > + > + io_domains: io-domains { > + compatible = "rockchip,rk3288-io-voltage-domain"; > + rockchip,grf = <&grf>; > + > + audio-supply = <&vcca_33>; > + bb-supply = <&vcc_io>; > + dvp-supply = <&dovdd_1v8>; > + flash0-supply = <&vcc_flash>; > + flash1-supply = <&vcc_lan>; > + gpio30-supply = <&vcc_io>; > + gpio1830-supply = <&vcc_io>; > + lcdc-supply = <&vcc_io>; > + sdcard-supply = <&vccio_sd>; > + wifi-supply = <&vccio_wl>; > + }; io-domains are now a sub-device of the GRF, see https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.8-armsoc/dts32&id=3445b2fae55f1a232e6e4843f4f74de074d8c07f Heiko
next prev parent reply other threads:[~2016-07-18 11:24 UTC|newest] Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-06 15:25 [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 16:13 ` Heiko Stuebner 2016-07-06 16:13 ` Heiko Stuebner 2016-07-06 16:13 ` Heiko Stuebner 2016-07-06 17:34 ` [PATCH 0/3] " Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:34 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:34 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:34 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:52 ` [PATCH 0/3] Re:[PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 18:06 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 18:06 ` Randy Li 2016-07-06 18:06 ` Randy Li 2016-07-06 18:22 ` [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Randy Li 2016-07-06 18:22 ` Randy Li 2016-07-06 18:22 ` Randy Li 2016-07-06 18:22 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li 2016-07-06 18:22 ` Randy Li 2016-07-06 18:22 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 18:22 ` Randy Li 2016-07-06 18:23 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li 2016-07-06 18:23 ` Randy Li 2016-07-07 21:35 ` [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Heiko Stuebner 2016-07-07 21:35 ` Heiko Stuebner 2016-07-07 21:35 ` Heiko Stuebner 2016-07-09 15:42 ` ayaka 2016-07-09 15:42 ` ayaka 2016-07-09 23:06 ` Heiko Stuebner 2016-07-09 23:06 ` Heiko Stuebner 2016-07-17 15:38 ` [PATCH] " Randy Li 2016-07-17 15:38 ` Randy Li [not found] ` <1468769937-23387-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> 2016-07-17 15:38 ` [PATCH] ARM: dts: add rk3288-firefly-reload Randy Li 2016-07-17 15:38 ` Randy Li [not found] ` <1468769937-23387-2-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> 2016-07-17 21:01 ` Rob Herring 2016-07-17 21:01 ` Rob Herring 2016-07-18 11:24 ` Heiko Stübner [this message] 2016-07-18 11:24 ` Heiko Stübner 2016-07-18 15:32 ` [PATCH v2] " Randy Li 2016-07-18 15:32 ` Randy Li 2016-07-18 15:32 ` Randy Li 2016-07-18 15:32 ` [PATCH] " Randy Li 2016-07-18 15:32 ` Randy Li 2016-07-18 15:32 ` Randy Li 2016-07-18 19:46 ` Heiko Stübner 2016-07-18 19:46 ` Heiko Stübner 2016-08-07 3:40 ` Shawn Lin 2016-08-07 3:40 ` Shawn Lin 2016-08-07 3:40 ` Shawn Lin 2016-08-07 14:44 ` Heiko Stuebner 2016-08-07 14:44 ` Heiko Stuebner 2016-08-07 14:44 ` Heiko Stuebner 2016-08-08 2:29 ` Shawn Lin 2016-08-08 2:29 ` Shawn Lin 2016-08-09 9:28 ` 陈豪 2016-08-09 9:28 ` 陈豪 2016-08-09 9:28 ` 陈豪 2016-08-09 10:02 ` 陈豪 2016-08-09 10:02 ` 陈豪 2016-08-09 10:02 ` 陈豪 2016-08-09 10:06 ` Randy Li 2016-08-09 10:06 ` Randy Li 2016-08-09 10:06 ` Randy Li 2016-08-09 10:58 ` Heiko Stübner 2016-08-09 10:58 ` Heiko Stübner 2016-08-09 10:58 ` Heiko Stübner 2016-08-10 1:12 ` Randy Li 2016-08-10 1:12 ` Randy Li 2016-08-10 1:12 ` Randy Li 2016-08-14 11:27 ` [PATCH 0/2] ARM: dts: rockchip: correct the regulators in firefly reload Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 12:30 ` Heiko Stuebner 2016-08-14 12:30 ` Heiko Stuebner 2016-08-14 12:38 ` ayaka 2016-08-14 12:38 ` ayaka 2016-08-14 12:38 ` ayaka 2016-08-17 14:10 ` Heiko Stübner 2016-08-17 14:10 ` Heiko Stübner 2016-08-17 17:03 ` [PATCH 0/2 v2] ARM: dts: rockchip: correct the regulators in " Randy Li 2016-08-17 17:03 ` Randy Li 2016-08-17 17:03 ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li 2016-08-17 17:03 ` Randy Li 2016-08-18 13:35 ` Heiko Stübner 2016-08-18 13:35 ` Heiko Stübner 2016-08-18 13:35 ` Heiko Stübner 2016-08-18 14:20 ` ayaka 2016-08-18 14:20 ` ayaka 2016-08-17 17:03 ` [PATCH 2/2] ARM: dts: rockchip: add missing regulators for firefly reload board Randy Li 2016-08-17 17:03 ` Randy Li 2016-08-17 17:03 ` Randy Li 2016-08-18 16:47 ` Heiko Stübner 2016-08-18 16:47 ` Heiko Stübner 2016-08-18 16:47 ` Heiko Stübner 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` Randy Li 2016-07-06 15:25 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` ayaka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1549971.ctkvOGm2xW@diego \ --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \ --cc==linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.