From: Heiko Stuebner <heiko@sntech.de> To: ayaka <ayaka@soulik.info> Cc: devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, mark.rutland@arm.com, robh+dt@kernel.org Subject: Re: [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Date: Sun, 10 Jul 2016 01:06:08 +0200 [thread overview] Message-ID: <5614243.tqTyZoc945@phil> (raw) In-Reply-To: <c7f8b96b-ceff-0449-8957-bac2779c9508@soulik.info> Hi Randy, Am Samstag, 9. Juli 2016, 23:42:28 schrieb ayaka: > On 07/08/2016 05:35 AM, Heiko Stuebner wrote: > > Am Donnerstag, 7. Juli 2016, 02:22:57 schrieb Randy Li: > >> The rk3288 firefly reload is a Rockchip RK3288 based board be found by > >> core board and main board. The regulators are connected in a different > >> way to the previous version of firefly boards, it is necessary to > >> move some common code to uncommon place. > >> > >> I only tested the ethernet and confirmed that works. > >> The usb in this board won't caused by the bugs in the driver. > >> > >> This version follow the suggests from Heiko Stuebner, > >> except the duplicated supply name problem, I don't think > >> it could be fixed in that way. > > > > I've now had a chance to look at that reload board on the firefly site. > > Firefly also is the company name, so a board named that way is not > > necessarily a "variant" :-) . > > > > And looking at the "reload" board this definitly seems to be a very > > different product with it being a system-on-module+baseboard design with > > additional peripherals like that sata bridge, camera interfaces and > > probably > sata bridge is just a SATA to usb bridge and the "reload" bring back the > DVP camera interface and > a HDMI rx chip connected to the other MIPI camera interface. there are always more things to control (reset pins, regulators) and the usb subsystem is currently in the process of getting support for such "embedded" uses. > > more. > > > > As you might've seen, most Rockchip boards are based on some reference- > > design, so are similar in a big part of their core layout. > > Yes, from the evb. But the even the main board of evb in rockchip > company have at lease 3 versions > as I known. > Also the evb is found by power board, main board and core board. > > > So, looking at the vastly different product the reload is, I'd really > > like to have a separate dts for the reload, to not run into more > > confusing differences later on. > > The main problem is that power connections are different. That is why I > decide to make a > separate dts. If the kernel introduce the override dts, I could have a > better way to implement > it. Just to make sure we're not talking about different things. This was meant to illustrate that even though core layouts often look similar we should not try to connect different product board files unnecessarily, as the small differences will make everything more complicated. The "reload" definitly is a completely different product that only shares the manufacturer (firefly) and the soc (rk3288) with the other product and as I wrote should get its own independent dts file. If anything you could do a split into a reload-core dtsi for the system-on- module part and a baseboard dts that includes that (something like what is done for rk3288-rock2). > > Also, when adding a new board, please also add an entry to > > Documentation/devicetree/bindingd/arm/rockchip.txt > > I would send a patch set in a few days. > > > Thanks > > Heiko > > Thank you for you review and you patient again no problem, always nice to have more people play with Rockchip stuff on a mainline kernel :-) Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Date: Sun, 10 Jul 2016 01:06:08 +0200 [thread overview] Message-ID: <5614243.tqTyZoc945@phil> (raw) In-Reply-To: <c7f8b96b-ceff-0449-8957-bac2779c9508@soulik.info> Hi Randy, Am Samstag, 9. Juli 2016, 23:42:28 schrieb ayaka: > On 07/08/2016 05:35 AM, Heiko Stuebner wrote: > > Am Donnerstag, 7. Juli 2016, 02:22:57 schrieb Randy Li: > >> The rk3288 firefly reload is a Rockchip RK3288 based board be found by > >> core board and main board. The regulators are connected in a different > >> way to the previous version of firefly boards, it is necessary to > >> move some common code to uncommon place. > >> > >> I only tested the ethernet and confirmed that works. > >> The usb in this board won't caused by the bugs in the driver. > >> > >> This version follow the suggests from Heiko Stuebner, > >> except the duplicated supply name problem, I don't think > >> it could be fixed in that way. > > > > I've now had a chance to look at that reload board on the firefly site. > > Firefly also is the company name, so a board named that way is not > > necessarily a "variant" :-) . > > > > And looking at the "reload" board this definitly seems to be a very > > different product with it being a system-on-module+baseboard design with > > additional peripherals like that sata bridge, camera interfaces and > > probably > sata bridge is just a SATA to usb bridge and the "reload" bring back the > DVP camera interface and > a HDMI rx chip connected to the other MIPI camera interface. there are always more things to control (reset pins, regulators) and the usb subsystem is currently in the process of getting support for such "embedded" uses. > > more. > > > > As you might've seen, most Rockchip boards are based on some reference- > > design, so are similar in a big part of their core layout. > > Yes, from the evb. But the even the main board of evb in rockchip > company have at lease 3 versions > as I known. > Also the evb is found by power board, main board and core board. > > > So, looking at the vastly different product the reload is, I'd really > > like to have a separate dts for the reload, to not run into more > > confusing differences later on. > > The main problem is that power connections are different. That is why I > decide to make a > separate dts. If the kernel introduce the override dts, I could have a > better way to implement > it. Just to make sure we're not talking about different things. This was meant to illustrate that even though core layouts often look similar we should not try to connect different product board files unnecessarily, as the small differences will make everything more complicated. The "reload" definitly is a completely different product that only shares the manufacturer (firefly) and the soc (rk3288) with the other product and as I wrote should get its own independent dts file. If anything you could do a split into a reload-core dtsi for the system-on- module part and a baseboard dts that includes that (something like what is done for rk3288-rock2). > > Also, when adding a new board, please also add an entry to > > Documentation/devicetree/bindingd/arm/rockchip.txt > > I would send a patch set in a few days. > > > Thanks > > Heiko > > Thank you for you review and you patient again no problem, always nice to have more people play with Rockchip stuff on a mainline kernel :-) Heiko
next prev parent reply other threads:[~2016-07-09 23:06 UTC|newest] Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-06 15:25 [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 16:13 ` Heiko Stuebner 2016-07-06 16:13 ` Heiko Stuebner 2016-07-06 16:13 ` Heiko Stuebner 2016-07-06 17:34 ` [PATCH 0/3] " Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:34 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:34 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:34 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li 2016-07-06 17:34 ` Randy Li 2016-07-06 17:52 ` [PATCH 0/3] Re:[PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 17:52 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li 2016-07-06 17:52 ` Randy Li 2016-07-06 18:06 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 18:06 ` Randy Li 2016-07-06 18:06 ` Randy Li 2016-07-06 18:22 ` [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Randy Li 2016-07-06 18:22 ` Randy Li 2016-07-06 18:22 ` Randy Li 2016-07-06 18:22 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li 2016-07-06 18:22 ` Randy Li 2016-07-06 18:22 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li 2016-07-06 18:22 ` Randy Li 2016-07-06 18:23 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li 2016-07-06 18:23 ` Randy Li 2016-07-07 21:35 ` [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Heiko Stuebner 2016-07-07 21:35 ` Heiko Stuebner 2016-07-07 21:35 ` Heiko Stuebner 2016-07-09 15:42 ` ayaka 2016-07-09 15:42 ` ayaka 2016-07-09 23:06 ` Heiko Stuebner [this message] 2016-07-09 23:06 ` Heiko Stuebner 2016-07-17 15:38 ` [PATCH] " Randy Li 2016-07-17 15:38 ` Randy Li [not found] ` <1468769937-23387-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> 2016-07-17 15:38 ` [PATCH] ARM: dts: add rk3288-firefly-reload Randy Li 2016-07-17 15:38 ` Randy Li [not found] ` <1468769937-23387-2-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> 2016-07-17 21:01 ` Rob Herring 2016-07-17 21:01 ` Rob Herring 2016-07-18 11:24 ` Heiko Stübner 2016-07-18 11:24 ` Heiko Stübner 2016-07-18 15:32 ` [PATCH v2] " Randy Li 2016-07-18 15:32 ` Randy Li 2016-07-18 15:32 ` Randy Li 2016-07-18 15:32 ` [PATCH] " Randy Li 2016-07-18 15:32 ` Randy Li 2016-07-18 15:32 ` Randy Li 2016-07-18 19:46 ` Heiko Stübner 2016-07-18 19:46 ` Heiko Stübner 2016-08-07 3:40 ` Shawn Lin 2016-08-07 3:40 ` Shawn Lin 2016-08-07 3:40 ` Shawn Lin 2016-08-07 14:44 ` Heiko Stuebner 2016-08-07 14:44 ` Heiko Stuebner 2016-08-07 14:44 ` Heiko Stuebner 2016-08-08 2:29 ` Shawn Lin 2016-08-08 2:29 ` Shawn Lin 2016-08-09 9:28 ` 陈豪 2016-08-09 9:28 ` 陈豪 2016-08-09 9:28 ` 陈豪 2016-08-09 10:02 ` 陈豪 2016-08-09 10:02 ` 陈豪 2016-08-09 10:02 ` 陈豪 2016-08-09 10:06 ` Randy Li 2016-08-09 10:06 ` Randy Li 2016-08-09 10:06 ` Randy Li 2016-08-09 10:58 ` Heiko Stübner 2016-08-09 10:58 ` Heiko Stübner 2016-08-09 10:58 ` Heiko Stübner 2016-08-10 1:12 ` Randy Li 2016-08-10 1:12 ` Randy Li 2016-08-10 1:12 ` Randy Li 2016-08-14 11:27 ` [PATCH 0/2] ARM: dts: rockchip: correct the regulators in firefly reload Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 12:30 ` Heiko Stuebner 2016-08-14 12:30 ` Heiko Stuebner 2016-08-14 12:38 ` ayaka 2016-08-14 12:38 ` ayaka 2016-08-14 12:38 ` ayaka 2016-08-17 14:10 ` Heiko Stübner 2016-08-17 14:10 ` Heiko Stübner 2016-08-17 17:03 ` [PATCH 0/2 v2] ARM: dts: rockchip: correct the regulators in " Randy Li 2016-08-17 17:03 ` Randy Li 2016-08-17 17:03 ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li 2016-08-17 17:03 ` Randy Li 2016-08-18 13:35 ` Heiko Stübner 2016-08-18 13:35 ` Heiko Stübner 2016-08-18 13:35 ` Heiko Stübner 2016-08-18 14:20 ` ayaka 2016-08-18 14:20 ` ayaka 2016-08-17 17:03 ` [PATCH 2/2] ARM: dts: rockchip: add missing regulators for firefly reload board Randy Li 2016-08-17 17:03 ` Randy Li 2016-08-17 17:03 ` Randy Li 2016-08-18 16:47 ` Heiko Stübner 2016-08-18 16:47 ` Heiko Stübner 2016-08-18 16:47 ` Heiko Stübner 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` Randy Li 2016-08-14 11:27 ` Randy Li 2016-07-06 15:25 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload ayaka 2016-07-06 15:25 ` ayaka 2016-07-06 15:25 ` ayaka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5614243.tqTyZoc945@phil \ --to=heiko@sntech.de \ --cc=ayaka@soulik.info \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.