[PATCH 0/4] Add PACKAGECONFIG

[PATCH 0/4] Add PACKAGECONFIG

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Add PACKAGECONFIG for 4 recipes

Changqing Li (4):
  net-snmp: add PACKAGECONFIG disable-des
  krb5: add PACKAGECONFIG disable-pkinit
  openhpi: add PACKAGECONFIG disable-snmpbc
  freeradius: add PACKAGECONFIGs

 meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb | 3 +++
 meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb             | 1 +
 meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb           | 1 +
 meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb                     | 1 +
 4 files changed, 6 insertions(+)

-- 
2.7.4

[meta-networking][PATCH 1/4] net-snmp: add PACKAGECONFIG disable-des

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
index 1e87fd0..6c16dce 100644
--- a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
+++ b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
@@ -52,6 +52,7 @@ PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,,"
 
 PACKAGECONFIG[perl] = "--enable-embedded-perl --with-perl-modules=yes, --disable-embedded-perl --with-perl-modules=no,\
                        perl, perl perl-lib"
+PACKAGECONFIG[disable-des] = "--disable-des,--enable-des"
 
 EXTRA_OECONF = "--enable-shared \
                 --disable-manuals \
-- 
2.7.4

[meta-oe][PATCH 2/4] krb5: add PACKAGECONFIG disable-pkinit

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb b/meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb
index c770f7b..f0561df 100644
--- a/meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb
+++ b/meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb
@@ -44,6 +44,7 @@ PACKAGECONFIG[openssl] = "--with-crypto-impl=openssl,,openssl"
 PACKAGECONFIG[keyutils] = "--enable-keyutils,--disable-keyutils,keyutils"
 PACKAGECONFIG[ldap] = "--with-ldap,--without-ldap,openldap"
 PACKAGECONFIG[readline] = "--with-readline,--without-readline,readline"
+PACKAGECONFIG[disable-pkinit] = "--disable-pkinit,--enable-pkinit"
 
 EXTRA_OECONF += " --without-tcl --with-system-et --disable-rpath"
 CACHED_CONFIGUREVARS += "krb5_cv_attr_constructor_destructor=yes ac_cv_func_regcomp=yes \
-- 
2.7.4

[meta-networking][PATCH 3/4] openhpi: add PACKAGECONFIG disable-snmpbc

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb b/meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb
index c4b3309..7b4ddec 100644
--- a/meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb
+++ b/meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb
@@ -64,6 +64,7 @@ PACKAGECONFIG ??= "libgcrypt non32bit"
 PACKAGECONFIG[sysfs] = "--enable-sysfs,--disable-sysfs,sysfsutils,"
 PACKAGECONFIG[libgcrypt] = "--enable-encryption,--disable-encryption,libgcrypt,"
 PACKAGECONFIG[non32bit] = "--enable-non32bit-int,--disable-non32bit-int,,"
+PACKAGECONFIG[disable-snmp-bc] = "--disable-snmp_bc,--enable-snmp_bc"
 
 export DISTRO
 
-- 
2.7.4

[meta-networking][PATCH 4/4] freeradius: add PACKAGECONFIGs

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

add 3 PACKAGECONFIG

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
index c17d56d..cee3b47 100644
--- a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
+++ b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
@@ -83,6 +83,9 @@ PACKAGECONFIG[perl] = "--with-perl=${STAGING_BINDIR_NATIVE}/perl-native/perl --w
 PACKAGECONFIG[python] = "--with-rlm_python --with-rlm-python-bin=${STAGING_BINDIR_NATIVE}/python-native/python --with-rlm-python-include-dir=${STAGING_INCDIR}/${PYTHON_DIR},--without-rlm_python,python-native python"
 PACKAGECONFIG[rest] = "--with-rlm_rest,--without-rlm_rest,curl json-c"
 PACKAGECONFIG[ruby] = "--with-rlm_ruby,--without-rlm_ruby,ruby"
+PACKAGECONFIG[no-ssl] = "--without-openssl,--with-openssl"
+PACKAGECONFIG[no-rlm-eap-fast] = "--without-rlm_eap_fast,--with-rlm_eap_fast"
+PACKAGECONFIG[no-rlm-eap-pwd] = "--without-rlm_eap_pwd,--with-rlm_eap_pwd"
 
 inherit useradd autotools-brokensep update-rc.d systemd
 
-- 
2.7.4

Re: [meta-networking][PATCH 4/4] freeradius: add PACKAGECONFIGs

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

On Wed, Feb 27, 2019 at 04:41:50PM +0800, changqing.li@windriver.com wrote:

> From: Changqing Li <changqing.li@windriver.com>
> 
> add 3 PACKAGECONFIG
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
> index c17d56d..cee3b47 100644
> --- a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
> +++ b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
> @@ -83,6 +83,9 @@ PACKAGECONFIG[perl] = "--with-perl=${STAGING_BINDIR_NATIVE}/perl-native/perl --w
>  PACKAGECONFIG[python] = "--with-rlm_python --with-rlm-python-bin=${STAGING_BINDIR_NATIVE}/python-native/python --with-rlm-python-include-dir=${STAGING_INCDIR}/${PYTHON_DIR},--without-rlm_python,python-native python"
>  PACKAGECONFIG[rest] = "--with-rlm_rest,--without-rlm_rest,curl json-c"
>  PACKAGECONFIG[ruby] = "--with-rlm_ruby,--without-rlm_ruby,ruby"
> +PACKAGECONFIG[no-ssl] = "--without-openssl,--with-openssl"

This is commonly done with 'openssl' as the PACKAGECONFIG flag.

> +PACKAGECONFIG[no-rlm-eap-fast] = "--without-rlm_eap_fast,--with-rlm_eap_fast"
> +PACKAGECONFIG[no-rlm-eap-pwd] = "--without-rlm_eap_pwd,--with-rlm_eap_pwd"

We also don't have any other examples of "no-xxx".  What is the behavior
we have here today?  If "enabled" we should put them in the default
PACKAGECONFIG instead, imho.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-networking][PATCH 4/4] freeradius: add PACKAGECONFIGs

[Changqing Li]

On 2/28/19 12:35 AM, Tom Rini wrote:
> On Wed, Feb 27, 2019 at 04:41:50PM +0800, changqing.li@windriver.com wrote:
>
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> add 3 PACKAGECONFIG
>>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>>   meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
>> index c17d56d..cee3b47 100644
>> --- a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
>> +++ b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
>> @@ -83,6 +83,9 @@ PACKAGECONFIG[perl] = "--with-perl=${STAGING_BINDIR_NATIVE}/perl-native/perl --w
>>   PACKAGECONFIG[python] = "--with-rlm_python --with-rlm-python-bin=${STAGING_BINDIR_NATIVE}/python-native/python --with-rlm-python-include-dir=${STAGING_INCDIR}/${PYTHON_DIR},--without-rlm_python,python-native python"
>>   PACKAGECONFIG[rest] = "--with-rlm_rest,--without-rlm_rest,curl json-c"
>>   PACKAGECONFIG[ruby] = "--with-rlm_ruby,--without-rlm_ruby,ruby"
>> +PACKAGECONFIG[no-ssl] = "--without-openssl,--with-openssl"
> This is commonly done with 'openssl' as the PACKAGECONFIG flag.
>
>> +PACKAGECONFIG[no-rlm-eap-fast] = "--without-rlm_eap_fast,--with-rlm_eap_fast"
>> +PACKAGECONFIG[no-rlm-eap-pwd] = "--without-rlm_eap_pwd,--with-rlm_eap_pwd"
> We also don't have any other examples of "no-xxx".  What is the behavior
> we have here today?  If "enabled" we should put them in the default
> PACKAGECONFIG instead, imho.
>
Hi, Khem

My original idea is default option is enable,  add 
PACKAGECONFIG[disable-xxx] is for

someone who want to disable it by append PACKAGECONFIG.  but if we have the

traditional way  like tom and Adrian said,  I am ok with that way.


I noticed that this patch is now on master-next,  so I will send a 
!fixup  of these patches based on master-next

branch in case we need to keep the traditional way.   Sorry for the 
inconvenient.


-- 
BRs

Sandy(Li Changqing)

Re: [meta-networking][PATCH 4/4] freeradius: add PACKAGECONFIGs

[Changqing Li]

On 2/28/19 10:57 AM, Changqing Li wrote:
>
> On 2/28/19 12:35 AM, Tom Rini wrote:
>> On Wed, Feb 27, 2019 at 04:41:50PM +0800, changqing.li@windriver.com 
>> wrote:
>>
>>> From: Changqing Li <changqing.li@windriver.com>
>>>
>>> add 3 PACKAGECONFIG
>>>
>>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>>> ---
>>> meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb 
>>> | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git 
>>> a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb 
>>> b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
>>> index c17d56d..cee3b47 100644
>>> --- 
>>> a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
>>> +++ 
>>> b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
>>> @@ -83,6 +83,9 @@ PACKAGECONFIG[perl] = 
>>> "--with-perl=${STAGING_BINDIR_NATIVE}/perl-native/perl --w
>>>   PACKAGECONFIG[python] = "--with-rlm_python 
>>> --with-rlm-python-bin=${STAGING_BINDIR_NATIVE}/python-native/python 
>>> --with-rlm-python-include-dir=${STAGING_INCDIR}/${PYTHON_DIR},--without-rlm_python,python-native 
>>> python"
>>>   PACKAGECONFIG[rest] = "--with-rlm_rest,--without-rlm_rest,curl 
>>> json-c"
>>>   PACKAGECONFIG[ruby] = "--with-rlm_ruby,--without-rlm_ruby,ruby"
>>> +PACKAGECONFIG[no-ssl] = "--without-openssl,--with-openssl"
>> This is commonly done with 'openssl' as the PACKAGECONFIG flag.
>>
>>> +PACKAGECONFIG[no-rlm-eap-fast] = 
>>> "--without-rlm_eap_fast,--with-rlm_eap_fast"
>>> +PACKAGECONFIG[no-rlm-eap-pwd] = 
>>> "--without-rlm_eap_pwd,--with-rlm_eap_pwd"
>> We also don't have any other examples of "no-xxx".  What is the behavior
>> we have here today?  If "enabled" we should put them in the default
>> PACKAGECONFIG instead, imho.
>>
> Hi, Khem
>
> My original idea is default option is enable,  add 
> PACKAGECONFIG[disable-xxx] is for
>
> someone who want to disable it by append PACKAGECONFIG.  but if we 
> have the
>
> traditional way  like tom and Adrian said,  I am ok with that way.
>
>
> I noticed that this patch is now on master-next,  so I will send a 
> !fixup  of these patches based on master-next
>
> branch in case we need to keep the traditional way.   Sorry for the 
> inconvenient.

I also need to  correct my commit message, so I will send a v2 today.

>
>
-- 
BRs

Sandy(Li Changqing)

Re: [meta-networking][PATCH 4/4] freeradius: add PACKAGECONFIGs

[Khem Raj]

On Wed, Feb 27, 2019 at 6:57 PM Changqing Li <changqing.li@windriver.com> wrote:
>
>
> On 2/28/19 12:35 AM, Tom Rini wrote:
> > On Wed, Feb 27, 2019 at 04:41:50PM +0800, changqing.li@windriver.com wrote:
> >
> >> From: Changqing Li <changqing.li@windriver.com>
> >>
> >> add 3 PACKAGECONFIG
> >>
> >> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> >> ---
> >>   meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
> >> index c17d56d..cee3b47 100644
> >> --- a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
> >> +++ b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
> >> @@ -83,6 +83,9 @@ PACKAGECONFIG[perl] = "--with-perl=${STAGING_BINDIR_NATIVE}/perl-native/perl --w
> >>   PACKAGECONFIG[python] = "--with-rlm_python --with-rlm-python-bin=${STAGING_BINDIR_NATIVE}/python-native/python --with-rlm-python-include-dir=${STAGING_INCDIR}/${PYTHON_DIR},--without-rlm_python,python-native python"
> >>   PACKAGECONFIG[rest] = "--with-rlm_rest,--without-rlm_rest,curl json-c"
> >>   PACKAGECONFIG[ruby] = "--with-rlm_ruby,--without-rlm_ruby,ruby"
> >> +PACKAGECONFIG[no-ssl] = "--without-openssl,--with-openssl"
> > This is commonly done with 'openssl' as the PACKAGECONFIG flag.
> >
> >> +PACKAGECONFIG[no-rlm-eap-fast] = "--without-rlm_eap_fast,--with-rlm_eap_fast"
> >> +PACKAGECONFIG[no-rlm-eap-pwd] = "--without-rlm_eap_pwd,--with-rlm_eap_pwd"
> > We also don't have any other examples of "no-xxx".  What is the behavior
> > we have here today?  If "enabled" we should put them in the default
> > PACKAGECONFIG instead, imho.
> >
> Hi, Khem
>
> My original idea is default option is enable,  add
> PACKAGECONFIG[disable-xxx] is for
>
> someone who want to disable it by append PACKAGECONFIG.  but if we have the
>
> traditional way  like tom and Adrian said,  I am ok with that way.
>
>

yes please address the review comments, they are valid concerns in this case.

> I noticed that this patch is now on master-next,  so I will send a
> !fixup  of these patches based on master-next
>

master-next is just a CI branch, its meant to collect patches so
people can try and report issues
along with what I do, I drop patches from master-next when there are
issues reported by reviewers or
system.

> branch in case we need to keep the traditional way.   Sorry for the
> inconvenient.
>
>
> --
> BRs
>
> Sandy(Li Changqing)
>

[PATCH 0/4 V2] Add PACKAGECONFIGs

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Add PACKAGECONFIGs

Changqing Li (4):
  freeradius: Add PACKAGECONFIG openssl/rlm-eap-fast/rlm-eap-pwd
  openhpi: Add PACKAGECONFIG snmp-bc
  net-snmp: Add PACKAGECONFIG des
  krb5: Add PACKAGECONFIG pkinit

 .../recipes-connectivity/freeradius/freeradius_3.0.17.bb            | 4 ++++
 meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb            | 3 ++-
 meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb          | 6 ++++--
 meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb                    | 3 ++-
 4 files changed, 12 insertions(+), 4 deletions(-)

-- 
2.7.4

[meta-networking][PATCH 1/4 V2] freeradius: Add PACKAGECONFIG openssl/rlm-eap-fast/rlm-eap-pwd

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
index c17d56d..5ab9a3f 100644
--- a/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
+++ b/meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb
@@ -68,6 +68,7 @@ EXTRA_OECONF = " --enable-strict-dependencies \
 
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \
                    pcre libcap \
+                   openssl rlm-eap-fast rlm-eap-pwd \
 "
 
 PACKAGECONFIG[krb5] = "--with-rlm_krb5,--without-rlm_krb5,krb5"
@@ -83,6 +84,9 @@ PACKAGECONFIG[perl] = "--with-perl=${STAGING_BINDIR_NATIVE}/perl-native/perl --w
 PACKAGECONFIG[python] = "--with-rlm_python --with-rlm-python-bin=${STAGING_BINDIR_NATIVE}/python-native/python --with-rlm-python-include-dir=${STAGING_INCDIR}/${PYTHON_DIR},--without-rlm_python,python-native python"
 PACKAGECONFIG[rest] = "--with-rlm_rest,--without-rlm_rest,curl json-c"
 PACKAGECONFIG[ruby] = "--with-rlm_ruby,--without-rlm_ruby,ruby"
+PACKAGECONFIG[openssl] = "--with-openssl, --without-openssl"
+PACKAGECONFIG[rlm-eap-fast] = "--with-rlm_eap_fast, --without-rlm_eap_fast"
+PACKAGECONFIG[rlm-eap-pwd] = "--with-rlm_eap_pwd, --without-rlm_eap_pwd"
 
 inherit useradd autotools-brokensep update-rc.d systemd
 
-- 
2.7.4

Re: [meta-networking][PATCH 1/4 V2] freeradius: Add PACKAGECONFIG openssl/rlm-eap-fast/rlm-eap-pwd

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

On Thu, Feb 28, 2019 at 01:42:12PM +0800, changqing.li@windriver.com wrote:

> From: Changqing Li <changqing.li@windriver.com>
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>

Thanks!

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[meta-networking][PATCH 2/4 V2] openhpi: Add PACKAGECONFIG snmp-bc

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb b/meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb
index c4b3309..ca9130d 100644
--- a/meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb
+++ b/meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb
@@ -60,10 +60,11 @@ FILES_${PN}-libs = "${libdir}/${BPN}/*.so /usr/lib/${BPN}/*.so"
 INSANE_SKIP_${PN}-libs = "dev-so"
 RDEPENDS_${PN} += "${PN}-libs"
 
-PACKAGECONFIG ??= "libgcrypt non32bit"
+PACKAGECONFIG ??= "libgcrypt non32bit snmp-bc"
 PACKAGECONFIG[sysfs] = "--enable-sysfs,--disable-sysfs,sysfsutils,"
 PACKAGECONFIG[libgcrypt] = "--enable-encryption,--disable-encryption,libgcrypt,"
 PACKAGECONFIG[non32bit] = "--enable-non32bit-int,--disable-non32bit-int,,"
+PACKAGECONFIG[snmp-bc] = "--enable-snmp_bc,--disable-snmp_bc"
 
 export DISTRO
 
-- 
2.7.4

[meta-networking][PATCH 3/4 V2] net-snmp: Add PACKAGECONFIG des

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
index e1c780b..f6ab73a 100644
--- a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
+++ b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
@@ -26,6 +26,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/net-snmp/net-snmp-${PV}.zip \
            file://net-snmp-fix-for-disable-des.patch \
            file://reproducibility-have-printcap.patch \
            file://reproducibility-accept-configure-options-from-env.patch \
+           file://0001-net-snmp-fix-compile-error-disable-des.patch \
            "
 SRC_URI[md5sum] = "6aae5948df7efde626613d6a4b3cd9d4"
 SRC_URI[sha256sum] = "c6291385b8ed84f05890fe4197005daf7e7ee7b082c2e390fa114a9477a56042"
@@ -42,15 +43,16 @@ CCACHE = ""
 
 TARGET_CC_ARCH += "${LDFLAGS}"
 
-PACKAGECONFIG ??= ""
+
+PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}, des"
 PACKAGECONFIG[elfutils] = "--with-elf, --without-elf, elfutils"
 PACKAGECONFIG[libnl] = "--with-nl, --without-nl, libnl"
 
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,,"
 
 PACKAGECONFIG[perl] = "--enable-embedded-perl --with-perl-modules=yes, --disable-embedded-perl --with-perl-modules=no,\
                        perl, perl perl-lib"
+PACKAGECONFIG[des] = "--enable-des,--disable-des"
 
 EXTRA_OECONF = "--enable-shared \
                 --disable-manuals \
-- 
2.7.4

[meta-oe][PATCH 4/4 V2] krb5: Add PACKAGECONFIG pkinit

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb b/meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb
index c770f7b..76b5d30 100644
--- a/meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb
+++ b/meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb
@@ -38,12 +38,13 @@ CVE_PRODUCT = "kerberos"
 
 S = "${WORKDIR}/${BP}/src"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "pkinit"
 PACKAGECONFIG[libedit] = "--with-libedit,--without-libedit,libedit"
 PACKAGECONFIG[openssl] = "--with-crypto-impl=openssl,,openssl"
 PACKAGECONFIG[keyutils] = "--enable-keyutils,--disable-keyutils,keyutils"
 PACKAGECONFIG[ldap] = "--with-ldap,--without-ldap,openldap"
 PACKAGECONFIG[readline] = "--with-readline,--without-readline,readline"
+PACKAGECONFIG[pkinit] = "--enable-pkinit, --disable-pkinit"
 
 EXTRA_OECONF += " --without-tcl --with-system-et --disable-rpath"
 CACHED_CONFIGUREVARS += "krb5_cv_attr_constructor_destructor=yes ac_cv_func_regcomp=yes \
-- 
2.7.4

[meta-networking][PATCH 3/4 V2] net-snmp: Add PACKAGECONFIG des

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
index e1c780b..f6ab73a 100644
--- a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
+++ b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
@@ -26,6 +26,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/net-snmp/net-snmp-${PV}.zip \
            file://net-snmp-fix-for-disable-des.patch \
            file://reproducibility-have-printcap.patch \
            file://reproducibility-accept-configure-options-from-env.patch \
+           file://0001-net-snmp-fix-compile-error-disable-des.patch \
            "
 SRC_URI[md5sum] = "6aae5948df7efde626613d6a4b3cd9d4"
 SRC_URI[sha256sum] = "c6291385b8ed84f05890fe4197005daf7e7ee7b082c2e390fa114a9477a56042"
@@ -42,15 +43,16 @@ CCACHE = ""
 
 TARGET_CC_ARCH += "${LDFLAGS}"
 
-PACKAGECONFIG ??= ""
+
+PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}, des"
 PACKAGECONFIG[elfutils] = "--with-elf, --without-elf, elfutils"
 PACKAGECONFIG[libnl] = "--with-nl, --without-nl, libnl"
 
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,,"
 
 PACKAGECONFIG[perl] = "--enable-embedded-perl --with-perl-modules=yes, --disable-embedded-perl --with-perl-modules=no,\
                        perl, perl perl-lib"
+PACKAGECONFIG[des] = "--enable-des,--disable-des"
 
 EXTRA_OECONF = "--enable-shared \
                 --disable-manuals \
-- 
2.7.4

Re: [meta-networking][PATCH 3/4 V2] net-snmp: Add PACKAGECONFIG des

[Khem Raj]

On Thu, Feb 28, 2019 at 12:18 AM <changqing.li@windriver.com> wrote:
>
> From: Changqing Li <changqing.li@windriver.com>
>
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
> index e1c780b..f6ab73a 100644
> --- a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
> +++ b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
> @@ -26,6 +26,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/net-snmp/net-snmp-${PV}.zip \
>             file://net-snmp-fix-for-disable-des.patch \
>             file://reproducibility-have-printcap.patch \
>             file://reproducibility-accept-configure-options-from-env.patch \
> +           file://0001-net-snmp-fix-compile-error-disable-des.patch \
>             "

this patch is missing. Please rebase on master-next and resend

>  SRC_URI[md5sum] = "6aae5948df7efde626613d6a4b3cd9d4"
>  SRC_URI[sha256sum] = "c6291385b8ed84f05890fe4197005daf7e7ee7b082c2e390fa114a9477a56042"
> @@ -42,15 +43,16 @@ CCACHE = ""
>
>  TARGET_CC_ARCH += "${LDFLAGS}"
>
> -PACKAGECONFIG ??= ""
> +
> +PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}, des"
>  PACKAGECONFIG[elfutils] = "--with-elf, --without-elf, elfutils"
>  PACKAGECONFIG[libnl] = "--with-nl, --without-nl, libnl"
>
> -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
>  PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,,"
>
>  PACKAGECONFIG[perl] = "--enable-embedded-perl --with-perl-modules=yes, --disable-embedded-perl --with-perl-modules=no,\
>                         perl, perl perl-lib"
> +PACKAGECONFIG[des] = "--enable-des,--disable-des"
>
>  EXTRA_OECONF = "--enable-shared \
>                  --disable-manuals \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[meta-networking][PATCH V3] net-snmp: Add PACKAGECONFIG des

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
index 1e87fd0..482eaf2 100644
--- a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
+++ b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb
@@ -43,15 +43,15 @@ CCACHE = ""
 
 TARGET_CC_ARCH += "${LDFLAGS}"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)} des"
 PACKAGECONFIG[elfutils] = "--with-elf, --without-elf, elfutils"
 PACKAGECONFIG[libnl] = "--with-nl, --without-nl, libnl"
 
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,,"
 
 PACKAGECONFIG[perl] = "--enable-embedded-perl --with-perl-modules=yes, --disable-embedded-perl --with-perl-modules=no,\
                        perl, perl perl-lib"
+PACKAGECONFIG[des] = "--enable-des,--disable-des"
 
 EXTRA_OECONF = "--enable-shared \
                 --disable-manuals \
-- 
2.7.4

Re: [PATCH 0/4] Add PACKAGECONFIG

[Adrian Bunk]

On Wed, Feb 27, 2019 at 04:41:46PM +0800, changqing.li@windriver.com wrote:
> From: Changqing Li <changqing.li@windriver.com>
> 
> Add PACKAGECONFIG for 4 recipes
> 
> Changqing Li (4):
>   net-snmp: add PACKAGECONFIG disable-des
>   krb5: add PACKAGECONFIG disable-pkinit
>   openhpi: add PACKAGECONFIG disable-snmpbc
>   freeradius: add PACKAGECONFIGs
>...

It would be better having all variables consistently as enable-options,
instead of having some as disable/no negative options.

Keeping options enabled by default can instead be done with the
PACKAGECONFIG default.

In other words, instead of
  PACKAGECONFIG ??= "libgcrypt non32bit"
  ...
  PACKAGECONFIG[disable-snmp-bc] = "--disable-snmp_bc,--enable-snmp_bc"

to do
  PACKAGECONFIG ??= "libgcrypt non32bit snmp-bc"
  ...
  PACKAGECONFIG[snmp-bc] = "--enable-snmp_bc,--disable-snmp_bc"


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH 0/4] Add PACKAGECONFIG

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

On Wed, Feb 27, 2019 at 04:41:46PM +0800, changqing.li@windriver.com wrote:

> From: Changqing Li <changqing.li@windriver.com>
> 
> Add PACKAGECONFIG for 4 recipes
> 
> Changqing Li (4):
>   net-snmp: add PACKAGECONFIG disable-des
>   krb5: add PACKAGECONFIG disable-pkinit
>   openhpi: add PACKAGECONFIG disable-snmpbc
>   freeradius: add PACKAGECONFIGs
> 
>  meta-networking/recipes-connectivity/freeradius/freeradius_3.0.17.bb | 3 +++
>  meta-networking/recipes-daemons/openhpi/openhpi_3.8.0.bb             | 1 +
>  meta-networking/recipes-protocols/net-snmp/net-snmp_5.8.bb           | 1 +
>  meta-oe/recipes-connectivity/krb5/krb5_1.16.2.bb                     | 1 +

I put this in my comment on 4/4, but I don't see any current examples of
disable- or no-.  We should make these be positive options and include
them in the default PACKAGECONFIG if we already have them on.  Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]