All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/4] staging: ralink-gdma: Fix type warning
@ 2019-03-05 12:49 Daniela Mormocea
  2019-03-05 12:50 ` [PATCH v2 1/4] staging: ralink-gdma: Avoid unnecessary line continuations in string Daniela Mormocea
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Daniela Mormocea @ 2019-03-05 12:49 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Daniela Mormocea

Complete unsigned int type as indicated by checkpatch

Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---

Changes in v2:
-make these a patch series

 drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index d78042e..7dada05 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -164,7 +164,7 @@ static inline uint32_t gdma_dma_read(struct gdma_dma_dev *dma_dev,
 }
 
 static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev,
-				  unsigned reg, uint32_t val)
+				  unsigned int reg, uint32_t val)
 {
 	writel(val, dma_dev->base + reg);
 }
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH v2 1/4] staging: ralink-gdma: Avoid unnecessary line continuations in string
  2019-03-05 12:49 [PATCH v2 0/4] staging: ralink-gdma: Fix type warning Daniela Mormocea
@ 2019-03-05 12:50 ` Daniela Mormocea
  2019-03-05 12:53 ` [PATCH v2 2/4] staging: ralink-gdma: Replace from uint32_t to u32 Daniela Mormocea
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Daniela Mormocea @ 2019-03-05 12:50 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Daniela Mormocea

Fix split string in multiple lines

Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---
Changes in v2:
-make these a patch series

 drivers/staging/ralink-gdma/ralink-gdma.c | 39 +++++++++++++++----------------
 1 file changed, 19 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 7dada05..a43d9b8 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -268,14 +268,14 @@ static int gdma_dma_terminate_all(struct dma_chan *c)
 
 static void rt305x_dump_reg(struct gdma_dma_dev *dma_dev, int id)
 {
-	dev_dbg(dma_dev->ddev.dev, "chan %d, src %08x, dst %08x, ctr0 %08x, " \
-			"ctr1 %08x, intr %08x, signal %08x\n", id,
-			gdma_dma_read(dma_dev, GDMA_REG_SRC_ADDR(id)),
-			gdma_dma_read(dma_dev, GDMA_REG_DST_ADDR(id)),
-			gdma_dma_read(dma_dev, GDMA_REG_CTRL0(id)),
-			gdma_dma_read(dma_dev, GDMA_REG_CTRL1(id)),
-			gdma_dma_read(dma_dev, GDMA_RT305X_STATUS_INT),
-			gdma_dma_read(dma_dev, GDMA_RT305X_STATUS_SIGNAL));
+	dev_dbg(dma_dev->ddev.dev, "chan %d, src %08x, dst %08x, ctr0 %08x, ctr1 %08x, intr %08x, signal %08x\n",
+		id,
+		gdma_dma_read(dma_dev, GDMA_REG_SRC_ADDR(id)),
+		gdma_dma_read(dma_dev, GDMA_REG_DST_ADDR(id)),
+		gdma_dma_read(dma_dev, GDMA_REG_CTRL0(id)),
+		gdma_dma_read(dma_dev, GDMA_REG_CTRL1(id)),
+		gdma_dma_read(dma_dev, GDMA_RT305X_STATUS_INT),
+		gdma_dma_read(dma_dev, GDMA_RT305X_STATUS_SIGNAL));
 }
 
 static int rt305x_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
@@ -342,18 +342,17 @@ static int rt305x_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 
 static void rt3883_dump_reg(struct gdma_dma_dev *dma_dev, int id)
 {
-	dev_dbg(dma_dev->ddev.dev, "chan %d, src %08x, dst %08x, ctr0 %08x, " \
-			"ctr1 %08x, unmask %08x, done %08x, " \
-			"req %08x, ack %08x, fin %08x\n", id,
-			gdma_dma_read(dma_dev, GDMA_REG_SRC_ADDR(id)),
-			gdma_dma_read(dma_dev, GDMA_REG_DST_ADDR(id)),
-			gdma_dma_read(dma_dev, GDMA_REG_CTRL0(id)),
-			gdma_dma_read(dma_dev, GDMA_REG_CTRL1(id)),
-			gdma_dma_read(dma_dev, GDMA_REG_UNMASK_INT),
-			gdma_dma_read(dma_dev, GDMA_REG_DONE_INT),
-			gdma_dma_read(dma_dev, GDMA_REG_REQSTS),
-			gdma_dma_read(dma_dev, GDMA_REG_ACKSTS),
-			gdma_dma_read(dma_dev, GDMA_REG_FINSTS));
+	dev_dbg(dma_dev->ddev.dev, "chan %d, src %08x, dst %08x, ctr0 %08x, ctr1 %08x, unmask %08x, done %08x, req %08x, ack %08x, fin %08x\n",
+		id,
+		gdma_dma_read(dma_dev, GDMA_REG_SRC_ADDR(id)),
+		gdma_dma_read(dma_dev, GDMA_REG_DST_ADDR(id)),
+		gdma_dma_read(dma_dev, GDMA_REG_CTRL0(id)),
+		gdma_dma_read(dma_dev, GDMA_REG_CTRL1(id)),
+		gdma_dma_read(dma_dev, GDMA_REG_UNMASK_INT),
+		gdma_dma_read(dma_dev, GDMA_REG_DONE_INT),
+		gdma_dma_read(dma_dev, GDMA_REG_REQSTS),
+		gdma_dma_read(dma_dev, GDMA_REG_ACKSTS),
+		gdma_dma_read(dma_dev, GDMA_REG_FINSTS));
 }
 
 static int rt3883_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH v2 2/4] staging: ralink-gdma: Replace from uint32_t to u32
  2019-03-05 12:49 [PATCH v2 0/4] staging: ralink-gdma: Fix type warning Daniela Mormocea
  2019-03-05 12:50 ` [PATCH v2 1/4] staging: ralink-gdma: Avoid unnecessary line continuations in string Daniela Mormocea
@ 2019-03-05 12:53 ` Daniela Mormocea
  2019-03-05 12:55 ` [PATCH v2 3/4] staging: ralink-gdma: Avoid unnecessary line continuations Daniela Mormocea
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Daniela Mormocea @ 2019-03-05 12:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Daniela Mormocea

Replace all uintr32_t with u32 to avoid getting
checkpatch warning

Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---

Changes in v2:
-make these a patch series

 drivers/staging/ralink-gdma/ralink-gdma.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index a43d9b8..ccf9ccc 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -283,7 +283,7 @@ static int rt305x_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 	struct gdma_dma_dev *dma_dev = gdma_dma_chan_get_dev(chan);
 	dma_addr_t src_addr, dst_addr;
 	struct gdma_dma_sg *sg;
-	uint32_t ctrl0, ctrl1;
+	u32 ctrl0, ctrl1;
 
 	/* verify chan is already stopped */
 	ctrl0 = gdma_dma_read(dma_dev, GDMA_REG_CTRL0(chan->id));
@@ -360,7 +360,7 @@ static int rt3883_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 	struct gdma_dma_dev *dma_dev = gdma_dma_chan_get_dev(chan);
 	dma_addr_t src_addr, dst_addr;
 	struct gdma_dma_sg *sg;
-	uint32_t ctrl0, ctrl1;
+	u32 ctrl0, ctrl1;
 
 	/* verify chan is already stopped */
 	ctrl0 = gdma_dma_read(dma_dev, GDMA_REG_CTRL0(chan->id));
@@ -752,7 +752,7 @@ static void gdma_dma_tasklet(unsigned long arg)
 
 static void rt305x_gdma_init(struct gdma_dma_dev *dma_dev)
 {
-	uint32_t gct;
+	u32 gct;
 
 	/* all chans round robin */
 	gdma_dma_write(dma_dev, GDMA_RT305X_GCT, GDMA_REG_GCT_ARBIT_RR);
@@ -766,7 +766,7 @@ static void rt305x_gdma_init(struct gdma_dma_dev *dma_dev)
 
 static void rt3883_gdma_init(struct gdma_dma_dev *dma_dev)
 {
-	uint32_t gct;
+	u32 gct;
 
 	/* all chans round robin */
 	gdma_dma_write(dma_dev, GDMA_REG_GCT, GDMA_REG_GCT_ARBIT_RR);
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH v2 3/4] staging: ralink-gdma: Avoid unnecessary line continuations
  2019-03-05 12:49 [PATCH v2 0/4] staging: ralink-gdma: Fix type warning Daniela Mormocea
  2019-03-05 12:50 ` [PATCH v2 1/4] staging: ralink-gdma: Avoid unnecessary line continuations in string Daniela Mormocea
  2019-03-05 12:53 ` [PATCH v2 2/4] staging: ralink-gdma: Replace from uint32_t to u32 Daniela Mormocea
@ 2019-03-05 12:55 ` Daniela Mormocea
  2019-03-05 12:57 ` [PATCH v2 4/4] staging: ralink-gdma: Remove whitespace and add blank line Daniela Mormocea
  2019-03-05 15:05 ` [PATCH v3 4/4] Fix unnecessary space after cast Daniela Mormocea
  4 siblings, 0 replies; 8+ messages in thread
From: Daniela Mormocea @ 2019-03-05 12:55 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Daniela Mormocea

Get rid of unnecessary line continuations in
boolean expressions, warning detected by checkpatch

Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---
Changes in v2:
-make these a patch series

 drivers/staging/ralink-gdma/ralink-gdma.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index ccf9ccc..44a65e2 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -298,14 +298,14 @@ static int rt305x_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 	if (chan->desc->direction == DMA_MEM_TO_DEV) {
 		src_addr = sg->src_addr;
 		dst_addr = chan->fifo_addr;
-		ctrl0 = GDMA_REG_CTRL0_DST_ADDR_FIXED | \
-			(8 << GDMA_RT305X_CTRL0_SRC_REQ_SHIFT) | \
+		ctrl0 = GDMA_REG_CTRL0_DST_ADDR_FIXED |
+			(8 << GDMA_RT305X_CTRL0_SRC_REQ_SHIFT) |
 			(chan->slave_id << GDMA_RT305X_CTRL0_DST_REQ_SHIFT);
 	} else if (chan->desc->direction == DMA_DEV_TO_MEM) {
 		src_addr = chan->fifo_addr;
 		dst_addr = sg->dst_addr;
-		ctrl0 = GDMA_REG_CTRL0_SRC_ADDR_FIXED | \
-			(chan->slave_id << GDMA_RT305X_CTRL0_SRC_REQ_SHIFT) | \
+		ctrl0 = GDMA_REG_CTRL0_SRC_ADDR_FIXED |
+			(chan->slave_id << GDMA_RT305X_CTRL0_SRC_REQ_SHIFT) |
 			(8 << GDMA_RT305X_CTRL0_DST_REQ_SHIFT);
 	} else if (chan->desc->direction == DMA_MEM_TO_MEM) {
 		/*
@@ -314,8 +314,8 @@ static int rt305x_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 		 */
 		src_addr = sg->src_addr;
 		dst_addr = sg->dst_addr;
-		ctrl0 = GDMA_REG_CTRL0_SW_MODE | \
-			(8 << GDMA_REG_CTRL1_SRC_REQ_SHIFT) | \
+		ctrl0 = GDMA_REG_CTRL0_SW_MODE |
+			(8 << GDMA_REG_CTRL1_SRC_REQ_SHIFT) |
 			(8 << GDMA_REG_CTRL1_DST_REQ_SHIFT);
 	} else {
 		dev_err(dma_dev->ddev.dev, "direction type %d error\n",
@@ -323,8 +323,8 @@ static int rt305x_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 		return -EINVAL;
 	}
 
-	ctrl0 |= (sg->len << GDMA_REG_CTRL0_TX_SHIFT) | \
-		 (chan->burst_size << GDMA_REG_CTRL0_BURST_SHIFT) | \
+	ctrl0 |= (sg->len << GDMA_REG_CTRL0_TX_SHIFT) |
+		 (chan->burst_size << GDMA_REG_CTRL0_BURST_SHIFT) |
 		 GDMA_REG_CTRL0_DONE_INT | GDMA_REG_CTRL0_ENABLE;
 	ctrl1 = chan->id << GDMA_REG_CTRL1_NEXT_SHIFT;
 
@@ -376,21 +376,21 @@ static int rt3883_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 		src_addr = sg->src_addr;
 		dst_addr = chan->fifo_addr;
 		ctrl0 = GDMA_REG_CTRL0_DST_ADDR_FIXED;
-		ctrl1 = (32 << GDMA_REG_CTRL1_SRC_REQ_SHIFT) | \
+		ctrl1 = (32 << GDMA_REG_CTRL1_SRC_REQ_SHIFT) |
 			(chan->slave_id << GDMA_REG_CTRL1_DST_REQ_SHIFT);
 	} else if (chan->desc->direction == DMA_DEV_TO_MEM) {
 		src_addr = chan->fifo_addr;
 		dst_addr = sg->dst_addr;
 		ctrl0 = GDMA_REG_CTRL0_SRC_ADDR_FIXED;
-		ctrl1 = (chan->slave_id << GDMA_REG_CTRL1_SRC_REQ_SHIFT) | \
-			(32 << GDMA_REG_CTRL1_DST_REQ_SHIFT) | \
+		ctrl1 = (chan->slave_id << GDMA_REG_CTRL1_SRC_REQ_SHIFT) |
+			(32 << GDMA_REG_CTRL1_DST_REQ_SHIFT) |
 			GDMA_REG_CTRL1_COHERENT;
 	} else if (chan->desc->direction == DMA_MEM_TO_MEM) {
 		src_addr = sg->src_addr;
 		dst_addr = sg->dst_addr;
 		ctrl0 = GDMA_REG_CTRL0_SW_MODE;
-		ctrl1 = (32 << GDMA_REG_CTRL1_SRC_REQ_SHIFT) | \
-			(32 << GDMA_REG_CTRL1_DST_REQ_SHIFT) | \
+		ctrl1 = (32 << GDMA_REG_CTRL1_SRC_REQ_SHIFT) |
+			(32 << GDMA_REG_CTRL1_DST_REQ_SHIFT) |
 			GDMA_REG_CTRL1_COHERENT;
 	} else {
 		dev_err(dma_dev->ddev.dev, "direction type %d error\n",
@@ -398,8 +398,8 @@ static int rt3883_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 		return -EINVAL;
 	}
 
-	ctrl0 |= (sg->len << GDMA_REG_CTRL0_TX_SHIFT) | \
-		 (chan->burst_size << GDMA_REG_CTRL0_BURST_SHIFT) | \
+	ctrl0 |= (sg->len << GDMA_REG_CTRL0_TX_SHIFT) |
+		 (chan->burst_size << GDMA_REG_CTRL0_BURST_SHIFT) |
 		 GDMA_REG_CTRL0_DONE_INT | GDMA_REG_CTRL0_ENABLE;
 	ctrl1 |= chan->id << GDMA_REG_CTRL1_NEXT_SHIFT;
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH v2 4/4] staging: ralink-gdma: Remove whitespace and add blank line
  2019-03-05 12:49 [PATCH v2 0/4] staging: ralink-gdma: Fix type warning Daniela Mormocea
                   ` (2 preceding siblings ...)
  2019-03-05 12:55 ` [PATCH v2 3/4] staging: ralink-gdma: Avoid unnecessary line continuations Daniela Mormocea
@ 2019-03-05 12:57 ` Daniela Mormocea
  2019-03-05 14:43   ` [Outreachy kernel] " Greg KH
  2019-03-05 15:05 ` [PATCH v3 4/4] Fix unnecessary space after cast Daniela Mormocea
  4 siblings, 1 reply; 8+ messages in thread
From: Daniela Mormocea @ 2019-03-05 12:57 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Daniela Mormocea

Delete unnecessary whitespace after cast, and
add blank line after declarations to avoid warnings.

Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---
Changes in v2:
-make these a patch series

 drivers/staging/ralink-gdma/ralink-gdma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 44a65e2..012213f 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -127,6 +127,7 @@ struct gdma_dma_dev {
 	struct gdma_data *data;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 	atomic_t cnt;
 
@@ -818,7 +819,7 @@ static int gdma_dma_probe(struct platform_device *pdev)
 	match = of_match_device(gdma_of_match_table, &pdev->dev);
 	if (!match)
 		return -EINVAL;
-	data = (struct gdma_data *) match->data;
+	data = (struct gdma_data *)match->data;
 
 	dma_dev = devm_kzalloc(&pdev->dev,
 			       struct_size(dma_dev, chan, data->chancnt),
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 4/4] staging: ralink-gdma: Remove whitespace and add blank line
  2019-03-05 12:57 ` [PATCH v2 4/4] staging: ralink-gdma: Remove whitespace and add blank line Daniela Mormocea
@ 2019-03-05 14:43   ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2019-03-05 14:43 UTC (permalink / raw)
  To: Daniela Mormocea; +Cc: outreachy-kernel

On Tue, Mar 05, 2019 at 02:57:18PM +0200, Daniela Mormocea wrote:
> Delete unnecessary whitespace after cast, and
> add blank line after declarations to avoid warnings.
> 
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
> Changes in v2:
> -make these a patch series
> 
>  drivers/staging/ralink-gdma/ralink-gdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 44a65e2..012213f 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -127,6 +127,7 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;

Checkpatch is wrong here, there should not be an extra line :(

It's getting confused as the code should not have 'volatile', but that's
a change that is much more complex to make.

>  
> @@ -818,7 +819,7 @@ static int gdma_dma_probe(struct platform_device *pdev)
>  	match = of_match_device(gdma_of_match_table, &pdev->dev);
>  	if (!match)
>  		return -EINVAL;
> -	data = (struct gdma_data *) match->data;
> +	data = (struct gdma_data *)match->data;

this one is fine.

Why did you do two different types of thing in the same patch?  Even if
both of them were ok, I would have asked you to split this into two
different patches.

The other 3 patches were fine, just fix this one up and resend it.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH v3 4/4] Fix unnecessary space after cast
  2019-03-05 12:49 [PATCH v2 0/4] staging: ralink-gdma: Fix type warning Daniela Mormocea
                   ` (3 preceding siblings ...)
  2019-03-05 12:57 ` [PATCH v2 4/4] staging: ralink-gdma: Remove whitespace and add blank line Daniela Mormocea
@ 2019-03-05 15:05 ` Daniela Mormocea
  2019-03-06  9:14   ` [Outreachy kernel] " Greg KH
  4 siblings, 1 reply; 8+ messages in thread
From: Daniela Mormocea @ 2019-03-05 15:05 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Daniela Mormocea

Delete space after cast

Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---
Changes in v3:
-correct mistake from previous patch, regarding 
a blank line

 drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 44a65e2..680ce02 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -818,7 +818,7 @@ static int gdma_dma_probe(struct platform_device *pdev)
 	match = of_match_device(gdma_of_match_table, &pdev->dev);
 	if (!match)
 		return -EINVAL;
-	data = (struct gdma_data *) match->data;
+	data = (struct gdma_data *)match->data;
 
 	dma_dev = devm_kzalloc(&pdev->dev,
 			       struct_size(dma_dev, chan, data->chancnt),
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH v3 4/4] Fix unnecessary space after cast
  2019-03-05 15:05 ` [PATCH v3 4/4] Fix unnecessary space after cast Daniela Mormocea
@ 2019-03-06  9:14   ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2019-03-06  9:14 UTC (permalink / raw)
  To: Daniela Mormocea; +Cc: outreachy-kernel

On Tue, Mar 05, 2019 at 05:05:06PM +0200, Daniela Mormocea wrote:
> Delete space after cast
> 
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
> Changes in v3:
> -correct mistake from previous patch, regarding 
> a blank line

Your subject line forgot to mention the driver being modified here :(



^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-06  9:14 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 12:49 [PATCH v2 0/4] staging: ralink-gdma: Fix type warning Daniela Mormocea
2019-03-05 12:50 ` [PATCH v2 1/4] staging: ralink-gdma: Avoid unnecessary line continuations in string Daniela Mormocea
2019-03-05 12:53 ` [PATCH v2 2/4] staging: ralink-gdma: Replace from uint32_t to u32 Daniela Mormocea
2019-03-05 12:55 ` [PATCH v2 3/4] staging: ralink-gdma: Avoid unnecessary line continuations Daniela Mormocea
2019-03-05 12:57 ` [PATCH v2 4/4] staging: ralink-gdma: Remove whitespace and add blank line Daniela Mormocea
2019-03-05 14:43   ` [Outreachy kernel] " Greg KH
2019-03-05 15:05 ` [PATCH v3 4/4] Fix unnecessary space after cast Daniela Mormocea
2019-03-06  9:14   ` [Outreachy kernel] " Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.