All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eddie Huang <eddie.huang@mediatek.com>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: "Lee Jones" <lee.jones@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Marc Zyngier" <marc.zyngier@arm.com>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Sean Wang" <Sean.Wang@mediatek.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Ran Bi (毕冉)" <Ran.Bi@mediatek.com>
Subject: Re: [PATCH v2 8/9] rtc: mt6397: fix alarm register overwrite
Date: Mon, 11 Mar 2019 14:05:02 +0800	[thread overview]
Message-ID: <1552284302.19917.2.camel@mtksdaap41> (raw)
In-Reply-To: <1552275991-34648-9-git-send-email-hsin-hsiung.wang@mediatek.com>

On Mon, 2019-03-11 at 11:46 +0800, Hsin-Hsiung Wang wrote:
> From: Ran Bi <ran.bi@mediatek.com>
> 
> Alarm registers high byte was reserved for other functions.
> This add mask in alarm registers operation functions.
> This also fix error condition in interrupt handler.
> 
> Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver")
> 
> Signed-off-by: Ran Bi <ran.bi@mediatek.com>
> ---
>  drivers/rtc/rtc-mt6397.c | 47 +++++++++++++++++++++++++++++++++--------------
>  1 file changed, 33 insertions(+), 14 deletions(-)
> 

Thanks your interrupt and race condition fix

Acked-by: Eddie Huang <eddie.huang@mediatek.com>




WARNING: multiple messages have this Message-ID (diff)
From: Eddie Huang <eddie.huang@mediatek.com>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Sean Wang <Sean.Wang@mediatek.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v2 8/9] rtc: mt6397: fix alarm register overwrite
Date: Mon, 11 Mar 2019 14:05:02 +0800	[thread overview]
Message-ID: <1552284302.19917.2.camel@mtksdaap41> (raw)
In-Reply-To: <1552275991-34648-9-git-send-email-hsin-hsiung.wang@mediatek.com>

On Mon, 2019-03-11 at 11:46 +0800, Hsin-Hsiung Wang wrote:
> From: Ran Bi <ran.bi@mediatek.com>
> 
> Alarm registers high byte was reserved for other functions.
> This add mask in alarm registers operation functions.
> This also fix error condition in interrupt handler.
> 
> Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver")
> 
> Signed-off-by: Ran Bi <ran.bi@mediatek.com>
> ---
>  drivers/rtc/rtc-mt6397.c | 47 +++++++++++++++++++++++++++++++++--------------
>  1 file changed, 33 insertions(+), 14 deletions(-)
> 

Thanks your interrupt and race condition fix

Acked-by: Eddie Huang <eddie.huang@mediatek.com>

WARNING: multiple messages have this Message-ID (diff)
From: Eddie Huang <eddie.huang@mediatek.com>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Marc Zyngier" <marc.zyngier@arm.com>,
	"Ran Bi (毕冉)" <Ran.Bi@mediatek.com>,
	"Sean Wang" <Sean.Wang@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 8/9] rtc: mt6397: fix alarm register overwrite
Date: Mon, 11 Mar 2019 14:05:02 +0800	[thread overview]
Message-ID: <1552284302.19917.2.camel@mtksdaap41> (raw)
In-Reply-To: <1552275991-34648-9-git-send-email-hsin-hsiung.wang@mediatek.com>

On Mon, 2019-03-11 at 11:46 +0800, Hsin-Hsiung Wang wrote:
> From: Ran Bi <ran.bi@mediatek.com>
> 
> Alarm registers high byte was reserved for other functions.
> This add mask in alarm registers operation functions.
> This also fix error condition in interrupt handler.
> 
> Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver")
> 
> Signed-off-by: Ran Bi <ran.bi@mediatek.com>
> ---
>  drivers/rtc/rtc-mt6397.c | 47 +++++++++++++++++++++++++++++++++--------------
>  1 file changed, 33 insertions(+), 14 deletions(-)
> 

Thanks your interrupt and race condition fix

Acked-by: Eddie Huang <eddie.huang@mediatek.com>




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-11  6:05 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11  3:46 [PATCH v2 0/9] Add Support for MediaTek PMIC MT6358 Hsin-Hsiung Wang
2019-03-11  3:46 ` Hsin-Hsiung Wang
2019-03-11  3:46 ` Hsin-Hsiung Wang
2019-03-11  3:46 ` [PATCH v2 1/9] mfd: mt6397: clean up code Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11 19:01   ` Sean Wang
2019-03-11 19:01     ` Sean Wang
2019-03-11 19:01     ` Sean Wang
2019-03-12 14:49     ` Matthias Brugger
2019-03-12 14:49       ` Matthias Brugger
2019-04-02  6:48   ` Lee Jones
2019-04-02  6:48     ` Lee Jones
2019-03-11  3:46 ` [PATCH v2 2/9] mfd: mt6397: extract irq related code from core driver Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11 19:10   ` Sean Wang
2019-03-11 19:10     ` Sean Wang
2019-03-11 19:10     ` Sean Wang
2019-03-14 23:25   ` Nicolas Boichat
2019-03-14 23:25     ` Nicolas Boichat
2019-03-14 23:25     ` Nicolas Boichat
2019-03-11  3:46 ` [PATCH v2 3/9] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11 19:19   ` Sean Wang
2019-03-11 19:19     ` Sean Wang
2019-03-11 19:19     ` Sean Wang
2019-03-11 22:06     ` Rob Herring
2019-03-11 22:06       ` Rob Herring
2019-03-12  2:25       ` Sean Wang
2019-03-12  2:25         ` Sean Wang
2019-04-02  7:00   ` Lee Jones
2019-04-02  7:00     ` Lee Jones
2019-03-11  3:46 ` [PATCH v2 4/9] regulator: Add document for MT6358 regulator Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11 19:43   ` Sean Wang
2019-03-11 19:43     ` Sean Wang
2019-03-11  3:46 ` [PATCH v2 5/9] mfd: Add support for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  8:22   ` Nicolas Boichat
2019-03-11  8:22     ` Nicolas Boichat
2019-03-11  8:22     ` Nicolas Boichat
2019-03-11 20:05   ` Sean Wang
2019-03-11 20:05     ` Sean Wang
2019-03-15  7:10   ` Nicolas Boichat
2019-03-15  7:10     ` Nicolas Boichat
2019-03-15  7:10     ` Nicolas Boichat
2019-03-15  7:25     ` Claire Chang
2019-03-15  7:37     ` Claire Chang
2019-03-15  7:37       ` Claire Chang
2019-03-15  7:37       ` Claire Chang
2019-03-11  3:46 ` [PATCH v2 6/9] regulator: mt6358: Add support for MT6358 regulator Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-13 15:01   ` Mark Brown
2019-03-13 15:01     ` Mark Brown
2019-03-11  3:46 ` [PATCH v2 7/9] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11 20:23   ` Sean Wang
2019-03-11 20:23     ` Sean Wang
2019-03-11  3:46 ` [PATCH v2 8/9] rtc: mt6397: fix alarm register overwrite Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  6:05   ` Eddie Huang [this message]
2019-03-11  6:05     ` Eddie Huang
2019-03-11  6:05     ` Eddie Huang
2019-03-11 20:50   ` Sean Wang
2019-03-11 20:50     ` Sean Wang
2019-03-14  2:46     ` mtk14576
2019-03-14  2:46       ` mtk14576
2019-03-14  2:46       ` mtk14576
2019-04-02 14:07   ` Alexandre Belloni
2019-04-02 14:07     ` Alexandre Belloni
2019-03-11  3:46 ` [PATCH v2 9/9] rtc: Add support for the MediaTek MT6358 RTC Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  3:46   ` Hsin-Hsiung Wang
2019-03-11  6:10   ` Eddie Huang
2019-03-11  6:10     ` Eddie Huang
2019-03-11  6:10     ` Eddie Huang
2019-03-21  9:51   ` Yingjoe Chen
2019-03-21  9:51     ` Yingjoe Chen
2019-03-21  9:51     ` Yingjoe Chen
2019-04-02 14:06     ` Alexandre Belloni
2019-04-02 14:06       ` Alexandre Belloni
2019-03-11 21:21 ` [PATCH v2 0/9] Add Support for MediaTek PMIC MT6358 Alexandre Belloni
2019-03-11 21:21   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552284302.19917.2.camel@mtksdaap41 \
    --to=eddie.huang@mediatek.com \
    --cc=Ran.Bi@mediatek.com \
    --cc=Sean.Wang@mediatek.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hsin-hsiung.wang@mediatek.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.