From: Matthias Brugger <matthias.bgg@gmail.com> To: Sean Wang <sean.wang@kernel.org>, Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> Cc: Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>, Eddie Huang <eddie.huang@mediatek.com>, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, Alexandre Belloni <alexandre.belloni@bootlin.com>, srv_heupstream <srv_heupstream@mediatek.com>, Alessandro Zummo <a.zummo@towertech.it>, Marc Zyngier <marc.zyngier@arm.com>, Sean Wang <sean.wang@mediatek.com>, linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, linux-mediatek@lists.infradead.org, Mark Rutland <mark.rutland@arm.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/9] mfd: mt6397: clean up code Date: Tue, 12 Mar 2019 15:49:12 +0100 [thread overview] Message-ID: <47b3a800-ff0b-bafe-6fca-fed1a18d5166@gmail.com> (raw) In-Reply-To: <CAGp9Lzo77XsggYZuhoTO20rh68PQrET1CSVB3GO4fpBzgWKPEw@mail.gmail.com> On 11/03/2019 20:01, Sean Wang wrote: > Hi, > > On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang > <hsin-hsiung.wang@mediatek.com> wrote: >> >> clean up code >> >> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> >> --- >> drivers/mfd/mt6397-core.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c >> index 77b64bd..acb9812 100644 >> --- a/drivers/mfd/mt6397-core.c >> +++ b/drivers/mfd/mt6397-core.c >> @@ -18,17 +18,17 @@ >> #include <linux/of_irq.h> >> #include <linux/regmap.h> >> #include <linux/mfd/core.h> >> -#include <linux/mfd/mt6397/core.h> >> #include <linux/mfd/mt6323/core.h> >> -#include <linux/mfd/mt6397/registers.h> >> +#include <linux/mfd/mt6397/core.h> >> #include <linux/mfd/mt6323/registers.h> >> +#include <linux/mfd/mt6397/registers.h> >> >> #define MT6397_RTC_BASE 0xe000 >> #define MT6397_RTC_SIZE 0x3e >> >> -#define MT6323_CID_CODE 0x23 >> -#define MT6391_CID_CODE 0x91 >> -#define MT6397_CID_CODE 0x97 >> +#define MT6323_CHIP_ID 0x23 >> +#define MT6391_CHIP_ID 0x91 >> +#define MT6397_CHIP_ID 0x97 >> > > It would be not necessary to simply rename the definition or do you > have a strong reason to do that? > I agree, apart, please provide a sound commit message. "clean up code" is difficult to understand. Regards, Matthias >> static const struct resource mt6397_rtc_resources[] = { >> { >> @@ -298,7 +298,7 @@ static int mt6397_probe(struct platform_device *pdev) >> return pmic->irq; >> >> switch (id & 0xff) { >> - case MT6323_CID_CODE: >> + case MT6323_CHIP_ID: >> pmic->int_con[0] = MT6323_INT_CON0; >> pmic->int_con[1] = MT6323_INT_CON1; >> pmic->int_status[0] = MT6323_INT_STATUS0; >> @@ -312,8 +312,8 @@ static int mt6397_probe(struct platform_device *pdev) >> 0, pmic->irq_domain); >> break; >> >> - case MT6397_CID_CODE: >> - case MT6391_CID_CODE: >> + case MT6391_CHIP_ID: >> + case MT6397_CHIP_ID: >> pmic->int_con[0] = MT6397_INT_CON0; >> pmic->int_con[1] = MT6397_INT_CON1; >> pmic->int_status[0] = MT6397_INT_STATUS0; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> Linux-mediatek mailing list >> Linux-mediatek@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com> To: Sean Wang <sean.wang@kernel.org>, Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, Alexandre Belloni <alexandre.belloni@bootlin.com>, srv_heupstream <srv_heupstream@mediatek.com>, Alessandro Zummo <a.zummo@towertech.it>, Marc Zyngier <marc.zyngier@arm.com>, Sean Wang <sean.wang@mediatek.com>, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, linux-mediatek@lists.infradead.org, Mark Rutland <mark.rutland@arm.com>, Eddie Huang <eddie.huang@mediatek.com>, Lee Jones <lee.jones@linaro.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/9] mfd: mt6397: clean up code Date: Tue, 12 Mar 2019 15:49:12 +0100 [thread overview] Message-ID: <47b3a800-ff0b-bafe-6fca-fed1a18d5166@gmail.com> (raw) In-Reply-To: <CAGp9Lzo77XsggYZuhoTO20rh68PQrET1CSVB3GO4fpBzgWKPEw@mail.gmail.com> On 11/03/2019 20:01, Sean Wang wrote: > Hi, > > On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang > <hsin-hsiung.wang@mediatek.com> wrote: >> >> clean up code >> >> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> >> --- >> drivers/mfd/mt6397-core.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c >> index 77b64bd..acb9812 100644 >> --- a/drivers/mfd/mt6397-core.c >> +++ b/drivers/mfd/mt6397-core.c >> @@ -18,17 +18,17 @@ >> #include <linux/of_irq.h> >> #include <linux/regmap.h> >> #include <linux/mfd/core.h> >> -#include <linux/mfd/mt6397/core.h> >> #include <linux/mfd/mt6323/core.h> >> -#include <linux/mfd/mt6397/registers.h> >> +#include <linux/mfd/mt6397/core.h> >> #include <linux/mfd/mt6323/registers.h> >> +#include <linux/mfd/mt6397/registers.h> >> >> #define MT6397_RTC_BASE 0xe000 >> #define MT6397_RTC_SIZE 0x3e >> >> -#define MT6323_CID_CODE 0x23 >> -#define MT6391_CID_CODE 0x91 >> -#define MT6397_CID_CODE 0x97 >> +#define MT6323_CHIP_ID 0x23 >> +#define MT6391_CHIP_ID 0x91 >> +#define MT6397_CHIP_ID 0x97 >> > > It would be not necessary to simply rename the definition or do you > have a strong reason to do that? > I agree, apart, please provide a sound commit message. "clean up code" is difficult to understand. Regards, Matthias >> static const struct resource mt6397_rtc_resources[] = { >> { >> @@ -298,7 +298,7 @@ static int mt6397_probe(struct platform_device *pdev) >> return pmic->irq; >> >> switch (id & 0xff) { >> - case MT6323_CID_CODE: >> + case MT6323_CHIP_ID: >> pmic->int_con[0] = MT6323_INT_CON0; >> pmic->int_con[1] = MT6323_INT_CON1; >> pmic->int_status[0] = MT6323_INT_STATUS0; >> @@ -312,8 +312,8 @@ static int mt6397_probe(struct platform_device *pdev) >> 0, pmic->irq_domain); >> break; >> >> - case MT6397_CID_CODE: >> - case MT6391_CID_CODE: >> + case MT6391_CHIP_ID: >> + case MT6397_CHIP_ID: >> pmic->int_con[0] = MT6397_INT_CON0; >> pmic->int_con[1] = MT6397_INT_CON1; >> pmic->int_status[0] = MT6397_INT_STATUS0; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> Linux-mediatek mailing list >> Linux-mediatek@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-12 14:49 UTC|newest] Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-11 3:46 [PATCH v2 0/9] Add Support for MediaTek PMIC MT6358 Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` [PATCH v2 1/9] mfd: mt6397: clean up code Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 19:01 ` Sean Wang 2019-03-11 19:01 ` Sean Wang 2019-03-11 19:01 ` Sean Wang 2019-03-12 14:49 ` Matthias Brugger [this message] 2019-03-12 14:49 ` Matthias Brugger 2019-04-02 6:48 ` Lee Jones 2019-04-02 6:48 ` Lee Jones 2019-03-11 3:46 ` [PATCH v2 2/9] mfd: mt6397: extract irq related code from core driver Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 19:10 ` Sean Wang 2019-03-11 19:10 ` Sean Wang 2019-03-11 19:10 ` Sean Wang 2019-03-14 23:25 ` Nicolas Boichat 2019-03-14 23:25 ` Nicolas Boichat 2019-03-14 23:25 ` Nicolas Boichat 2019-03-11 3:46 ` [PATCH v2 3/9] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 19:19 ` Sean Wang 2019-03-11 19:19 ` Sean Wang 2019-03-11 19:19 ` Sean Wang 2019-03-11 22:06 ` Rob Herring 2019-03-11 22:06 ` Rob Herring 2019-03-12 2:25 ` Sean Wang 2019-03-12 2:25 ` Sean Wang 2019-04-02 7:00 ` Lee Jones 2019-04-02 7:00 ` Lee Jones 2019-03-11 3:46 ` [PATCH v2 4/9] regulator: Add document for MT6358 regulator Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 19:43 ` Sean Wang 2019-03-11 19:43 ` Sean Wang 2019-03-11 3:46 ` [PATCH v2 5/9] mfd: Add support for the MediaTek MT6358 PMIC Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 8:22 ` Nicolas Boichat 2019-03-11 8:22 ` Nicolas Boichat 2019-03-11 8:22 ` Nicolas Boichat 2019-03-11 20:05 ` Sean Wang 2019-03-11 20:05 ` Sean Wang 2019-03-15 7:10 ` Nicolas Boichat 2019-03-15 7:10 ` Nicolas Boichat 2019-03-15 7:10 ` Nicolas Boichat 2019-03-15 7:25 ` Claire Chang 2019-03-15 7:37 ` Claire Chang 2019-03-15 7:37 ` Claire Chang 2019-03-15 7:37 ` Claire Chang 2019-03-11 3:46 ` [PATCH v2 6/9] regulator: mt6358: Add support for MT6358 regulator Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-13 15:01 ` Mark Brown 2019-03-13 15:01 ` Mark Brown 2019-03-11 3:46 ` [PATCH v2 7/9] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 20:23 ` Sean Wang 2019-03-11 20:23 ` Sean Wang 2019-03-11 3:46 ` [PATCH v2 8/9] rtc: mt6397: fix alarm register overwrite Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 6:05 ` Eddie Huang 2019-03-11 6:05 ` Eddie Huang 2019-03-11 6:05 ` Eddie Huang 2019-03-11 20:50 ` Sean Wang 2019-03-11 20:50 ` Sean Wang 2019-03-14 2:46 ` mtk14576 2019-03-14 2:46 ` mtk14576 2019-03-14 2:46 ` mtk14576 2019-04-02 14:07 ` Alexandre Belloni 2019-04-02 14:07 ` Alexandre Belloni 2019-03-11 3:46 ` [PATCH v2 9/9] rtc: Add support for the MediaTek MT6358 RTC Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 3:46 ` Hsin-Hsiung Wang 2019-03-11 6:10 ` Eddie Huang 2019-03-11 6:10 ` Eddie Huang 2019-03-11 6:10 ` Eddie Huang 2019-03-21 9:51 ` Yingjoe Chen 2019-03-21 9:51 ` Yingjoe Chen 2019-03-21 9:51 ` Yingjoe Chen 2019-04-02 14:06 ` Alexandre Belloni 2019-04-02 14:06 ` Alexandre Belloni 2019-03-11 21:21 ` [PATCH v2 0/9] Add Support for MediaTek PMIC MT6358 Alexandre Belloni 2019-03-11 21:21 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=47b3a800-ff0b-bafe-6fca-fed1a18d5166@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=eddie.huang@mediatek.com \ --cc=hsin-hsiung.wang@mediatek.com \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-rtc@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@kernel.org \ --cc=sean.wang@mediatek.com \ --cc=srv_heupstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.