From: Lucas Stach <l.stach@pengutronix.de> To: "Angus Ainslie (Purism)" <angus@akkea.ca>, andrew.smirnov@gmail.com Cc: "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Fabio Estevam" <festevam@gmail.com>, "NXP Linux Team" <linux-imx@nxp.com>, "Carlo Caione" <ccaione@baylibre.com>, "Abel Vesa" <abel.vesa@nxp.com>, "Baruch Siach" <baruch@tkos.co.il>, "Guido Günther" <agx@sigxcpu.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: fsl: imx8mq: enable the multi sensor TMU Date: Tue, 19 Mar 2019 12:46:00 +0100 [thread overview] Message-ID: <1552995960.4806.5.camel@pengutronix.de> (raw) In-Reply-To: <20190318184643.24025-1-angus@akkea.ca> Hi Angus, Am Montag, den 18.03.2019, 11:46 -0700 schrieb Angus Ainslie (Purism): > Add the imx8mq TMU (Thermal mannagement unit) nodes for CPU, > GPU, and VPU. > > Changes since v1: > > Removed references to multi sensor patch. > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 118 ++++++++++++++++++++++ > 1 file changed, 118 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 9155bd4784eb..885395e74452 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi [...] > + thermal-zones { > + cpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 0>; > + > + trips { > + cpu_alert: cpu-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu_crit { > + temperature = <95000>; All the critical trip points seem to be too high. The consumer parts have a maximum junction temperature of 95°C, so the common DT configuration used by all boards should have a crit trip point at least a few degrees below this value. Boards that only use the industrial parts can always overwrite the trip points if the designer wishes to do so. > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&cpu_alert>; > + cooling-device = > + <&A53_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + > + gpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 1>; > + > + trips { > + cpu-crit { Should be gpu-crit. > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + > + vpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 2>; > + > + trips { > + cpu-crit { Should be vpu-crit. Regards, Lucas
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: "Angus Ainslie (Purism)" <angus@akkea.ca>, andrew.smirnov@gmail.com Cc: "Mark Rutland" <mark.rutland@arm.com>, devicetree@vger.kernel.org, "Baruch Siach" <baruch@tkos.co.il>, "Abel Vesa" <abel.vesa@nxp.com>, "Carlo Caione" <ccaione@baylibre.com>, "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>, "NXP Linux Team" <linux-imx@nxp.com>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Fabio Estevam" <festevam@gmail.com>, "Guido Günther" <agx@sigxcpu.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: fsl: imx8mq: enable the multi sensor TMU Date: Tue, 19 Mar 2019 12:46:00 +0100 [thread overview] Message-ID: <1552995960.4806.5.camel@pengutronix.de> (raw) In-Reply-To: <20190318184643.24025-1-angus@akkea.ca> Hi Angus, Am Montag, den 18.03.2019, 11:46 -0700 schrieb Angus Ainslie (Purism): > Add the imx8mq TMU (Thermal mannagement unit) nodes for CPU, > GPU, and VPU. > > Changes since v1: > > Removed references to multi sensor patch. > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 118 ++++++++++++++++++++++ > 1 file changed, 118 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 9155bd4784eb..885395e74452 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi [...] > + thermal-zones { > + cpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 0>; > + > + trips { > + cpu_alert: cpu-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu_crit { > + temperature = <95000>; All the critical trip points seem to be too high. The consumer parts have a maximum junction temperature of 95°C, so the common DT configuration used by all boards should have a crit trip point at least a few degrees below this value. Boards that only use the industrial parts can always overwrite the trip points if the designer wishes to do so. > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&cpu_alert>; > + cooling-device = > + <&A53_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + > + gpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 1>; > + > + trips { > + cpu-crit { Should be gpu-crit. > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + > + vpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 2>; > + > + trips { > + cpu-crit { Should be vpu-crit. Regards, Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-19 11:46 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-11 21:31 [PATCH] arm64: dts: fsl: imx8mq: enable the thermal management unit (TMU) Angus Ainslie (Purism) 2019-03-12 2:35 ` Andrey Smirnov 2019-03-12 2:35 ` Andrey Smirnov 2019-03-12 12:54 ` Angus Ainslie 2019-03-12 12:54 ` Angus Ainslie 2019-03-12 20:18 ` Angus Ainslie 2019-03-12 20:18 ` Angus Ainslie 2019-03-12 20:32 ` Fabio Estevam 2019-03-13 0:31 ` Andrey Smirnov 2019-03-13 0:31 ` Andrey Smirnov 2019-03-18 15:48 ` [PATCH v2] " Angus Ainslie (Purism) 2019-03-18 15:48 ` Angus Ainslie (Purism) 2019-03-18 16:04 ` [PATCH] arm64: dts: fsl: imx8mq: enable the multi sensor TMU Angus Ainslie (Purism) 2019-03-18 16:04 ` Angus Ainslie (Purism) 2019-03-18 16:52 ` Fabio Estevam 2019-03-18 16:52 ` Fabio Estevam 2019-03-18 18:46 ` [PATCH v2] " Angus Ainslie (Purism) 2019-03-18 18:46 ` Angus Ainslie (Purism) 2019-03-19 11:46 ` Lucas Stach [this message] 2019-03-19 11:46 ` Lucas Stach 2019-03-19 15:10 ` [PATCH v3] " Angus Ainslie (Purism) 2019-03-19 15:10 ` Angus Ainslie (Purism) 2019-03-19 15:10 ` Angus Ainslie (Purism) 2019-03-19 16:18 ` Fabio Estevam 2019-03-19 16:18 ` Fabio Estevam 2019-03-21 12:52 ` [PATCH v4] " Angus Ainslie (Purism) 2019-03-21 12:52 ` Angus Ainslie (Purism) 2019-03-21 14:48 ` Lucas Stach 2019-03-21 14:48 ` Lucas Stach 2019-03-22 2:11 ` Shawn Guo 2019-03-22 2:11 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1552995960.4806.5.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=abel.vesa@nxp.com \ --cc=agx@sigxcpu.org \ --cc=andrew.smirnov@gmail.com \ --cc=angus@akkea.ca \ --cc=baruch@tkos.co.il \ --cc=ccaione@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.