From: Stephen Boyd <sboyd@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>, Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 00/19] clk: imx: Switch the imx6 and imx7 to clk_hw based API
Date: Tue, 23 Apr 2019 14:49:59 -0700 [thread overview]
Message-ID: <155605619927.15276.90300312265075245@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <155493360763.20095.6174028293897341109@swboyd.mtv.corp.google.com>
Quoting Stephen Boyd (2019-04-10 15:00:07)
> Quoting Fabio Estevam (2019-03-22 09:24:54)
> > Hi Abel,
> >
> > On Fri, Mar 22, 2019 at 12:37 PM Abel Vesa <abel.vesa@nxp.com> wrote:
> > >
> > > This work is part of the effort of switching the entire imx clock drivers
> > > towards clk_hw based API. In order to do that, we have to keep the old
> >
> > Maybe I missed some earlier discussions on this topic, but let me ask
> > a fundamental question first: what is the motivation for this API
> > change?
> >
> > I could not find the reasoning inside the series.
>
> The reasoning should be added to the series, but I would like to see clk
> providers only deal with clk_hw structures and not with clk structures.
> This clearly divides the line between clk consumers and clk providers so
> that we know if clk providers are using the clk API themselves. That's
> why I introduced clk_hw_register() in the first place.
>
FYI, I'm dropping this from my review queue under the assumption it will
be sent again. Also, it would be nice to not have the wrappers at all in
the next series so that everything is clk_hw based instead of clk based.
Otherwise, it looks good to me and I'd like to see this work completed.
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>, Fabio Estevam <festevam@gmail.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [RFC 00/19] clk: imx: Switch the imx6 and imx7 to clk_hw based API
Date: Tue, 23 Apr 2019 14:49:59 -0700 [thread overview]
Message-ID: <155605619927.15276.90300312265075245@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <155493360763.20095.6174028293897341109@swboyd.mtv.corp.google.com>
Quoting Stephen Boyd (2019-04-10 15:00:07)
> Quoting Fabio Estevam (2019-03-22 09:24:54)
> > Hi Abel,
> >
> > On Fri, Mar 22, 2019 at 12:37 PM Abel Vesa <abel.vesa@nxp.com> wrote:
> > >
> > > This work is part of the effort of switching the entire imx clock drivers
> > > towards clk_hw based API. In order to do that, we have to keep the old
> >
> > Maybe I missed some earlier discussions on this topic, but let me ask
> > a fundamental question first: what is the motivation for this API
> > change?
> >
> > I could not find the reasoning inside the series.
>
> The reasoning should be added to the series, but I would like to see clk
> providers only deal with clk_hw structures and not with clk structures.
> This clearly divides the line between clk consumers and clk providers so
> that we know if clk providers are using the clk API themselves. That's
> why I introduced clk_hw_register() in the first place.
>
FYI, I'm dropping this from my review queue under the assumption it will
be sent again. Also, it would be nice to not have the wrappers at all in
the next series so that everything is clk_hw based instead of clk based.
Otherwise, it looks good to me and I'd like to see this work completed.
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-23 21:50 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 15:37 [RFC 00/19] clk: imx: Switch the imx6 and imx7 to clk_hw based API Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 01/19] clk: imx: Remove unused imx_get_clk_hw_fixed Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 02/19] clk: imx: Add imx_obtain_fixed_clock clk_hw based variant Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 03/19] clk: imx6sx: Do not reparent to unregistered IMX6SX_CLK_AXI Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 04/19] clk: imx6q: Do not reparent uninitialized IMX6QDL_CLK_PERIPH2 clock Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 05/19] clk: imx: clk-busy: Switch to clk_hw based API Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-23 6:59 ` Daniel Baluta
2019-03-23 6:59 ` Daniel Baluta
2019-03-22 15:37 ` [RFC 06/19] clk: imx: clk-cpu: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 07/19] clk: imx: clk-gate2: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 08/19] clk: imx: clk-pllv3: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 09/19] clk: imx: clk-pfd: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 10/19] clk: imx: clk-gate-exclusive: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 11/19] clk: imx: clk-fixup-div: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 12/19] clk: imx: clk-fixup-mux: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 13/19] clk: imx: Switch wrappers " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 14/19] clk: imx6q: Switch " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 15/19] clk: imx6sl: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 16/19] clk: imx6sx: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 17/19] clk: imx6ul: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 15:37 ` [RFC 18/19] clk: imx7d: " Abel Vesa
2019-03-22 15:37 ` [RFC 19/19] clk: imx6sll: " Abel Vesa
2019-03-22 15:37 ` Abel Vesa
2019-03-22 16:24 ` [RFC 00/19] clk: imx: Switch the imx6 and imx7 " Fabio Estevam
2019-03-22 16:24 ` Fabio Estevam
2019-04-10 22:00 ` Stephen Boyd
2019-04-10 22:00 ` Stephen Boyd
2019-04-23 21:49 ` Stephen Boyd [this message]
2019-04-23 21:49 ` Stephen Boyd
2019-04-24 7:13 ` [EXT] " Abel Vesa
2019-04-24 7:13 ` Abel Vesa
2019-04-25 15:53 ` Stephen Boyd
2019-04-25 15:53 ` Stephen Boyd
2019-04-27 20:02 ` Abel Vesa
2019-04-27 20:02 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155605619927.15276.90300312265075245@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.