From: Stephen Boyd <sboyd@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver
Date: Thu, 25 Apr 2019 14:20:41 -0700 [thread overview]
Message-ID: <155622724107.15276.12946928869888731656@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190425211009.GP14604@piout.net>
Quoting Alexandre Belloni (2019-04-25 14:10:09)
> On 25/04/2019 13:58:10-0700, Stephen Boyd wrote:
> > > IIRC two clocks are used by the clocksource and having it as a platform
> > > device make the clocksource driver fail with -EPROBE_DEFER.
> > >
> >
> > Ok. I'll add a comment in the driver. It needs to be
> > CLK_OF_DECLARE_DRIVER() because it's used somewhere else too? Or it can
> > be CLK_OF_DECLARE() instead?
>
> It is coming from that comment:
> https://lore.kernel.org/lkml/153573753043.93865.2420370848457480370@swboyd.mtv.corp.google.com/
>
> Maybe I misinterpreted it.
>
Hmm I was just confused it seems. If you don't have two devices probing
the same DT node with this compatible string then I think it can just be
CLK_OF_DECLARE(). I was thinking that you were running into some sort of
issue where the other driver using this same compatible couldn't probe.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver
Date: Thu, 25 Apr 2019 14:20:41 -0700 [thread overview]
Message-ID: <155622724107.15276.12946928869888731656@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190425211009.GP14604@piout.net>
Quoting Alexandre Belloni (2019-04-25 14:10:09)
> On 25/04/2019 13:58:10-0700, Stephen Boyd wrote:
> > > IIRC two clocks are used by the clocksource and having it as a platform
> > > device make the clocksource driver fail with -EPROBE_DEFER.
> > >
> >
> > Ok. I'll add a comment in the driver. It needs to be
> > CLK_OF_DECLARE_DRIVER() because it's used somewhere else too? Or it can
> > be CLK_OF_DECLARE() instead?
>
> It is coming from that comment:
> https://lore.kernel.org/lkml/153573753043.93865.2420370848457480370@swboyd.mtv.corp.google.com/
>
> Maybe I misinterpreted it.
>
Hmm I was just confused it seems. If you don't have two devices probing
the same DT node with this compatible string then I think it can just be
CLK_OF_DECLARE(). I was thinking that you were running into some sort of
issue where the other driver using this same compatible couldn't probe.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-25 21:20 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 12:50 [PATCH v3 0/7] clk: at91: add sam9x60 pmc clock support Alexandre Belloni
2019-04-02 12:50 ` Alexandre Belloni
2019-04-02 12:50 ` [PATCH v3 1/7] clk: at91: allow configuring peripheral PCR layout Alexandre Belloni
2019-04-02 12:50 ` Alexandre Belloni
2019-04-25 19:36 ` Stephen Boyd
2019-04-25 19:36 ` Stephen Boyd
2019-04-02 12:50 ` [PATCH v3 2/7] clk: at91: allow configuring generated " Alexandre Belloni
2019-04-02 12:50 ` Alexandre Belloni
2019-04-25 19:37 ` Stephen Boyd
2019-04-25 19:37 ` Stephen Boyd
2019-04-02 12:50 ` [PATCH v3 3/7] clk: at91: usb: Add sam9x60 support Alexandre Belloni
2019-04-02 12:50 ` Alexandre Belloni
2019-04-25 19:37 ` Stephen Boyd
2019-04-25 19:37 ` Stephen Boyd
2019-04-02 12:50 ` [PATCH v3 4/7] clk: at91: master: " Alexandre Belloni
2019-04-02 12:50 ` Alexandre Belloni
2019-04-25 19:37 ` Stephen Boyd
2019-04-25 19:37 ` Stephen Boyd
2019-04-02 12:50 ` [PATCH v3 5/7] clk: at91: add sam9x60 PLL driver Alexandre Belloni
2019-04-02 12:50 ` Alexandre Belloni
2019-04-25 19:37 ` Stephen Boyd
2019-04-25 19:37 ` Stephen Boyd
2019-04-02 12:50 ` [PATCH v3 6/7] dt-bindings: clk: at91: add bindings for SAM9X60 pmc Alexandre Belloni
2019-04-02 12:50 ` Alexandre Belloni
2019-04-25 19:37 ` Stephen Boyd
2019-04-25 19:37 ` Stephen Boyd
2019-04-02 12:50 ` [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver Alexandre Belloni
2019-04-02 12:50 ` Alexandre Belloni
2019-04-25 19:38 ` Stephen Boyd
2019-04-25 19:38 ` Stephen Boyd
2019-04-25 20:31 ` Alexandre Belloni
2019-04-25 20:31 ` Alexandre Belloni
2019-04-25 20:58 ` Stephen Boyd
2019-04-25 20:58 ` Stephen Boyd
2019-04-25 21:10 ` Alexandre Belloni
2019-04-25 21:10 ` Alexandre Belloni
2019-04-25 21:20 ` Stephen Boyd [this message]
2019-04-25 21:20 ` Stephen Boyd
2019-04-26 21:06 ` Alexandre Belloni
2019-04-26 21:06 ` Alexandre Belloni
2019-04-26 22:02 ` Stephen Boyd
2019-04-26 22:02 ` Stephen Boyd
2019-04-25 21:14 ` Stephen Boyd
2019-04-25 21:14 ` Stephen Boyd
2019-04-26 20:52 ` Alexandre Belloni
2019-04-26 20:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155622724107.15276.12946928869888731656@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.