[U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt()

[U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt()

[Patrice Chotard]

This function  takes an argument, blob,
but never uses it, instead uses gd->fdt_blob directly.

Fixes: e81c98649b7a ("dm: core: add clocks node scan")

Reported-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---

 drivers/core/root.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/core/root.c b/drivers/core/root.c
index 8fa0966..aa5ca40 100644
--- a/drivers/core/root.c
+++ b/drivers/core/root.c
@@ -342,7 +342,7 @@ int dm_extended_scan_fdt(const void *blob, bool pre_reloc_only)
 {
 	int ret;
 
-	ret = dm_scan_fdt(gd->fdt_blob, pre_reloc_only);
+	ret = dm_scan_fdt(blob, pre_reloc_only);
 	if (ret) {
 		debug("dm_scan_fdt() failed: %d\n", ret);
 		return ret;
-- 
1.9.1

[U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt()

[Bin Meng]

On Wed, May 15, 2019 at 4:07 PM Patrice Chotard <patrice.chotard@st.com> wrote:
>
> This function  takes an argument, blob,

nits: there are 2 spaces between "function" and "takes"

> but never uses it, instead uses gd->fdt_blob directly.
>
> Fixes: e81c98649b7a ("dm: core: add clocks node scan")
>
> Reported-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>
>  drivers/core/root.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/core/root.c b/drivers/core/root.c
> index 8fa0966..aa5ca40 100644
> --- a/drivers/core/root.c
> +++ b/drivers/core/root.c
> @@ -342,7 +342,7 @@ int dm_extended_scan_fdt(const void *blob, bool pre_reloc_only)
>  {
>         int ret;
>
> -       ret = dm_scan_fdt(gd->fdt_blob, pre_reloc_only);
> +       ret = dm_scan_fdt(blob, pre_reloc_only);
>         if (ret) {
>                 debug("dm_scan_fdt() failed: %d\n", ret);
>                 return ret;

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt()

[Simon Glass]

On Wed, 15 May 2019 at 02:26, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Wed, May 15, 2019 at 4:07 PM Patrice Chotard <patrice.chotard@st.com> wrote:
> >
> > This function  takes an argument, blob,
>
> nits: there are 2 spaces between "function" and "takes"
>
> > but never uses it, instead uses gd->fdt_blob directly.
> >
> > Fixes: e81c98649b7a ("dm: core: add clocks node scan")
> >
> > Reported-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> > ---
> >
> >  drivers/core/root.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >

Applied to u-boot-dm, thanks!