* [U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt()
@ 2019-05-15 8:07 Patrice Chotard
2019-05-15 8:25 ` Bin Meng
0 siblings, 1 reply; 3+ messages in thread
From: Patrice Chotard @ 2019-05-15 8:07 UTC (permalink / raw)
To: u-boot
This function takes an argument, blob,
but never uses it, instead uses gd->fdt_blob directly.
Fixes: e81c98649b7a ("dm: core: add clocks node scan")
Reported-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---
drivers/core/root.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/core/root.c b/drivers/core/root.c
index 8fa0966..aa5ca40 100644
--- a/drivers/core/root.c
+++ b/drivers/core/root.c
@@ -342,7 +342,7 @@ int dm_extended_scan_fdt(const void *blob, bool pre_reloc_only)
{
int ret;
- ret = dm_scan_fdt(gd->fdt_blob, pre_reloc_only);
+ ret = dm_scan_fdt(blob, pre_reloc_only);
if (ret) {
debug("dm_scan_fdt() failed: %d\n", ret);
return ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt()
2019-05-15 8:07 [U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt() Patrice Chotard
@ 2019-05-15 8:25 ` Bin Meng
2019-05-22 13:21 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Bin Meng @ 2019-05-15 8:25 UTC (permalink / raw)
To: u-boot
On Wed, May 15, 2019 at 4:07 PM Patrice Chotard <patrice.chotard@st.com> wrote:
>
> This function takes an argument, blob,
nits: there are 2 spaces between "function" and "takes"
> but never uses it, instead uses gd->fdt_blob directly.
>
> Fixes: e81c98649b7a ("dm: core: add clocks node scan")
>
> Reported-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>
> drivers/core/root.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/core/root.c b/drivers/core/root.c
> index 8fa0966..aa5ca40 100644
> --- a/drivers/core/root.c
> +++ b/drivers/core/root.c
> @@ -342,7 +342,7 @@ int dm_extended_scan_fdt(const void *blob, bool pre_reloc_only)
> {
> int ret;
>
> - ret = dm_scan_fdt(gd->fdt_blob, pre_reloc_only);
> + ret = dm_scan_fdt(blob, pre_reloc_only);
> if (ret) {
> debug("dm_scan_fdt() failed: %d\n", ret);
> return ret;
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt()
2019-05-15 8:25 ` Bin Meng
@ 2019-05-22 13:21 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2019-05-22 13:21 UTC (permalink / raw)
To: u-boot
On Wed, 15 May 2019 at 02:26, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Wed, May 15, 2019 at 4:07 PM Patrice Chotard <patrice.chotard@st.com> wrote:
> >
> > This function takes an argument, blob,
>
> nits: there are 2 spaces between "function" and "takes"
>
> > but never uses it, instead uses gd->fdt_blob directly.
> >
> > Fixes: e81c98649b7a ("dm: core: add clocks node scan")
> >
> > Reported-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> > ---
> >
> > drivers/core/root.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-22 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 8:07 [U-Boot] [PATCH] dm: core: Fix dm_extended_scan_fdt() Patrice Chotard
2019-05-15 8:25 ` Bin Meng
2019-05-22 13:21 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.