[U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured

[U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured

[Horatiu Vultur]

When serdes configuration was written in hardware there was a delay
of 100ms to be sure that configuration was written. But the delay is not
needed because already the function serdes_write it is checking that the
operation finished.

Therefore remove the mdelay. This improves the speed of configuring the
network driver.

Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
 drivers/net/mscc_eswitch/serval_switch.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/mscc_eswitch/serval_switch.c b/drivers/net/mscc_eswitch/serval_switch.c
index 2559f5d..2c30941 100644
--- a/drivers/net/mscc_eswitch/serval_switch.c
+++ b/drivers/net/mscc_eswitch/serval_switch.c
@@ -356,8 +356,6 @@ static void serdes_write(void __iomem *base, u32 addr)
 	do {
 		data = readl(base + HSIO_MCB_SERDES1G_CFG);
 	} while (data & HSIO_MCB_SERDES1G_CFG_WR_ONE_SHOT);
-
-	mdelay(100);
 }
 
 static void serdes1g_setup(void __iomem *base, uint32_t addr,
-- 
2.7.4

[U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured

[Daniel Schwierzeck]

Am 23.05.19 um 21:45 schrieb Horatiu Vultur:
> When serdes configuration was written in hardware there was a delay
> of 100ms to be sure that configuration was written. But the delay is not
> needed because already the function serdes_write it is checking that the
> operation finished.
> 
> Therefore remove the mdelay. This improves the speed of configuring the
> network driver.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  drivers/net/mscc_eswitch/serval_switch.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>

-- 
- Daniel

[U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured

[Horatiu Vultur]

Hi,

I just wanted to give you a gentle ping. Thanks.

The 06/01/2019 20:10, Daniel Schwierzeck wrote:
> External E-Mail
> 
> 
> 
> Am 23.05.19 um 21:45 schrieb Horatiu Vultur:
> > When serdes configuration was written in hardware there was a delay
> > of 100ms to be sure that configuration was written. But the delay is not
> > needed because already the function serdes_write it is checking that the
> > operation finished.
> > 
> > Therefore remove the mdelay. This improves the speed of configuring the
> > network driver.
> > 
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  drivers/net/mscc_eswitch/serval_switch.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> 
> Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> 
> -- 
> - Daniel

-- 
/Horatiu

[U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured

[Joe Hershberger]

On Thu, May 23, 2019 at 2:48 PM Horatiu Vultur
<horatiu.vultur@microchip.com> wrote:
>
> When serdes configuration was written in hardware there was a delay
> of 100ms to be sure that configuration was written. But the delay is not
> needed because already the function serdes_write it is checking that the
> operation finished.
>
> Therefore remove the mdelay. This improves the speed of configuring the
> network driver.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

[U-Boot] net: mscc: serval: Remove delay when serdes is configured

[Joe Hershberger]

Hi Horatiu,

https://patchwork.ozlabs.org/patch/1104383/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe