* [U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured
@ 2019-05-23 19:45 Horatiu Vultur
2019-06-01 18:10 ` Daniel Schwierzeck
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Horatiu Vultur @ 2019-05-23 19:45 UTC (permalink / raw)
To: u-boot
When serdes configuration was written in hardware there was a delay
of 100ms to be sure that configuration was written. But the delay is not
needed because already the function serdes_write it is checking that the
operation finished.
Therefore remove the mdelay. This improves the speed of configuring the
network driver.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/mscc_eswitch/serval_switch.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/mscc_eswitch/serval_switch.c b/drivers/net/mscc_eswitch/serval_switch.c
index 2559f5d..2c30941 100644
--- a/drivers/net/mscc_eswitch/serval_switch.c
+++ b/drivers/net/mscc_eswitch/serval_switch.c
@@ -356,8 +356,6 @@ static void serdes_write(void __iomem *base, u32 addr)
do {
data = readl(base + HSIO_MCB_SERDES1G_CFG);
} while (data & HSIO_MCB_SERDES1G_CFG_WR_ONE_SHOT);
-
- mdelay(100);
}
static void serdes1g_setup(void __iomem *base, uint32_t addr,
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured
2019-05-23 19:45 [U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured Horatiu Vultur
@ 2019-06-01 18:10 ` Daniel Schwierzeck
2019-06-09 13:32 ` Horatiu Vultur
2019-07-08 21:35 ` Joe Hershberger
2019-07-15 22:51 ` [U-Boot] " Joe Hershberger
2 siblings, 1 reply; 5+ messages in thread
From: Daniel Schwierzeck @ 2019-06-01 18:10 UTC (permalink / raw)
To: u-boot
Am 23.05.19 um 21:45 schrieb Horatiu Vultur:
> When serdes configuration was written in hardware there was a delay
> of 100ms to be sure that configuration was written. But the delay is not
> needed because already the function serdes_write it is checking that the
> operation finished.
>
> Therefore remove the mdelay. This improves the speed of configuring the
> network driver.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> drivers/net/mscc_eswitch/serval_switch.c | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
--
- Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured
2019-06-01 18:10 ` Daniel Schwierzeck
@ 2019-06-09 13:32 ` Horatiu Vultur
0 siblings, 0 replies; 5+ messages in thread
From: Horatiu Vultur @ 2019-06-09 13:32 UTC (permalink / raw)
To: u-boot
Hi,
I just wanted to give you a gentle ping. Thanks.
The 06/01/2019 20:10, Daniel Schwierzeck wrote:
> External E-Mail
>
>
>
> Am 23.05.19 um 21:45 schrieb Horatiu Vultur:
> > When serdes configuration was written in hardware there was a delay
> > of 100ms to be sure that configuration was written. But the delay is not
> > needed because already the function serdes_write it is checking that the
> > operation finished.
> >
> > Therefore remove the mdelay. This improves the speed of configuring the
> > network driver.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > drivers/net/mscc_eswitch/serval_switch.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
>
> Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>
> --
> - Daniel
--
/Horatiu
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured
2019-05-23 19:45 [U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured Horatiu Vultur
2019-06-01 18:10 ` Daniel Schwierzeck
@ 2019-07-08 21:35 ` Joe Hershberger
2019-07-15 22:51 ` [U-Boot] " Joe Hershberger
2 siblings, 0 replies; 5+ messages in thread
From: Joe Hershberger @ 2019-07-08 21:35 UTC (permalink / raw)
To: u-boot
On Thu, May 23, 2019 at 2:48 PM Horatiu Vultur
<horatiu.vultur@microchip.com> wrote:
>
> When serdes configuration was written in hardware there was a delay
> of 100ms to be sure that configuration was written. But the delay is not
> needed because already the function serdes_write it is checking that the
> operation finished.
>
> Therefore remove the mdelay. This improves the speed of configuring the
> network driver.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] net: mscc: serval: Remove delay when serdes is configured
2019-05-23 19:45 [U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured Horatiu Vultur
2019-06-01 18:10 ` Daniel Schwierzeck
2019-07-08 21:35 ` Joe Hershberger
@ 2019-07-15 22:51 ` Joe Hershberger
2 siblings, 0 replies; 5+ messages in thread
From: Joe Hershberger @ 2019-07-15 22:51 UTC (permalink / raw)
To: u-boot
Hi Horatiu,
https://patchwork.ozlabs.org/patch/1104383/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks!
-Joe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-15 22:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 19:45 [U-Boot] [PATCH] net: mscc: serval: Remove delay when serdes is configured Horatiu Vultur
2019-06-01 18:10 ` Daniel Schwierzeck
2019-06-09 13:32 ` Horatiu Vultur
2019-07-08 21:35 ` Joe Hershberger
2019-07-15 22:51 ` [U-Boot] " Joe Hershberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.