[PATCH 0/2] Enable HuC by default for Gen11+

[PATCH 0/2] Enable HuC by default for Gen11+

[Michal Wajdeczko]

HuC firmware is required to unlock advanced video codecs in media driver.
Let's enable it by default for Gen11+ platforms, where we know it works.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Michal Wajdeczko (2):
  drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11
  drm/i915/guc: Turn on GuC/HuC auto mode

 drivers/gpu/drm/i915/i915_params.h |  2 +-
 drivers/gpu/drm/i915/intel_uc.c    | 10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 1/2] drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11

[Michal Wajdeczko]

We are about to change default setting of "enable_guc" modparam
from 0(disabled) to -1(auto). As we only want to turn on
GuC/HuC on Gen11+, keep it off for older gens.

Note that it would be still possible to enable GuC/HuC on these
old platforms using explicit "enable_guc=2" modparam.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/i915/intel_uc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index fdf00f1ebb57..72bbcb2597fd 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -58,12 +58,16 @@ static int __get_platform_enable_guc(struct drm_i915_private *i915)
 	struct intel_uc_fw *huc_fw = &i915->huc.fw;
 	int enable_guc = 0;
 
-	/* Default is to use HuC if we know GuC and HuC firmwares */
+	if (!HAS_GUC(i915))
+		return 0;
+
+	/* We don't want to enable GuC/HuC on pre-Gen11 by default */
+	if (INTEL_GEN(i915) < 11)
+		return 0;
+
 	if (intel_uc_fw_is_selected(guc_fw) && intel_uc_fw_is_selected(huc_fw))
 		enable_guc |= ENABLE_GUC_LOAD_HUC;
 
-	/* Any platform specific fine-tuning can be done here */
-
 	return enable_guc;
 }
 
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Michal Wajdeczko]

Using "enable_guc" modparam auto mode (-1) will let driver
decide on which platforms and in which configuration we want
to use GuC/HuC firmwares.

Today driver will enable HuC firmware authentication by GuC
only on Gen11+ platforms as HuC firmware is required to unlock
advanced video codecs in media driver.

Legacy platforms with GuC/HuC are not affected by this change
as for them driver still defaults to disabled(0) in auto mode.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index d29ade3b7de6..5736c55694fe 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -54,7 +54,7 @@ struct drm_printer;
 	param(int, disable_power_well, -1) \
 	param(int, enable_ips, 1) \
 	param(int, invert_brightness, 0) \
-	param(int, enable_guc, 0) \
+	param(int, enable_guc, -1) \
 	param(int, guc_log_level, -1) \
 	param(char *, guc_firmware_path, NULL) \
 	param(char *, huc_firmware_path, NULL) \
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11

[Joonas Lahtinen]

Quoting Michal Wajdeczko (2019-07-12 14:14:44)
> We are about to change default setting of "enable_guc" modparam
> from 0(disabled) to -1(auto). As we only want to turn on
> GuC/HuC on Gen11+, keep it off for older gens.
> 
> Note that it would be still possible to enable GuC/HuC on these
> old platforms using explicit "enable_guc=2" modparam.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Joonas Lahtinen]

Quoting Michal Wajdeczko (2019-07-12 14:14:45)
> Using "enable_guc" modparam auto mode (-1) will let driver
> decide on which platforms and in which configuration we want
> to use GuC/HuC firmwares.
> 
> Today driver will enable HuC firmware authentication by GuC
> only on Gen11+ platforms as HuC firmware is required to unlock
> advanced video codecs in media driver.
> 
> Legacy platforms with GuC/HuC are not affected by this change
> as for them driver still defaults to disabled(0) in auto mode.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11

[Rodrigo Vivi]

On Fri, Jul 12, 2019 at 11:14:44AM +0000, Michal Wajdeczko wrote:
> We are about to change default setting of "enable_guc" modparam
> from 0(disabled) to -1(auto). As we only want to turn on
> GuC/HuC on Gen11+, keep it off for older gens.
> 
> Note that it would be still possible to enable GuC/HuC on these
> old platforms using explicit "enable_guc=2" modparam.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_uc.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index fdf00f1ebb57..72bbcb2597fd 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -58,12 +58,16 @@ static int __get_platform_enable_guc(struct drm_i915_private *i915)
>  	struct intel_uc_fw *huc_fw = &i915->huc.fw;
>  	int enable_guc = 0;
>  
> -	/* Default is to use HuC if we know GuC and HuC firmwares */
> +	if (!HAS_GUC(i915))
> +		return 0;
> +
> +	/* We don't want to enable GuC/HuC on pre-Gen11 by default */
> +	if (INTEL_GEN(i915) < 11)
> +		return 0;
> +
>  	if (intel_uc_fw_is_selected(guc_fw) && intel_uc_fw_is_selected(huc_fw))
>  		enable_guc |= ENABLE_GUC_LOAD_HUC;
>  
> -	/* Any platform specific fine-tuning can be done here */
> -
>  	return enable_guc;
>  }
>  
> -- 
> 2.19.2
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Rodrigo Vivi]

On Fri, Jul 12, 2019 at 11:14:45AM +0000, Michal Wajdeczko wrote:
> Using "enable_guc" modparam auto mode (-1) will let driver
> decide on which platforms and in which configuration we want
> to use GuC/HuC firmwares.
> 
> Today driver will enable HuC firmware authentication by GuC
> only on Gen11+ platforms as HuC firmware is required to unlock
> advanced video codecs in media driver.
> 
> Legacy platforms with GuC/HuC are not affected by this change
> as for them driver still defaults to disabled(0) in auto mode.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index d29ade3b7de6..5736c55694fe 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -54,7 +54,7 @@ struct drm_printer;
>  	param(int, disable_power_well, -1) \
>  	param(int, enable_ips, 1) \
>  	param(int, invert_brightness, 0) \
> -	param(int, enable_guc, 0) \
> +	param(int, enable_guc, -1) \
>  	param(int, guc_log_level, -1) \
>  	param(char *, guc_firmware_path, NULL) \
>  	param(char *, huc_firmware_path, NULL) \
> -- 
> 2.19.2
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for Enable HuC by default for Gen11+

[Patchwork]

== Series Details ==

Series: Enable HuC by default for Gen11+
URL   : https://patchwork.freedesktop.org/series/63635/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6472 -> Patchwork_13642
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/

Known issues
------------

  Here are the changes found in Patchwork_13642 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_busy@basic-flip-c:
    - fi-skl-6770hq:      [PASS][1] -> [SKIP][2] ([fdo#109271] / [fdo#109278]) +2 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html

  * igt@kms_flip@basic-flip-vs-dpms:
    - fi-skl-6770hq:      [PASS][3] -> [SKIP][4] ([fdo#109271]) +23 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html

  
#### Possible fixes ####

  * igt@i915_selftest@live_blt:
    - fi-icl-dsi:         [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/fi-icl-dsi/igt@i915_selftest@live_blt.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/fi-icl-dsi/igt@i915_selftest@live_blt.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          [FAIL][7] ([fdo#103167]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278


Participating hosts (54 -> 47)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6472 -> Patchwork_13642

  CI_DRM_6472: 649e17f8cfe7361cbc104427d155f685cf7151d5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5094: d7f140b5b02d054183a74842b4579cf7f5533927 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13642: 2011d7770a68783a6f438dcfd1ef4db6ecf21df3 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

2011d7770a68 drm/i915/guc: Turn on GuC/HuC auto mode
51e212f28dd1 drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Chris Wilson]

Quoting Rodrigo Vivi (2019-07-12 12:29:31)
> On Fri, Jul 12, 2019 at 11:14:45AM +0000, Michal Wajdeczko wrote:
> > Using "enable_guc" modparam auto mode (-1) will let driver
> > decide on which platforms and in which configuration we want
> > to use GuC/HuC firmwares.
> > 
> > Today driver will enable HuC firmware authentication by GuC
> > only on Gen11+ platforms as HuC firmware is required to unlock
> > advanced video codecs in media driver.
> > 
> > Legacy platforms with GuC/HuC are not affected by this change
> > as for them driver still defaults to disabled(0) in auto mode.
> > 
> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

And pushed. Good luck!
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for Enable HuC by default for Gen11+

[Patchwork]

== Series Details ==

Series: Enable HuC by default for Gen11+
URL   : https://patchwork.freedesktop.org/series/63635/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6472_full -> Patchwork_13642_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_13642_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_tiled_swapping@non-threaded:
    - shard-glk:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108686])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-glk7/igt@gem_tiled_swapping@non-threaded.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-glk4/igt@gem_tiled_swapping@non-threaded.html

  * igt@i915_pm_rpm@modeset-lpsp-stress:
    - shard-iclb:         [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108840])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb5/igt@i915_pm_rpm@modeset-lpsp-stress.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb2/igt@i915_pm_rpm@modeset-lpsp-stress.html

  * igt@i915_suspend@sysfs-reader:
    - shard-skl:          [PASS][5] -> [INCOMPLETE][6] ([fdo#104108]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-skl4/igt@i915_suspend@sysfs-reader.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-skl4/igt@i915_suspend@sysfs-reader.html
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +6 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-apl6/igt@i915_suspend@sysfs-reader.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-apl6/igt@i915_suspend@sysfs-reader.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
    - shard-iclb:         [PASS][9] -> [FAIL][10] ([fdo#103167]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
    - shard-iclb:         [PASS][11] -> [INCOMPLETE][12] ([fdo#107713])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb2/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb7/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [PASS][13] -> [FAIL][14] ([fdo#108145] / [fdo#110403])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][15] -> [FAIL][16] ([fdo#103166])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_basic:
    - shard-iclb:         [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb2/igt@kms_psr@psr2_basic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb3/igt@kms_psr@psr2_basic.html

  * igt@kms_setmode@basic:
    - shard-skl:          [PASS][19] -> [FAIL][20] ([fdo#99912])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-skl5/igt@kms_setmode@basic.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-skl10/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-apl:          [DMESG-WARN][21] ([fdo#108566]) -> [PASS][22] +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-apl4/igt@gem_ctx_isolation@bcs0-s3.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-apl5/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-iclb:         [INCOMPLETE][23] ([fdo#107713] / [fdo#108686]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb4/igt@gem_tiled_swapping@non-threaded.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb2/igt@gem_tiled_swapping@non-threaded.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [FAIL][25] ([fdo#103167]) -> [PASS][26] +1 similar issue
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
    - shard-skl:          [INCOMPLETE][27] ([fdo#104108] / [fdo#106978]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [FAIL][29] ([fdo#108145] / [fdo#110403]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [FAIL][31] ([fdo#108145]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [SKIP][33] ([fdo#109441]) -> [PASS][34] +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][35] ([fdo#99912]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-apl5/igt@kms_setmode@basic.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-apl4/igt@kms_setmode@basic.html

  
#### Warnings ####

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - shard-iclb:         [SKIP][37] ([fdo#109289]) -> [SKIP][38] ([fdo#110933])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb4/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb5/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][39] ([fdo#109349]) -> [DMESG-WARN][40] ([fdo#107724])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
    - shard-iclb:         [INCOMPLETE][41] ([fdo#106978] / [fdo#107713]) -> [FAIL][42] ([fdo#103167])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6472/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html

  
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#110933]: https://bugs.freedesktop.org/show_bug.cgi?id=110933
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6472 -> Patchwork_13642

  CI_DRM_6472: 649e17f8cfe7361cbc104427d155f685cf7151d5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5094: d7f140b5b02d054183a74842b4579cf7f5533927 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13642: 2011d7770a68783a6f438dcfd1ef4db6ecf21df3 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13642/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Ye, Tony]

On 7/10/2019 10:27 PM, Michal Wajdeczko wrote:
> On Tue, 09 Jul 2019 16:17:02 +0200, Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com> wrote:
>
>> Better subject would be: "Enable HuC (through GuC) on supported 
>> platforms"
>
> Such subject sounds better, but on one hand it does not reflect real
> code change (since we are not explicitly enabling HuC, but instead we
> are just letting the driver enable GuC/HuC to whatever mode it decides),
> but on other hand this is what actual outcome of the change is (as i915
> currently enables GuC loading with HuC authentication on every platform
> where corresponding firmwares are defined/available, and nothing more).
>
> Please confirm if you still opt-in to use your subject.
>
>>
>> Quoting Michal Wajdeczko (2019-07-03 14:36:40)
>>> GuC firmware is now mature, so let it run by default.
>>
>> That's bit of a misleading statement (in more than one way).
>
> It's mature enough to perform HuC authentication, and we
> don't expect more from it ;)
>
>>
>> "Enable loading HuC firmware (through GuC) to unlock
>> advanced video codecs on supported platforms.
>>
>> GuC firmware is required to authenticate the HuC firmware,
>> which is a requirement for it to operate."
>
> To some extend this duplicates existing "DOC: HuC Firmware"
> Do we need to repeat that again here?
>
>>
>> Has the most recent firmware been merged to linux-firmware and
>> is it present in our CI systems?
>
> My understanding is: No and Yes.
> Maybe Anusha can provide more details here.
>
>>
>> It would also be good to list what kind of tests have been run
>> to ensure that there are no regressions,
>
> I'm afraid on IGT level we don't have HuC tests.
> But media team was using modparam override to force GuC/HuC for
> a while, Tony do you have such test list/results handy?

HuC functionality has been tested with AVC VDENC/HEVC VDENC/VP9VDENC 
encoding test cases in regular CI.

Thanks, -Tony

>
>> and which platforms
>> this change affects.
>
> This change affects all platforms where we have GuC/HuC firmwares
> defined, so: SKL, BXT, KBL, CFL, ICL.
>
> Note that we'll still have possibility to tweak that inside
> driver, as auto mode is just moving responsibility what can
> be enabled from the user to the i915.
>
>>
>> Regards, Joonas
>>
>>> Note that today GuC is only used for HuC authentication.
>>>
>>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_params.h 
>>> b/drivers/gpu/drm/i915/i915_params.h
>>> index d29ade3b7de6..5736c55694fe 100644
>>> --- a/drivers/gpu/drm/i915/i915_params.h
>>> +++ b/drivers/gpu/drm/i915/i915_params.h
>>> @@ -54,7 +54,7 @@ struct drm_printer;
>>>         param(int, disable_power_well, -1) \
>>>         param(int, enable_ips, 1) \
>>>         param(int, invert_brightness, 0) \
>>> -       param(int, enable_guc, 0) \
>>> +       param(int, enable_guc, -1) \
>>>         param(int, guc_log_level, -1) \
>>>         param(char *, guc_firmware_path, NULL) \
>>>         param(char *, huc_firmware_path, NULL) \
>>> -- 
>>> 2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Srivatsa, Anusha]

>-----Original Message-----
>From: Wajdeczko, Michal
>Sent: Wednesday, July 10, 2019 7:27 AM
>To: intel-gfx@lists.freedesktop.org; Joonas Lahtinen
><joonas.lahtinen@linux.intel.com>; Srivatsa, Anusha
><anusha.srivatsa@intel.com>; Ye, Tony <tony.ye@intel.com>
>Cc: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>; Chris Wilson
><chris@chris-wilson.co.uk>
>Subject: Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode
>
>On Tue, 09 Jul 2019 16:17:02 +0200, Joonas Lahtinen
><joonas.lahtinen@linux.intel.com> wrote:
>
>> Better subject would be: "Enable HuC (through GuC) on supported
>> platforms"
>
>Such subject sounds better, but on one hand it does not reflect real code change
>(since we are not explicitly enabling HuC, but instead we are just letting the driver
>enable GuC/HuC to whatever mode it decides), but on other hand this is what
>actual outcome of the change is (as i915 currently enables GuC loading with HuC
>authentication on every platform where corresponding firmwares are
>defined/available, and nothing more).
>
>Please confirm if you still opt-in to use your subject.
>
>>
>> Quoting Michal Wajdeczko (2019-07-03 14:36:40)
>>> GuC firmware is now mature, so let it run by default.
>>
>> That's bit of a misleading statement (in more than one way).
>
>It's mature enough to perform HuC authentication, and we don't expect more
>from it ;)
>
>>
>> "Enable loading HuC firmware (through GuC) to unlock advanced video
>> codecs on supported platforms.
>>
>> GuC firmware is required to authenticate the HuC firmware, which is a
>> requirement for it to operate."
>
>To some extend this duplicates existing "DOC: HuC Firmware"
>Do we need to repeat that again here?
>
>>
>> Has the most recent firmware been merged to linux-firmware and is it
>> present in our CI systems?
>
>My understanding is: No and Yes.
>Maybe Anusha can provide more details here.

Waiting on the firmware to get merged to linux-firmware. Sent the PR.
The latest firmware is however available on our CI.

Anusha 
>>
>> It would also be good to list what kind of tests have been run to
>> ensure that there are no regressions,
>
>I'm afraid on IGT level we don't have HuC tests.
>But media team was using modparam override to force GuC/HuC for a while,
>Tony do you have such test list/results handy?
>
>> and which platforms
>> this change affects.
>
>This change affects all platforms where we have GuC/HuC firmwares defined, so:
>SKL, BXT, KBL, CFL, ICL.
>
>Note that we'll still have possibility to tweak that inside driver, as auto mode is
>just moving responsibility what can be enabled from the user to the i915.
>
>>
>> Regards, Joonas
>>
>>> Note that today GuC is only used for HuC authentication.
>>>
>>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_params.h
>>> b/drivers/gpu/drm/i915/i915_params.h
>>> index d29ade3b7de6..5736c55694fe 100644
>>> --- a/drivers/gpu/drm/i915/i915_params.h
>>> +++ b/drivers/gpu/drm/i915/i915_params.h
>>> @@ -54,7 +54,7 @@ struct drm_printer;
>>>         param(int, disable_power_well, -1) \
>>>         param(int, enable_ips, 1) \
>>>         param(int, invert_brightness, 0) \
>>> -       param(int, enable_guc, 0) \
>>> +       param(int, enable_guc, -1) \
>>>         param(int, guc_log_level, -1) \
>>>         param(char *, guc_firmware_path, NULL) \
>>>         param(char *, huc_firmware_path, NULL) \
>>> --
>>> 2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Michal Wajdeczko]

On Tue, 09 Jul 2019 16:17:02 +0200, Joonas Lahtinen
<joonas.lahtinen@linux.intel.com> wrote:

> Better subject would be: "Enable HuC (through GuC) on supported  
> platforms"

Such subject sounds better, but on one hand it does not reflect real
code change (since we are not explicitly enabling HuC, but instead we
are just letting the driver enable GuC/HuC to whatever mode it decides),
but on other hand this is what actual outcome of the change is (as i915
currently enables GuC loading with HuC authentication on every platform
where corresponding firmwares are defined/available, and nothing more).

Please confirm if you still opt-in to use your subject.

>
> Quoting Michal Wajdeczko (2019-07-03 14:36:40)
>> GuC firmware is now mature, so let it run by default.
>
> That's bit of a misleading statement (in more than one way).

It's mature enough to perform HuC authentication, and we
don't expect more from it ;)

>
> "Enable loading HuC firmware (through GuC) to unlock
> advanced video codecs on supported platforms.
>
> GuC firmware is required to authenticate the HuC firmware,
> which is a requirement for it to operate."

To some extend this duplicates existing "DOC: HuC Firmware"
Do we need to repeat that again here?

>
> Has the most recent firmware been merged to linux-firmware and
> is it present in our CI systems?

My understanding is: No and Yes.
Maybe Anusha can provide more details here.

>
> It would also be good to list what kind of tests have been run
> to ensure that there are no regressions,

I'm afraid on IGT level we don't have HuC tests.
But media team was using modparam override to force GuC/HuC for
a while, Tony do you have such test list/results handy?

> and which platforms
> this change affects.

This change affects all platforms where we have GuC/HuC firmwares
defined, so: SKL, BXT, KBL, CFL, ICL.

Note that we'll still have possibility to tweak that inside
driver, as auto mode is just moving responsibility what can
be enabled from the user to the i915.

>
> Regards, Joonas
>
>> Note that today GuC is only used for HuC authentication.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.h  
>> b/drivers/gpu/drm/i915/i915_params.h
>> index d29ade3b7de6..5736c55694fe 100644
>> --- a/drivers/gpu/drm/i915/i915_params.h
>> +++ b/drivers/gpu/drm/i915/i915_params.h
>> @@ -54,7 +54,7 @@ struct drm_printer;
>>         param(int, disable_power_well, -1) \
>>         param(int, enable_ips, 1) \
>>         param(int, invert_brightness, 0) \
>> -       param(int, enable_guc, 0) \
>> +       param(int, enable_guc, -1) \
>>         param(int, guc_log_level, -1) \
>>         param(char *, guc_firmware_path, NULL) \
>>         param(char *, huc_firmware_path, NULL) \
>> --
>> 2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Joonas Lahtinen]

Better subject would be: "Enable HuC (through GuC) on supported platforms"

Quoting Michal Wajdeczko (2019-07-03 14:36:40)
> GuC firmware is now mature, so let it run by default.

That's bit of a misleading statement (in more than one way).

"Enable loading HuC firmware (through GuC) to unlock
advanced video codecs on supported platforms.

GuC firmware is required to authenticate the HuC firmware,
which is a requirement for it to operate."

Has the most recent firmware been merged to linux-firmware and
is it present in our CI systems?

It would also be good to list what kind of tests have been run
to ensure that there are no regressions, and which platforms
this change affects.

Regards, Joonas

> Note that today GuC is only used for HuC authentication.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index d29ade3b7de6..5736c55694fe 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -54,7 +54,7 @@ struct drm_printer;
>         param(int, disable_power_well, -1) \
>         param(int, enable_ips, 1) \
>         param(int, invert_brightness, 0) \
> -       param(int, enable_guc, 0) \
> +       param(int, enable_guc, -1) \
>         param(int, guc_log_level, -1) \
>         param(char *, guc_firmware_path, NULL) \
>         param(char *, huc_firmware_path, NULL) \
> -- 
> 2.19.2
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Chris Wilson]

Quoting Michal Wajdeczko (2019-07-03 14:02:51)
> On Wed, 03 Jul 2019 13:40:06 +0200, Chris Wilson  
> <chris@chris-wilson.co.uk> wrote:
> 
> > Quoting Michal Wajdeczko (2019-07-03 12:36:40)
> >> GuC firmware is now mature, so let it run by default.
> >> Note that today GuC is only used for HuC authentication.
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=110617 ?
> 
> Above bug was found on suspicious kernel with old GuC 9.39:
> 
> [    2.381803] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
> (version 2.0)
> [    2.386316] [drm] GuC: Loaded firmware i915/kbl_guc_ver9_39.bin  
> (version 9.39)
> [    2.438318] [drm:intel_huc_auth] *ERROR* HuC: Firmware not verified  
> 0x6000
> [    2.445235] [drm:intel_huc_auth] *ERROR* HuC: Authentication failed -110
> [    2.451975] i915 0000:00:02.0: GuC initialization failed -110
> 
> while results from try-bot [1] with 33.0.0 on KBL are looking fine:
> 
> [    3.854084] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
> (version 2.0)
> [    3.865419] [drm] GuC: Loaded firmware i915/kbl_guc_33.0.0.bin (version  
> 33.0)
> [    3.876243] i915 0000:00:02.0: GuC submission disabled
> [    3.876245] i915 0000:00:02.0: HuC enabled
> 
> Note that newer GuC fixes other known issue [2] that has similar signature:
> 
> [160.168623] [drm:intel_huc_auth [i915]] *ERROR* HuC: Firmware not  
> verified -110
> [160.168839] [drm:intel_huc_auth [i915]] *ERROR* HuC: Authentication  
> failed -110
> [160.169159] [drm:i915_gem_init_hw [i915]] *ERROR* Enabling uc failed  
> (-110)

Pushed the switch to the new GuC version, but I am deferring the
decision to enable-by-default to someone in MAINTAINERS. Probably Joonas
if he survives his swim with the fishes.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Michal Wajdeczko]

On Wed, 03 Jul 2019 13:40:06 +0200, Chris Wilson  
<chris@chris-wilson.co.uk> wrote:

> Quoting Michal Wajdeczko (2019-07-03 12:36:40)
>> GuC firmware is now mature, so let it run by default.
>> Note that today GuC is only used for HuC authentication.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=110617 ?

Above bug was found on suspicious kernel with old GuC 9.39:

[    2.381803] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
(version 2.0)
[    2.386316] [drm] GuC: Loaded firmware i915/kbl_guc_ver9_39.bin  
(version 9.39)
[    2.438318] [drm:intel_huc_auth] *ERROR* HuC: Firmware not verified  
0x6000
[    2.445235] [drm:intel_huc_auth] *ERROR* HuC: Authentication failed -110
[    2.451975] i915 0000:00:02.0: GuC initialization failed -110

while results from try-bot [1] with 33.0.0 on KBL are looking fine:

[    3.854084] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
(version 2.0)
[    3.865419] [drm] GuC: Loaded firmware i915/kbl_guc_33.0.0.bin (version  
33.0)
[    3.876243] i915 0000:00:02.0: GuC submission disabled
[    3.876245] i915 0000:00:02.0: HuC enabled

Note that newer GuC fixes other known issue [2] that has similar signature:

[160.168623] [drm:intel_huc_auth [i915]] *ERROR* HuC: Firmware not  
verified -110
[160.168839] [drm:intel_huc_auth [i915]] *ERROR* HuC: Authentication  
failed -110
[160.169159] [drm:i915_gem_init_hw [i915]] *ERROR* Enabling uc failed  
(-110)

Michal

[1]  
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4514/fi-kbl-7567u/boot0.log
[2] https://bugs.freedesktop.org/show_bug.cgi?id=110820




_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Chris Wilson]

Quoting Michal Wajdeczko (2019-07-03 12:36:40)
> GuC firmware is now mature, so let it run by default.
> Note that today GuC is only used for HuC authentication.

https://bugs.freedesktop.org/show_bug.cgi?id=110617 ?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Michal Wajdeczko]

GuC firmware is now mature, so let it run by default.
Note that today GuC is only used for HuC authentication.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index d29ade3b7de6..5736c55694fe 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -54,7 +54,7 @@ struct drm_printer;
 	param(int, disable_power_well, -1) \
 	param(int, enable_ips, 1) \
 	param(int, invert_brightness, 0) \
-	param(int, enable_guc, 0) \
+	param(int, enable_guc, -1) \
 	param(int, guc_log_level, -1) \
 	param(char *, guc_firmware_path, NULL) \
 	param(char *, huc_firmware_path, NULL) \
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx