[thud/master][PATCH v2] rng-tools: remove duplicate initscript and wait for module load

[thud/master][PATCH v2] rng-tools: remove duplicate initscript and wait for module load

[Denys Dmytriyenko]

Since Arago still has a mix of SysVinit iniscripts and systemd unit files, it
enables both of the DISTRO_FEATURES, resulting in some duplication. It appears
that rngd currently has a problem handling signals when forked in daemon mode.
Hence, drop SysVinit initscript in favor of systemd service, as the latter one
starts rngd in foreground. Also, add udev dependency rule on omap_rng module.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
v2 - since dropping initscript, disable corresponding update-rc.d processing

 .../recipes-support/rng-tools/rng-tools/rngd.rules        |  1 +
 .../recipes-support/rng-tools/rng-tools_%.bbappend        | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
 create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend

diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
new file mode 100644
index 0000000..a21c99b
--- /dev/null
+++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
@@ -0,0 +1 @@
+ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng", TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
new file mode 100644
index 0000000..2a7810f
--- /dev/null
+++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
@@ -0,0 +1,15 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+
+PR_append = ".arago0"
+
+SRC_URI += "file://rngd.rules"
+
+do_install_append() {
+	# remove duplicate initscript
+	rm -f ${D}${sysconfdir}/init.d/rng-tools
+
+	install -d ${D}${sysconfdir}/udev/rules.d/
+	install -m0644 ${WORKDIR}/rngd.rules ${D}${sysconfdir}/udev/rules.d/
+}
+
+INHIBIT_UPDATERCD_BBCLASS = "1"
-- 
2.7.4

Re: [EXTERNAL] [thud/master][PATCH v2] rng-tools: remove duplicate initscript and wait for module load

[Jacob Stiffler]

Denys,

Can you backport this to ti2019.03?


Thanks,

Jake

On 9/4/2019 1:25 PM, Denys Dmytriyenko wrote:
> Since Arago still has a mix of SysVinit iniscripts and systemd unit files, it
> enables both of the DISTRO_FEATURES, resulting in some duplication. It appears
> that rngd currently has a problem handling signals when forked in daemon mode.
> Hence, drop SysVinit initscript in favor of systemd service, as the latter one
> starts rngd in foreground. Also, add udev dependency rule on omap_rng module.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> v2 - since dropping initscript, disable corresponding update-rc.d processing
>
>   .../recipes-support/rng-tools/rng-tools/rngd.rules        |  1 +
>   .../recipes-support/rng-tools/rng-tools_%.bbappend        | 15 +++++++++++++++
>   2 files changed, 16 insertions(+)
>   create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>   create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>
> diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> new file mode 100644
> index 0000000..a21c99b
> --- /dev/null
> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> @@ -0,0 +1 @@
> +ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng", TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
> diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
> new file mode 100644
> index 0000000..2a7810f
> --- /dev/null
> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
> @@ -0,0 +1,15 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +PR_append = ".arago0"
> +
> +SRC_URI += "file://rngd.rules"
> +
> +do_install_append() {
> +	# remove duplicate initscript
> +	rm -f ${D}${sysconfdir}/init.d/rng-tools
> +
> +	install -d ${D}${sysconfdir}/udev/rules.d/
> +	install -m0644 ${WORKDIR}/rngd.rules ${D}${sysconfdir}/udev/rules.d/
> +}
> +
> +INHIBIT_UPDATERCD_BBCLASS = "1"