From: Thomas Falcon <tlfalcon@linux.ibm.com> To: jakub.kicinski@netronome.com Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, dnbanerg@us.ibm.com, brking@linux.vnet.ibm.com, julietk@linux.vnet.ibm.com, Thomas Falcon <tlfalcon@linux.ibm.com> Subject: [PATCH net v2 0/4] ibmvnic: Harden device commands and queries Date: Mon, 25 Nov 2019 17:12:52 -0600 [thread overview] Message-ID: <1574723576-27553-1-git-send-email-tlfalcon@linux.ibm.com> (raw) In-Reply-To: <20191125112359.7a468352@cakuba.hsd1.ca.comcast.net> This patch series fixes some shortcomings with the current VNIC device command implementation. The first patch fixes the initialization of driver completion structures used for device commands. Additionally, all waits for device commands are bounded with a timeout in the event that the device does not respond or becomes inoperable. Finally, serialize queries to retain the integrity of device return codes. Changes in v2: - included header comment for ibmvnic_wait_for_completion - removed open-coded loop in patch 3/4, suggested by Jakub - ibmvnic_wait_for_completion accepts timeout value in milliseconds instead of jiffies - timeout calculations cleaned up and completed before wait loop - included missing mutex_destroy calls, suggested by Jakub - included comment before mutex declaration Thomas Falcon (4): ibmvnic: Fix completion structure initialization ibmvnic: Terminate waiting device threads after loss of service ibmvnic: Bound waits for device queries ibmvnic: Serialize device queries drivers/net/ethernet/ibm/ibmvnic.c | 192 +++++++++++++++++++++++++++++++------ drivers/net/ethernet/ibm/ibmvnic.h | 2 + 2 files changed, 167 insertions(+), 27 deletions(-) -- 2.12.3
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Falcon <tlfalcon@linux.ibm.com> To: jakub.kicinski@netronome.com Cc: julietk@linux.vnet.ibm.com, netdev@vger.kernel.org, dnbanerg@us.ibm.com, linuxppc-dev@ozlabs.org, Thomas Falcon <tlfalcon@linux.ibm.com>, brking@linux.vnet.ibm.com Subject: [PATCH net v2 0/4] ibmvnic: Harden device commands and queries Date: Mon, 25 Nov 2019 17:12:52 -0600 [thread overview] Message-ID: <1574723576-27553-1-git-send-email-tlfalcon@linux.ibm.com> (raw) In-Reply-To: <20191125112359.7a468352@cakuba.hsd1.ca.comcast.net> This patch series fixes some shortcomings with the current VNIC device command implementation. The first patch fixes the initialization of driver completion structures used for device commands. Additionally, all waits for device commands are bounded with a timeout in the event that the device does not respond or becomes inoperable. Finally, serialize queries to retain the integrity of device return codes. Changes in v2: - included header comment for ibmvnic_wait_for_completion - removed open-coded loop in patch 3/4, suggested by Jakub - ibmvnic_wait_for_completion accepts timeout value in milliseconds instead of jiffies - timeout calculations cleaned up and completed before wait loop - included missing mutex_destroy calls, suggested by Jakub - included comment before mutex declaration Thomas Falcon (4): ibmvnic: Fix completion structure initialization ibmvnic: Terminate waiting device threads after loss of service ibmvnic: Bound waits for device queries ibmvnic: Serialize device queries drivers/net/ethernet/ibm/ibmvnic.c | 192 +++++++++++++++++++++++++++++++------ drivers/net/ethernet/ibm/ibmvnic.h | 2 + 2 files changed, 167 insertions(+), 27 deletions(-) -- 2.12.3
next prev parent reply other threads:[~2019-11-25 23:13 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-22 19:41 [PATCH net 0/4] ibmvnic: Harden device commands and queries Thomas Falcon 2019-11-22 19:41 ` Thomas Falcon 2019-11-22 19:41 ` [PATCH net 1/4] ibmvnic: Fix completion structure initialization Thomas Falcon 2019-11-22 19:41 ` Thomas Falcon 2019-11-22 19:41 ` [PATCH net 2/4] ibmvnic: Terminate waiting device threads after loss of service Thomas Falcon 2019-11-22 19:41 ` Thomas Falcon 2019-11-22 19:41 ` [PATCH net 3/4] ibmvnic: Bound waits for device queries Thomas Falcon 2019-11-22 19:41 ` Thomas Falcon 2019-11-24 1:46 ` Jakub Kicinski 2019-11-24 1:46 ` Jakub Kicinski 2019-11-22 19:41 ` [PATCH net 4/4] ibmvnic: Serialize " Thomas Falcon 2019-11-22 19:41 ` Thomas Falcon 2019-11-24 1:47 ` Jakub Kicinski 2019-11-24 1:47 ` Jakub Kicinski 2019-11-24 1:49 ` [PATCH net 0/4] ibmvnic: Harden device commands and queries Jakub Kicinski 2019-11-24 1:49 ` Jakub Kicinski 2019-11-25 18:40 ` Thomas Falcon 2019-11-25 18:40 ` Thomas Falcon 2019-11-25 19:23 ` Jakub Kicinski 2019-11-25 19:23 ` Jakub Kicinski 2019-11-25 23:12 ` Thomas Falcon [this message] 2019-11-25 23:12 ` [PATCH net v2 " Thomas Falcon 2019-11-25 23:12 ` [PATCH net v2 1/4] ibmvnic: Fix completion structure initialization Thomas Falcon 2019-11-25 23:12 ` Thomas Falcon 2019-11-25 23:12 ` [PATCH net v2 2/4] ibmvnic: Terminate waiting device threads after loss of service Thomas Falcon 2019-11-25 23:12 ` Thomas Falcon 2019-11-25 23:12 ` [PATCH net v2 3/4] ibmvnic: Bound waits for device queries Thomas Falcon 2019-11-25 23:12 ` Thomas Falcon 2019-11-25 23:12 ` [PATCH net v2 4/4] ibmvnic: Serialize " Thomas Falcon 2019-11-25 23:12 ` Thomas Falcon 2019-11-26 21:19 ` [PATCH net v2 0/4] ibmvnic: Harden device commands and queries David Miller 2019-11-26 21:19 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1574723576-27553-1-git-send-email-tlfalcon@linux.ibm.com \ --to=tlfalcon@linux.ibm.com \ --cc=brking@linux.vnet.ibm.com \ --cc=dnbanerg@us.ibm.com \ --cc=jakub.kicinski@netronome.com \ --cc=julietk@linux.vnet.ibm.com \ --cc=linuxppc-dev@ozlabs.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.