All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH CI 1/3] drm/i915/display: Check the old state to find port sync slave
@ 2019-12-02 22:25 ` José Roberto de Souza
  0 siblings, 0 replies; 14+ messages in thread
From: José Roberto de Souza @ 2019-12-02 22:25 UTC (permalink / raw)
  To: intel-gfx

If the CRTC is going from enabled to disabled and it is a port sync
slave, it needs to check to the old state to be disabled before the
port sync master.

Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 1f1cd7578706..3062578e2bdb 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -14497,8 +14497,8 @@ static void intel_commit_modeset_disables(struct intel_atomic_state *state)
 		 * slave CRTCs are disabled first and then master CRTC since
 		 * Slave vblanks are masked till Master Vblanks.
 		 */
-		if (is_trans_port_sync_mode(new_crtc_state)) {
-			if (is_trans_port_sync_master(new_crtc_state))
+		if (is_trans_port_sync_mode(old_crtc_state)) {
+			if (is_trans_port_sync_master(old_crtc_state))
 				intel_trans_port_sync_modeset_disables(state,
 								       crtc,
 								       old_crtc_state,
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-12-03 22:04 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 22:25 [PATCH CI 1/3] drm/i915/display: Check the old state to find port sync slave José Roberto de Souza
2019-12-02 22:25 ` [Intel-gfx] " José Roberto de Souza
2019-12-02 22:25 ` [PATCH CI 2/3] drm/i915/dp: Power down sink before disable pipe/transcoder clock José Roberto de Souza
2019-12-02 22:25   ` [Intel-gfx] " José Roberto de Souza
2019-12-02 22:25 ` [PATCH CI 3/3] drm/i915/display/mst: Move DPMS_OFF call to post_disable José Roberto de Souza
2019-12-02 22:25   ` [Intel-gfx] " José Roberto de Souza
2019-12-03  1:09 ` ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/display: Check the old state to find port sync slave Patchwork
2019-12-03  1:09   ` [Intel-gfx] " Patchwork
2019-12-03  2:11 ` ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/display: Check the old state to find port sync slave (rev2) Patchwork
2019-12-03  2:11   ` [Intel-gfx] " Patchwork
2019-12-03  8:24 ` ✓ Fi.CI.IGT: " Patchwork
2019-12-03  8:24   ` [Intel-gfx] " Patchwork
2019-12-03 20:36   ` Souza, Jose
2019-12-03 22:08 ` [Intel-gfx] [PATCH CI 1/3] drm/i915/display: Check the old state to find port sync slave Manasi Navare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.