From: Chris Wilson <chris@chris-wilson.co.uk>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: kenneth.w.graunke@intel.com, sanjay.k.kumar@intel.com,
dri-devel@lists.freedesktop.org, jason.ekstrand@intel.com,
dave.hansen@intel.com, jglisse@redhat.com, jgg@mellanox.com,
daniel.vetter@intel.com, dan.j.williams@intel.com,
ira.weiny@intel.com
Subject: Re: [Intel-gfx] [RFC v2 03/12] drm/i915/svm: Implicitly migrate BOs upon CPU access
Date: Sat, 14 Dec 2019 10:58:35 +0000 [thread overview]
Message-ID: <157632111528.7535.2801931080292335530@skylake-alporthouse-com> (raw)
In-Reply-To: <20191213215614.24558-4-niranjana.vishwanathapura@intel.com>
Quoting Niranjana Vishwanathapura (2019-12-13 21:56:05)
> +int i915_gem_object_migrate_region(struct drm_i915_gem_object *obj,
> + u32 *regions, int size)
> +{
> + struct drm_i915_private *dev_priv = to_i915(obj->base.dev);
> + struct intel_context *ce = dev_priv->engine[BCS0]->kernel_context;
> + int i, ret;
> +
> mutex_lock(&dev_priv->drm.struct_mutex);
> ret = i915_gem_object_prepare_move(obj);
You appear to be based on a very broken code base. I'd recommend not
doing that.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: kenneth.w.graunke@intel.com, sanjay.k.kumar@intel.com,
dri-devel@lists.freedesktop.org, jason.ekstrand@intel.com,
dave.hansen@intel.com, jglisse@redhat.com, jgg@mellanox.com,
daniel.vetter@intel.com, dan.j.williams@intel.com,
ira.weiny@intel.com
Subject: Re: [Intel-gfx] [RFC v2 03/12] drm/i915/svm: Implicitly migrate BOs upon CPU access
Date: Sat, 14 Dec 2019 10:58:35 +0000 [thread overview]
Message-ID: <157632111528.7535.2801931080292335530@skylake-alporthouse-com> (raw)
In-Reply-To: <20191213215614.24558-4-niranjana.vishwanathapura@intel.com>
Quoting Niranjana Vishwanathapura (2019-12-13 21:56:05)
> +int i915_gem_object_migrate_region(struct drm_i915_gem_object *obj,
> + u32 *regions, int size)
> +{
> + struct drm_i915_private *dev_priv = to_i915(obj->base.dev);
> + struct intel_context *ce = dev_priv->engine[BCS0]->kernel_context;
> + int i, ret;
> +
> mutex_lock(&dev_priv->drm.struct_mutex);
> ret = i915_gem_object_prepare_move(obj);
You appear to be based on a very broken code base. I'd recommend not
doing that.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-14 10:58 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 21:56 [RFC v2 00/12] drm/i915/svm: Add SVM support Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 01/12] drm/i915/svm: Add SVM documentation Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 22:58 ` Jason Ekstrand
2019-12-13 22:58 ` Jason Ekstrand
2019-12-13 23:13 ` Niranjan Vishwanathapura
2019-12-13 23:13 ` Niranjan Vishwanathapura
2019-12-14 0:36 ` Jason Ekstrand
2019-12-14 0:36 ` Jason Ekstrand
2019-12-14 10:31 ` Chris Wilson
2019-12-14 10:31 ` Chris Wilson
2019-12-16 4:13 ` Niranjan Vishwanathapura
2019-12-16 4:13 ` Niranjan Vishwanathapura
2019-12-17 18:01 ` Jason Ekstrand
2019-12-17 18:01 ` Jason Ekstrand
2019-12-18 23:25 ` Niranjana Vishwanathapura
2019-12-18 23:25 ` Niranjana Vishwanathapura
2019-12-14 10:56 ` Chris Wilson
2019-12-14 10:56 ` Chris Wilson
2019-12-16 4:15 ` Niranjan Vishwanathapura
2019-12-16 4:15 ` Niranjan Vishwanathapura
2019-12-18 22:51 ` Niranjana Vishwanathapura
2019-12-18 22:51 ` Niranjana Vishwanathapura
2019-12-17 20:18 ` Jason Gunthorpe
2019-12-17 20:18 ` [Intel-gfx] " Jason Gunthorpe
2019-12-18 23:34 ` Niranjana Vishwanathapura
2019-12-18 23:34 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 03/12] drm/i915/svm: Implicitly migrate BOs upon CPU access Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-14 10:58 ` Chris Wilson [this message]
2019-12-14 10:58 ` Chris Wilson
2019-12-16 4:17 ` Niranjan Vishwanathapura
2019-12-16 4:17 ` Niranjan Vishwanathapura
2019-12-13 21:56 ` [RFC v2 04/12] drm/i915/svm: Page table update support for SVM Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 05/12] drm/i915/svm: Page table mirroring support Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-17 20:31 ` Jason Gunthorpe
2019-12-17 20:31 ` [Intel-gfx] " Jason Gunthorpe
2019-12-18 22:41 ` Niranjana Vishwanathapura
2019-12-18 22:41 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-20 13:45 ` Jason Gunthorpe
2019-12-20 13:45 ` [Intel-gfx] " Jason Gunthorpe
2019-12-22 19:54 ` Niranjana Vishwanathapura
2019-12-22 19:54 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 06/12] drm/i915/svm: Device memory support Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-17 20:35 ` Jason Gunthorpe
2019-12-17 20:35 ` [Intel-gfx] " Jason Gunthorpe
2019-12-18 22:15 ` Niranjana Vishwanathapura
2019-12-18 22:15 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 07/12] drm/i915/svm: Implicitly migrate pages upon CPU fault Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 08/12] drm/i915/svm: Page copy support during migration Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 09/12] drm/i915/svm: Add functions to blitter copy SVM buffers Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 10/12] drm/i915/svm: Use blitter copy for migration Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 11/12] drm/i915/svm: Add support to en/disable SVM Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-13 21:56 ` [RFC v2 12/12] drm/i915/svm: Add page table dump support Niranjana Vishwanathapura
2019-12-13 21:56 ` [Intel-gfx] " Niranjana Vishwanathapura
2019-12-14 1:32 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/svm: Add SVM support (rev2) Patchwork
2020-01-24 8:42 ` [RFC v2 00/12] drm/i915/svm: Add SVM support Niranjana Vishwanathapura
2020-01-24 8:42 ` [Intel-gfx] " Niranjana Vishwanathapura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157632111528.7535.2801931080292335530@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dave.hansen@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ira.weiny@intel.com \
--cc=jason.ekstrand@intel.com \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=kenneth.w.graunke@intel.com \
--cc=niranjana.vishwanathapura@intel.com \
--cc=sanjay.k.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.