All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge
@ 2020-02-03 20:21 Chris Wilson
  2020-02-04  9:06 ` Andi Shyti
  2020-02-04 20:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
  0 siblings, 2 replies; 5+ messages in thread
From: Chris Wilson @ 2020-02-03 20:21 UTC (permalink / raw)
  To: intel-gfx

The current rc6 threshold is larger than the evaluation interval on
Ivybridge; it never enters rc6. Remove the special casing so it behaves
like the other gen6/gen7, and we see rc6 residencies before we manually
park the system.

Closes: https://gitlab.freedesktop.org/drm/intel/issues/1114
Testcase: igt/i915_pm_rc6_residency/rc6-idle #ivb
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index 01a99fdbb3c4..682f598f7042 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -226,10 +226,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)
 
 	set(uncore, GEN6_RC_SLEEP, 0);
 	set(uncore, GEN6_RC1e_THRESHOLD, 1000);
-	if (IS_IVYBRIDGE(i915))
-		set(uncore, GEN6_RC6_THRESHOLD, 125000);
-	else
-		set(uncore, GEN6_RC6_THRESHOLD, 50000);
+	set(uncore, GEN6_RC6_THRESHOLD, 50000);
 	set(uncore, GEN6_RC6p_THRESHOLD, 150000);
 	set(uncore, GEN6_RC6pp_THRESHOLD, 64000); /* unused */
 
-- 
2.25.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge
  2020-02-03 20:21 [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge Chris Wilson
@ 2020-02-04  9:06 ` Andi Shyti
  2020-02-04  9:09   ` Chris Wilson
  2020-02-04 20:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
  1 sibling, 1 reply; 5+ messages in thread
From: Andi Shyti @ 2020-02-04  9:06 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

Hi Chris,

> The current rc6 threshold is larger than the evaluation interval on
> Ivybridge; it never enters rc6. Remove the special casing so it behaves
> like the other gen6/gen7, and we see rc6 residencies before we manually
> park the system.
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/1114
> Testcase: igt/i915_pm_rc6_residency/rc6-idle #ivb
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> index 01a99fdbb3c4..682f598f7042 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> @@ -226,10 +226,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)
>  
>  	set(uncore, GEN6_RC_SLEEP, 0);
>  	set(uncore, GEN6_RC1e_THRESHOLD, 1000);
> -	if (IS_IVYBRIDGE(i915))
> -		set(uncore, GEN6_RC6_THRESHOLD, 125000);
> -	else
> -		set(uncore, GEN6_RC6_THRESHOLD, 50000);
> +	set(uncore, GEN6_RC6_THRESHOLD, 50000);

why was is set like this in a first place?

Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge
  2020-02-04  9:06 ` Andi Shyti
@ 2020-02-04  9:09   ` Chris Wilson
  2020-02-04  9:58     ` Andi Shyti
  0 siblings, 1 reply; 5+ messages in thread
From: Chris Wilson @ 2020-02-04  9:09 UTC (permalink / raw)
  To: Andi Shyti; +Cc: intel-gfx

Quoting Andi Shyti (2020-02-04 09:06:36)
> Hi Chris,
> 
> > The current rc6 threshold is larger than the evaluation interval on
> > Ivybridge; it never enters rc6. Remove the special casing so it behaves
> > like the other gen6/gen7, and we see rc6 residencies before we manually
> > park the system.
> > 
> > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1114
> > Testcase: igt/i915_pm_rc6_residency/rc6-idle #ivb
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Andi Shyti <andi.shyti@intel.com>
> > ---
> >  drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > index 01a99fdbb3c4..682f598f7042 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > @@ -226,10 +226,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)
> >  
> >       set(uncore, GEN6_RC_SLEEP, 0);
> >       set(uncore, GEN6_RC1e_THRESHOLD, 1000);
> > -     if (IS_IVYBRIDGE(i915))
> > -             set(uncore, GEN6_RC6_THRESHOLD, 125000);
> > -     else
> > -             set(uncore, GEN6_RC6_THRESHOLD, 50000);
> > +     set(uncore, GEN6_RC6_THRESHOLD, 50000);
> 
> why was is set like this in a first place?

No one knows.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge
  2020-02-04  9:09   ` Chris Wilson
@ 2020-02-04  9:58     ` Andi Shyti
  0 siblings, 0 replies; 5+ messages in thread
From: Andi Shyti @ 2020-02-04  9:58 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

> > > The current rc6 threshold is larger than the evaluation interval on
> > > Ivybridge; it never enters rc6. Remove the special casing so it behaves
> > > like the other gen6/gen7, and we see rc6 residencies before we manually
> > > park the system.
> > > 
> > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1114
> > > Testcase: igt/i915_pm_rc6_residency/rc6-idle #ivb
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Andi Shyti <andi.shyti@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +----
> > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > > index 01a99fdbb3c4..682f598f7042 100644
> > > --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> > > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > > @@ -226,10 +226,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)
> > >  
> > >       set(uncore, GEN6_RC_SLEEP, 0);
> > >       set(uncore, GEN6_RC1e_THRESHOLD, 1000);
> > > -     if (IS_IVYBRIDGE(i915))
> > > -             set(uncore, GEN6_RC6_THRESHOLD, 125000);
> > > -     else
> > > -             set(uncore, GEN6_RC6_THRESHOLD, 50000);
> > > +     set(uncore, GEN6_RC6_THRESHOLD, 50000);
> > 
> > why was is set like this in a first place?
> 
> No one knows.

I haven't found any exception either...

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix rc6 on Ivybridge
  2020-02-03 20:21 [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge Chris Wilson
  2020-02-04  9:06 ` Andi Shyti
@ 2020-02-04 20:05 ` Patchwork
  1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-02-04 20:05 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/gt: Fix rc6 on Ivybridge
URL   : https://patchwork.freedesktop.org/series/72938/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7864 -> Patchwork_16402
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/index.html

Known issues
------------

  Here are the changes found in Patchwork_16402 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_parallel@fds:
    - fi-byt-n2820:       [PASS][1] -> [FAIL][2] ([i915#694])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-byt-n2820/igt@gem_exec_parallel@fds.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-byt-n2820/igt@gem_exec_parallel@fds.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-hsw-4770:        [PASS][3] -> [DMESG-FAIL][4] ([i915#722])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][5] -> [FAIL][6] ([fdo#111407])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_parallel@contexts:
    - fi-byt-j1900:       [TIMEOUT][7] ([fdo#112271] / [i915#1084]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-byt-j1900/igt@gem_exec_parallel@contexts.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-byt-j1900/igt@gem_exec_parallel@contexts.html
    - fi-byt-n2820:       [TIMEOUT][9] ([fdo#112271]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-byt-n2820/igt@gem_exec_parallel@contexts.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][11] ([i915#725]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-j1900:       [DMESG-FAIL][13] ([i915#1052]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html

  * igt@i915_selftest@live_gtt:
    - fi-skl-6600u:       [TIMEOUT][15] ([fdo#111732] / [fdo#112271]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-skl-6600u/igt@i915_selftest@live_gtt.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-skl-6600u/igt@i915_selftest@live_gtt.html

  * igt@i915_selftest@live_perf:
    - fi-apl-guc:         [INCOMPLETE][17] ([fdo#103927]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-apl-guc/igt@i915_selftest@live_perf.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-apl-guc/igt@i915_selftest@live_perf.html

  
#### Warnings ####

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-icl-u2:          [DMESG-WARN][19] ([IGT#4] / [i915#263]) -> [FAIL][20] ([i915#217])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7864/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html

  
  [IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111732]: https://bugs.freedesktop.org/show_bug.cgi?id=111732
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#1052]: https://gitlab.freedesktop.org/drm/intel/issues/1052
  [i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725


Participating hosts (50 -> 40)
------------------------------

  Additional (2): fi-skl-lmem fi-snb-2520m 
  Missing    (12): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-cfl-8700k fi-ctg-p8600 fi-kbl-8809g fi-bsw-kefka fi-tgl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7864 -> Patchwork_16402

  CI-20190529: 20190529
  CI_DRM_7864: 5a140e2fc771e4c8b10d14e2db7bfb4996ee9d8a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5417: 33cc93c8ba5daa0b7498f297a4f626844d895d06 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_16402: 8cb1290bf3e0af10c32be2ef208ef0f7c1b01108 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

8cb1290bf3e0 drm/i915/gt: Fix rc6 on Ivybridge

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16402/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-04 20:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 20:21 [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge Chris Wilson
2020-02-04  9:06 ` Andi Shyti
2020-02-04  9:09   ` Chris Wilson
2020-02-04  9:58     ` Andi Shyti
2020-02-04 20:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.