From: Stanley Chu <stanley.chu@mediatek.com> To: Eric Biggers <ebiggers@kernel.org> Cc: Christoph Hellwig <hch@infradead.org>, Satya Tangirala <satyat@google.com>, <linux-block@vger.kernel.org>, <linux-scsi@vger.kernel.org>, <linux-fscrypt@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>, <linux-ext4@vger.kernel.org>, Barani Muthukumaran <bmuthuku@qti.qualcomm.com>, Kuohong Wang <kuohong.wang@mediatek.com>, "Kim Boojin" <boojin.kim@samsung.com>, Ladvine D Almeida <Ladvine.DAlmeida@synopsys.com>, Parshuram Raju Thombare <pthombar@cadence.com> Subject: Re: [PATCH v7 6/9] scsi: ufs: Add inline encryption support to UFS Date: Sun, 23 Feb 2020 21:47:36 +0800 [thread overview] Message-ID: <1582465656.26304.69.camel@mtksdccf07> (raw) In-Reply-To: <20200221181109.GB925@sol.localdomain> Hi, On Fri, 2020-02-21 at 10:11 -0800, Eric Biggers wrote: > On Fri, Feb 21, 2020 at 09:22:44AM -0800, Christoph Hellwig wrote: > > On Fri, Feb 21, 2020 at 03:50:47AM -0800, Satya Tangirala wrote: > > > Wire up ufshcd.c with the UFS Crypto API, the block layer inline > > > encryption additions and the keyslot manager. > > > > > > Also, introduce UFSHCD_QUIRK_BROKEN_CRYPTO that certain UFS drivers > > > that don't yet support inline encryption need to use - taken from > > > patches by John Stultz <john.stultz@linaro.org> > > > (https://android-review.googlesource.com/c/kernel/common/+/1162224/5) > > > (https://android-review.googlesource.com/c/kernel/common/+/1162225/5) > > > (https://android-review.googlesource.com/c/kernel/common/+/1164506/1) > > > > Between all these quirks, with what upstream SOC does this feature > > actually work? > > It will work on DragonBoard 845c, i.e. Qualcomm's Snapdragon 845 SoC, if we > apply my patchset > https://lkml.kernel.org/linux-block/20200110061634.46742-1-ebiggers@kernel.org/. > It's currently based on Satya's v6 patchset, but I'll be rebasing it onto v7 and > resending. It uses all the UFS standard crypto code that Satya is adding except > for ufshcd_program_key(), which has to be replaced with a vendor-specific > operation. It does also add vendor-specific code to ufs-qcom to initialize the > crypto hardware, but that's in addition to the standard code, not replacing it. > > DragonBoard 845c is a commercially available development board that boots the > mainline kernel (modulo two arm-smmu IOMMU patches that Linaro is working on), > so I think it counts as an "upstream SoC". > > That's all that we currently have the hardware to verify ourselves, though > Mediatek says that Satya's patches are working on their hardware too. And the > UFS controller on Mediatek SoCs is supported by the upstream kernel via > ufs-mediatek. But I don't know whether it just works exactly as-is or whether > they needed to patch ufs-mediatek too. Stanley or Kuohong, can you confirm? Yes, MediaTek is keeping work closely with inline encryption patch sets. Currently the v6 version can work well (without UFSHCD_QUIRK_BROKEN_CRYPTO quirk) at least in our MT6779 SoC platform which basic SoC support and some other peripheral drivers are under upstreaming as below link, https://patchwork.kernel.org/project/linux-mediatek/list/?state=% 2A&q=6779&series=&submitter=&delegate=&archive=both The integration with inline encryption patch set needs to patch ufs-mediatek and patches are ready in downstream. We plan to upstream them soon after inline encryption patch sets get merged. > > We're also hoping that the patches are usable with the UFS controllers from > Cadence Design Systems and Synopsys, which have upstream kernel support in > drivers/scsi/ufs/cdns-pltfrm.c and drivers/scsi/ufs/ufshcd-dwc.c. But we don't > currently have a way to verify this. But in 2018, both companies had tried to > get the UFS v2.1 standard crypto support upstream, so presumably they must have > implemented it in their hardware. +Cc the people who were working on that. > > - Eric Thanks, Stanley Chu
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com> To: Eric Biggers <ebiggers@kernel.org> Cc: linux-block@vger.kernel.org, Ladvine D Almeida <Ladvine.DAlmeida@synopsys.com>, linux-ext4@vger.kernel.org, linux-scsi@vger.kernel.org, Kim Boojin <boojin.kim@samsung.com>, Kuohong Wang <kuohong.wang@mediatek.com>, Parshuram Raju Thombare <pthombar@cadence.com>, Barani Muthukumaran <bmuthuku@qti.qualcomm.com>, Satya Tangirala <satyat@google.com>, Christoph Hellwig <hch@infradead.org>, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v7 6/9] scsi: ufs: Add inline encryption support to UFS Date: Sun, 23 Feb 2020 21:47:36 +0800 [thread overview] Message-ID: <1582465656.26304.69.camel@mtksdccf07> (raw) In-Reply-To: <20200221181109.GB925@sol.localdomain> Hi, On Fri, 2020-02-21 at 10:11 -0800, Eric Biggers wrote: > On Fri, Feb 21, 2020 at 09:22:44AM -0800, Christoph Hellwig wrote: > > On Fri, Feb 21, 2020 at 03:50:47AM -0800, Satya Tangirala wrote: > > > Wire up ufshcd.c with the UFS Crypto API, the block layer inline > > > encryption additions and the keyslot manager. > > > > > > Also, introduce UFSHCD_QUIRK_BROKEN_CRYPTO that certain UFS drivers > > > that don't yet support inline encryption need to use - taken from > > > patches by John Stultz <john.stultz@linaro.org> > > > (https://android-review.googlesource.com/c/kernel/common/+/1162224/5) > > > (https://android-review.googlesource.com/c/kernel/common/+/1162225/5) > > > (https://android-review.googlesource.com/c/kernel/common/+/1164506/1) > > > > Between all these quirks, with what upstream SOC does this feature > > actually work? > > It will work on DragonBoard 845c, i.e. Qualcomm's Snapdragon 845 SoC, if we > apply my patchset > https://lkml.kernel.org/linux-block/20200110061634.46742-1-ebiggers@kernel.org/. > It's currently based on Satya's v6 patchset, but I'll be rebasing it onto v7 and > resending. It uses all the UFS standard crypto code that Satya is adding except > for ufshcd_program_key(), which has to be replaced with a vendor-specific > operation. It does also add vendor-specific code to ufs-qcom to initialize the > crypto hardware, but that's in addition to the standard code, not replacing it. > > DragonBoard 845c is a commercially available development board that boots the > mainline kernel (modulo two arm-smmu IOMMU patches that Linaro is working on), > so I think it counts as an "upstream SoC". > > That's all that we currently have the hardware to verify ourselves, though > Mediatek says that Satya's patches are working on their hardware too. And the > UFS controller on Mediatek SoCs is supported by the upstream kernel via > ufs-mediatek. But I don't know whether it just works exactly as-is or whether > they needed to patch ufs-mediatek too. Stanley or Kuohong, can you confirm? Yes, MediaTek is keeping work closely with inline encryption patch sets. Currently the v6 version can work well (without UFSHCD_QUIRK_BROKEN_CRYPTO quirk) at least in our MT6779 SoC platform which basic SoC support and some other peripheral drivers are under upstreaming as below link, https://patchwork.kernel.org/project/linux-mediatek/list/?state=% 2A&q=6779&series=&submitter=&delegate=&archive=both The integration with inline encryption patch set needs to patch ufs-mediatek and patches are ready in downstream. We plan to upstream them soon after inline encryption patch sets get merged. > > We're also hoping that the patches are usable with the UFS controllers from > Cadence Design Systems and Synopsys, which have upstream kernel support in > drivers/scsi/ufs/cdns-pltfrm.c and drivers/scsi/ufs/ufshcd-dwc.c. But we don't > currently have a way to verify this. But in 2018, both companies had tried to > get the UFS v2.1 standard crypto support upstream, so presumably they must have > implemented it in their hardware. +Cc the people who were working on that. > > - Eric Thanks, Stanley Chu _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-02-23 13:47 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-21 11:50 [PATCH v7 0/9] Inline Encryption Support Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-21 11:50 ` [PATCH v7 1/9] block: Keyslot Manager for Inline Encryption Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-21 17:04 ` Christoph Hellwig 2020-02-21 17:04 ` [f2fs-dev] " Christoph Hellwig 2020-02-21 17:31 ` Christoph Hellwig 2020-02-21 17:31 ` [f2fs-dev] " Christoph Hellwig 2020-02-27 18:14 ` Eric Biggers 2020-02-27 18:14 ` [f2fs-dev] " Eric Biggers 2020-02-27 21:25 ` Satya Tangirala 2020-02-27 21:25 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-03-05 16:11 ` Christoph Hellwig 2020-03-05 16:11 ` [f2fs-dev] " Christoph Hellwig 2020-02-27 18:48 ` Eric Biggers 2020-02-27 18:48 ` [f2fs-dev] " Eric Biggers 2020-02-21 11:50 ` [PATCH v7 2/9] block: Inline encryption support for blk-mq Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-21 17:22 ` Christoph Hellwig 2020-02-21 17:22 ` [f2fs-dev] " Christoph Hellwig 2020-02-22 0:52 ` Satya Tangirala 2020-02-22 0:52 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-24 23:34 ` Christoph Hellwig 2020-02-24 23:34 ` [f2fs-dev] " Christoph Hellwig 2020-02-27 18:25 ` Eric Biggers 2020-02-27 18:25 ` [f2fs-dev] " Eric Biggers 2020-02-21 11:50 ` [PATCH v7 3/9] block: blk-crypto-fallback for Inline Encryption Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-21 16:51 ` Randy Dunlap 2020-02-21 16:51 ` [f2fs-dev] " Randy Dunlap 2020-02-21 17:25 ` Christoph Hellwig 2020-02-21 17:25 ` [f2fs-dev] " Christoph Hellwig 2020-02-21 17:35 ` Christoph Hellwig 2020-02-21 17:35 ` [f2fs-dev] " Christoph Hellwig 2020-02-21 18:34 ` Eric Biggers 2020-02-21 18:34 ` [f2fs-dev] " Eric Biggers 2020-02-24 23:36 ` Christoph Hellwig 2020-02-24 23:36 ` [f2fs-dev] " Christoph Hellwig 2020-02-27 19:25 ` Eric Biggers 2020-02-27 19:25 ` [f2fs-dev] " Eric Biggers 2020-02-21 11:50 ` [PATCH v7 4/9] scsi: ufs: UFS driver v2.1 spec crypto additions Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-21 11:50 ` [PATCH v7 5/9] scsi: ufs: UFS crypto API Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-22 4:59 ` Eric Biggers 2020-02-22 4:59 ` [f2fs-dev] " Eric Biggers 2020-02-21 11:50 ` [PATCH v7 6/9] scsi: ufs: Add inline encryption support to UFS Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-21 17:22 ` Christoph Hellwig 2020-02-21 17:22 ` [f2fs-dev] " Christoph Hellwig 2020-02-21 18:11 ` Eric Biggers 2020-02-21 18:11 ` [f2fs-dev] " Eric Biggers 2020-02-23 13:47 ` Stanley Chu [this message] 2020-02-23 13:47 ` Stanley Chu 2020-02-24 23:37 ` Christoph Hellwig 2020-02-24 23:37 ` [f2fs-dev] " Christoph Hellwig 2020-02-25 7:21 ` Stanley Chu 2020-02-25 7:21 ` [f2fs-dev] " Stanley Chu 2020-02-26 1:12 ` Eric Biggers 2020-02-26 1:12 ` [f2fs-dev] " Eric Biggers 2020-02-26 6:43 ` Stanley Chu 2020-02-26 6:43 ` [f2fs-dev] " Stanley Chu 2020-03-02 9:17 ` Stanley Chu 2020-03-02 9:17 ` [f2fs-dev] " Stanley Chu 2020-02-21 11:50 ` [PATCH v7 7/9] fscrypt: add inline encryption support Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-21 18:40 ` Eric Biggers 2020-02-21 18:40 ` [f2fs-dev] " Eric Biggers 2020-02-22 5:39 ` Eric Biggers 2020-02-22 5:39 ` [f2fs-dev] " Eric Biggers 2020-02-26 0:30 ` Eric Biggers 2020-02-26 0:30 ` [f2fs-dev] " Eric Biggers 2020-02-21 11:50 ` [PATCH v7 8/9] f2fs: " Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-21 11:50 ` [PATCH v7 9/9] ext4: " Satya Tangirala 2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-02-22 5:21 ` Eric Biggers 2020-02-22 5:21 ` [f2fs-dev] " Eric Biggers 2020-02-21 17:16 ` [PATCH v7 0/9] Inline Encryption Support Eric Biggers 2020-02-21 17:16 ` [f2fs-dev] " Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1582465656.26304.69.camel@mtksdccf07 \ --to=stanley.chu@mediatek.com \ --cc=Ladvine.DAlmeida@synopsys.com \ --cc=bmuthuku@qti.qualcomm.com \ --cc=boojin.kim@samsung.com \ --cc=ebiggers@kernel.org \ --cc=hch@infradead.org \ --cc=kuohong.wang@mediatek.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=pthombar@cadence.com \ --cc=satyat@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.