From: Christoph Hellwig <hch@infradead.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org,
Barani Muthukumaran <bmuthuku@qti.qualcomm.com>,
Kuohong Wang <kuohong.wang@mediatek.com>,
Kim Boojin <boojin.kim@samsung.com>
Subject: Re: [PATCH v7 1/9] block: Keyslot Manager for Inline Encryption
Date: Fri, 21 Feb 2020 09:31:18 -0800 [thread overview]
Message-ID: <20200221173118.GA30670@infradead.org> (raw)
In-Reply-To: <20200221170434.GA438@infradead.org>
On Fri, Feb 21, 2020 at 09:04:34AM -0800, Christoph Hellwig wrote:
> Given that blk_ksm_get_slot_for_key returns a signed keyslot that
> can return errors, and the only callers stores it in a signed variable
> I think this function should take a signed slot as well, and the check
> for a non-negative slot should be moved here from the only caller.
Actually looking over the code again I think it might be better to
return only the error code (and that might actually be a blk_status_t),
and then use an argument to return a pointer to the actual struct
keyslot. That gives us much easier to understand code and better
type safety.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-scsi@vger.kernel.org, Kim Boojin <boojin.kim@samsung.com>,
Kuohong Wang <kuohong.wang@mediatek.com>,
Barani Muthukumaran <bmuthuku@qti.qualcomm.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v7 1/9] block: Keyslot Manager for Inline Encryption
Date: Fri, 21 Feb 2020 09:31:18 -0800 [thread overview]
Message-ID: <20200221173118.GA30670@infradead.org> (raw)
In-Reply-To: <20200221170434.GA438@infradead.org>
On Fri, Feb 21, 2020 at 09:04:34AM -0800, Christoph Hellwig wrote:
> Given that blk_ksm_get_slot_for_key returns a signed keyslot that
> can return errors, and the only callers stores it in a signed variable
> I think this function should take a signed slot as well, and the check
> for a non-negative slot should be moved here from the only caller.
Actually looking over the code again I think it might be better to
return only the error code (and that might actually be a blk_status_t),
and then use an argument to return a pointer to the actual struct
keyslot. That gives us much easier to understand code and better
type safety.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-02-21 17:31 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 11:50 [PATCH v7 0/9] Inline Encryption Support Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 11:50 ` [PATCH v7 1/9] block: Keyslot Manager for Inline Encryption Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 17:04 ` Christoph Hellwig
2020-02-21 17:04 ` [f2fs-dev] " Christoph Hellwig
2020-02-21 17:31 ` Christoph Hellwig [this message]
2020-02-21 17:31 ` Christoph Hellwig
2020-02-27 18:14 ` Eric Biggers
2020-02-27 18:14 ` [f2fs-dev] " Eric Biggers
2020-02-27 21:25 ` Satya Tangirala
2020-02-27 21:25 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-03-05 16:11 ` Christoph Hellwig
2020-03-05 16:11 ` [f2fs-dev] " Christoph Hellwig
2020-02-27 18:48 ` Eric Biggers
2020-02-27 18:48 ` [f2fs-dev] " Eric Biggers
2020-02-21 11:50 ` [PATCH v7 2/9] block: Inline encryption support for blk-mq Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 17:22 ` Christoph Hellwig
2020-02-21 17:22 ` [f2fs-dev] " Christoph Hellwig
2020-02-22 0:52 ` Satya Tangirala
2020-02-22 0:52 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-24 23:34 ` Christoph Hellwig
2020-02-24 23:34 ` [f2fs-dev] " Christoph Hellwig
2020-02-27 18:25 ` Eric Biggers
2020-02-27 18:25 ` [f2fs-dev] " Eric Biggers
2020-02-21 11:50 ` [PATCH v7 3/9] block: blk-crypto-fallback for Inline Encryption Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 16:51 ` Randy Dunlap
2020-02-21 16:51 ` [f2fs-dev] " Randy Dunlap
2020-02-21 17:25 ` Christoph Hellwig
2020-02-21 17:25 ` [f2fs-dev] " Christoph Hellwig
2020-02-21 17:35 ` Christoph Hellwig
2020-02-21 17:35 ` [f2fs-dev] " Christoph Hellwig
2020-02-21 18:34 ` Eric Biggers
2020-02-21 18:34 ` [f2fs-dev] " Eric Biggers
2020-02-24 23:36 ` Christoph Hellwig
2020-02-24 23:36 ` [f2fs-dev] " Christoph Hellwig
2020-02-27 19:25 ` Eric Biggers
2020-02-27 19:25 ` [f2fs-dev] " Eric Biggers
2020-02-21 11:50 ` [PATCH v7 4/9] scsi: ufs: UFS driver v2.1 spec crypto additions Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 11:50 ` [PATCH v7 5/9] scsi: ufs: UFS crypto API Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-22 4:59 ` Eric Biggers
2020-02-22 4:59 ` [f2fs-dev] " Eric Biggers
2020-02-21 11:50 ` [PATCH v7 6/9] scsi: ufs: Add inline encryption support to UFS Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 17:22 ` Christoph Hellwig
2020-02-21 17:22 ` [f2fs-dev] " Christoph Hellwig
2020-02-21 18:11 ` Eric Biggers
2020-02-21 18:11 ` [f2fs-dev] " Eric Biggers
2020-02-23 13:47 ` Stanley Chu
2020-02-23 13:47 ` [f2fs-dev] " Stanley Chu
2020-02-24 23:37 ` Christoph Hellwig
2020-02-24 23:37 ` [f2fs-dev] " Christoph Hellwig
2020-02-25 7:21 ` Stanley Chu
2020-02-25 7:21 ` [f2fs-dev] " Stanley Chu
2020-02-26 1:12 ` Eric Biggers
2020-02-26 1:12 ` [f2fs-dev] " Eric Biggers
2020-02-26 6:43 ` Stanley Chu
2020-02-26 6:43 ` [f2fs-dev] " Stanley Chu
2020-03-02 9:17 ` Stanley Chu
2020-03-02 9:17 ` [f2fs-dev] " Stanley Chu
2020-02-21 11:50 ` [PATCH v7 7/9] fscrypt: add inline encryption support Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 18:40 ` Eric Biggers
2020-02-21 18:40 ` [f2fs-dev] " Eric Biggers
2020-02-22 5:39 ` Eric Biggers
2020-02-22 5:39 ` [f2fs-dev] " Eric Biggers
2020-02-26 0:30 ` Eric Biggers
2020-02-26 0:30 ` [f2fs-dev] " Eric Biggers
2020-02-21 11:50 ` [PATCH v7 8/9] f2fs: " Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 11:50 ` [PATCH v7 9/9] ext4: " Satya Tangirala
2020-02-21 11:50 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-22 5:21 ` Eric Biggers
2020-02-22 5:21 ` [f2fs-dev] " Eric Biggers
2020-02-21 17:16 ` [PATCH v7 0/9] Inline Encryption Support Eric Biggers
2020-02-21 17:16 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221173118.GA30670@infradead.org \
--to=hch@infradead.org \
--cc=bmuthuku@qti.qualcomm.com \
--cc=boojin.kim@samsung.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.